Skip to contentSkip to conversation

arm64: dts: imx8m*-venice-gw7: Fix TPM schema violations

PATCH Applied Tim Harvey 3 participants 3 messages Apr 2, 2024 – Apr 3, 2024

Subsystems (2)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 arm64: dts: imx8m*-venice-gw7: Fix TPM schema violations

Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS bindings"), several issues are reported by "make dtbs_check" for arm64 devicetrees:

The compatible property needs to contain the chip's name in addition to the generic "tcg,tpm_tis-spi".

tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
from schema $id:
http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#

Fix these schema violations.

Gateworks Venice uses an Atmel ATTPM20P:
https://trac.gateworks.com/wiki/tpm

---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts  | 2 +-
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi +1 -1
index 41c966147b94..429be2bab8a2 100644
@@ -57,7 +57,7 @@ &ecspi2 {
 	status = "okay";
 
 	tpm@1 {
-		compatible = "tcg,tpm_tis-spi";
+		compatible = "atmel,attpm20p", "tcg,tpm_tis-spi";
 		reg = <0x1>;
 		spi-max-frequency = <36000000>;
 	};
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts +1 -1
index 5e2cbaf27e0f..35ae0faa815b 100644
@@ -297,7 +297,7 @@ flash@0 {
 	};
 
 	tpm@1 {
-		compatible = "tcg,tpm_tis-spi";
+		compatible = "atmel,attpm20p", "tcg,tpm_tis-spi";
 		reg = <0x1>;
 		spi-max-frequency = <36000000>;
 	};
arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +1 -1
index e7bf032265e0..2f740d74707b 100644
@@ -68,7 +68,7 @@ &ecspi2 {
 	status = "okay";
 
 	tpm@1 {
-		compatible = "tcg,tpm_tis-spi";
+		compatible = "atmel,attpm20p", "tcg,tpm_tis-spi";
 		reg = <0x1>;
 		spi-max-frequency = <36000000>;
 	};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Tim,

Quoted 8 lines · Tim Harvey

Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS bindings"), several issues are reported by "make dtbs_check" for arm64 devicetrees:

The compatible property needs to contain the chip's name in addition to the generic "tcg,tpm_tis-spi".

Quoted 8 lines

tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
from schema $id:
http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#

Fix these schema violations.

Gateworks Venice uses an Atmel ATTPM20P:
https://trac.gateworks.com/wiki/tpm

Thanks for the fix.

Applied
#2 lore raw
In reply to Tim Harvey
Quoted 11 lines · Tim Harvey

Since commit 26c9d152ebf3 ("dt-bindings: tpm: Consolidate TCG TIS bindings"), several issues are reported by "make dtbs_check" for arm64 devicetrees:

The compatible property needs to contain the chip's name in addition to the generic "tcg,tpm_tis-spi".

tpm@1: compatible: ['tcg,tpm_tis-spi'] is too short
from schema $id:
http://devicetree.org/schemas/tpm/tcg,tpm_tis-spi.yaml#

Quoted 7 lines

Fix these schema violations.

Gateworks Venice uses an Atmel ATTPM20P:
https://trac.gateworks.com/wiki/tpm

Applied, thanks!