Skip to contentSkip to conversation

soc: mediatek: mtk-socinfo: select CONFIG_SOC_BUS

PATCH In review Arnd Bergmann 3 participants 4 messages Apr 8, 2024 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: mediatek: mtk-socinfo: select CONFIG_SOC_BUS

From: Arnd Bergmann <[email protected]>

This is needed to avoid a link failure:

ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!

Fixes 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
---
 drivers/soc/mediatek/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/mediatek/Kconfig +1 -0
index 50c664b65f4d..1b7afb19ccd6 100644
@@ -72,6 +72,7 @@ config MTK_SOCINFO
 	tristate "MediaTek SoC Information"
 	default y
 	depends on NVMEM_MTK_EFUSE
+	select SOC_BUS
 	help
 	  The MediaTek SoC Information (mtk-socinfo) driver provides
 	  information about the SoC to the userspace including the
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw

Il 08/04/24 14:55, Arnd Bergmann ha scritto:

Quoted 9 lines

From: Arnd Bergmann <[email protected]>

This is needed to avoid a link failure:

ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!

Fixes 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
#2 lore raw
In reply to Arnd Bergmann

Hi,

Quoted 7 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This is needed to avoid a link failure:

ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!

I've tried to take care of this in the exact same way a long time ago. Don't ask me why it didn't find it's way into stable yet

https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/

Cheers

Daniel

Quoted 22 lines
Fixes 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
---
 drivers/soc/mediatek/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/mediatek/Kconfig +1 -0
index 50c664b65f4d..1b7afb19ccd6 100644
@@ -72,6 +72,7 @@ config MTK_SOCINFO
 	tristate "MediaTek SoC Information"
 	default y
 	depends on NVMEM_MTK_EFUSE
+	select SOC_BUS
 	help
 	  The MediaTek SoC Information (mtk-socinfo) driver provides
 	  information about the SoC to the userspace including the
Signature · 1 line
2.39.2
#3 lore raw

Il 08/04/24 14:59, Daniel Golle ha scritto:

Quoted 7 lines

Hi,

Quoted 4 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

This is needed to avoid a link failure:

Quoted 10 lines
Quoted 3 lines

ERROR: modpost: "soc_device_register" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!
ERROR: modpost: "soc_device_unregister" [drivers/soc/mediatek/mtk-socinfo.ko] undefined!

I've tried to take care of this in the exact same way a long time ago. Don't ask me why it didn't find it's way into stable yet

https://patchwork.kernel.org/project/linux-mediatek/patch/cc8f7f7da5bdccce514a320e0ae7468659cf7346.1707327680.git.daniel@makrotopia.org/

Sorry, went out of my radar for reasons.
Your commit should take precedence.

Angelo

Quoted 27 lines

Cheers

Daniel

Quoted 22 lines
Fixes 423a54da3c7e ("soc: mediatek: mtk-socinfo: Add driver for getting chip information")
---
  drivers/soc/mediatek/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/soc/mediatek/Kconfig +1 -0
index 50c664b65f4d..1b7afb19ccd6 100644
@@ -72,6 +72,7 @@ config MTK_SOCINFO
  	tristate "MediaTek SoC Information"
  	default y
  	depends on NVMEM_MTK_EFUSE
+	select SOC_BUS
  	help
  	  The MediaTek SoC Information (mtk-socinfo) driver provides
  	  information about the SoC to the userspace including the
Signature · 1 line
2.39.2