Skip to contentSkip to conversation

arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

PATCH Applied Fabio Estevam 4 participants 5 messages Apr 4, 2024 – Apr 22, 2024

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp-debix-som-a-bmb-08: Remove 'phy-supply' from eqos

From: Fabio Estevam <[email protected]>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

Remove it to fix the following dt-schema warning:

ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

---
 arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +0 -1
index b11d694b98e1..d241db3743a9 100644
@@ -144,7 +144,6 @@ &eqos {
 	pinctrl-0 = <&pinctrl_eqos>;
 	nvmem-cells = <&ethmac1>;
 	nvmem-cell-names = "mac-address";
-	phy-supply = <&reg_baseboard_vdd3v3>;
 	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-id";
 	status = "okay";
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

I don't have a SoM so I can't test this. Paul, Umang, Kieran, could one of you review this patch ?

Quoted 26 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

Remove it to fix the following dt-schema warning:

ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

---
 arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +0 -1
index b11d694b98e1..d241db3743a9 100644
@@ -144,7 +144,6 @@ &eqos {
 	pinctrl-0 = <&pinctrl_eqos>;
 	nvmem-cells = <&ethmac1>;
 	nvmem-cell-names = "mac-address";
-	phy-supply = <&reg_baseboard_vdd3v3>;
 	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-id";
 	status = "okay";
Signature · 8 lines
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by Tested-by
#2 lore raw

Hello,

Quoted 18 lines · Laurent Pinchart

I don't have a SoM so I can't test this. Paul, Umang, Kieran, could one of you review this patch ?

Quoted 14 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

Remove it to fix the following dt-schema warning:

ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

---
  arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 1 -
  1 file changed, 1 deletion(-)
Quoted 9 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts &eqos { · line 147

Quoted 9 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +0 -1
index b11d694b98e1..d241db3743a9 100644
@@ -144,7 +144,6 @@ &eqos {
  	pinctrl-0 = <&pinctrl_eqos>;
  	nvmem-cells = <&ethmac1>;
  	nvmem-cell-names = "mac-address";
-	phy-supply = <&reg_baseboard_vdd3v3>;

Is this also applicable for &fec ethernet node  (since debix-som-a has two ethernet ports) ?

As far as this patch goes,

Quoted 3 lines

arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts &eqos { · line 149

Quoted 3 lines
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +0 -0
  	phy-handle = <&ethphy0>;
  	phy-mode = "rgmii-id";
  	status = "okay";

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author reviewer
#3 lore raw

Hi Umang,

Quoted 2 lines · Umang Jain

Is this also applicable for &fec ethernet node (since debix-som-a has two ethernet ports) ?

The fec node can accept 'phy-supply'.

Quoted 5 lines

As far as this patch goes,

Thanks for testing it!

Cheers

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Applied
#4 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

Remove it to fix the following dt-schema warning:

ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel