Skip to contentSkip to conversation

drm/ili9341: Remove the duplicative driver

PATCH In review Andy Shevchenko 2 participants 5 messages Apr 25, 2024 – Apr 29, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/ili9341: Remove the duplicative driver

First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels.

Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality.

Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody.

Also see discussion [1] for details about Ilitek 9341 duplication code.

---
 drivers/gpu/drm/tiny/Kconfig   |  13 --
 drivers/gpu/drm/tiny/Makefile  |   1 -
 drivers/gpu/drm/tiny/ili9341.c | 253 ---------------------------------
 3 files changed, 267 deletions(-)
 delete mode 100644 drivers/gpu/drm/tiny/ili9341.c
drivers/gpu/drm/tiny/Kconfig +0 -13
index f6889f649bc1..2ab07bd0bb44 100644
@@ -134,19 +134,6 @@ config TINYDRM_ILI9225
 
 	  If M is selected the module will be called ili9225.
 
-config TINYDRM_ILI9341
-	tristate "DRM support for ILI9341 display panels"
-	depends on DRM && SPI
-	select DRM_KMS_HELPER
-	select DRM_GEM_DMA_HELPER
-	select DRM_MIPI_DBI
-	select BACKLIGHT_CLASS_DEVICE
-	help
-	  DRM driver for the following Ilitek ILI9341 panels:
-	  * YX240QV29-T 2.4" 240x320 TFT (Adafruit 2.4")
-
-	  If M is selected the module will be called ili9341.
-
 config TINYDRM_ILI9486
 	tristate "DRM support for ILI9486 display panels"
 	depends on DRM && SPI
drivers/gpu/drm/tiny/Makefile +0 -1
index 76dde89a044b..37cc9b27e79d 100644
@@ -10,7 +10,6 @@ obj-$(CONFIG_DRM_SIMPLEDRM)		+= simpledrm.o
 obj-$(CONFIG_TINYDRM_HX8357D)		+= hx8357d.o
 obj-$(CONFIG_TINYDRM_ILI9163)		+= ili9163.o
 obj-$(CONFIG_TINYDRM_ILI9225)		+= ili9225.o
-obj-$(CONFIG_TINYDRM_ILI9341)		+= ili9341.o
 obj-$(CONFIG_TINYDRM_ILI9486)		+= ili9486.o
 obj-$(CONFIG_TINYDRM_MI0283QT)		+= mi0283qt.o
 obj-$(CONFIG_TINYDRM_REPAPER)		+= repaper.o
drivers/gpu/drm/tiny/ili9341.c deleted +0 -253

253 lines not on this page · raw message

Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
maintainer
#1 lore raw

Hi,

Quoted 6 lines · Andy Shevchenko

First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels.

Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality.

Quoted 8 lines

Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody.

Also see discussion [1] for details about Ilitek 9341 duplication code.

I think it should be the other way around and we should remove the mipi-dbi handling from panel/panel-ilitek-ili9341.c

It's basically two drivers glued together for no particular reason and handling two very different use cases which just adds more complexity than it needs to.

And it's the only driver doing so afaik, so it's definitely not "least surprise" compliant.

Maxime

#2 lore raw
Quoted 12 lines · Maxime Ripard

Hi,

Quoted 9 lines · Andy Shevchenko

First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels.

Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality.

Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody.

Quoted 8 lines
Quoted 5 lines

Also see discussion [1] for details about Ilitek 9341 duplication code.

I think it should be the other way around and we should remove the mipi-dbi handling from panel/panel-ilitek-ili9341.c

Then please do it! I whining already for a few years about this.

Quoted 6 lines

It's basically two drivers glued together for no particular reason and handling two very different use cases which just adds more complexity than it needs to.

And it's the only driver doing so afaik, so it's definitely not "least surprise" compliant.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#3 lore raw
Quoted 16 lines · Andy Shevchenko
Quoted 15 lines · Maxime Ripard

Hi,

Quoted 12 lines · Andy Shevchenko

First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels.

Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality.

Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody.

Also see discussion [1] for details about Ilitek 9341 duplication code.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I think it should be the other way around and we should remove the mipi-dbi handling from panel/panel-ilitek-ili9341.c

Then please do it! I whining already for a few years about this.

I have neither the hardware nor the interest to do so. Seems it looks like you have plenty of the latter at least, I'm sure you'll find some time to tackle this.

Maxime

#4 lore raw
Quoted 18 lines · Maxime Ripard
Quoted 17 lines · Andy Shevchenko
Quoted 16 lines · Maxime Ripard
Quoted 14 lines · Andy Shevchenko

First of all, the driver was introduced when it was already two drivers available for Ilitek 9341 panels.

Second, the most recent (fourth!) driver has incorporated this one and hence, when enabled, it covers the provided functionality.

Taking into account the above, remove duplicative driver and make maintenance and support eaiser for everybody.

Also see discussion [1] for details about Ilitek 9341 duplication code.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I think it should be the other way around and we should remove the mipi-dbi handling from panel/panel-ilitek-ili9341.c

Then please do it! I whining already for a few years about this.

I have neither the hardware nor the interest to do so. Seems it looks like you have plenty of the latter at least, I'm sure you'll find some time to tackle this.

Hmm... Since the use of Arduino part in panel IliTek 9341 is clarified in this thread, I won't use that, but I have no time to clean up the mess in DRM in the nearest future, sorry. And TBH it seems you, guys, know much better what you want.

FYI:
The drivers/gpu/drm/tiny/mi0283qt.c works for me (the plenty of the HW you referred to).

TL;DR: consider this as a (bug/feature/cleanup) report.

Signature · 2 lines
With Best Regards,
Andy Shevchenko