Skip to contentSkip to conversation

RDMA/ipoib: Remove NULL check before dev_{put, hold}

PATCH Applied Jules Irenge 2 participants 2 messages Apr 30, 2024 – May 2, 2024 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 RDMA/ipoib: Remove NULL check before dev_{put, hold}

Coccinelle reports a warning

WARNING: NULL check before dev_{put, hold} functions is not needed

The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL There is no need to check before using dev_{put, hold}

---
 drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_main.c +1 -2
index 6f2a688fccbf..4abec0124ea3 100644
@@ -329,8 +329,7 @@ static struct net_device *ipoib_get_master_net_dev(struct net_device *dev)
 
 	rcu_read_lock();
 	master = netdev_master_upper_dev_get_rcu(dev);
-	if (master)
-		dev_hold(master);
+	dev_hold(master);
 	rcu_read_unlock();
 
 	if (master)
Signature · 1 line
2.43.2
#1 lore raw
Quoted 8 lines · Jules Irenge

Coccinelle reports a warning

WARNING: NULL check before dev_{put, hold} functions is not needed

The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL There is no need to check before using dev_{put, hold}

[...]

Applied, thanks!

[1/1] RDMA/ipoib: Remove NULL check before dev_{put, hold}

      https://git.kernel.org/rdma/rdma/c/e4e40a87024c50

Best regards,

Signature · 1 line
Leon Romanovsky <[email protected]>