Skip to contentSkip to conversation

arm64: Default to 4K translation granule

PATCH In review Oliver Upton 1 participant 2 messages May 2, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: Default to 4K translation granule

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

---
 configure | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
configure +2 -6
index 49f047cb2d7d..4ac2ff3e6106 100755
@@ -75,7 +75,7 @@ usage() {
 	                           (s390x only)
 	    --page-size=PAGE_SIZE
 	                           Specify the page size (translation granule) (4k, 16k or
-	                           64k, default is 64k, arm64 only)
+	                           64k, default is 4k, arm64 only)
 	    --earlycon=EARLYCON
 	                           Specify the UART name, type and address (optional, arm and
 	                           arm64 only). The specified address will overwrite the UART
@@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
 fi
 
 if [ -z "$page_size" ]; then
-    if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
-        page_size="4096"
-    elif [ "$arch" = "arm64" ]; then
-        page_size="65536"
-    elif [ "$arch" = "arm" ]; then
+    if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
         page_size="4096"
     fi
 else
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
#1 lore raw

disregard -- forgot I didn't have my subject prefix config set on this machine.

Quoted 42 lines · Oliver Upton

Some arm64 implementations in the wild, like the Apple parts, do not support the 64K translation granule. This can be a bit annoying when running with the defaults on such hardware, as every test fails before getting the MMU turned on.

Switch the default page size to 4K with the intention of having the default setting be the most widely applicable one.

---
 configure | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
configure +2 -6
index 49f047cb2d7d..4ac2ff3e6106 100755
@@ -75,7 +75,7 @@ usage() {
 	                           (s390x only)
 	    --page-size=PAGE_SIZE
 	                           Specify the page size (translation granule) (4k, 16k or
-	                           64k, default is 64k, arm64 only)
+	                           64k, default is 4k, arm64 only)
 	    --earlycon=EARLYCON
 	                           Specify the UART name, type and address (optional, arm and
 	                           arm64 only). The specified address will overwrite the UART
@@ -243,11 +243,7 @@ if [ "$efi" ] && [ "$arch" = "riscv64" ] && [ -z "$efi_direct" ]; then
 fi
 
 if [ -z "$page_size" ]; then
-    if [ "$efi" = 'y' ] && [ "$arch" = "arm64" ]; then
-        page_size="4096"
-    elif [ "$arch" = "arm64" ]; then
-        page_size="65536"
-    elif [ "$arch" = "arm" ]; then
+    if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
         page_size="4096"
     fi
 else
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
Signature · 2 lines
Thanks,
Oliver