Skip to contentSkip to conversation

Input updates for v6.9-rc6

GIT PULL Merged Dmitry Torokhov 3 participants 6 messages May 5, 2024 – May 20 HID

lore
Share & tools
lore
#0 lore raw

Hi Linus,

Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git tags/input-for-v6.9-rc6

to receive updates for the input subsystem. You will get:

- a new ID for ASUS ROG RAIKIRI controllers added to xpad driver

- amimouse driver structure annotated with __refdata to prevent section mismatch warnings.

Changelog:
---------

Uwe Kleine-König (1):
Input: amimouse - mark driver struct with __refdata to prevent section mismatch

Vicki Pfau (1):
Input: xpad - add support for ASUS ROG RAIKIRI

Diffstat:
--------

 drivers/input/joystick/xpad.c  | 2 ++
 drivers/input/mouse/amimouse.c | 8 +++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

Thanks.

Signature · 1 line
Dmitry
merge bot Merged
#1 lore raw
The pull request you sent on Sat, 4 May 2024 20:25:58 -0700:

The pull request you sent on Sat, 4 May 2024 20:25:58 -0700:

Quoted 1 line

git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git tags/input-for-v6.9-rc6

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3f1d0865002795eb45c49e30a4fbc40f7956b6ae

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
#2 lore raw

Mismatched product ids for the ASUS ROG RAIKIRI PRO

In reply to Dmitry Torokhov

Hey Dimity,

I had a question on the product id,
{ 0x0b05, 0x1abb, "ASUS ROG RAIKIRI PRO", 0, XTYPE_XBOXONE },

This doesn’t match both my devices so I was wondering if somehow we have similar named devices with need for different product ids or if there was a mistake in the original commit?

My relevant entries from lsusb are
Bus 001 Device 002: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO Bus 001 Device 003: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO

On my system I have ended up using this udev rule for quite some time
ACTION=="add", ATTRS{idVendor}=="0b05", ATTRS{idProduct}=="1a3c", GROUP="input", MODE="0660", TAG+="uaccess", TAG+="seat", RUN+="/bin/sh -c 'echo 0b05 1a3c > /sys/bus/usb/drivers/xpad/new_id'"

Regards,
Justin

#3 lore raw

Re: Mismatched product ids for the ASUS ROG RAIKIRI PRO

Hi Justin,

Quoted 9 lines · Justin Opini

Hey Dimity,

I had a question on the product id,
{ 0x0b05, 0x1abb, "ASUS ROG RAIKIRI PRO", 0, XTYPE_XBOXONE },

This doesn’t match both my devices so I was wondering if somehow we have similar named devices with need for different product ids or if there was a mistake in the original commit?

Quoted 6 lines

My relevant entries from lsusb are
Bus 001 Device 002: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO Bus 001 Device 003: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO

On my system I have ended up using this udev rule for quite some time
ACTION=="add", ATTRS{idVendor}=="0b05", ATTRS{idProduct}=="1a3c", GROUP="input", MODE="0660", TAG+="uaccess", TAG+="seat", RUN+="/bin/sh -c 'echo 0b05 1a3c > /sys/bus/usb/drivers/xpad/new_id'"

I am CC-ing Luke who added this VID/PID comboi to double check, but it looks like there are many variants of this controller using the same "ROG RAIKIRI PRO" name. For example
https://github.com/atar-axis/xpadneo/issues/612 talks about 0x0b05/0x1abd.

Thanks.

Signature · 1 line
Dmitry
#4 lore raw

Re: Mismatched product ids for the ASUS ROG RAIKIRI PRO

Quoted 16 lines · Dmitry Torokhov

Hi Justin,

Quoted 13 lines · Justin Opini

Hey Dimity,

I had a question on the product id,
{ 0x0b05, 0x1abb, "ASUS ROG RAIKIRI PRO", 0, XTYPE_XBOXONE },

This doesn’t match both my devices so I was wondering if somehow we have similar named devices with need for different product ids or if there was a mistake in the original commit?

My relevant entries from lsusb are
Bus 001 Device 002: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO Bus 001 Device 003: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO

Quoted 9 lines
Quoted 2 lines

On my system I have ended up using this udev rule for quite some time
ACTION=="add", ATTRS{idVendor}=="0b05", ATTRS{idProduct}=="1a3c", GROUP="input", MODE="0660", TAG+="uaccess", TAG+="seat", RUN+="/bin/sh -c 'echo 0b05 1a3c > /sys/bus/usb/drivers/xpad/new_id'"

I am CC-ing Luke who added this VID/PID comboi to double check, but it looks like there are many variants of this controller using the same "ROG RAIKIRI PRO" name. For example
https://github.com/atar-axis/xpadneo/issues/612 talks about 0x0b05/0x1abd.

Ah i was thinking about this more. The device has 3 modes of connection, there is Bluetooth(on the Github tracker), and 2.4GHz via USB receiver(which is what I use) as well as USB directly to the device. Not use if this is enough to introduce variants, but I thought it was worth thinking out aloud. Maybe Luke could chime in on usage? In any case is a patch appropriate here to introduce variant?

Quoted 5 lines

Thanks.

--
Dmitry

#5 lore raw

Re: Mismatched product ids for the ASUS ROG RAIKIRI PRO

Quoted 22 lines · On Wednesday, May 20th, 2026 at 3:06 PM, [email protected]…
Quoted 19 lines · Dmitry Torokhov

Hi Justin,

Quoted 15 lines · Justin Opini

Hey Dimity,

I had a question on the product id,
{ 0x0b05, 0x1abb, "ASUS ROG RAIKIRI PRO", 0, XTYPE_XBOXONE },

This doesn’t match both my devices so I was wondering if somehow we have similar named devices with need for different product ids or if there was a mistake in the original commit?

My relevant entries from lsusb are
Bus 001 Device 002: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO Bus 001 Device 003: ID 0b05:1a3c ASUSTek Computer, Inc. ROG RAIKIRI PRO

On my system I have ended up using this udev rule for quite some time
ACTION=="add", ATTRS{idVendor}=="0b05", ATTRS{idProduct}=="1a3c", GROUP="input", MODE="0660", TAG+="uaccess", TAG+="seat", RUN+="/bin/sh -c 'echo 0b05 1a3c > /sys/bus/usb/drivers/xpad/new_id'"

Quoted 8 lines
Quoted 6 lines

I am CC-ing Luke who added this VID/PID comboi to double check, but it looks like there are many variants of this controller using the same "ROG RAIKIRI PRO" name. For example
https://github.com/atar-axis/xpadneo/issues/612 talks about 0x0b05/0x1abd.

Ah i was thinking about this more. The device has 3 modes of connection, there is Bluetooth(on the Github tracker), and 2.4GHz via USB receiver(which is what I use) as well as USB directly to the device. Not use if this is enough to introduce variants, but I thought it was worth thinking out aloud. Maybe Luke could chime in on usage? In any case is a patch appropriate here to introduce variant?

Connected via USB I get,

Bus 003 Device 004: ID 0b05:1abb ASUSTek Computer, Inc. ROG RAIKIRI PRO

I can't test Bluetooth because I have a motherboard that doesn't have a supported driver yet.

Quoted 6 lines
Quoted 6 lines

Thanks.

--
Dmitry