perf callchain: Use zfree() to avoid possibly accessing dangling pointers
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf callchain: Use zfree() to avoid possibly accessing dangling pointers
When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b.
Convert one such case in the callchain code.
Cc Adrian Hunter <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kan Liang <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/callchain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/callchain.c +1 -1
@@ -606,7 +606,7 @@ fill_node(struct callchain_node *node, struct callchain_cursor *cursor) call->brtype_stat =zalloc (sizeof (*call->brtype_stat));if (!call->brtype_stat) {perror ("not enough memory for the code path branch statistics" ); -free (call->brtype_stat); +zfree (&call->brtype_stat);return -ENOMEM ; } }
Signature · 1 line
2.44.0
Quoted 6 lines · Arnaldo Carvalho de Melo
When freeing
a->bit is good practice to seta->bto NULL usingzfree(&a->b)so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to usea->b.
Quoted 8 lines
Convert one such case in the callchain code.
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Reviewed-by Ian Rogers <[email protected]>
Thanks,
Ian
Quoted 20 lines
--- tools/perf/util/callchain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/callchain.c +1
-2@@ -606,7 +606,7 @@ fill_node(struct callchain_node *node, struct callchain_cursor *cursor) call->brtype_stat =zalloc (sizeof (*call->brtype_stat));if (!call->brtype_stat) {perror ("not enough memory for the code path branch statistics" ); -free (call->brtype_stat); +zfree (&call->brtype_stat);return -ENOMEM ; } } --2.44.0