Skip to contentSkip to conversation

perf probe: Use zfree() to avoid possibly accessing dangling pointers

PATCH In review Arnaldo Carvalho de Melo 2 participants 2 messages May 7, 2024 – May 9, 2024 perf events

lore
Share & tools
lore

Arnaldo Carvalho de Melo

author maintainer
#0 lore raw

PATCH 1/1 perf probe: Use zfree() to avoid possibly accessing dangling pointers

When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b.

Convert one such case in the 'perf probe' codebase.

Cc Adrian Hunter <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kan Liang <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/builtin-probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-probe.c +1 -1
index 019fef8da6a8e60f..003a3bcebfdfc2d1 100644
@@ -325,7 +325,7 @@ static void cleanup_params(void)
 	for (i = 0; i < params->nevents; i++)
 		clear_perf_probe_event(params->events + i);
 	line_range__clear(&params->line_range);
-	free(params->target);
+	zfree(&params->target);
 	strfilter__delete(params->filter);
 	nsinfo__put(params->nsi);
 	zfree(&params);
Signature · 1 line
2.44.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 23 lines · Arnaldo Carvalho de Melo

When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b.

Convert one such case in the 'perf probe' codebase.

Cc Adrian Hunter <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kan Liang <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/perf/builtin-probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-probe.c +0 -0
index 019fef8da6a8e60f..003a3bcebfdfc2d1 100644

tools/perf/builtin-probe.c static void cleanup_params(void) · line 331

Quoted 8 lines
tools/perf/builtin-probe.c +1 -1
@@ -325,7 +325,7 @@ static void cleanup_params(void)
        for (i = 0; i < params->nevents; i++)
                clear_perf_probe_event(params->events + i);
        line_range__clear(&params->line_range);
-       free(params->target);
+       zfree(&params->target);
        strfilter__delete(params->filter);
        nsinfo__put(params->nsi);
        zfree(&params);

The change is fine but params is freed here, so the potential to read "->target" is small.

Thanks,
Ian

Quoted 3 lines

--
2.44.0