perf probe: Use zfree() to avoid possibly accessing dangling pointers
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf probe: Use zfree() to avoid possibly accessing dangling pointers
When freeing a->b it is good practice to set a->b to NULL using zfree(&a->b) so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to use a->b.
Convert one such case in the 'perf probe' codebase.
--- tools/perf/builtin-probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-probe.c +1 -1
@@ -325,7 +325,7 @@ static void cleanup_params(void)for (i =0 ; i < params->nevents; i++)clear_perf_probe_event (params->events + i);line_range__clear (¶ms->line_range); -free (params->target); +zfree (¶ms->target);strfilter__delete (params->filter);nsinfo__put (params->nsi);zfree (¶ms);
Signature · 1 line
2.44.0
Quoted 23 lines · Arnaldo Carvalho de Melo
When freeing
a->bit is good practice to seta->bto NULL usingzfree(&a->b)so that when we have a bug where a reference to a freed 'a' pointer is kept somewhere, we can more quickly cause a segfault if some code tries to usea->b.Convert one such case in the 'perf probe' codebase.
Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>--- tools/perf/builtin-probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/builtin-probe.c +0
-0
tools/perf/builtin-probe.c static void cleanup_params(void) · line 331
Quoted 8 lines
tools/perf/builtin-probe.c +1
-1@@ -325,7 +325,7 @@ static void cleanup_params(void)for (i =0 ; i < params->nevents; i++)clear_perf_probe_event (params->events + i);line_range__clear (¶ms->line_range); -free (params->target); +zfree (¶ms->target);strfilter__delete (params->filter);nsinfo__put (params->nsi);zfree (¶ms);
The change is fine but params is freed here, so the potential to read "->target" is small.
Thanks,
Ian
Quoted 3 lines
--
2.44.0