can: mcp251x: Fix up includes
Subsystems (3)
PATCH 1/1 can: mcp251x: Fix up includes
This driver is including the legacy GPIO header <linux/gpio.h> but the only thing it is using from that header is the wrong define for GPIOF_DIR_OUT.
Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/net/can/spi/mcp251x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/can/spi/mcp251x.c +2 -3
@@ -28,7 +28,6 @@#include <linux/device.h> #include <linux/ethtool.h> #include <linux/freezer.h> -#include <linux/gpio.h> #include <linux/gpio/driver.h> #include <linux/interrupt.h> #include <linux/io.h>
@@ -482,9 +481,9 @@ static int mcp251x_gpio_get_direction(struct gpio_chip *chip, unsigned int offset) {if (mcp251x_gpio_is_input (offset)) -return GPIOF_DIR_IN ; +return GPIO_LINE_DIRECTION_IN ; -return GPIOF_DIR_OUT ; +return GPIO_LINE_DIRECTION_OUT ; }static int mcp251x_gpio_get (struct gpio_chip *chip,unsigned int offset)
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Quoted 7 lines · Andy Shevchenko
This driver is including the legacy GPIO header <
linux/gpio.h> but the only thing it is using from that header is the wrong define forGPIOF_DIR_OUT.Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Signed-off-by Andy Shevchenko <[email protected]>
Thank you for the patch.
Reviewed-by Vincent Mailhol <[email protected]>
Quoted 5 lines · Andy Shevchenko
This driver is including the legacy GPIO header <
linux/gpio.h> but the only thing it is using from that header is the wrong define forGPIOF_DIR_OUT.Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
Marc, any comments on this?
Signature · 2 lines
With Best Regards, Andy Shevchenko