Skip to contentSkip to conversation

virtio-can: rephrase notification mechanism

PATCH In review Matias Ezequiel Vara Larsen 3 participants 6 messages May 21, 2024 – Jun 11, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-can: rephrase notification mechanism

Rephrase the notification mechanism.

---
* This patch applies on top of virtio-1.4, which has not been released yet.

---
 device-types/can/description.tex | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
device-types/can/description.tex +6 -7
index 2511d9c..2931aa9 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 
 If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification as the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.
 
 On transition to the STOPPED state the device cancels all CAN messages
 already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
#1 lore raw
Quoted 1 line · Matias Ezequiel Vara Larsen

Rephrase the notification mechanism.

I'd suggest to explain here what are we clarifying with the rephrase.
Sorry, I'm not a CAN expert, so I don't understand the difference between the two versions.

Stefano

Quoted 39 lines

---
* This patch applies on top of virtio-1.4, which has not been released yet.
---
device-types/can/description.tex | 13 ++++++-------

1 file changed, 6 insertions(+), 7 deletions(-)
device-types/can/description.tex +0 -0
index 2511d9c..2931aa9 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 

If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK

device-types/can/description.tex +6 -7
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification as the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.

On transition to the STOPPED state the device cancels all CAN messages already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
#2 lore raw

Hello,

exactly this is my problem here also. For me this change looks like saying exactly the same thing just in different (not better) words.

Thinking still about the replacement "from the driver" => "by the driver". Was the original "from the driver" correct? My native language is German and of course it can be that I made a grammar mistake applying German grammar to an English text. Absolutely unclear to me.

But if it's not that I have as a non-native speaker of English in the moment no idea where the improvement is.

Regards
Harald

Quoted 53 lines · Stefano Garzarella
Quoted 1 line · Matias Ezequiel Vara Larsen

Rephrase the notification mechanism.

I'd suggest to explain here what are we clarifying with the rephrase.
Sorry, I'm not a CAN expert, so I don't understand the difference between the two versions.

Stefano

Quoted 44 lines

---
* This patch applies on top of virtio-1.4, which has not been released yet.
---
device-types/can/description.tex | 13 ++++++-------

1 file changed, 6 insertions(+), 7 deletions(-)
device-types/can/description.tex +0 -0
index 2511d9c..2931aa9 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller 

Mode}\label{sec:Device Types / CAN Device / Device Ope \end{lstlisting}

If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK

device-types/can/description.tex +1 -7
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is 

necessary, the
+device updates the configuration \field{status} before marking the request

device-types/can/description.tex +2 -0
+used. The device may omit the configuration change notification as the
+configuration \field{status} change is requested by the driver. The 

device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.

On transition to the STOPPED state the device cancels all CAN messages already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
Signature · 14 lines
Dipl.-Ing. Harald Mommer
Senior Software Engineer

OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin

Phone:  +49 (30) 60 98 540-0 <== Zentrale
Fax:    +49 (30) 60 98 540-99
E-Mail: [email protected]

www.opensynergy.com

Handelsregister: Amtsgericht Charlottenburg, HRB 108616B
Geschäftsführer/Managing Director: Regis Adjamah
#3 lore raw
Quoted 10 lines · Harald Mommer

Hello,

exactly this is my problem here also. For me this change looks like saying exactly the same thing just in different (not better) words.

Thinking still about the replacement "from the driver" => "by the driver". Was the original "from the driver" correct? My native language is German and of course it can be that I made a grammar mistake applying German grammar to an English text. Absolutely unclear to me.

Quoted 15 lines

But if it's not that I have as a non-native speaker of English in the moment no idea where the improvement is.

Regards
Harald

Quoted 8 lines · Stefano Garzarella
Quoted 1 line · Matias Ezequiel Vara Larsen

Rephrase the notification mechanism.

I'd suggest to explain here what are we clarifying with the rephrase. Sorry, I'm not a CAN expert, so I don't understand the difference between the two versions.

Thanks both for the review. The only sentence that I wanted to change is:

"As the configuration \field{status} change is caused by a request from the driver the device is allowed to omit the configuration change notification here."

I though it could be rewritten in a more direct way like:

"The device may omit the configuration change notification as the configuration \field{status} change is requested by the driver. "

But I don't know if that clarifies anything. If not, we can drop this patch.

Matias

#4 lore raw
Quoted 34 lines · Matias Ezequiel Vara Larsen
Quoted 10 lines · Harald Mommer

Hello,

exactly this is my problem here also. For me this change looks like saying exactly the same thing just in different (not better) words.

Thinking still about the replacement "from the driver" => "by the driver". Was the original "from the driver" correct? My native language is German and of course it can be that I made a grammar mistake applying German grammar to an English text. Absolutely unclear to me.

Quoted 15 lines

But if it's not that I have as a non-native speaker of English in the moment no idea where the improvement is.

Regards
Harald

Quoted 8 lines · Stefano Garzarella
Quoted 1 line · Matias Ezequiel Vara Larsen

Rephrase the notification mechanism.

I'd suggest to explain here what are we clarifying with the rephrase. Sorry, I'm not a CAN expert, so I don't understand the difference between the two versions.

Thanks both for the review. The only sentence that I wanted to change is:

"As the configuration \field{status} change is caused by a request from the driver the device is allowed to omit the configuration change notification here."

Quoted 7 lines

I though it could be rewritten in a more direct way like:

"The device may omit the configuration change notification as the configuration \field{status} change is requested by the driver. "

But I don't know if that clarifies anything. If not, we can drop this patch.

Yeah, I think is more clear but I suggest to explain it in the commit description as well.

Thanks,
Stefano

#5 lore raw
Quoted 37 lines · Stefano Garzarella
Quoted 36 lines · Matias Ezequiel Vara Larsen
Quoted 10 lines · Harald Mommer

Hello,

exactly this is my problem here also. For me this change looks like saying exactly the same thing just in different (not better) words.

Thinking still about the replacement "from the driver" => "by the driver". Was the original "from the driver" correct? My native language is German and of course it can be that I made a grammar mistake applying German grammar to an English text. Absolutely unclear to me.

Quoted 15 lines

But if it's not that I have as a non-native speaker of English in the moment no idea where the improvement is.

Regards
Harald

Quoted 8 lines · Stefano Garzarella
Quoted 1 line · Matias Ezequiel Vara Larsen

Rephrase the notification mechanism.

I'd suggest to explain here what are we clarifying with the rephrase. Sorry, I'm not a CAN expert, so I don't understand the difference between the two versions.

Thanks both for the review. The only sentence that I wanted to change is:

"As the configuration \field{status} change is caused by a request from the driver the device is allowed to omit the configuration change notification here."

I though it could be rewritten in a more direct way like:

Quoted 9 lines
Quoted 5 lines

"The device may omit the configuration change notification as the configuration \field{status} change is requested by the driver. "

But I don't know if that clarifies anything. If not, we can drop this patch.

Yeah, I think is more clear but I suggest to explain it in the commit description as well.

Thanks, I will submit a v2 adding that.

Matias