arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect
Subsystems (2)
PATCH v3 1/2 arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect
The DSI to HDMI bridge supports hot-plug-detect.The driver supports shared GPIO IRQ pins, so it's save to enable them which allows for hot-plug detect.
---
V3: Update commit message, no functional changes.
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +2 -0
@@ -304,6 +304,8 @@ adv_bridge: hdmi@3d { compatible = "adi,adv7535"; reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; reg-names = "main", "cec", "edid", "packet"; + interrupt-parent = <&gpio4>; + interrupts = <27 IRQ_TYPE_EDGE_FALLING>; adi,dsi-lanes = <4>; #sound-dai-cells = <0>;
Signature · 1 line
2.43.0
PATCH v3 2/2 arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
The adv7535 has some unnecessary entries which can be removed since they were not setup properly anyway and the defaults work just fine. Removing them and adding some required regulators make the errors detected from CHECK_DTBS go away:
reg-names:1: 'edid' was expected
reg-names:2: 'cec' was expected
'avdd-supply' is a required property
'dvdd-supply' is a required property
'pvdd-supply' is a required property
'a2vdd-supply' is a required property
'v3p3-supply' is a required property
---
V2: No Change
V3: Update commit message, no functional changes.
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +9 -2
@@ -302,12 +302,19 @@ pca6416_3: gpio@20 { adv_bridge: hdmi@3d { compatible = "adi,adv7535"; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>; + reg-names = "main"; interrupt-parent = <&gpio4>; interrupts = <27 IRQ_TYPE_EDGE_FALLING>; adi,dsi-lanes = <4>; #sound-dai-cells = <0>; + avdd-supply = <&buck5>; + dvdd-supply = <&buck5>; + pvdd-supply = <&buck5>; + a2vdd-supply = <&buck5>; + v1p2-supply = <&buck5>; + v3p3-supply = <&buck4>; + ports { #address-cells = <1>;
Signature · 1 line
2.43.0
Re: [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
Quoted 7 lines · Adam Ford
adv_bridge: hdmi@3d { compatible = "adi,adv7535";arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +2
-2- reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>; + reg-names = "main"; interrupt-parent = <&gpio4>;
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts pca6416_3: gpio@20 { · line 317
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +7
-0interrupts = <27 IRQ_TYPE_EDGE_FALLING>; adi,dsi-lanes = <4>; #sound-dai-cells = <0>; + avdd-supply = <&buck5>; + dvdd-supply = <&buck5>; + pvdd-supply = <&buck5>; + a2vdd-supply = <&buck5>; + v1p2-supply = <&buck5>; + v3p3-supply = <&buck4>; +
The extra blank line is not needed.
Thanks for fixing the dt-schema warnings:
Re: [PATCH V3 2/2] arm64: dts: imx8mp-beacon-kit: Fix errors found from CHECK_DTBS
Quoted 20 lines · Fabio Estevam
Quoted 7 lines · Adam Ford
adv_bridge: hdmi@3d { compatible = "adi,adv7535";arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +2
-2- reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>; + reg-names = "main"; interrupt-parent = <&gpio4>;arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts pca6416_3: gpio@20 { · line 317
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +7
-0interrupts = <27 IRQ_TYPE_EDGE_FALLING>; adi,dsi-lanes = <4>; #sound-dai-cells = <0>; + avdd-supply = <&buck5>; + dvdd-supply = <&buck5>; + pvdd-supply = <&buck5>; + a2vdd-supply = <&buck5>; + v1p2-supply = <&buck5>; + v3p3-supply = <&buck4>; +
Quoted 1 line
The extra blank line is not needed.
Fixed it up and applied, thanks!
Hi Adam,
Quoted 7 lines · Adam Ford
The DSI to HDMI bridge supports hot-plug-detect.The driver supports shared GPIO IRQ pins, so it's save to enable them which allows for hot-plug detect.
Signed-off-by Adam Ford <[email protected]>Reviewed-by Laurent Pinchart <[email protected]>