Skip to contentSkip to conversation

virtio-can: rephrase notification mechanism

PATCH In review Matias Ezequiel Vara Larsen 2 participants 3 messages Jun 13, 2024 – Jun 21, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-can: rephrase notification mechanism

Rephrase when the device may omit to notify the driver due to a status change in a more straight-forward way.

---
* This patch applies on top of virtio-1.4, which has not been released yet.

v0 -> v1:
* Rephrase commit message

---
 device-types/can/description.tex | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
device-types/can/description.tex +6 -7
index 2511d9c..b13da9c 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 
 If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification when the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.
 
 On transition to the STOPPED state the device cancels all CAN messages
 already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Matias Ezequiel Vara Larsen

Rephrase when the device may omit to notify the driver due to a status change in a more straight-forward way.

---
* This patch applies on top of virtio-1.4, which has not been released yet.

Quoted 5 lines

v0 -> v1:
* Rephrase commit message
---
device-types/can/description.tex | 13 ++++++-------

1 file changed, 6 insertions(+), 7 deletions(-)

LGTM:

Quoted 30 lines
device-types/can/description.tex +0 -0
index 2511d9c..b13da9c 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 

If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK

device-types/can/description.tex +6 -7
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification when the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.

On transition to the STOPPED state the device cancels all CAN messages already pending for transmission and marks them as used with

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0
#2 lore raw
In reply to Matias Ezequiel Vara Larsen
Quoted 39 lines · Matias Ezequiel Vara Larsen

Rephrase when the device may omit to notify the driver due to a status change in a more straight-forward way.

---
* This patch applies on top of virtio-1.4, which has not been released yet.

v0 -> v1:
* Rephrase commit message

---
 device-types/can/description.tex | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
device-types/can/description.tex +6 -7
index 2511d9c..b13da9c 100644
@@ -128,13 +128,12 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
 \end{lstlisting}
 
 If the transition succeeded the \field{result} is VIRTIO_CAN_RESULT_OK
-otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is
-necessary, the device updates the configuration \field{status} before
-marking the request used. As the configuration \field{status} change is
-caused by a request from the driver the device is allowed to omit the
-configuration change notification here. The device marks the request
-used when the CAN controller has finalized the transition to the
-requested controller mode.
+otherwise it is VIRTIO_CAN_RESULT_NOT_OK. If a status update is necessary, the
+device updates the configuration \field{status} before marking the request
+used. The device may omit the configuration change notification when the
+configuration \field{status} change is requested by the driver. The device
+marks the request used when the CAN controller has finalized the transition to
+the requested controller mode.
 
 On transition to the STOPPED state the device cancels all CAN messages
 already pending for transmission and marks them as used with
Quoted 4 lines

base-commit: 37c6a406678a5ee891fdf5671298cb4fcfa517f2

Signature · 1 line
2.42.0

Dear TC,

I'd like to request a vote on solving issue 199.