Skip to contentSkip to conversation

media: i2c: Add driver for Sony IMX728

PATCH Superseded Spencer Hill 4 participants 17 messages Jun 26, 2024 – Jun 28, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover media: i2c: Add driver for Sony IMX728

Add a v4l2 sensor driver for Sony IMX728

v4l2-compliance 1.24.1, 64 bits, 64-bit time_t

Compliance test for device /dev/v4l-subdev4:

Driver Info:

        Driver version   : 6.1.80
        Capabilities     : 0x00000002
                Streams Support

Required ioctls:
test VIDIOC_SUDBEV_QUERYCAP: OK
test invalid ioctls: OK

Allow for multiple opens:
test second /dev/v4l-subdev4 open: OK
test VIDIOC_SUBDEV_QUERYCAP: OK
test for unlimited opens: OK

Debug ioctls:
test VIDIOC_LOG_STATUS: OK (Not Supported)

Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0

Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0

Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)

Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 12 Private Controls: 0

Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported) test VIDIOC_G/S_PARM: OK (Not Supported)
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK (Not Supported)
test VIDIOC_TRY_FMT: OK (Not Supported)
test VIDIOC_S_FMT: OK (Not Supported)
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
test Cropping: OK (Not Supported)
test Composing: OK (Not Supported)
test Scaling: OK (Not Supported)

Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)

Buffer ioctls:
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported) test VIDIOC_EXPBUF: OK (Not Supported)
test Requests: OK (Not Supported)

Total for device /dev/v4l-subdev4: 43, Succeeded: 43, Failed: 0, Warnings: 0

Spencer Hill (2):
media: i2c: Add driver for Sony IMX728
media: dt-bindings: Add Sony IMX728

 .../bindings/media/i2c/sony,imx728.yaml       |   78 +
 MAINTAINERS                                   |    9 +
 drivers/media/i2c/Kconfig                     |   11 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/imx728.c                    | 1167 ++++++
 drivers/media/i2c/imx728.h                    | 3458 +++++++++++++++++
 6 files changed, 4724 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h

--
2.40.1

Please be aware that this email includes email addresses outside of the organization.

#1 lore raw

PATCH 1/2 media: i2c: Add driver for Sony IMX728

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +1167 -0

1,167 lines not on this page · raw message

drivers/media/i2c/imx728.h new file +3458 -0

1,809 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

--
2.40.1

Please be aware that this email includes email addresses outside of the organization.

Part of the diff is not shown here. View the raw message.

#2 lore raw
Quoted 4 lines · Spencer Hill

Add a driver for the Sony IMX728 image sensor.

---

...

Quoted 18 lines
drivers/media/i2c/imx728.c new file +18 -0
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,

drivers/media/i2c/imx728.c line 931

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);

dev_dbg
clock rates are easy to check from sysfs

...

drivers/media/i2c/imx728.c line 1036

Quoted 2 lines
drivers/media/i2c/imx728.c new file +2 -0
+
+       dev_info(imx728->dev, "imx728 probed\n");

No, drop. It's useless and there are existing interfaces telling you this.

Quoted 20 lines
drivers/media/i2c/imx728.c new file +20 -0
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;

drivers/media/i2c/imx728.c

Quoted 10 lines
drivers/media/i2c/imx728.c new file +8 -0
+}
 
 
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),

Drop of_match_ptr(), you have warnigns here.

Quoted 28 lines
(quoted diff) +26 -0
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
 
 
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;

Review

Quoted 10 lines
(quoted diff) +10 -0
+};
+
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },
+};
+
+static const u32 imx728_mbus_formats[] = {

No, NAK. You cannot have data allocations in header. This does not make any sense and leeds to duplicated structures.

Best regards,
Krzysztof

#3 lore raw
Quoted 41 lines · Krzysztof Kozlowski
Quoted 4 lines · Spencer Hill

Add a driver for the Sony IMX728 image sensor.

---

...

Quoted 18 lines
drivers/media/i2c/imx728.c new file +18 -0
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,

drivers/media/i2c/imx728.c line 931

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);

dev_dbg
clock rates are easy to check from sysfs

Quoted 2 lines

...

Will fix.

Quoted 5 lines

drivers/media/i2c/imx728.c line 1036

Quoted 2 lines
drivers/media/i2c/imx728.c new file +2 -0
+
+       dev_info(imx728->dev, "imx728 probed\n");

No, drop. It's useless and there are existing interfaces telling you this.

Okay

Quoted 23 lines
Quoted 21 lines
drivers/media/i2c/imx728.c new file +21 -0
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;
+}
Quoted 10 lines

drivers/media/i2c/imx728.c line 1156

Quoted 7 lines
drivers/media/i2c/imx728.c new file +7 -0
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),

Drop of_match_ptr(), you have warnigns here.

I'll remove that.

Quoted 33 lines
Quoted 33 lines
(quoted diff) +31 -0
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
 
 
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;
+};
+
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
Quoted 9 lines

drivers/media/i2c/imx728.h line 160

Quoted 5 lines
drivers/media/i2c/imx728.h new file +5 -0
+               .height = IMX728_OUT_HEIGHT,
+       },
+};
+
+static const u32 imx728_mbus_formats[] = {

No, NAK. You cannot have data allocations in header. This does not make any sense and leeds to duplicated structures.

I will be moving the code from the header into the c file in response to other feedback, does this solve this problem?

Quoted 5 lines

Best regards,
Krzysztof

Thanks,
Spencer
Please be aware that this email includes email addresses outside of the organization.

#4 lore raw
In reply to Spencer Hill

Hi Spencer,

thanks for the patch.

Just having a glimpse and giving some feedback.

Am Mittwoch, 26. Juni 2024, 23:15:28 CEST schrieb Spencer Hill:

Quoted 71 lines

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +19 -0
new file mode 100644
index 000000000000..b23359133a22
@@ -0,0 +1,1167 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/delay.h>
+#include <linux/clk.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/v4l2-mediabus.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-ctrls.h>

drivers/media/i2c/imx728.c line 29

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+#include <media/v4l2-event.h>
+
+#include "imx728.h"
+
+static inline struct imx728 *to_imx728(struct v4l2_subdev *sd)
+{
+       return container_of(sd, struct imx728, subdev);
+}
+
+static int imx728_read(struct imx728 *imx728, u16 addr, u32 *val, size_t nbytes)

Use cci_read instead and remove this function.

Quoted 7 lines
drivers/media/i2c/imx728.c new file +7 -0
+{
+       int ret;
+       __le32 val_le = 0;
+
+       ret = regmap_bulk_read(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0) {
+               dev_err(imx728->dev, "%s: failed to read reg 0x%04x: %d\n",

drivers/media/i2c/imx728.c line 46

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                       __func__, addr, ret);
+               return ret;
+       }
+
+       *val = le32_to_cpu(val_le);
+
+       return 0;
+}
+
+static int imx728_write(struct imx728 *imx728, u16 addr, u32 val, size_t nbytes)

Use cci_write instead and remove this function.

drivers/media/i2c/imx728.c line 59

Quoted 13 lines
drivers/media/i2c/imx728.c new file +13 -0
+{
+       int ret;
+       __le32 val_le = cpu_to_le32(val);
+
+       ret = regmap_bulk_write(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0)
+               dev_err(imx728->dev, "%s: failed to write reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+
+       return ret;
+}
+
+static int imx728_update_bits(struct imx728 *imx728, u16 addr, u32 val, u32 mask, size_t nbytes)

Use cci_update_bits instead and remove this function.

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+{
+       int ret;
+       u32 cfg;
+
+       ret = imx728_read(imx728, addr, &cfg, nbytes);
+       if (ret < 0)

drivers/media/i2c/imx728.c line 75

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+               return ret;
+
+       cfg = (val) ? (cfg | mask) : (cfg & (~mask));
+
+       return imx728_write(imx728, addr, cfg, nbytes);
+}
+
+static int imx728_write_table(struct imx728 *imx728,
+                             const struct reg_sequence *regs,
+                             unsigned int nr_regs)

Use cci_multi_reg_write instead and remove this function.

Quoted 7 lines
drivers/media/i2c/imx728.c new file +7 -0
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(imx728->regmap, regs, nr_regs);
+       if (ret < 0)
+               dev_err(imx728->dev,
+                       "%s: failed to write reg table (%d)!\n", __func__, ret);

drivers/media/i2c/imx728.c line 92

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       return ret;
+}
+
+static int imx728_wait_for_state(struct imx728 *imx728, enum imx728_sensor_state state)
+{
+       int ret, i;
+       u32 val;
+
+       for (i = 0; i < 50; i++) {
+               ret = imx728_read(imx728, 0x2CAC, &val, 1);

Please add proper register defines using CCI_REG* macros.

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+               if (ret == 0 && val == state) {
+                       dev_info(imx728->dev, "%s: Enter state %u\n", __func__, val);
+                       return 0;
+               }
+               usleep_range(1000, 10000);
+       }
+
+       return -EBUSY;
+}
+

drivers/media/i2c/imx728.c line 112

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+static void imx728_init_formats(struct v4l2_subdev_state *state)
+{
+       struct v4l2_mbus_framefmt *format;
+
+       format = v4l2_subdev_state_get_format(state, 0, 0);
+       format->code = imx728_mbus_formats[0];
+       format->width = imx728_framesizes[0].width;
+       format->height = imx728_framesizes[0].height;
+       format->field = V4L2_FIELD_NONE;
+       format->colorspace = V4L2_COLORSPACE_SMPTE170M;

Are you sure about this colorspace? I would have expected V4L2_COLORSPACE_RAW, but I don't know any details on this hardware.

Also set ycbcr_enc, quantization and xfer_func.

drivers/media/i2c/imx728.c line 116

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+}
+
+static int _imx728_set_routing(struct v4l2_subdev *sd,
+                              struct v4l2_subdev_state *state)

Why this special variant with a underscore? Just move the code into imx728_set_routing.

Quoted 101 lines
drivers/media/i2c/imx728.c new file +101 -0
+{
+       struct v4l2_subdev_route routes[] = {
+               {
+                       .source_pad = 0,
+                       .source_stream = 0,
+                       .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE,
+               },
+               {
+                       .source_pad = 0,
+                       .source_stream = 1,
+               }
+       };
+
+       struct v4l2_subdev_krouting routing = {
+               .num_routes = ARRAY_SIZE(routes),
+               .routes = routes,
+       };
+
+       int ret;
+
+       ret = v4l2_subdev_set_routing(sd, state, &routing);
+       if (ret < 0)
+               return ret;
+
+       imx728_init_formats(state);
+
+       return 0;
+}
+
+static int imx728_enum_mbus_code(struct v4l2_subdev *sd,
+                                struct v4l2_subdev_state *state,
+                                struct v4l2_subdev_mbus_code_enum *code)
+{
+
+       if (code->index >= ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       code->code = imx728_mbus_formats[code->index];
+
+       return 0;
+}
+
+static int imx728_enum_frame_sizes(struct v4l2_subdev *sd,
+                                  struct v4l2_subdev_state *state,
+                                  struct v4l2_subdev_frame_size_enum *fse)
+{
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fse->code)
+                       break;
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       if (fse->index >= ARRAY_SIZE(imx728_framesizes))
+               return -EINVAL;
+
+       fse->min_width = imx728_framesizes[fse->index].width;
+       fse->max_width = fse->min_width;
+       fse->min_height = imx728_framesizes[fse->index].height;
+       fse->max_height = fse->min_height;
+
+       return 0;
+}
+
+static int imx728_set_fmt(struct v4l2_subdev *sd,
+                         struct v4l2_subdev_state *state,
+                         struct v4l2_subdev_format *fmt)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       struct v4l2_mbus_framefmt *format;
+       const struct v4l2_area *fsize;
+       unsigned int i;
+       u32 code;
+       int ret = 0;
+
+       if (fmt->pad != 0)
+               return -EINVAL;
+
+       if (fmt->stream != 0)
+               return -EINVAL;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fmt->format.code) {
+                       code = fmt->format.code;
+                       break;
+               }
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               code = imx728_mbus_formats[0];
+
+       fsize = v4l2_find_nearest_size(imx728_framesizes,
+                                      ARRAY_SIZE(imx728_framesizes), width,
+                                      height, fmt->format.width,
+                                      fmt->format.height);
+
+       mutex_lock(&imx728->lock);
+

drivers/media/i2c/imx728.c line 227

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       format = v4l2_subdev_state_get_format(state, fmt->pad, fmt->stream);
+
+       if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE && imx728->streaming) {
+               ret = -EBUSY;
+               goto done;
+       }
+
+       format->code = code;
+       format->width = fsize->width;
+       format->height = fsize->height;

This should be done before calling v4l2_subdev_state_get_format, no? Also ycbcr_enc, quantization and xfer_func are missing.

Quoted 92 lines
drivers/media/i2c/imx728.c new file +92 -0
+
+       fmt->format = *format;
+
+done:
+       mutex_unlock(&imx728->lock);
+
+       return ret;
+}
+
+static int imx728_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
+                                struct v4l2_mbus_frame_desc *fd)
+{
+       struct v4l2_subdev_state *state;
+       struct v4l2_mbus_framefmt *fmt;
+       u32 bpp;
+       int ret = 0;
+
+       if (pad != 0)
+               return -EINVAL;
+
+       state = v4l2_subdev_lock_and_get_active_state(sd);
+
+       fmt = v4l2_subdev_state_get_format(state, 0, 0);
+       if (!fmt) {
+               ret = -EPIPE;
+               goto out;
+       }
+
+       memset(fd, 0, sizeof(*fd));
+
+       fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
+
+       bpp = 10;
+
+       fd->entry[fd->num_entries].stream = 0;
+
+       fd->entry[fd->num_entries].flags = V4L2_MBUS_FRAME_DESC_FL_LEN_MAX;
+       fd->entry[fd->num_entries].length = fmt->width * fmt->height * bpp / 8;
+       fd->entry[fd->num_entries].pixelcode = fmt->code;
+       fd->entry[fd->num_entries].bus.csi2.vc = 0;
+       fd->entry[fd->num_entries].bus.csi2.dt = 0x2b;
+
+       fd->num_entries++;
+
+out:
+
+       v4l2_subdev_unlock_state(state);
+
+       return ret;
+}
+
+static int imx728_set_routing(struct v4l2_subdev *sd,
+                             struct v4l2_subdev_state *state,
+                             enum v4l2_subdev_format_whence which,
+                             struct v4l2_subdev_krouting *routing)
+{
+       int ret;
+
+       if (routing->num_routes == 0 || routing->num_routes > 1)
+               return -EINVAL;
+
+       ret = _imx728_set_routing(sd, state);
+
+       return ret;
+}
+
+static int imx728_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+       struct imx728 *imx728 = container_of(ctrl->handler,
+                                       struct imx728, ctrl.handler);
+       int ret = 0;
+
+       dev_dbg(imx728->dev, "%s: %s, value: %d\n",
+                       __func__, ctrl->name, ctrl->val);
+
+       if (!pm_runtime_get_if_in_use(imx728->dev))
+               return 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_EXPOSURE:
+               ret = imx728_write(imx728, 0x98DC, ctrl->val, 4);
+               break;
+       case V4L2_CID_ANALOGUE_GAIN:
+               ret = imx728_update_bits(imx728, 0x98F8,
+                               (ctrl->val * 10),
+                               0x1FFFF, 4);
+               break;
+       case V4L2_CID_HFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val, 0x1, 1);
+               ret |= imx728_update_bits(imx728, 0xB67C,
+                                         ctrl->val, 0x1, 1);

drivers/media/i2c/imx728.c line 329

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+               break;
+       case V4L2_CID_VFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val << 1, 0x2, 1);
+               ret = imx728_update_bits(imx728, 0xB67D,
+                                        ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_WIDE_DYNAMIC_RANGE:
+       case V4L2_CID_TEST_PATTERN:
+               // Both of these are configured during start stream.

Are they not configurable while streaming?

Quoted 126 lines
drivers/media/i2c/imx728.c new file +126 -0
+               ret = 0;
+               break;
+       default:
+               ret = -EINVAL;
+       }
+
+       pm_runtime_put_noidle(imx728->dev);
+       return ret;
+}
+
+static int imx728_detect(struct imx728 *imx728)
+{
+       int ret;
+       u32 minor, major;
+
+       ret = imx728_read(imx728, 0x6002, &major, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MAJOR_VER!");
+               return ret;
+       }
+       ret = imx728_read(imx728, 0x6000, &minor, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MINOR_VER!");
+               return ret;
+       }
+       dev_dbg(imx728->dev, "Got version: %d.%d", major, minor);
+
+       return 0;
+}
+
+static int imx728_reset(struct imx728 *imx728)
+{
+
+       if (!IS_ERR_OR_NULL(imx728->xclr_gpio)) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+               usleep_range(1000, 10000);
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 0);
+               msleep(100);
+
+               return 0;
+       }
+
+       return -1;
+}
+
+static int imx728_power_on(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = clk_prepare_enable(imx728->clk);
+       if (ret < 0)
+               return ret;
+
+       imx728_reset(imx728);
+       return 0;
+}
+
+static int imx728_power_off(struct imx728 *imx728)
+{
+
+       if (imx728->xclr_gpio) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+
+               usleep_range(1, 10);
+       }
+       clk_disable_unprepare(imx728->clk);
+       return 0;
+}
+
+static int imx728_get_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = imx728->fps;
+       return 0;
+}
+
+static int imx728_set_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       u32 req_fps;
+
+       mutex_lock(&imx728->lock);
+
+       if (fi->interval.numerator == 0 || fi->interval.denominator == 0) {
+               fi->interval.denominator = IMX728_FRAMERATE_DEFAULT;
+               fi->interval.numerator = 1;
+       }
+
+       req_fps = clamp_val(DIV_ROUND_CLOSEST(fi->interval.denominator,
+                                             fi->interval.numerator),
+                           IMX728_FRAMERATE_MIN, IMX728_FRAMERATE_MAX);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = req_fps;
+
+       imx728->fps = req_fps;
+
+       mutex_unlock(&imx728->lock);
+       dev_dbg(imx728->dev, "%s frame rate = %d\n", __func__, imx728->fps);
+
+       return 0;
+}
+
+static int imx728_powerup_to_standby(struct imx728 *imx728)
+{
+       int ret;
+
+       dev_info(imx728->dev, "powerup -> standby...");
+
+       ret = imx728_reset(imx728);
+       if (ret) {
+               dev_err(imx728->dev, "Error resetting: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_SLEEP);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Sleep state!");
+               return ret;
+       }

drivers/media/i2c/imx728.c line 465

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+       ret = imx728_write(imx728, 0x1B20, imx728->clk_rate / 1000000, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B1C, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");

Error message doesn't seem to match. This is a fixed write, independent from any frequency.

Quoted 442 lines
drivers/media/i2c/imx728.c new file +442 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B05, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write to CK_SLEEP!");
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition from Sleep to Standby state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xFFFF, IMX728_REMAP_MODE_STANDBY, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write regmap mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_hdr_fixed_brightness(struct imx728 *imx728)
+{
+       int ret;
+
+       // Sony recommended values
+       unsigned int exposure_sp1_sp2_us = 10000;
+       unsigned int exposure_sp1vs_us = 56;
+       unsigned int sp1h_gain = 240;
+       unsigned int sp1l_gain = 75;
+       unsigned int sp1ec_gain = 21;
+       unsigned int sp2_gain = 33;
+       unsigned int sp1vs_gain = 84;
+
+       ret = imx728_write(imx728, 0x98DC, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98E4, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98EC, exposure_sp1vs_us, 4);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed exposure values.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x98F8,
+                         sp1h_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x98FC,
+                         sp1l_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9900,
+                         sp1ec_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9904,
+                         sp2_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9908,
+                         sp1vs_gain,
+                         0x1FFFF,
+                         4);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed gain values.");
+               return ret;
+       }
+
+       dev_info(imx728->dev, "Wrote fixed brightness for HDR");
+
+       return 0;
+}
+
+static int imx728_hdr_configure(
+       struct imx728 *imx728,
+       struct imx728_ctrl_point *points,
+       int hdr_bits)
+{
+       u32 hdr_norm_x0;
+       u32 hdr_norm_x1;
+       u32 hdr_norm_y0;
+       u32 hdr_norm_y1;
+
+       int ret;
+       int i;
+
+       switch (hdr_bits) {
+       case 20:
+               hdr_norm_x0 = 0x2000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xd000;
+               break;
+       case 24:
+               hdr_norm_x0 = 0x3000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xe000;
+               break;
+       default:
+               dev_err(imx728->dev, "%i bit HDR not supported.", hdr_bits);
+               break;
+       }
+
+       ret = imx728_write(imx728, 0x9C60, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C6C, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C64, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C70, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C68, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C74, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C6A, hdr_norm_y1, 2);
+       ret |= imx728_write(imx728, 0x9C76, hdr_norm_y1, 2);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed when setting HDR Normalization gains: %i", ret);
+               return ret;
+       }
+
+       for (i = 0; i < 16; i++) {
+               ret = imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_X(i),
+                       points->x, 4);
+
+               ret |= imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_Y(i),
+                       points->y, 4);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to write control point %i", i);
+                       return ret;
+               }
+
+               if ((points+1)->x >= 0 && (points+1)->y >= 0)
+                       points++;
+       }
+
+       return imx728_hdr_fixed_brightness(imx728);
+}
+
+static int imx728_configure(struct imx728 *imx728)
+{
+       int ret;
+       bool hdr = imx728->ctrl.wdr->val;
+       enum imx728_img_raw_mode img_out_mode;
+       enum imx728_drive_mode mode_sel;
+       enum imx728_aemode ae_mode;
+
+       if (hdr) {
+               img_out_mode = IMX728_IMG_MODE_HDR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       } else {
+               img_out_mode = IMX728_IMG_MODE_LINEAR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       }
+
+       ret = imx728_write(imx728, 0x98AC, ae_mode, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set AE mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xA248, IMX728_AWBMODE_FULL_MWB, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x1808, 0x1, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't enable full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E8, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98F0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       if (hdr) {
+               ret = imx728_hdr_configure(imx728, imx728_hdr_20bit, 20);
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Couldn't configure sensor for HDR mode: %i", ret);
+                       return ret;
+               }
+       }
+
+       dev_info(imx728->dev, "Disabling metadata...");
+       ret = imx728_write(imx728, 0x1708, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1709, 0x00, 1);
+       ret |= imx728_write(imx728, 0x170A, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1B40, 0x00, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling metadata: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x9728,
+                         mode_sel,
+                         0x7FFF,
+                         2);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write mode select.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0xEC7E,
+                         img_out_mode,
+                         0x7,
+                         1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't select image out mode.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xEC12, 0x28, 2);
+       ret |= imx728_write(imx728, 0xEC14, 0x0, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling OB output.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1761, 0x0, 1);
+       if (ret < 0)
+               dev_err(imx728->dev, "Error disabling skew calibration from sensor to SER");
+
+       switch (imx728->ctrl.pg_mode->val) {
+       case 0:
+               break;
+       case 1:
+               // Horizontal Color Bars
+               ret = imx728_write(imx728, 0x1A2A, 8, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x0, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x0, 1);
+               break;
+       case 2:
+               // Vertical Color Bars
+               ret = imx728_write(imx728, 0x1A2C, 16, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x1, 1);
+               break;
+       default:
+               break;
+       }
+
+       // Assume that everything except 'disabled' requires pattern gen enable
+       if (imx728->ctrl.pg_mode->val != 0) {
+               ret |= imx728_write(imx728, 0xB58E, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C4, 0x1, 1);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to enable PG mode.");
+                       return ret;
+               }
+       }
+
+       ret = imx728_update_bits(imx728, 0x9714,
+                         IMX728_RAW_SEL_SP1H,
+                         0x7,
+                         1);
+       ret |= imx728_update_bits(imx728, 0xB684,
+                          IMX728_RAW_SEL_SP1H,
+                          0x7,
+                          1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to set subpixel register");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_start_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_powerup_to_standby(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_write_table(imx728, imx728_3840x2160, ARRAY_SIZE(imx728_3840x2160));
+       if (ret < 0)
+               return ret;
+
+       msleep(100);
+
+       ret = imx728_configure(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = __v4l2_ctrl_handler_setup(imx728->subdev.ctrl_handler);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: failed to apply v4l2 ctrls: %d\n", __func__, ret);
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B04, 0x5C, 1);
+       if (ret < 0)
+               return ret;
+       ret = imx728_write(imx728, 0x1B04, 0xA3, 1);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STREAMING);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Streaming!");
+               return ret;
+       }
+
+       msleep(20);
+
+       return 0;
+}
+
+static int imx728_stop_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_write(imx728, 0x1B04, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error sending stop stream command: %i", ret);
+               return ret;
+       }
+
+       imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition out of Streaming mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       mutex_lock(&imx728->lock);
+       if (imx728->streaming == enable) {
+               mutex_unlock(&imx728->lock);
+               return 0;
+       }
+
+       if (enable) {
+               ret = pm_runtime_get_sync(imx728->dev);
+               if (ret < 0) {
+                       pm_runtime_put_noidle(imx728->dev);
+                       goto err_unlock;
+               }
+
+               ret = imx728_start_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+       } else {
+               ret = imx728_stop_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+               pm_runtime_mark_last_busy(imx728->dev);
+               pm_runtime_put_autosuspend(imx728->dev);
+       }
+
+       imx728->streaming = enable;
+
+       __v4l2_ctrl_grab(imx728->ctrl.wdr, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.h_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.v_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.pg_mode, enable);
+
+       mutex_unlock(&imx728->lock);
+       return 0;
+
+err_runtime_put:
+       pm_runtime_put(imx728->dev);
+
+err_unlock:
+       mutex_unlock(&imx728->lock);
+       dev_err(imx728->dev,
+               "%s: failed to setup streaming %d\n", __func__, ret);
+       return ret;
+}
+
+static const struct v4l2_subdev_core_ops imx728_core_ops = {
+       .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+       .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
+static const struct v4l2_subdev_video_ops imx728_subdev_video_ops = {
+       .s_stream = imx728_set_stream,
+};
+
+static const struct v4l2_subdev_pad_ops imx728_subdev_pad_ops = {
+       .enum_mbus_code = imx728_enum_mbus_code,
+       .enum_frame_size = imx728_enum_frame_sizes,
+       .get_fmt = v4l2_subdev_get_fmt,
+       .set_fmt = imx728_set_fmt,
+       .get_frame_interval = imx728_get_frame_interval,
+       .set_frame_interval = imx728_set_frame_interval,
+       .set_routing = imx728_set_routing,
+       .get_frame_desc = imx728_get_frame_desc,
+};
+
+static const struct v4l2_subdev_ops imx728_subdev_ops = {
+       .core  = &imx728_core_ops,
+       .video = &imx728_subdev_video_ops,
+       .pad   = &imx728_subdev_pad_ops,
+};
+
+static const struct v4l2_ctrl_ops imx728_ctrl_ops = {
+       .s_ctrl = imx728_set_ctrl,
+};
+
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;

drivers/media/i2c/imx728.c line 917

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);

Please use devm_cci_regmap_init_i2c().

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,

drivers/media/i2c/imx728.c line 931

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);

No need for this. clock frequency is available in debugfs if necessary.

drivers/media/i2c/imx728.h

Quoted 241 lines
drivers/media/i2c/imx728.c new file +236 -0
+
+       if (imx728->clk_rate < 18000000 || imx728->clk_rate > 30000000)
+               return -EINVAL;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_detect(imx728);
+       if (ret < 0)
+               return ret;
+
+       sd = &imx728->subdev;
+       v4l2_i2c_subdev_init(sd, client, &imx728_subdev_ops);
+
+       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                    V4L2_SUBDEV_FL_HAS_EVENTS |
+                    V4L2_SUBDEV_FL_STREAMS;
+
+       imx728->pad.flags = MEDIA_PAD_FL_SOURCE;
+       sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
+       ret = media_entity_pads_init(&sd->entity, 1, &imx728->pad);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: media entity init failed %d\n", __func__, ret);
+               return ret;
+       }
+
+       ctrl_hdr = &imx728->ctrl.handler;
+       ret = v4l2_ctrl_handler_init(ctrl_hdr, 8);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: ctrl handler init failed: %d\n", __func__, ret);
+               goto err_media_cleanup;
+       }
+
+       mutex_init(&imx728->lock);
+       imx728->ctrl.handler.lock = &imx728->lock;
+       imx728->fps = IMX728_FRAMERATE_DEFAULT;
+
+       imx728->ctrl.exposure = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                                 V4L2_CID_EXPOSURE, 0,
+                                                 33000, 1,
+                                                 IMX728_EXPOSURE_DEFAULT);
+
+       imx728->ctrl.again = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                              V4L2_CID_ANALOGUE_GAIN, 0,
+                                              102, 1,
+                                              24);
+
+       imx728->ctrl.wdr = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_WIDE_DYNAMIC_RANGE,
+                                            0, 1, 1, 1);
+
+       imx728->ctrl.h_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_HFLIP, 0, 1, 1, 0);
+
+       imx728->ctrl.v_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_VFLIP, 0, 1, 1, 0);
+
+       imx728->ctrl.pg_mode = v4l2_ctrl_new_std_menu_items(ctrl_hdr,
+                                       &imx728_ctrl_ops, V4L2_CID_TEST_PATTERN,
+                                       ARRAY_SIZE(imx728_ctrl_pg_qmenu) - 1,
+                                       0, 0, imx728_ctrl_pg_qmenu);
+
+       imx728->ctrl.pixel_rate = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE, 1,
+                                            IMX728_PIXEL_RATE);
+
+       imx728->ctrl.link_freq = v4l2_ctrl_new_int_menu(ctrl_hdr, &imx728_ctrl_ops,
+                                                V4L2_CID_LINK_FREQ,
+                                                ARRAY_SIZE(imx728_link_freq_menu) - 1, 0,
+                                                imx728_link_freq_menu);
+
+       if (imx728->ctrl.link_freq)
+               imx728->ctrl.link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+       imx728->subdev.ctrl_handler = ctrl_hdr;
+       if (imx728->ctrl.handler.error) {
+               ret = imx728->ctrl.handler.error;
+               dev_err(imx728->dev,
+                       "%s: failed to add the ctrls: %d\n", __func__, ret);
+               goto err_ctrl_free;
+       }
+
+       pm_runtime_set_active(imx728->dev);
+       pm_runtime_enable(imx728->dev);
+       pm_runtime_set_autosuspend_delay(imx728->dev, IMX728_PM_IDLE_TIMEOUT);
+       pm_runtime_use_autosuspend(imx728->dev);
+       pm_runtime_get_noresume(imx728->dev);
+
+       ret = v4l2_subdev_init_finalize(sd);
+       if (ret < 0)
+               goto err_pm_disable;
+
+       ret = v4l2_async_register_subdev(sd);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: v4l2 subdev register failed %d\n", __func__, ret);
+               goto err_subdev_cleanup;
+       }
+
+       dev_info(imx728->dev, "imx728 probed\n");
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;
+}
+
+static int __maybe_unused imx728_runtime_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int __maybe_unused imx728_runtime_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       imx728_power_off(imx728);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       if (imx728->streaming)
+               imx728_stop_stream(imx728);
+
+       ret = pm_runtime_force_suspend(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to suspend: %i\n", __func__, ret);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = pm_runtime_force_resume(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to resume: %i\n", __func__, ret);
+
+       if (imx728->streaming)
+               ret = imx728_start_stream(imx728);
+
+       if (ret < 0) {
+               imx728_stop_stream(imx728);
+               imx728->streaming = 0;
+               return ret;
+       }
+
+       return 0;
+}
+
+static void imx728_remove(struct i2c_client *client)
+{
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       v4l2_async_unregister_subdev(sd);
+       v4l2_ctrl_handler_free(&imx728->ctrl.handler);
+       v4l2_subdev_cleanup(&imx728->subdev);
+       media_entity_cleanup(&sd->entity);
+       mutex_destroy(&imx728->lock);
+
+       pm_runtime_disable(imx728->dev);
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_set_suspended(imx728->dev);
+}
+
+static const struct dev_pm_ops imx728_pm_ops = {
+       SET_RUNTIME_PM_OPS(imx728_runtime_suspend,
+                          imx728_runtime_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(imx728_suspend, imx728_resume)
+};
+
+static const struct of_device_id imx728_dt_id[] = {
+       { .compatible = "sony,imx728" },
+       { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
+
+MODULE_DESCRIPTION("Camera Sensor Driver for Sony IMX728");
+MODULE_AUTHOR("Spencer Hill <[email protected]>");
+MODULE_LICENSE("GPL");
drivers/media/i2c/imx728.h new file +0 -0
new file mode 100644
index 000000000000..6f320214b780

There is only a single user of this header, move this into the c file.

Quoted 103 lines
drivers/media/i2c/imx728.h new file +102 -0
@@ -0,0 +1,3458 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/types.h>
+
+#define IMX728_OUT_WIDTH               3840
+#define IMX728_OUT_HEIGHT              2160
+
+#define IMX728_FRAMERATE_MAX           30
+#define IMX728_FRAMERATE_DEFAULT       30
+#define IMX728_FRAMERATE_MIN           10
+
+#define IMX728_PIXEL_RATE              225504000
+#define IMX728_LINK_FREQ               800000000
+
+#define IMX728_EXPOSURE_DEFAULT                10000
+
+#define IMX728_PM_IDLE_TIMEOUT         1000
+
+
+#define IMX728_REG_CTRL_POINT_X(i) (0xA198 + (i) * 8)
+#define IMX728_REG_CTRL_POINT_Y(i) (IMX728_REG_CTRL_POINT_X(i) + 4)
+
+enum imx728_sensor_state {
+       IMX728_SENSOR_STATE_SLEEP               = 0x02,
+       IMX728_SENSOR_STATE_STANDBY             = 0x04,
+       IMX728_SENSOR_STATE_STREAMING           = 0x10,
+       IMX728_SENSOR_STATE_SAFE                = 0x20,
+};
+
+
+enum imx728_remap_mode_id {
+       IMX728_REMAP_MODE_STANDBY = 0x00,
+       IMX728_REMAP_MODE_STANDBY_PIXEL_SHADING_COMPENSATION = 0x01,
+       IMX728_REMAP_MODE_STANDBY_SPOT_PIXEL_COMPENSATION = 0x02,
+       IMX728_REMAP_MODE_STREAMING = 0x04,
+       IMX728_REMAP_MODE_STREAMING_PIXEL_SHADING_COMPENSATION = 0x05,
+       IMX728_REMAP_MODE_STREAMING_SPOT_PIXEL_COMPENSATION = 0x06,
+       IMX728_REMAP_MODE_SLEEP = 0x20,
+};
+
+enum imx728_drive_mode {
+       IMX728_MODE_3856x2176_45_4LANE_RAW10 = 0x01,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12 = 0x02,
+       IMX728_MODE_3856x2176_45_4LANE_RAW16 = 0x03,
+       IMX728_MODE_3856x2176_45_4LANE_RAW20 = 0x04,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12_HDR = 0x05,
+       IMX728_MODE_3856x2176_40_4LANE_RAW10 = 0x11,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12 = 0x12,
+       IMX728_MODE_3856x2176_40_4LANE_RAW16 = 0x13,
+       IMX728_MODE_3856x2176_40_4LANE_RAW20 = 0x14,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12_HDR = 0x16,
+};
+
+enum imx728_awbmode {
+       IMX728_AWBMODE_ATW = 0,
+       IMX728_AWBMODE_ALL_PULL_IN = 1,
+       IMX728_AWBMODE_USER_PRESET = 2,
+       IMX728_AWBMODE_FULL_MWB = 3,
+       IMX728_AWBMODE_HOLD = 4,
+};
+
+enum imx728_img_raw_mode {
+       IMX728_IMG_MODE_LINEAR = 0x0,
+       IMX728_IMG_MODE_LI = 0x1,
+       IMX728_IMG_MODE_HDR = 0x2,
+       IMX728_IMG_MODE_LI_HDR = 0x3,
+};
+
+enum imx728_aemode {
+       IMX728_AEMODE_AE_AUTO  = 0,
+       IMX728_AEMODE_AE_HOLD  = 1,
+       IMX728_AEMODE_SCALE_ME = 2,
+       IMX728_AEMODE_FULL_ME  = 3,
+};
+
+enum imx728_fme_shtval_unit {
+       IMX728_FME_SHTVAL_UNIT_LINES            = 1,
+       IMX728_FME_SHTVAL_UNIT_MICROSECONDS     = 3,
+       IMX728_FME_SHTVAL_UNIT_FRAMES           = 4,
+};
+
+enum imx728_linear_raw_sel {
+       IMX728_RAW_SEL_SP1H = 0x0,
+       IMX728_RAW_SEL_SP1L = 0x1,
+       IMX728_RAW_SEL_SP1EC = 0x2,
+       IMX728_RAW_SEL_SP2 = 0x3,
+       IMX728_RAW_SEL_SP1VS = 0x4
+};
+
+enum imx728_binn_avg {
+       IMX728_BINN_SIMPLE_AVG,
+       IMX728_BINN_WEIGHTED_AVG,
+};
+
+struct imx728_ctrl {
+       struct v4l2_ctrl_handler handler;
+       struct v4l2_ctrl *wdr;

drivers/media/i2c/imx728.h line 112

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       struct v4l2_ctrl *exposure;
+       struct v4l2_ctrl *again;
+       struct v4l2_ctrl *h_flip;
+       struct v4l2_ctrl *v_flip;
+       struct v4l2_ctrl *pg_mode;
+       struct v4l2_ctrl *pixel_rate;
+       struct v4l2_ctrl *link_freq;
+};
+
+struct imx728_ctrl_point {

What does ctrl_point mean? What is x and y?

Quoted 35 lines
drivers/media/i2c/imx728.h new file +35 -0
+       int x, y;
+};
+
+/*
+ * struct imx728 - imx728 device structure
+ * @dev: Device handle
+ * @clk: Pointer to imx728 clock
+ * @client: Pointer to I2C client
+ * @regmap: Pointer to regmap structure
+ * @xclr_gpio: Pointer to XCLR gpio
+ * @subdev: V4L2 subdevice structure
+ * @format: V4L2 media bus frame format structure
+ *             (width and height are in sync with the compose rect)
+ * @pad: Media pad structure
+ * @ctrl: imx728 control structure
+ * @clk_rate: Frequency of imx728 clock
+ * @lock: Mutex structure for V4L2 ctrl handler
+ * @streaming: Flag to store streaming on/off status
+ */
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;

drivers/media/i2c/imx728.h line 157

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+
+       struct mutex lock;
+       bool streaming;
+};
+
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },

Are you sure this is the only supported resolution? I would prefer using actual numbers here.

Quoted 22 lines
drivers/media/i2c/imx728.h new file +22 -0
+};
+
+static const u32 imx728_mbus_formats[] = {
+       MEDIA_BUS_FMT_SRGGB10_1X10,
+};
+
+static const s64 imx728_link_freq_menu[] = {
+       IMX728_LINK_FREQ,
+};
+
+static const struct regmap_config imx728_regmap_config = {
+       .reg_bits = 16,
+       .val_bits = 8,
+};
+
+static const char *const imx728_ctrl_pg_qmenu[] = {
+       "Disabled",
+       "Horizontal Color Bars",
+       "Vertical Color Bars",
+};
+
+static struct imx728_ctrl_point imx728_hdr_20bit[] = {

drivers/media/i2c/imx728.h line 189

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       {0, 0},
+       {1566 >> 4, 938},
+       {105740 >> 4, 1863},
+       {387380 >> 4, 2396},
+       {3818601 >> 4, 3251},
+       {16777215 >> 4, 4095},
+       {-1, -1}
+};
+
+static const struct reg_sequence imx728_3840x2160[] = {

Please use struct cci_reg_sequence.

Best regards,
Alexander

Quoted 11 lines
drivers/media/i2c/imx728.h new file +4 -1
+       {0xFFFF, 0x00, 1000},
+       {0x1749, 0x01},
+       {0x174B, 0x01},
[snip]
+};
--

2.40.1

Please be aware that this email includes email addresses outside of the organization.

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
#5 lore raw
Quoted 82 lines · Alexander Stein

Hi Spencer,

thanks for the patch.

Just having a glimpse and giving some feedback.

Am Mittwoch, 26. Juni 2024, 23:15:28 CEST schrieb Spencer Hill:

Quoted 75 lines

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +23 -0
new file mode 100644
index 000000000000..b23359133a22
@@ -0,0 +1,1167 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/delay.h>
+#include <linux/clk.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/v4l2-mediabus.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-event.h>
+
+#include "imx728.h"
+
Quoted 9 lines

drivers/media/i2c/imx728.c line 29

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+static inline struct imx728 *to_imx728(struct v4l2_subdev *sd)
+{
+       return container_of(sd, struct imx728, subdev);
+}
+
+static int imx728_read(struct imx728 *imx728, u16 addr, u32 *val, size_t nbytes)

Use cci_read instead and remove this function.

Will do.

Quoted 11 lines
Quoted 11 lines
drivers/media/i2c/imx728.c new file +11 -0
+{
+       int ret;
+       __le32 val_le = 0;
+
+       ret = regmap_bulk_read(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0) {
+               dev_err(imx728->dev, "%s: failed to read reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+               return ret;
+       }
+
Quoted 9 lines

drivers/media/i2c/imx728.c line 46

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+       *val = le32_to_cpu(val_le);
+
+       return 0;
+}
+
+static int imx728_write(struct imx728 *imx728, u16 addr, u32 val, size_t nbytes)

Use cci_write instead and remove this function.

Will do.

Quoted 7 lines
Quoted 7 lines
drivers/media/i2c/imx728.c new file +7 -0
+{
+       int ret;
+       __le32 val_le = cpu_to_le32(val);
+
+       ret = regmap_bulk_write(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0)
+               dev_err(imx728->dev, "%s: failed to write reg 0x%04x: %d\n",
Quoted 9 lines

drivers/media/i2c/imx728.c line 59

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+                       __func__, addr, ret);
+
+       return ret;
+}
+
+static int imx728_update_bits(struct imx728 *imx728, u16 addr, u32 val, u32 mask, size_t nbytes)

Use cci_update_bits instead and remove this function.

Will do.

Quoted 10 lines
Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+{
+       int ret;
+       u32 cfg;
+
+       ret = imx728_read(imx728, addr, &cfg, nbytes);
+       if (ret < 0)
+               return ret;
+
+       cfg = (val) ? (cfg | mask) : (cfg & (~mask));
+
Quoted 9 lines

drivers/media/i2c/imx728.c line 75

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+       return imx728_write(imx728, addr, cfg, nbytes);
+}
+
+static int imx728_write_table(struct imx728 *imx728,
+                             const struct reg_sequence *regs,
+                             unsigned int nr_regs)

Use cci_multi_reg_write instead and remove this function.

Will do.

Quoted 11 lines
Quoted 11 lines
drivers/media/i2c/imx728.c new file +11 -0
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(imx728->regmap, regs, nr_regs);
+       if (ret < 0)
+               dev_err(imx728->dev,
+                       "%s: failed to write reg table (%d)!\n", __func__, ret);
+       return ret;
+}
+
+static int imx728_wait_for_state(struct imx728 *imx728, enum imx728_sensor_state state)
Quoted 9 lines

drivers/media/i2c/imx728.c line 92

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+{
+       int ret, i;
+       u32 val;
+
+       for (i = 0; i < 50; i++) {
+               ret = imx728_read(imx728, 0x2CAC, &val, 1);

Please add proper register defines using CCI_REG* macros.

Is using those macros in place in these functions OK?

Quoted 24 lines
Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+               if (ret == 0 && val == state) {
+                       dev_info(imx728->dev, "%s: Enter state %u\n", __func__, val);
+                       return 0;
+               }
+               usleep_range(1000, 10000);
+       }
+
+       return -EBUSY;
+}
+

drivers/media/i2c/imx728.c line 112

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+static void imx728_init_formats(struct v4l2_subdev_state *state)
+{
+       struct v4l2_mbus_framefmt *format;
+
+       format = v4l2_subdev_state_get_format(state, 0, 0);
+       format->code = imx728_mbus_formats[0];
+       format->width = imx728_framesizes[0].width;
+       format->height = imx728_framesizes[0].height;
+       format->field = V4L2_FIELD_NONE;
+       format->colorspace = V4L2_COLORSPACE_SMPTE170M;

Are you sure about this colorspace? I would have expected V4L2_COLORSPACE_RAW, but I don't know any details on this hardware.

Quoted 2 lines

Also set ycbcr_enc, quantization and xfer_func.

V4L2_COLORSPACE_RAW is probably more correct.
I am not sure what would be correct for the ycbcr_enc, similar drivers seem to use V4L2_YCBCR_ENC_601, would that be correct here?

Quoted 8 lines

drivers/media/i2c/imx728.c line 116

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+}
+
+static int _imx728_set_routing(struct v4l2_subdev *sd,
+                              struct v4l2_subdev_state *state)

Why this special variant with a underscore? Just move the code into imx728_set_routing.

I will put this into the other function.

Quoted 106 lines
Quoted 106 lines
drivers/media/i2c/imx728.c new file +106 -0
+{
+       struct v4l2_subdev_route routes[] = {
+               {
+                       .source_pad = 0,
+                       .source_stream = 0,
+                       .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE,
+               },
+               {
+                       .source_pad = 0,
+                       .source_stream = 1,
+               }
+       };
+
+       struct v4l2_subdev_krouting routing = {
+               .num_routes = ARRAY_SIZE(routes),
+               .routes = routes,
+       };
+
+       int ret;
+
+       ret = v4l2_subdev_set_routing(sd, state, &routing);
+       if (ret < 0)
+               return ret;
+
+       imx728_init_formats(state);
+
+       return 0;
+}
+
+static int imx728_enum_mbus_code(struct v4l2_subdev *sd,
+                                struct v4l2_subdev_state *state,
+                                struct v4l2_subdev_mbus_code_enum *code)
+{
+
+       if (code->index >= ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       code->code = imx728_mbus_formats[code->index];
+
+       return 0;
+}
+
+static int imx728_enum_frame_sizes(struct v4l2_subdev *sd,
+                                  struct v4l2_subdev_state *state,
+                                  struct v4l2_subdev_frame_size_enum *fse)
+{
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fse->code)
+                       break;
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       if (fse->index >= ARRAY_SIZE(imx728_framesizes))
+               return -EINVAL;
+
+       fse->min_width = imx728_framesizes[fse->index].width;
+       fse->max_width = fse->min_width;
+       fse->min_height = imx728_framesizes[fse->index].height;
+       fse->max_height = fse->min_height;
+
+       return 0;
+}
+
+static int imx728_set_fmt(struct v4l2_subdev *sd,
+                         struct v4l2_subdev_state *state,
+                         struct v4l2_subdev_format *fmt)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       struct v4l2_mbus_framefmt *format;
+       const struct v4l2_area *fsize;
+       unsigned int i;
+       u32 code;
+       int ret = 0;
+
+       if (fmt->pad != 0)
+               return -EINVAL;
+
+       if (fmt->stream != 0)
+               return -EINVAL;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fmt->format.code) {
+                       code = fmt->format.code;
+                       break;
+               }
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               code = imx728_mbus_formats[0];
+
+       fsize = v4l2_find_nearest_size(imx728_framesizes,
+                                      ARRAY_SIZE(imx728_framesizes), width,
+                                      height, fmt->format.width,
+                                      fmt->format.height);
+
+       mutex_lock(&imx728->lock);
+
+       format = v4l2_subdev_state_get_format(state, fmt->pad, fmt->stream);
+
+       if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE && imx728->streaming) {
+               ret = -EBUSY;
+               goto done;
Quoted 9 lines

drivers/media/i2c/imx728.c line 227

Quoted 5 lines
drivers/media/i2c/imx728.c new file +5 -0
+       }
+
+       format->code = code;
+       format->width = fsize->width;
+       format->height = fsize->height;

This should be done before calling v4l2_subdev_state_get_format, no? Also ycbcr_enc, quantization and xfer_func are missing.

I will move these to be before get_format, more similar to the imx290 driver.

Quoted 96 lines
Quoted 96 lines
drivers/media/i2c/imx728.c new file +96 -0
+
+       fmt->format = *format;
+
+done:
+       mutex_unlock(&imx728->lock);
+
+       return ret;
+}
+
+static int imx728_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
+                                struct v4l2_mbus_frame_desc *fd)
+{
+       struct v4l2_subdev_state *state;
+       struct v4l2_mbus_framefmt *fmt;
+       u32 bpp;
+       int ret = 0;
+
+       if (pad != 0)
+               return -EINVAL;
+
+       state = v4l2_subdev_lock_and_get_active_state(sd);
+
+       fmt = v4l2_subdev_state_get_format(state, 0, 0);
+       if (!fmt) {
+               ret = -EPIPE;
+               goto out;
+       }
+
+       memset(fd, 0, sizeof(*fd));
+
+       fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
+
+       bpp = 10;
+
+       fd->entry[fd->num_entries].stream = 0;
+
+       fd->entry[fd->num_entries].flags = V4L2_MBUS_FRAME_DESC_FL_LEN_MAX;
+       fd->entry[fd->num_entries].length = fmt->width * fmt->height * bpp / 8;
+       fd->entry[fd->num_entries].pixelcode = fmt->code;
+       fd->entry[fd->num_entries].bus.csi2.vc = 0;
+       fd->entry[fd->num_entries].bus.csi2.dt = 0x2b;
+
+       fd->num_entries++;
+
+out:
+
+       v4l2_subdev_unlock_state(state);
+
+       return ret;
+}
+
+static int imx728_set_routing(struct v4l2_subdev *sd,
+                             struct v4l2_subdev_state *state,
+                             enum v4l2_subdev_format_whence which,
+                             struct v4l2_subdev_krouting *routing)
+{
+       int ret;
+
+       if (routing->num_routes == 0 || routing->num_routes > 1)
+               return -EINVAL;
+
+       ret = _imx728_set_routing(sd, state);
+
+       return ret;
+}
+
+static int imx728_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+       struct imx728 *imx728 = container_of(ctrl->handler,
+                                       struct imx728, ctrl.handler);
+       int ret = 0;
+
+       dev_dbg(imx728->dev, "%s: %s, value: %d\n",
+                       __func__, ctrl->name, ctrl->val);
+
+       if (!pm_runtime_get_if_in_use(imx728->dev))
+               return 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_EXPOSURE:
+               ret = imx728_write(imx728, 0x98DC, ctrl->val, 4);
+               break;
+       case V4L2_CID_ANALOGUE_GAIN:
+               ret = imx728_update_bits(imx728, 0x98F8,
+                               (ctrl->val * 10),
+                               0x1FFFF, 4);
+               break;
+       case V4L2_CID_HFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val, 0x1, 1);
+               ret |= imx728_update_bits(imx728, 0xB67C,
+                                         ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_VFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val << 1, 0x2, 1);
Quoted 9 lines

drivers/media/i2c/imx728.c line 329

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+               ret = imx728_update_bits(imx728, 0xB67D,
+                                        ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_WIDE_DYNAMIC_RANGE:
+       case V4L2_CID_TEST_PATTERN:
+               // Both of these are configured during start stream.

Are they not configurable while streaming?

My understanding is that this depends on the mode that the sensor is operating in. I believe in the current mode it should be possible to configure this during streaming. I will move the configuration into a new function and allow it to be configured while streaming.

Quoted 130 lines
Quoted 130 lines
drivers/media/i2c/imx728.c new file +130 -0
+               ret = 0;
+               break;
+       default:
+               ret = -EINVAL;
+       }
+
+       pm_runtime_put_noidle(imx728->dev);
+       return ret;
+}
+
+static int imx728_detect(struct imx728 *imx728)
+{
+       int ret;
+       u32 minor, major;
+
+       ret = imx728_read(imx728, 0x6002, &major, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MAJOR_VER!");
+               return ret;
+       }
+       ret = imx728_read(imx728, 0x6000, &minor, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MINOR_VER!");
+               return ret;
+       }
+       dev_dbg(imx728->dev, "Got version: %d.%d", major, minor);
+
+       return 0;
+}
+
+static int imx728_reset(struct imx728 *imx728)
+{
+
+       if (!IS_ERR_OR_NULL(imx728->xclr_gpio)) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+               usleep_range(1000, 10000);
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 0);
+               msleep(100);
+
+               return 0;
+       }
+
+       return -1;
+}
+
+static int imx728_power_on(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = clk_prepare_enable(imx728->clk);
+       if (ret < 0)
+               return ret;
+
+       imx728_reset(imx728);
+       return 0;
+}
+
+static int imx728_power_off(struct imx728 *imx728)
+{
+
+       if (imx728->xclr_gpio) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+
+               usleep_range(1, 10);
+       }
+       clk_disable_unprepare(imx728->clk);
+       return 0;
+}
+
+static int imx728_get_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = imx728->fps;
+       return 0;
+}
+
+static int imx728_set_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       u32 req_fps;
+
+       mutex_lock(&imx728->lock);
+
+       if (fi->interval.numerator == 0 || fi->interval.denominator == 0) {
+               fi->interval.denominator = IMX728_FRAMERATE_DEFAULT;
+               fi->interval.numerator = 1;
+       }
+
+       req_fps = clamp_val(DIV_ROUND_CLOSEST(fi->interval.denominator,
+                                             fi->interval.numerator),
+                           IMX728_FRAMERATE_MIN, IMX728_FRAMERATE_MAX);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = req_fps;
+
+       imx728->fps = req_fps;
+
+       mutex_unlock(&imx728->lock);
+       dev_dbg(imx728->dev, "%s frame rate = %d\n", __func__, imx728->fps);
+
+       return 0;
+}
+
+static int imx728_powerup_to_standby(struct imx728 *imx728)
+{
+       int ret;
+
+       dev_info(imx728->dev, "powerup -> standby...");
+
+       ret = imx728_reset(imx728);
+       if (ret) {
+               dev_err(imx728->dev, "Error resetting: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_SLEEP);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Sleep state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B20, imx728->clk_rate / 1000000, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
Quoted 9 lines

drivers/media/i2c/imx728.c line 465

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B1C, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");

Error message doesn't seem to match. This is a fixed write, independent from any frequency.

This write is the enable flag for the configured INCK frequency. By default the sensor ignores the user configured frequency until this is set.

Quoted 446 lines
Quoted 446 lines
drivers/media/i2c/imx728.c new file +446 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B05, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write to CK_SLEEP!");
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition from Sleep to Standby state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xFFFF, IMX728_REMAP_MODE_STANDBY, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write regmap mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_hdr_fixed_brightness(struct imx728 *imx728)
+{
+       int ret;
+
+       // Sony recommended values
+       unsigned int exposure_sp1_sp2_us = 10000;
+       unsigned int exposure_sp1vs_us = 56;
+       unsigned int sp1h_gain = 240;
+       unsigned int sp1l_gain = 75;
+       unsigned int sp1ec_gain = 21;
+       unsigned int sp2_gain = 33;
+       unsigned int sp1vs_gain = 84;
+
+       ret = imx728_write(imx728, 0x98DC, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98E4, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98EC, exposure_sp1vs_us, 4);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed exposure values.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x98F8,
+                         sp1h_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x98FC,
+                         sp1l_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9900,
+                         sp1ec_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9904,
+                         sp2_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9908,
+                         sp1vs_gain,
+                         0x1FFFF,
+                         4);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed gain values.");
+               return ret;
+       }
+
+       dev_info(imx728->dev, "Wrote fixed brightness for HDR");
+
+       return 0;
+}
+
+static int imx728_hdr_configure(
+       struct imx728 *imx728,
+       struct imx728_ctrl_point *points,
+       int hdr_bits)
+{
+       u32 hdr_norm_x0;
+       u32 hdr_norm_x1;
+       u32 hdr_norm_y0;
+       u32 hdr_norm_y1;
+
+       int ret;
+       int i;
+
+       switch (hdr_bits) {
+       case 20:
+               hdr_norm_x0 = 0x2000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xd000;
+               break;
+       case 24:
+               hdr_norm_x0 = 0x3000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xe000;
+               break;
+       default:
+               dev_err(imx728->dev, "%i bit HDR not supported.", hdr_bits);
+               break;
+       }
+
+       ret = imx728_write(imx728, 0x9C60, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C6C, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C64, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C70, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C68, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C74, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C6A, hdr_norm_y1, 2);
+       ret |= imx728_write(imx728, 0x9C76, hdr_norm_y1, 2);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed when setting HDR Normalization gains: %i", ret);
+               return ret;
+       }
+
+       for (i = 0; i < 16; i++) {
+               ret = imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_X(i),
+                       points->x, 4);
+
+               ret |= imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_Y(i),
+                       points->y, 4);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to write control point %i", i);
+                       return ret;
+               }
+
+               if ((points+1)->x >= 0 && (points+1)->y >= 0)
+                       points++;
+       }
+
+       return imx728_hdr_fixed_brightness(imx728);
+}
+
+static int imx728_configure(struct imx728 *imx728)
+{
+       int ret;
+       bool hdr = imx728->ctrl.wdr->val;
+       enum imx728_img_raw_mode img_out_mode;
+       enum imx728_drive_mode mode_sel;
+       enum imx728_aemode ae_mode;
+
+       if (hdr) {
+               img_out_mode = IMX728_IMG_MODE_HDR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       } else {
+               img_out_mode = IMX728_IMG_MODE_LINEAR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       }
+
+       ret = imx728_write(imx728, 0x98AC, ae_mode, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set AE mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xA248, IMX728_AWBMODE_FULL_MWB, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x1808, 0x1, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't enable full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E8, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98F0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       if (hdr) {
+               ret = imx728_hdr_configure(imx728, imx728_hdr_20bit, 20);
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Couldn't configure sensor for HDR mode: %i", ret);
+                       return ret;
+               }
+       }
+
+       dev_info(imx728->dev, "Disabling metadata...");
+       ret = imx728_write(imx728, 0x1708, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1709, 0x00, 1);
+       ret |= imx728_write(imx728, 0x170A, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1B40, 0x00, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling metadata: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x9728,
+                         mode_sel,
+                         0x7FFF,
+                         2);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write mode select.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0xEC7E,
+                         img_out_mode,
+                         0x7,
+                         1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't select image out mode.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xEC12, 0x28, 2);
+       ret |= imx728_write(imx728, 0xEC14, 0x0, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling OB output.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1761, 0x0, 1);
+       if (ret < 0)
+               dev_err(imx728->dev, "Error disabling skew calibration from sensor to SER");
+
+       switch (imx728->ctrl.pg_mode->val) {
+       case 0:
+               break;
+       case 1:
+               // Horizontal Color Bars
+               ret = imx728_write(imx728, 0x1A2A, 8, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x0, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x0, 1);
+               break;
+       case 2:
+               // Vertical Color Bars
+               ret = imx728_write(imx728, 0x1A2C, 16, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x1, 1);
+               break;
+       default:
+               break;
+       }
+
+       // Assume that everything except 'disabled' requires pattern gen enable
+       if (imx728->ctrl.pg_mode->val != 0) {
+               ret |= imx728_write(imx728, 0xB58E, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C4, 0x1, 1);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to enable PG mode.");
+                       return ret;
+               }
+       }
+
+       ret = imx728_update_bits(imx728, 0x9714,
+                         IMX728_RAW_SEL_SP1H,
+                         0x7,
+                         1);
+       ret |= imx728_update_bits(imx728, 0xB684,
+                          IMX728_RAW_SEL_SP1H,
+                          0x7,
+                          1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to set subpixel register");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_start_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_powerup_to_standby(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_write_table(imx728, imx728_3840x2160, ARRAY_SIZE(imx728_3840x2160));
+       if (ret < 0)
+               return ret;
+
+       msleep(100);
+
+       ret = imx728_configure(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = __v4l2_ctrl_handler_setup(imx728->subdev.ctrl_handler);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: failed to apply v4l2 ctrls: %d\n", __func__, ret);
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B04, 0x5C, 1);
+       if (ret < 0)
+               return ret;
+       ret = imx728_write(imx728, 0x1B04, 0xA3, 1);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STREAMING);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Streaming!");
+               return ret;
+       }
+
+       msleep(20);
+
+       return 0;
+}
+
+static int imx728_stop_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_write(imx728, 0x1B04, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error sending stop stream command: %i", ret);
+               return ret;
+       }
+
+       imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition out of Streaming mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       mutex_lock(&imx728->lock);
+       if (imx728->streaming == enable) {
+               mutex_unlock(&imx728->lock);
+               return 0;
+       }
+
+       if (enable) {
+               ret = pm_runtime_get_sync(imx728->dev);
+               if (ret < 0) {
+                       pm_runtime_put_noidle(imx728->dev);
+                       goto err_unlock;
+               }
+
+               ret = imx728_start_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+       } else {
+               ret = imx728_stop_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+               pm_runtime_mark_last_busy(imx728->dev);
+               pm_runtime_put_autosuspend(imx728->dev);
+       }
+
+       imx728->streaming = enable;
+
+       __v4l2_ctrl_grab(imx728->ctrl.wdr, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.h_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.v_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.pg_mode, enable);
+
+       mutex_unlock(&imx728->lock);
+       return 0;
+
+err_runtime_put:
+       pm_runtime_put(imx728->dev);
+
+err_unlock:
+       mutex_unlock(&imx728->lock);
+       dev_err(imx728->dev,
+               "%s: failed to setup streaming %d\n", __func__, ret);
+       return ret;
+}
+
+static const struct v4l2_subdev_core_ops imx728_core_ops = {
+       .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+       .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
+static const struct v4l2_subdev_video_ops imx728_subdev_video_ops = {
+       .s_stream = imx728_set_stream,
+};
+
+static const struct v4l2_subdev_pad_ops imx728_subdev_pad_ops = {
+       .enum_mbus_code = imx728_enum_mbus_code,
+       .enum_frame_size = imx728_enum_frame_sizes,
+       .get_fmt = v4l2_subdev_get_fmt,
+       .set_fmt = imx728_set_fmt,
+       .get_frame_interval = imx728_get_frame_interval,
+       .set_frame_interval = imx728_set_frame_interval,
+       .set_routing = imx728_set_routing,
+       .get_frame_desc = imx728_get_frame_desc,
+};
+
+static const struct v4l2_subdev_ops imx728_subdev_ops = {
+       .core  = &imx728_core_ops,
+       .video = &imx728_subdev_video_ops,
+       .pad   = &imx728_subdev_pad_ops,
+};
+
+static const struct v4l2_ctrl_ops imx728_ctrl_ops = {
+       .s_ctrl = imx728_set_ctrl,
+};
+
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
Quoted 9 lines

drivers/media/i2c/imx728.c line 917

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);

Please use devm_cci_regmap_init_i2c().

Will do.

Quoted 8 lines
Quoted 8 lines
drivers/media/i2c/imx728.c new file +8 -0
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
Quoted 9 lines

drivers/media/i2c/imx728.c line 931

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);

No need for this. clock frequency is available in debugfs if necessary.

I have changed this to a dev_dbg

Quoted 235 lines
Quoted 235 lines
drivers/media/i2c/imx728.c new file +235 -0
+
+       if (imx728->clk_rate < 18000000 || imx728->clk_rate > 30000000)
+               return -EINVAL;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_detect(imx728);
+       if (ret < 0)
+               return ret;
+
+       sd = &imx728->subdev;
+       v4l2_i2c_subdev_init(sd, client, &imx728_subdev_ops);
+
+       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                    V4L2_SUBDEV_FL_HAS_EVENTS |
+                    V4L2_SUBDEV_FL_STREAMS;
+
+       imx728->pad.flags = MEDIA_PAD_FL_SOURCE;
+       sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
+       ret = media_entity_pads_init(&sd->entity, 1, &imx728->pad);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: media entity init failed %d\n", __func__, ret);
+               return ret;
+       }
+
+       ctrl_hdr = &imx728->ctrl.handler;
+       ret = v4l2_ctrl_handler_init(ctrl_hdr, 8);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: ctrl handler init failed: %d\n", __func__, ret);
+               goto err_media_cleanup;
+       }
+
+       mutex_init(&imx728->lock);
+       imx728->ctrl.handler.lock = &imx728->lock;
+       imx728->fps = IMX728_FRAMERATE_DEFAULT;
+
+       imx728->ctrl.exposure = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                                 V4L2_CID_EXPOSURE, 0,
+                                                 33000, 1,
+                                                 IMX728_EXPOSURE_DEFAULT);
+
+       imx728->ctrl.again = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                              V4L2_CID_ANALOGUE_GAIN, 0,
+                                              102, 1,
+                                              24);
+
+       imx728->ctrl.wdr = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_WIDE_DYNAMIC_RANGE,
+                                            0, 1, 1, 1);
+
+       imx728->ctrl.h_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_HFLIP, 0, 1, 1, 0);
+
+       imx728->ctrl.v_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_VFLIP, 0, 1, 1, 0);
+
+       imx728->ctrl.pg_mode = v4l2_ctrl_new_std_menu_items(ctrl_hdr,
+                                       &imx728_ctrl_ops, V4L2_CID_TEST_PATTERN,
+                                       ARRAY_SIZE(imx728_ctrl_pg_qmenu) - 1,
+                                       0, 0, imx728_ctrl_pg_qmenu);
+
+       imx728->ctrl.pixel_rate = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE, 1,
+                                            IMX728_PIXEL_RATE);
+
+       imx728->ctrl.link_freq = v4l2_ctrl_new_int_menu(ctrl_hdr, &imx728_ctrl_ops,
+                                                V4L2_CID_LINK_FREQ,
+                                                ARRAY_SIZE(imx728_link_freq_menu) - 1, 0,
+                                                imx728_link_freq_menu);
+
+       if (imx728->ctrl.link_freq)
+               imx728->ctrl.link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+       imx728->subdev.ctrl_handler = ctrl_hdr;
+       if (imx728->ctrl.handler.error) {
+               ret = imx728->ctrl.handler.error;
+               dev_err(imx728->dev,
+                       "%s: failed to add the ctrls: %d\n", __func__, ret);
+               goto err_ctrl_free;
+       }
+
+       pm_runtime_set_active(imx728->dev);
+       pm_runtime_enable(imx728->dev);
+       pm_runtime_set_autosuspend_delay(imx728->dev, IMX728_PM_IDLE_TIMEOUT);
+       pm_runtime_use_autosuspend(imx728->dev);
+       pm_runtime_get_noresume(imx728->dev);
+
+       ret = v4l2_subdev_init_finalize(sd);
+       if (ret < 0)
+               goto err_pm_disable;
+
+       ret = v4l2_async_register_subdev(sd);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: v4l2 subdev register failed %d\n", __func__, ret);
+               goto err_subdev_cleanup;
+       }
+
+       dev_info(imx728->dev, "imx728 probed\n");
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;
+}
+
+static int __maybe_unused imx728_runtime_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int __maybe_unused imx728_runtime_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       imx728_power_off(imx728);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       if (imx728->streaming)
+               imx728_stop_stream(imx728);
+
+       ret = pm_runtime_force_suspend(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to suspend: %i\n", __func__, ret);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = pm_runtime_force_resume(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to resume: %i\n", __func__, ret);
+
+       if (imx728->streaming)
+               ret = imx728_start_stream(imx728);
+
+       if (ret < 0) {
+               imx728_stop_stream(imx728);
+               imx728->streaming = 0;
+               return ret;
+       }
+
+       return 0;
+}
+
+static void imx728_remove(struct i2c_client *client)
+{
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       v4l2_async_unregister_subdev(sd);
+       v4l2_ctrl_handler_free(&imx728->ctrl.handler);
+       v4l2_subdev_cleanup(&imx728->subdev);
+       media_entity_cleanup(&sd->entity);
+       mutex_destroy(&imx728->lock);
+
+       pm_runtime_disable(imx728->dev);
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_set_suspended(imx728->dev);
+}
+
+static const struct dev_pm_ops imx728_pm_ops = {
+       SET_RUNTIME_PM_OPS(imx728_runtime_suspend,
+                          imx728_runtime_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(imx728_suspend, imx728_resume)
+};
+
+static const struct of_device_id imx728_dt_id[] = {
+       { .compatible = "sony,imx728" },
+       { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
+
+MODULE_DESCRIPTION("Camera Sensor Driver for Sony IMX728");
+MODULE_AUTHOR("Spencer Hill <[email protected]>");
Quoted 9 lines

drivers/media/i2c/imx728.h

Quoted 6 lines
drivers/media/i2c/imx728.c new file +1 -0
+MODULE_LICENSE("GPL");
drivers/media/i2c/imx728.h new file +0 -0
new file mode 100644
index 000000000000..6f320214b780

There is only a single user of this header, move this into the c file.

I will combine these two files.

Quoted 107 lines
Quoted 107 lines
drivers/media/i2c/imx728.h new file +106 -0
@@ -0,0 +1,3458 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/types.h>
+
+#define IMX728_OUT_WIDTH               3840
+#define IMX728_OUT_HEIGHT              2160
+
+#define IMX728_FRAMERATE_MAX           30
+#define IMX728_FRAMERATE_DEFAULT       30
+#define IMX728_FRAMERATE_MIN           10
+
+#define IMX728_PIXEL_RATE              225504000
+#define IMX728_LINK_FREQ               800000000
+
+#define IMX728_EXPOSURE_DEFAULT                10000
+
+#define IMX728_PM_IDLE_TIMEOUT         1000
+
+
+#define IMX728_REG_CTRL_POINT_X(i) (0xA198 + (i) * 8)
+#define IMX728_REG_CTRL_POINT_Y(i) (IMX728_REG_CTRL_POINT_X(i) + 4)
+
+enum imx728_sensor_state {
+       IMX728_SENSOR_STATE_SLEEP               = 0x02,
+       IMX728_SENSOR_STATE_STANDBY             = 0x04,
+       IMX728_SENSOR_STATE_STREAMING           = 0x10,
+       IMX728_SENSOR_STATE_SAFE                = 0x20,
+};
+
+
+enum imx728_remap_mode_id {
+       IMX728_REMAP_MODE_STANDBY = 0x00,
+       IMX728_REMAP_MODE_STANDBY_PIXEL_SHADING_COMPENSATION = 0x01,
+       IMX728_REMAP_MODE_STANDBY_SPOT_PIXEL_COMPENSATION = 0x02,
+       IMX728_REMAP_MODE_STREAMING = 0x04,
+       IMX728_REMAP_MODE_STREAMING_PIXEL_SHADING_COMPENSATION = 0x05,
+       IMX728_REMAP_MODE_STREAMING_SPOT_PIXEL_COMPENSATION = 0x06,
+       IMX728_REMAP_MODE_SLEEP = 0x20,
+};
+
+enum imx728_drive_mode {
+       IMX728_MODE_3856x2176_45_4LANE_RAW10 = 0x01,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12 = 0x02,
+       IMX728_MODE_3856x2176_45_4LANE_RAW16 = 0x03,
+       IMX728_MODE_3856x2176_45_4LANE_RAW20 = 0x04,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12_HDR = 0x05,
+       IMX728_MODE_3856x2176_40_4LANE_RAW10 = 0x11,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12 = 0x12,
+       IMX728_MODE_3856x2176_40_4LANE_RAW16 = 0x13,
+       IMX728_MODE_3856x2176_40_4LANE_RAW20 = 0x14,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12_HDR = 0x16,
+};
+
+enum imx728_awbmode {
+       IMX728_AWBMODE_ATW = 0,
+       IMX728_AWBMODE_ALL_PULL_IN = 1,
+       IMX728_AWBMODE_USER_PRESET = 2,
+       IMX728_AWBMODE_FULL_MWB = 3,
+       IMX728_AWBMODE_HOLD = 4,
+};
+
+enum imx728_img_raw_mode {
+       IMX728_IMG_MODE_LINEAR = 0x0,
+       IMX728_IMG_MODE_LI = 0x1,
+       IMX728_IMG_MODE_HDR = 0x2,
+       IMX728_IMG_MODE_LI_HDR = 0x3,
+};
+
+enum imx728_aemode {
+       IMX728_AEMODE_AE_AUTO  = 0,
+       IMX728_AEMODE_AE_HOLD  = 1,
+       IMX728_AEMODE_SCALE_ME = 2,
+       IMX728_AEMODE_FULL_ME  = 3,
+};
+
+enum imx728_fme_shtval_unit {
+       IMX728_FME_SHTVAL_UNIT_LINES            = 1,
+       IMX728_FME_SHTVAL_UNIT_MICROSECONDS     = 3,
+       IMX728_FME_SHTVAL_UNIT_FRAMES           = 4,
+};
+
+enum imx728_linear_raw_sel {
+       IMX728_RAW_SEL_SP1H = 0x0,
+       IMX728_RAW_SEL_SP1L = 0x1,
+       IMX728_RAW_SEL_SP1EC = 0x2,
+       IMX728_RAW_SEL_SP2 = 0x3,
+       IMX728_RAW_SEL_SP1VS = 0x4
+};
+
+enum imx728_binn_avg {
+       IMX728_BINN_SIMPLE_AVG,
+       IMX728_BINN_WEIGHTED_AVG,
+};
+
+struct imx728_ctrl {
+       struct v4l2_ctrl_handler handler;
+       struct v4l2_ctrl *wdr;
+       struct v4l2_ctrl *exposure;
+       struct v4l2_ctrl *again;
+       struct v4l2_ctrl *h_flip;
+       struct v4l2_ctrl *v_flip;
Quoted 9 lines

drivers/media/i2c/imx728.h line 112

Quoted 6 lines
drivers/media/i2c/imx728.h new file +6 -0
+       struct v4l2_ctrl *pg_mode;
+       struct v4l2_ctrl *pixel_rate;
+       struct v4l2_ctrl *link_freq;
+};
+
+struct imx728_ctrl_point {

What does ctrl_point mean? What is x and y?

Control points are used internally by the sensor to adjust how the HDR data from the sensor is compressed into the output bit depth. The values used were provided by Sony.

Quoted 40 lines
Quoted 40 lines
drivers/media/i2c/imx728.h new file +40 -0
+       int x, y;
+};
+
+/*
+ * struct imx728 - imx728 device structure
+ * @dev: Device handle
+ * @clk: Pointer to imx728 clock
+ * @client: Pointer to I2C client
+ * @regmap: Pointer to regmap structure
+ * @xclr_gpio: Pointer to XCLR gpio
+ * @subdev: V4L2 subdevice structure
+ * @format: V4L2 media bus frame format structure
+ *             (width and height are in sync with the compose rect)
+ * @pad: Media pad structure
+ * @ctrl: imx728 control structure
+ * @clk_rate: Frequency of imx728 clock
+ * @lock: Mutex structure for V4L2 ctrl handler
+ * @streaming: Flag to store streaming on/off status
+ */
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;
+};
+
Quoted 9 lines

drivers/media/i2c/imx728.h line 157

Quoted 5 lines
drivers/media/i2c/imx728.h new file +5 -0
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },

Are you sure this is the only supported resolution? I would prefer using actual numbers here.

This is not the only supported resolution by the sensor, however it is the only resolution that I have a configuration for at the moment. I will remove the defines and switch to actual numbers to make supporting other resolutions easier in the future.

Quoted 35 lines
Quoted 22 lines
drivers/media/i2c/imx728.h new file +22 -0
+};
+
+static const u32 imx728_mbus_formats[] = {
+       MEDIA_BUS_FMT_SRGGB10_1X10,
+};
+
+static const s64 imx728_link_freq_menu[] = {
+       IMX728_LINK_FREQ,
+};
+
+static const struct regmap_config imx728_regmap_config = {
+       .reg_bits = 16,
+       .val_bits = 8,
+};
+
+static const char *const imx728_ctrl_pg_qmenu[] = {
+       "Disabled",
+       "Horizontal Color Bars",
+       "Vertical Color Bars",
+};
+
+static struct imx728_ctrl_point imx728_hdr_20bit[] = {

drivers/media/i2c/imx728.h line 189

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       {0, 0},
+       {1566 >> 4, 938},
+       {105740 >> 4, 1863},
+       {387380 >> 4, 2396},
+       {3818601 >> 4, 3251},
+       {16777215 >> 4, 4095},
+       {-1, -1}
+};
+
+static const struct reg_sequence imx728_3840x2160[] = {

Please use struct cci_reg_sequence.

Quoted 3 lines

Best regards,
Alexander

I will change this.

Quoted 13 lines
Quoted 11 lines
drivers/media/i2c/imx728.h new file +4 -1
+       {0xFFFF, 0x00, 1000},
+       {0x1749, 0x01},
+       {0x174B, 0x01},
[snip]
+};
--

2.40.1

Please be aware that this email includes email addresses outside of the organization.

Quoted 7 lines

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Please be aware that this email includes email addresses outside of the organization.

#6 lore raw

Hi,

Am Donnerstag, 27. Juni 2024, 20:39:04 CEST schrieb Spencer Hill:

Quoted 82 lines · Alexander Stein
Quoted 59 lines

Hi Spencer,

thanks for the patch.

Just having a glimpse and giving some feedback.

Am Mittwoch, 26. Juni 2024, 23:15:28 CEST schrieb Spencer Hill:

Quoted 52 lines

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +0 -0
new file mode 100644
index 000000000000..b23359133a22
@@ -0,0 +1,1167 @@

[snip]

Quoted 11 lines
Quoted 11 lines
drivers/media/i2c/imx728.c new file +11 -0
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(imx728->regmap, regs, nr_regs);
+       if (ret < 0)
+               dev_err(imx728->dev,
+                       "%s: failed to write reg table (%d)!\n", __func__, ret);
+       return ret;
+}
+
+static int imx728_wait_for_state(struct imx728 *imx728, enum imx728_sensor_state state)
Quoted 9 lines

drivers/media/i2c/imx728.c line 92

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+{
+       int ret, i;
+       u32 val;
+
+       for (i = 0; i < 50; i++) {
+               ret = imx728_read(imx728, 0x2CAC, &val, 1);

Please add proper register defines using CCI_REG* macros.

Quoted 1 line

Is using those macros in place in these functions OK?

List the registers on top of file, see for example imx415.c or imx290.c

Quoted 25 lines
Quoted 25 lines
Quoted 11 lines
drivers/media/i2c/imx728.c new file +10 -0
+               if (ret == 0 && val == state) {
+                       dev_info(imx728->dev, "%s: Enter state %u\n", __func__, val);
+                       return 0;
+               }
+               usleep_range(1000, 10000);
+       }
+
+       return -EBUSY;
+}
+

drivers/media/i2c/imx728.c line 112

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+static void imx728_init_formats(struct v4l2_subdev_state *state)
+{
+       struct v4l2_mbus_framefmt *format;
+
+       format = v4l2_subdev_state_get_format(state, 0, 0);
+       format->code = imx728_mbus_formats[0];
+       format->width = imx728_framesizes[0].width;
+       format->height = imx728_framesizes[0].height;
+       format->field = V4L2_FIELD_NONE;
+       format->colorspace = V4L2_COLORSPACE_SMPTE170M;

Are you sure about this colorspace? I would have expected V4L2_COLORSPACE_RAW, but I don't know any details on this hardware.

Quoted 6 lines
Quoted 2 lines

Also set ycbcr_enc, quantization and xfer_func.

V4L2_COLORSPACE_RAW is probably more correct.
I am not sure what would be correct for the ycbcr_enc, similar drivers seem to use V4L2_YCBCR_ENC_601, would that be correct here?

AFAICS V4L2_MAP_YCBCR_ENC_DEFAULT() converts V4L2_COLORSPACE_RAW to V4L2_YCBCR_ENC_601, so yes this seems correct. For the others use V4L2_XFER_FUNC_NONE and V4L2_QUANTIZATION_DEFAULT.

Quoted 44 lines
Quoted 8 lines

drivers/media/i2c/imx728.c line 116

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+}
+
+static int _imx728_set_routing(struct v4l2_subdev *sd,
+                              struct v4l2_subdev_state *state)

Why this special variant with a underscore? Just move the code into imx728_set_routing.

I will put this into the other function.

[snip]

Quoted 22 lines
Quoted 22 lines
drivers/media/i2c/imx728.c new file +22 -0
+
+static int imx728_powerup_to_standby(struct imx728 *imx728)
+{
+       int ret;
+
+       dev_info(imx728->dev, "powerup -> standby...");
+
+       ret = imx728_reset(imx728);
+       if (ret) {
+               dev_err(imx728->dev, "Error resetting: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_SLEEP);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Sleep state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B20, imx728->clk_rate / 1000000, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
Quoted 9 lines

drivers/media/i2c/imx728.c line 465

Quoted 6 lines
drivers/media/i2c/imx728.c new file +6 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B1C, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");

Error message doesn't seem to match. This is a fixed write, independent from any frequency.

Quoted 3 lines

This write is the enable flag for the configured INCK frequency. By default the sensor ignores the user configured frequency until this is set.

Okay, I see. But if you use a sequence of cci_write() calls you can instead raise an error message on call site, see imx290_set_clock() for that.

Quoted 209 lines
Quoted 24 lines
Quoted 24 lines
drivers/media/i2c/imx728.c new file +24 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B05, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write to CK_SLEEP!");
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition from Sleep to Standby state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xFFFF, IMX728_REMAP_MODE_STANDBY, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write regmap mode!");
+               return ret;
+       }
+
+       return 0;
+}
+

[snip]

Quoted 8 lines

drivers/media/i2c/imx728.h

Quoted 5 lines
drivers/media/i2c/imx728.h new file +0 -0
new file mode 100644
index 000000000000..6f320214b780

There is only a single user of this header, move this into the c file.

I will combine these two files.

Quoted 107 lines
Quoted 107 lines
drivers/media/i2c/imx728.h new file +106 -0
@@ -0,0 +1,3458 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/types.h>
+
+#define IMX728_OUT_WIDTH               3840
+#define IMX728_OUT_HEIGHT              2160
+
+#define IMX728_FRAMERATE_MAX           30
+#define IMX728_FRAMERATE_DEFAULT       30
+#define IMX728_FRAMERATE_MIN           10
+
+#define IMX728_PIXEL_RATE              225504000
+#define IMX728_LINK_FREQ               800000000
+
+#define IMX728_EXPOSURE_DEFAULT                10000
+
+#define IMX728_PM_IDLE_TIMEOUT         1000
+
+
+#define IMX728_REG_CTRL_POINT_X(i) (0xA198 + (i) * 8)
+#define IMX728_REG_CTRL_POINT_Y(i) (IMX728_REG_CTRL_POINT_X(i) + 4)
+
+enum imx728_sensor_state {
+       IMX728_SENSOR_STATE_SLEEP               = 0x02,
+       IMX728_SENSOR_STATE_STANDBY             = 0x04,
+       IMX728_SENSOR_STATE_STREAMING           = 0x10,
+       IMX728_SENSOR_STATE_SAFE                = 0x20,
+};
+
+
+enum imx728_remap_mode_id {
+       IMX728_REMAP_MODE_STANDBY = 0x00,
+       IMX728_REMAP_MODE_STANDBY_PIXEL_SHADING_COMPENSATION = 0x01,
+       IMX728_REMAP_MODE_STANDBY_SPOT_PIXEL_COMPENSATION = 0x02,
+       IMX728_REMAP_MODE_STREAMING = 0x04,
+       IMX728_REMAP_MODE_STREAMING_PIXEL_SHADING_COMPENSATION = 0x05,
+       IMX728_REMAP_MODE_STREAMING_SPOT_PIXEL_COMPENSATION = 0x06,
+       IMX728_REMAP_MODE_SLEEP = 0x20,
+};
+
+enum imx728_drive_mode {
+       IMX728_MODE_3856x2176_45_4LANE_RAW10 = 0x01,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12 = 0x02,
+       IMX728_MODE_3856x2176_45_4LANE_RAW16 = 0x03,
+       IMX728_MODE_3856x2176_45_4LANE_RAW20 = 0x04,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12_HDR = 0x05,
+       IMX728_MODE_3856x2176_40_4LANE_RAW10 = 0x11,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12 = 0x12,
+       IMX728_MODE_3856x2176_40_4LANE_RAW16 = 0x13,
+       IMX728_MODE_3856x2176_40_4LANE_RAW20 = 0x14,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12_HDR = 0x16,
+};
+
+enum imx728_awbmode {
+       IMX728_AWBMODE_ATW = 0,
+       IMX728_AWBMODE_ALL_PULL_IN = 1,
+       IMX728_AWBMODE_USER_PRESET = 2,
+       IMX728_AWBMODE_FULL_MWB = 3,
+       IMX728_AWBMODE_HOLD = 4,
+};
+
+enum imx728_img_raw_mode {
+       IMX728_IMG_MODE_LINEAR = 0x0,
+       IMX728_IMG_MODE_LI = 0x1,
+       IMX728_IMG_MODE_HDR = 0x2,
+       IMX728_IMG_MODE_LI_HDR = 0x3,
+};
+
+enum imx728_aemode {
+       IMX728_AEMODE_AE_AUTO  = 0,
+       IMX728_AEMODE_AE_HOLD  = 1,
+       IMX728_AEMODE_SCALE_ME = 2,
+       IMX728_AEMODE_FULL_ME  = 3,
+};
+
+enum imx728_fme_shtval_unit {
+       IMX728_FME_SHTVAL_UNIT_LINES            = 1,
+       IMX728_FME_SHTVAL_UNIT_MICROSECONDS     = 3,
+       IMX728_FME_SHTVAL_UNIT_FRAMES           = 4,
+};
+
+enum imx728_linear_raw_sel {
+       IMX728_RAW_SEL_SP1H = 0x0,
+       IMX728_RAW_SEL_SP1L = 0x1,
+       IMX728_RAW_SEL_SP1EC = 0x2,
+       IMX728_RAW_SEL_SP2 = 0x3,
+       IMX728_RAW_SEL_SP1VS = 0x4
+};
+
+enum imx728_binn_avg {
+       IMX728_BINN_SIMPLE_AVG,
+       IMX728_BINN_WEIGHTED_AVG,
+};
+
+struct imx728_ctrl {
+       struct v4l2_ctrl_handler handler;
+       struct v4l2_ctrl *wdr;
+       struct v4l2_ctrl *exposure;
+       struct v4l2_ctrl *again;
+       struct v4l2_ctrl *h_flip;
+       struct v4l2_ctrl *v_flip;
Quoted 9 lines

drivers/media/i2c/imx728.h line 112

Quoted 6 lines
drivers/media/i2c/imx728.h new file +6 -0
+       struct v4l2_ctrl *pg_mode;
+       struct v4l2_ctrl *pixel_rate;
+       struct v4l2_ctrl *link_freq;
+};
+
+struct imx728_ctrl_point {

What does ctrl_point mean? What is x and y?

Control points are used internally by the sensor to adjust how the HDR data from the sensor is compressed into the output bit depth. The values used were provided by Sony.

Quoted 40 lines
Quoted 40 lines
drivers/media/i2c/imx728.h new file +40 -0
+       int x, y;
+};
+
+/*
+ * struct imx728 - imx728 device structure
+ * @dev: Device handle
+ * @clk: Pointer to imx728 clock
+ * @client: Pointer to I2C client
+ * @regmap: Pointer to regmap structure
+ * @xclr_gpio: Pointer to XCLR gpio
+ * @subdev: V4L2 subdevice structure
+ * @format: V4L2 media bus frame format structure
+ *             (width and height are in sync with the compose rect)
+ * @pad: Media pad structure
+ * @ctrl: imx728 control structure
+ * @clk_rate: Frequency of imx728 clock
+ * @lock: Mutex structure for V4L2 ctrl handler
+ * @streaming: Flag to store streaming on/off status
+ */
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;
+};
+
Quoted 9 lines

drivers/media/i2c/imx728.h line 157

Quoted 5 lines
drivers/media/i2c/imx728.h new file +5 -0
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },

Are you sure this is the only supported resolution? I would prefer using actual numbers here.

Quoted 4 lines

This is not the only supported resolution by the sensor, however it is the only resolution that I have a configuration for at the moment. I will remove the defines and switch to actual numbers to make supporting other resolutions easier in the future.

Nice, thanks.

Best regards,
Alexander

Quoted 64 lines
Quoted 35 lines
Quoted 22 lines
drivers/media/i2c/imx728.h new file +22 -0
+};
+
+static const u32 imx728_mbus_formats[] = {
+       MEDIA_BUS_FMT_SRGGB10_1X10,
+};
+
+static const s64 imx728_link_freq_menu[] = {
+       IMX728_LINK_FREQ,
+};
+
+static const struct regmap_config imx728_regmap_config = {
+       .reg_bits = 16,
+       .val_bits = 8,
+};
+
+static const char *const imx728_ctrl_pg_qmenu[] = {
+       "Disabled",
+       "Horizontal Color Bars",
+       "Vertical Color Bars",
+};
+
+static struct imx728_ctrl_point imx728_hdr_20bit[] = {

drivers/media/i2c/imx728.h line 189

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       {0, 0},
+       {1566 >> 4, 938},
+       {105740 >> 4, 1863},
+       {387380 >> 4, 2396},
+       {3818601 >> 4, 3251},
+       {16777215 >> 4, 4095},
+       {-1, -1}
+};
+
+static const struct reg_sequence imx728_3840x2160[] = {

Please use struct cci_reg_sequence.

Quoted 3 lines

Best regards,
Alexander

I will change this.

Quoted 13 lines
Quoted 11 lines
drivers/media/i2c/imx728.h new file +4 -1
+       {0xFFFF, 0x00, 1000},
+       {0x1749, 0x01},
+       {0x174B, 0x01},
[snip]
+};
--

2.40.1

Please be aware that this email includes email addresses outside of the organization.

Quoted 7 lines

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Please be aware that this email includes email addresses outside of the organization.

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
#7 lore raw
In reply to Spencer Hill

Hi Spencer

Thanks for the patch - always nice to see new sensors being supported.

I assume there's no public datasheet for the sensor, but are you aware of even a product brief? Reviews are tricky without data to work with. I've just read through looking for discrepancies and common errors.

Quoted 194 lines · Spencer Hill

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +141 -0
new file mode 100644
index 000000000000..b23359133a22
@@ -0,0 +1,1167 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/delay.h>
+#include <linux/clk.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/v4l2-mediabus.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-event.h>
+
+#include "imx728.h"
+
+static inline struct imx728 *to_imx728(struct v4l2_subdev *sd)
+{
+       return container_of(sd, struct imx728, subdev);
+}
+
+static int imx728_read(struct imx728 *imx728, u16 addr, u32 *val, size_t nbytes)
+{
+       int ret;
+       __le32 val_le = 0;
+
+       ret = regmap_bulk_read(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0) {
+               dev_err(imx728->dev, "%s: failed to read reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+               return ret;
+       }
+
+       *val = le32_to_cpu(val_le);
+
+       return 0;
+}
+
+static int imx728_write(struct imx728 *imx728, u16 addr, u32 val, size_t nbytes)
+{
+       int ret;
+       __le32 val_le = cpu_to_le32(val);
+
+       ret = regmap_bulk_write(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0)
+               dev_err(imx728->dev, "%s: failed to write reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+
+       return ret;
+}
+
+static int imx728_update_bits(struct imx728 *imx728, u16 addr, u32 val, u32 mask, size_t nbytes)
+{
+       int ret;
+       u32 cfg;
+
+       ret = imx728_read(imx728, addr, &cfg, nbytes);
+       if (ret < 0)
+               return ret;
+
+       cfg = (val) ? (cfg | mask) : (cfg & (~mask));
+
+       return imx728_write(imx728, addr, cfg, nbytes);
+}
+
+static int imx728_write_table(struct imx728 *imx728,
+                             const struct reg_sequence *regs,
+                             unsigned int nr_regs)
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(imx728->regmap, regs, nr_regs);
+       if (ret < 0)
+               dev_err(imx728->dev,
+                       "%s: failed to write reg table (%d)!\n", __func__, ret);
+       return ret;
+}
+
+static int imx728_wait_for_state(struct imx728 *imx728, enum imx728_sensor_state state)
+{
+       int ret, i;
+       u32 val;
+
+       for (i = 0; i < 50; i++) {
+               ret = imx728_read(imx728, 0x2CAC, &val, 1);
+               if (ret == 0 && val == state) {
+                       dev_info(imx728->dev, "%s: Enter state %u\n", __func__, val);
+                       return 0;
+               }
+               usleep_range(1000, 10000);
+       }
+
+       return -EBUSY;
+}
+
+static void imx728_init_formats(struct v4l2_subdev_state *state)
+{
+       struct v4l2_mbus_framefmt *format;
+
+       format = v4l2_subdev_state_get_format(state, 0, 0);
+       format->code = imx728_mbus_formats[0];
+       format->width = imx728_framesizes[0].width;
+       format->height = imx728_framesizes[0].height;
+       format->field = V4L2_FIELD_NONE;
+       format->colorspace = V4L2_COLORSPACE_SMPTE170M;
+}
+
+static int _imx728_set_routing(struct v4l2_subdev *sd,
+                              struct v4l2_subdev_state *state)
+{
+       struct v4l2_subdev_route routes[] = {
+               {
+                       .source_pad = 0,
+                       .source_stream = 0,
+                       .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE,
+               },
+               {
+                       .source_pad = 0,
+                       .source_stream = 1,
+               }
+       };
+
+       struct v4l2_subdev_krouting routing = {
+               .num_routes = ARRAY_SIZE(routes),
+               .routes = routes,
+       };
+
+       int ret;
+
+       ret = v4l2_subdev_set_routing(sd, state, &routing);
+       if (ret < 0)
+               return ret;
+
+       imx728_init_formats(state);

drivers/media/i2c/imx728.c line 151

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+       return 0;
+}
+
+static int imx728_enum_mbus_code(struct v4l2_subdev *sd,
+                                struct v4l2_subdev_state *state,
+                                struct v4l2_subdev_mbus_code_enum *code)
+{
+
+       if (code->index >= ARRAY_SIZE(imx728_mbus_formats))

imx728_mbus_formats only lists MEDIA_BUS_FMT_SRGGB10_1X10. Is this for potential addition of the 12, 16, or 20 bit readout modes? How likely are those to actually happen?

Quoted 107 lines
drivers/media/i2c/imx728.c new file +107 -0
+               return -EINVAL;
+
+       code->code = imx728_mbus_formats[code->index];
+
+       return 0;
+}
+
+static int imx728_enum_frame_sizes(struct v4l2_subdev *sd,
+                                  struct v4l2_subdev_state *state,
+                                  struct v4l2_subdev_frame_size_enum *fse)
+{
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fse->code)
+                       break;
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       if (fse->index >= ARRAY_SIZE(imx728_framesizes))
+               return -EINVAL;
+
+       fse->min_width = imx728_framesizes[fse->index].width;
+       fse->max_width = fse->min_width;
+       fse->min_height = imx728_framesizes[fse->index].height;
+       fse->max_height = fse->min_height;
+
+       return 0;
+}
+
+static int imx728_set_fmt(struct v4l2_subdev *sd,
+                         struct v4l2_subdev_state *state,
+                         struct v4l2_subdev_format *fmt)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       struct v4l2_mbus_framefmt *format;
+       const struct v4l2_area *fsize;
+       unsigned int i;
+       u32 code;
+       int ret = 0;
+
+       if (fmt->pad != 0)
+               return -EINVAL;
+
+       if (fmt->stream != 0)
+               return -EINVAL;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fmt->format.code) {
+                       code = fmt->format.code;
+                       break;
+               }
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               code = imx728_mbus_formats[0];
+
+       fsize = v4l2_find_nearest_size(imx728_framesizes,
+                                      ARRAY_SIZE(imx728_framesizes), width,
+                                      height, fmt->format.width,
+                                      fmt->format.height);
+
+       mutex_lock(&imx728->lock);
+
+       format = v4l2_subdev_state_get_format(state, fmt->pad, fmt->stream);
+
+       if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE && imx728->streaming) {
+               ret = -EBUSY;
+               goto done;
+       }
+
+       format->code = code;
+       format->width = fsize->width;
+       format->height = fsize->height;
+
+       fmt->format = *format;
+
+done:
+       mutex_unlock(&imx728->lock);
+
+       return ret;
+}
+
+static int imx728_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
+                                struct v4l2_mbus_frame_desc *fd)
+{
+       struct v4l2_subdev_state *state;
+       struct v4l2_mbus_framefmt *fmt;
+       u32 bpp;
+       int ret = 0;
+
+       if (pad != 0)
+               return -EINVAL;
+
+       state = v4l2_subdev_lock_and_get_active_state(sd);
+
+       fmt = v4l2_subdev_state_get_format(state, 0, 0);
+       if (!fmt) {
+               ret = -EPIPE;
+               goto out;
+       }
+
+       memset(fd, 0, sizeof(*fd));
+
+       fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;

drivers/media/i2c/imx728.c line 268

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+       bpp = 10;
+
+       fd->entry[fd->num_entries].stream = 0;
+
+       fd->entry[fd->num_entries].flags = V4L2_MBUS_FRAME_DESC_FL_LEN_MAX;
+       fd->entry[fd->num_entries].length = fmt->width * fmt->height * bpp / 8;
+       fd->entry[fd->num_entries].pixelcode = fmt->code;
+       fd->entry[fd->num_entries].bus.csi2.vc = 0;
+       fd->entry[fd->num_entries].bus.csi2.dt = 0x2b;

Presumably this 0x2b is MIPI_CSI2_DT_RAW10.
That comes back to the question above as to whether supporting other bit depths is really likely, as if so then prepare to change this value based on mbus_code.

drivers/media/i2c/imx728.c line 270

Quoted 2 lines
drivers/media/i2c/imx728.c new file +2 -0
+
+       fd->num_entries++;

Presumably this fd->num_entries manipulation is due to expecting to support multiple data types? Whilst not wrong, at the moment it feels a little redundant.

Quoted 154 lines
drivers/media/i2c/imx728.c new file +154 -0
+
+out:
+
+       v4l2_subdev_unlock_state(state);
+
+       return ret;
+}
+
+static int imx728_set_routing(struct v4l2_subdev *sd,
+                             struct v4l2_subdev_state *state,
+                             enum v4l2_subdev_format_whence which,
+                             struct v4l2_subdev_krouting *routing)
+{
+       int ret;
+
+       if (routing->num_routes == 0 || routing->num_routes > 1)
+               return -EINVAL;
+
+       ret = _imx728_set_routing(sd, state);
+
+       return ret;
+}
+
+static int imx728_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+       struct imx728 *imx728 = container_of(ctrl->handler,
+                                       struct imx728, ctrl.handler);
+       int ret = 0;
+
+       dev_dbg(imx728->dev, "%s: %s, value: %d\n",
+                       __func__, ctrl->name, ctrl->val);
+
+       if (!pm_runtime_get_if_in_use(imx728->dev))
+               return 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_EXPOSURE:
+               ret = imx728_write(imx728, 0x98DC, ctrl->val, 4);
+               break;
+       case V4L2_CID_ANALOGUE_GAIN:
+               ret = imx728_update_bits(imx728, 0x98F8,
+                               (ctrl->val * 10),
+                               0x1FFFF, 4);
+               break;
+       case V4L2_CID_HFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val, 0x1, 1);
+               ret |= imx728_update_bits(imx728, 0xB67C,
+                                         ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_VFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val << 1, 0x2, 1);
+               ret = imx728_update_bits(imx728, 0xB67D,
+                                        ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_WIDE_DYNAMIC_RANGE:
+       case V4L2_CID_TEST_PATTERN:
+               // Both of these are configured during start stream.
+               ret = 0;
+               break;
+       default:
+               ret = -EINVAL;
+       }
+
+       pm_runtime_put_noidle(imx728->dev);
+       return ret;
+}
+
+static int imx728_detect(struct imx728 *imx728)
+{
+       int ret;
+       u32 minor, major;
+
+       ret = imx728_read(imx728, 0x6002, &major, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MAJOR_VER!");
+               return ret;
+       }
+       ret = imx728_read(imx728, 0x6000, &minor, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MINOR_VER!");
+               return ret;
+       }
+       dev_dbg(imx728->dev, "Got version: %d.%d", major, minor);
+
+       return 0;
+}
+
+static int imx728_reset(struct imx728 *imx728)
+{
+
+       if (!IS_ERR_OR_NULL(imx728->xclr_gpio)) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+               usleep_range(1000, 10000);
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 0);
+               msleep(100);
+
+               return 0;
+       }
+
+       return -1;
+}
+
+static int imx728_power_on(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = clk_prepare_enable(imx728->clk);
+       if (ret < 0)
+               return ret;
+
+       imx728_reset(imx728);
+       return 0;
+}
+
+static int imx728_power_off(struct imx728 *imx728)
+{
+
+       if (imx728->xclr_gpio) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+
+               usleep_range(1, 10);
+       }
+       clk_disable_unprepare(imx728->clk);
+       return 0;
+}
+
+static int imx728_get_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = imx728->fps;
+       return 0;
+}
+
+static int imx728_set_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       u32 req_fps;
+
+       mutex_lock(&imx728->lock);
+
+       if (fi->interval.numerator == 0 || fi->interval.denominator == 0) {
+               fi->interval.denominator = IMX728_FRAMERATE_DEFAULT;
+               fi->interval.numerator = 1;
+       }
+
+       req_fps = clamp_val(DIV_ROUND_CLOSEST(fi->interval.denominator,

drivers/media/i2c/imx728.c line 434

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                                             fi->interval.numerator),
+                           IMX728_FRAMERATE_MIN, IMX728_FRAMERATE_MAX);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = req_fps;
+
+       imx728->fps = req_fps;
+
+       mutex_unlock(&imx728->lock);
+       dev_dbg(imx728->dev, "%s frame rate = %d\n", __func__, imx728->fps);

Is setting the frame rate actually supported in the driver? I can't see imx728->fps being used other than to return the value in imx728_get_frame_interval.

Frame rate control on raw sensors is normally controlled through
V4L2_CID_VBLANK and V4L2_CID_HBLANK, not these ioctls.
See https://www.kernel.org/doc/html/latest/userspace-api/media/drivers/camera-sensor.html#raw-camera-sensors

Quoted 183 lines
drivers/media/i2c/imx728.c new file +183 -0
+
+       return 0;
+}
+
+static int imx728_powerup_to_standby(struct imx728 *imx728)
+{
+       int ret;
+
+       dev_info(imx728->dev, "powerup -> standby...");
+
+       ret = imx728_reset(imx728);
+       if (ret) {
+               dev_err(imx728->dev, "Error resetting: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_SLEEP);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Sleep state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B20, imx728->clk_rate / 1000000, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B1C, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B05, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write to CK_SLEEP!");
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition from Sleep to Standby state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xFFFF, IMX728_REMAP_MODE_STANDBY, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write regmap mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_hdr_fixed_brightness(struct imx728 *imx728)
+{
+       int ret;
+
+       // Sony recommended values
+       unsigned int exposure_sp1_sp2_us = 10000;
+       unsigned int exposure_sp1vs_us = 56;
+       unsigned int sp1h_gain = 240;
+       unsigned int sp1l_gain = 75;
+       unsigned int sp1ec_gain = 21;
+       unsigned int sp2_gain = 33;
+       unsigned int sp1vs_gain = 84;
+
+       ret = imx728_write(imx728, 0x98DC, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98E4, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98EC, exposure_sp1vs_us, 4);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed exposure values.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x98F8,
+                         sp1h_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x98FC,
+                         sp1l_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9900,
+                         sp1ec_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9904,
+                         sp2_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9908,
+                         sp1vs_gain,
+                         0x1FFFF,
+                         4);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed gain values.");
+               return ret;
+       }
+
+       dev_info(imx728->dev, "Wrote fixed brightness for HDR");
+
+       return 0;
+}
+
+static int imx728_hdr_configure(
+       struct imx728 *imx728,
+       struct imx728_ctrl_point *points,
+       int hdr_bits)
+{
+       u32 hdr_norm_x0;
+       u32 hdr_norm_x1;
+       u32 hdr_norm_y0;
+       u32 hdr_norm_y1;
+
+       int ret;
+       int i;
+
+       switch (hdr_bits) {
+       case 20:
+               hdr_norm_x0 = 0x2000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xd000;
+               break;
+       case 24:
+               hdr_norm_x0 = 0x3000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xe000;
+               break;
+       default:
+               dev_err(imx728->dev, "%i bit HDR not supported.", hdr_bits);
+               break;
+       }
+
+       ret = imx728_write(imx728, 0x9C60, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C6C, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C64, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C70, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C68, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C74, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C6A, hdr_norm_y1, 2);
+       ret |= imx728_write(imx728, 0x9C76, hdr_norm_y1, 2);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed when setting HDR Normalization gains: %i", ret);
+               return ret;
+       }
+
+       for (i = 0; i < 16; i++) {
+               ret = imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_X(i),
+                       points->x, 4);
+
+               ret |= imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_Y(i),
+                       points->y, 4);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to write control point %i", i);
+                       return ret;
+               }
+
+               if ((points+1)->x >= 0 && (points+1)->y >= 0)
+                       points++;
+       }
+
+       return imx728_hdr_fixed_brightness(imx728);
+}
+
+static int imx728_configure(struct imx728 *imx728)
+{
+       int ret;
+       bool hdr = imx728->ctrl.wdr->val;
+       enum imx728_img_raw_mode img_out_mode;
+       enum imx728_drive_mode mode_sel;

drivers/media/i2c/imx728.c line 627

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       enum imx728_aemode ae_mode;
+
+       if (hdr) {
+               img_out_mode = IMX728_IMG_MODE_HDR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       } else {
+               img_out_mode = IMX728_IMG_MODE_LINEAR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;

Unless my eyes deceive me, mode_sel and ae_mode are the same in both modes. Why do they need to be conditional?

Quoted 29 lines
drivers/media/i2c/imx728.c new file +29 -0
+       }
+
+       ret = imx728_write(imx728, 0x98AC, ae_mode, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set AE mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xA248, IMX728_AWBMODE_FULL_MWB, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x1808, 0x1, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't enable full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E8, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");

drivers/media/i2c/imx728.c line 666

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98F0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       if (hdr) {

The xclr GPIO is optional, so is there a guaranteed register reset in the big table to reset these HDR registers back to defaults?

Quoted 37 lines
drivers/media/i2c/imx728.c new file +37 -0
+               ret = imx728_hdr_configure(imx728, imx728_hdr_20bit, 20);
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Couldn't configure sensor for HDR mode: %i", ret);
+                       return ret;
+               }
+       }
+
+       dev_info(imx728->dev, "Disabling metadata...");
+       ret = imx728_write(imx728, 0x1708, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1709, 0x00, 1);
+       ret |= imx728_write(imx728, 0x170A, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1B40, 0x00, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling metadata: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x9728,
+                         mode_sel,
+                         0x7FFF,
+                         2);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write mode select.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0xEC7E,
+                         img_out_mode,
+                         0x7,
+                         1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't select image out mode.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xEC12, 0x28, 2);
+       ret |= imx728_write(imx728, 0xEC14, 0x0, 1);

drivers/media/i2c/imx728.c line 713

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling OB output.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1761, 0x0, 1);
+       if (ret < 0)
+               dev_err(imx728->dev, "Error disabling skew calibration from sensor to SER");
+
+       switch (imx728->ctrl.pg_mode->val) {

Even if the test mode can't be changed whilst running, this could be in imx728_set_ctrl as it'll be called by __v4l2_ctrl_handler_setup

drivers/media/i2c/imx728.c line 714

Quoted 1 line
drivers/media/i2c/imx728.c new file +1 -0
+       case 0:

Again xclr GPIO is optional. Are these reset to defaults?

Quoted 47 lines
drivers/media/i2c/imx728.c new file +47 -0
+               break;
+       case 1:
+               // Horizontal Color Bars
+               ret = imx728_write(imx728, 0x1A2A, 8, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x0, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x0, 1);
+               break;
+       case 2:
+               // Vertical Color Bars
+               ret = imx728_write(imx728, 0x1A2C, 16, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x1, 1);
+               break;
+       default:
+               break;
+       }
+
+       // Assume that everything except 'disabled' requires pattern gen enable
+       if (imx728->ctrl.pg_mode->val != 0) {
+               ret |= imx728_write(imx728, 0xB58E, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C4, 0x1, 1);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to enable PG mode.");
+                       return ret;
+               }
+       }
+
+       ret = imx728_update_bits(imx728, 0x9714,
+                         IMX728_RAW_SEL_SP1H,
+                         0x7,
+                         1);
+       ret |= imx728_update_bits(imx728, 0xB684,
+                          IMX728_RAW_SEL_SP1H,
+                          0x7,
+                          1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to set subpixel register");
+               return ret;
+       }
+
+       return 0;
+}

drivers/media/i2c/imx728.c line 771

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+static int imx728_start_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_powerup_to_standby(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_write_table(imx728, imx728_3840x2160, ARRAY_SIZE(imx728_3840x2160));

You've enabled delayed suspend through pm_runtime, but you're always sending the whole of this array. Is there an option for only resending on actual power up to reduce the time to restart if the device hasn't suspended?

Quoted 110 lines
drivers/media/i2c/imx728.c new file +110 -0
+       if (ret < 0)
+               return ret;
+
+       msleep(100);
+
+       ret = imx728_configure(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = __v4l2_ctrl_handler_setup(imx728->subdev.ctrl_handler);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: failed to apply v4l2 ctrls: %d\n", __func__, ret);
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B04, 0x5C, 1);
+       if (ret < 0)
+               return ret;
+       ret = imx728_write(imx728, 0x1B04, 0xA3, 1);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STREAMING);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Streaming!");
+               return ret;
+       }
+
+       msleep(20);
+
+       return 0;
+}
+
+static int imx728_stop_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_write(imx728, 0x1B04, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error sending stop stream command: %i", ret);
+               return ret;
+       }
+
+       imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition out of Streaming mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       mutex_lock(&imx728->lock);
+       if (imx728->streaming == enable) {
+               mutex_unlock(&imx728->lock);
+               return 0;
+       }
+
+       if (enable) {
+               ret = pm_runtime_get_sync(imx728->dev);
+               if (ret < 0) {
+                       pm_runtime_put_noidle(imx728->dev);
+                       goto err_unlock;
+               }
+
+               ret = imx728_start_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+       } else {
+               ret = imx728_stop_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+               pm_runtime_mark_last_busy(imx728->dev);
+               pm_runtime_put_autosuspend(imx728->dev);
+       }
+
+       imx728->streaming = enable;
+
+       __v4l2_ctrl_grab(imx728->ctrl.wdr, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.h_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.v_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.pg_mode, enable);
+
+       mutex_unlock(&imx728->lock);
+       return 0;
+
+err_runtime_put:
+       pm_runtime_put(imx728->dev);
+
+err_unlock:
+       mutex_unlock(&imx728->lock);
+       dev_err(imx728->dev,
+               "%s: failed to setup streaming %d\n", __func__, ret);
+       return ret;
+}
+
+static const struct v4l2_subdev_core_ops imx728_core_ops = {
+       .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+       .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
+static const struct v4l2_subdev_video_ops imx728_subdev_video_ops = {
+       .s_stream = imx728_set_stream,
+};

drivers/media/i2c/imx728.c line 891

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+static const struct v4l2_subdev_pad_ops imx728_subdev_pad_ops = {
+       .enum_mbus_code = imx728_enum_mbus_code,
+       .enum_frame_size = imx728_enum_frame_sizes,
+       .get_fmt = v4l2_subdev_get_fmt,
+       .set_fmt = imx728_set_fmt,
+       .get_frame_interval = imx728_get_frame_interval,
+       .set_frame_interval = imx728_set_frame_interval,
+       .set_routing = imx728_set_routing,
+       .get_frame_desc = imx728_get_frame_desc,

Support for get_selection would be nice to reflect the array geometry, assuming the information is in the datasheet. It's likely to be mandatory for libcamera soon.

Quoted 74 lines
drivers/media/i2c/imx728.c new file +74 -0
+};
+
+static const struct v4l2_subdev_ops imx728_subdev_ops = {
+       .core  = &imx728_core_ops,
+       .video = &imx728_subdev_video_ops,
+       .pad   = &imx728_subdev_pad_ops,
+};
+
+static const struct v4l2_ctrl_ops imx728_ctrl_ops = {
+       .s_ctrl = imx728_set_ctrl,
+};
+
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);
+
+       if (imx728->clk_rate < 18000000 || imx728->clk_rate > 30000000)
+               return -EINVAL;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_detect(imx728);
+       if (ret < 0)
+               return ret;
+
+       sd = &imx728->subdev;
+       v4l2_i2c_subdev_init(sd, client, &imx728_subdev_ops);
+
+       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                    V4L2_SUBDEV_FL_HAS_EVENTS |
+                    V4L2_SUBDEV_FL_STREAMS;
+
+       imx728->pad.flags = MEDIA_PAD_FL_SOURCE;
+       sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
+       ret = media_entity_pads_init(&sd->entity, 1, &imx728->pad);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: media entity init failed %d\n", __func__, ret);
+               return ret;
+       }
+
+       ctrl_hdr = &imx728->ctrl.handler;
+       ret = v4l2_ctrl_handler_init(ctrl_hdr, 8);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: ctrl handler init failed: %d\n", __func__, ret);
+               goto err_media_cleanup;

drivers/media/i2c/imx728.c line 975

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       }
+
+       mutex_init(&imx728->lock);
+       imx728->ctrl.handler.lock = &imx728->lock;
+       imx728->fps = IMX728_FRAMERATE_DEFAULT;
+
+       imx728->ctrl.exposure = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                                 V4L2_CID_EXPOSURE, 0,
+                                                 33000, 1,
+                                                 IMX728_EXPOSURE_DEFAULT);

That looks like you're clipping the max exposure time based on 30fps, and the units are usecs.
Units on V4L2_CID_EXPOSURE are undefined, and normally expected to be lines for raw image sensors, but that then needs to know HBLANK and PIXEL_RATE.
There is V4L2_CID_EXPOSURE_ABSOLUTE which has defined units of 100usecs, but I'm not sure if that is very useful in this case.

Quoted 5 lines
drivers/media/i2c/imx728.c new file +5 -0
+
+       imx728->ctrl.again = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                              V4L2_CID_ANALOGUE_GAIN, 0,
+                                              102, 1,
+                                              24);

drivers/media/i2c/imx728.c line 990

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+
+       imx728->ctrl.wdr = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_WIDE_DYNAMIC_RANGE,
+                                            0, 1, 1, 1);
+
+       imx728->ctrl.h_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_HFLIP, 0, 1, 1, 0);
+
+       imx728->ctrl.v_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_VFLIP, 0, 1, 1, 0);

Other Sony sensors end up changing the Bayer order based on flips. I just want to check that this isn't the case for this sensor, otherwise you need to set the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag and report the mbus code based on flips.

Quoted 113 lines
drivers/media/i2c/imx728.c new file +113 -0
+
+       imx728->ctrl.pg_mode = v4l2_ctrl_new_std_menu_items(ctrl_hdr,
+                                       &imx728_ctrl_ops, V4L2_CID_TEST_PATTERN,
+                                       ARRAY_SIZE(imx728_ctrl_pg_qmenu) - 1,
+                                       0, 0, imx728_ctrl_pg_qmenu);
+
+       imx728->ctrl.pixel_rate = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE, 1,
+                                            IMX728_PIXEL_RATE);
+
+       imx728->ctrl.link_freq = v4l2_ctrl_new_int_menu(ctrl_hdr, &imx728_ctrl_ops,
+                                                V4L2_CID_LINK_FREQ,
+                                                ARRAY_SIZE(imx728_link_freq_menu) - 1, 0,
+                                                imx728_link_freq_menu);
+
+       if (imx728->ctrl.link_freq)
+               imx728->ctrl.link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+       imx728->subdev.ctrl_handler = ctrl_hdr;
+       if (imx728->ctrl.handler.error) {
+               ret = imx728->ctrl.handler.error;
+               dev_err(imx728->dev,
+                       "%s: failed to add the ctrls: %d\n", __func__, ret);
+               goto err_ctrl_free;
+       }
+
+       pm_runtime_set_active(imx728->dev);
+       pm_runtime_enable(imx728->dev);
+       pm_runtime_set_autosuspend_delay(imx728->dev, IMX728_PM_IDLE_TIMEOUT);
+       pm_runtime_use_autosuspend(imx728->dev);
+       pm_runtime_get_noresume(imx728->dev);
+
+       ret = v4l2_subdev_init_finalize(sd);
+       if (ret < 0)
+               goto err_pm_disable;
+
+       ret = v4l2_async_register_subdev(sd);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: v4l2 subdev register failed %d\n", __func__, ret);
+               goto err_subdev_cleanup;
+       }
+
+       dev_info(imx728->dev, "imx728 probed\n");
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;
+}
+
+static int __maybe_unused imx728_runtime_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int __maybe_unused imx728_runtime_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       imx728_power_off(imx728);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       if (imx728->streaming)
+               imx728_stop_stream(imx728);
+
+       ret = pm_runtime_force_suspend(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to suspend: %i\n", __func__, ret);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);

drivers/media/i2c/imx728.c line 1113

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = pm_runtime_force_resume(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to resume: %i\n", __func__, ret);
+
+       if (imx728->streaming)
+               ret = imx728_start_stream(imx728);

You're likely to get comment from Laurent on this one. He went through and removed all the suspend/resume handlers as they should really be handled by the CSI2 receiver driver, not the sensor driver. Resuming streaming in a random order on system resume is unlikely to work.

Quoted 61 lines
drivers/media/i2c/imx728.c new file +54 -0
+
+       if (ret < 0) {
+               imx728_stop_stream(imx728);
+               imx728->streaming = 0;
+               return ret;
+       }
+
+       return 0;
+}
+
+static void imx728_remove(struct i2c_client *client)
+{
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       v4l2_async_unregister_subdev(sd);
+       v4l2_ctrl_handler_free(&imx728->ctrl.handler);
+       v4l2_subdev_cleanup(&imx728->subdev);
+       media_entity_cleanup(&sd->entity);
+       mutex_destroy(&imx728->lock);
+
+       pm_runtime_disable(imx728->dev);
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_set_suspended(imx728->dev);
+}
+
+static const struct dev_pm_ops imx728_pm_ops = {
+       SET_RUNTIME_PM_OPS(imx728_runtime_suspend,
+                          imx728_runtime_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(imx728_suspend, imx728_resume)
+};
+
+static const struct of_device_id imx728_dt_id[] = {
+       { .compatible = "sony,imx728" },
+       { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
+
+MODULE_DESCRIPTION("Camera Sensor Driver for Sony IMX728");
+MODULE_AUTHOR("Spencer Hill <[email protected]>");
+MODULE_LICENSE("GPL");
drivers/media/i2c/imx728.h new file +1 -0
new file mode 100644
index 000000000000..6f320214b780
@@ -0,0 +1,3458 @@
+/* SPDX-License-Identifier: GPL-2.0 */

drivers/media/i2c/imx728.h line 11

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/types.h>
+
+#define IMX728_OUT_WIDTH               3840
+#define IMX728_OUT_HEIGHT              2160

https://leopardimaging.com/wp-content/uploads/pdf/LI-IMX728-9295-xxxH-_Datasheet.pdf
lists IMX728 as 3857x2177 (strange to see odd numbers in a Bayer sensor). Do you have definitive numbers for the array size?

Seeing as these defines are only used in imx728_framesizes, I'd stick the values directly in the structure.

drivers/media/i2c/imx728.h line 17

Quoted 6 lines
drivers/media/i2c/imx728.h new file +6 -0
+
+#define IMX728_FRAMERATE_MAX           30
+#define IMX728_FRAMERATE_DEFAULT       30
+#define IMX728_FRAMERATE_MIN           10
+
+#define IMX728_PIXEL_RATE              225504000

225504000 / 3840 / 2160 = 27.18fps. How does that square with achieving 30fps?

drivers/media/i2c/imx728.h line 18

Quoted 1 line
drivers/media/i2c/imx728.h new file +1 -0
+#define IMX728_LINK_FREQ               800000000

1.6Gbit/s per lane feels high. I assume it has been checked.

Quoted 70 lines
drivers/media/i2c/imx728.h new file +70 -0
+
+#define IMX728_EXPOSURE_DEFAULT                10000
+
+#define IMX728_PM_IDLE_TIMEOUT         1000
+
+
+#define IMX728_REG_CTRL_POINT_X(i) (0xA198 + (i) * 8)
+#define IMX728_REG_CTRL_POINT_Y(i) (IMX728_REG_CTRL_POINT_X(i) + 4)
+
+enum imx728_sensor_state {
+       IMX728_SENSOR_STATE_SLEEP               = 0x02,
+       IMX728_SENSOR_STATE_STANDBY             = 0x04,
+       IMX728_SENSOR_STATE_STREAMING           = 0x10,
+       IMX728_SENSOR_STATE_SAFE                = 0x20,
+};
+
+
+enum imx728_remap_mode_id {
+       IMX728_REMAP_MODE_STANDBY = 0x00,
+       IMX728_REMAP_MODE_STANDBY_PIXEL_SHADING_COMPENSATION = 0x01,
+       IMX728_REMAP_MODE_STANDBY_SPOT_PIXEL_COMPENSATION = 0x02,
+       IMX728_REMAP_MODE_STREAMING = 0x04,
+       IMX728_REMAP_MODE_STREAMING_PIXEL_SHADING_COMPENSATION = 0x05,
+       IMX728_REMAP_MODE_STREAMING_SPOT_PIXEL_COMPENSATION = 0x06,
+       IMX728_REMAP_MODE_SLEEP = 0x20,
+};
+
+enum imx728_drive_mode {
+       IMX728_MODE_3856x2176_45_4LANE_RAW10 = 0x01,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12 = 0x02,
+       IMX728_MODE_3856x2176_45_4LANE_RAW16 = 0x03,
+       IMX728_MODE_3856x2176_45_4LANE_RAW20 = 0x04,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12_HDR = 0x05,
+       IMX728_MODE_3856x2176_40_4LANE_RAW10 = 0x11,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12 = 0x12,
+       IMX728_MODE_3856x2176_40_4LANE_RAW16 = 0x13,
+       IMX728_MODE_3856x2176_40_4LANE_RAW20 = 0x14,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12_HDR = 0x16,
+};
+
+enum imx728_awbmode {
+       IMX728_AWBMODE_ATW = 0,
+       IMX728_AWBMODE_ALL_PULL_IN = 1,
+       IMX728_AWBMODE_USER_PRESET = 2,
+       IMX728_AWBMODE_FULL_MWB = 3,
+       IMX728_AWBMODE_HOLD = 4,
+};
+
+enum imx728_img_raw_mode {
+       IMX728_IMG_MODE_LINEAR = 0x0,
+       IMX728_IMG_MODE_LI = 0x1,
+       IMX728_IMG_MODE_HDR = 0x2,
+       IMX728_IMG_MODE_LI_HDR = 0x3,
+};
+
+enum imx728_aemode {
+       IMX728_AEMODE_AE_AUTO  = 0,
+       IMX728_AEMODE_AE_HOLD  = 1,
+       IMX728_AEMODE_SCALE_ME = 2,
+       IMX728_AEMODE_FULL_ME  = 3,
+};
+
+enum imx728_fme_shtval_unit {
+       IMX728_FME_SHTVAL_UNIT_LINES            = 1,
+       IMX728_FME_SHTVAL_UNIT_MICROSECONDS     = 3,
+       IMX728_FME_SHTVAL_UNIT_FRAMES           = 4,
+};
+
+enum imx728_linear_raw_sel {
+       IMX728_RAW_SEL_SP1H = 0x0,

drivers/media/i2c/imx728.h line 98

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       IMX728_RAW_SEL_SP1L = 0x1,
+       IMX728_RAW_SEL_SP1EC = 0x2,
+       IMX728_RAW_SEL_SP2 = 0x3,
+       IMX728_RAW_SEL_SP1VS = 0x4
+};
+
+enum imx728_binn_avg {
+       IMX728_BINN_SIMPLE_AVG,
+       IMX728_BINN_WEIGHTED_AVG,
+};

Not used.

Quoted 82 lines
drivers/media/i2c/imx728.h new file +82 -0
+
+struct imx728_ctrl {
+       struct v4l2_ctrl_handler handler;
+       struct v4l2_ctrl *wdr;
+       struct v4l2_ctrl *exposure;
+       struct v4l2_ctrl *again;
+       struct v4l2_ctrl *h_flip;
+       struct v4l2_ctrl *v_flip;
+       struct v4l2_ctrl *pg_mode;
+       struct v4l2_ctrl *pixel_rate;
+       struct v4l2_ctrl *link_freq;
+};
+
+struct imx728_ctrl_point {
+       int x, y;
+};
+
+/*
+ * struct imx728 - imx728 device structure
+ * @dev: Device handle
+ * @clk: Pointer to imx728 clock
+ * @client: Pointer to I2C client
+ * @regmap: Pointer to regmap structure
+ * @xclr_gpio: Pointer to XCLR gpio
+ * @subdev: V4L2 subdevice structure
+ * @format: V4L2 media bus frame format structure
+ *             (width and height are in sync with the compose rect)
+ * @pad: Media pad structure
+ * @ctrl: imx728 control structure
+ * @clk_rate: Frequency of imx728 clock
+ * @lock: Mutex structure for V4L2 ctrl handler
+ * @streaming: Flag to store streaming on/off status
+ */
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;
+};
+
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },
+};
+
+static const u32 imx728_mbus_formats[] = {
+       MEDIA_BUS_FMT_SRGGB10_1X10,
+};
+
+static const s64 imx728_link_freq_menu[] = {
+       IMX728_LINK_FREQ,
+};
+
+static const struct regmap_config imx728_regmap_config = {
+       .reg_bits = 16,
+       .val_bits = 8,
+};
+
+static const char *const imx728_ctrl_pg_qmenu[] = {
+       "Disabled",
+       "Horizontal Color Bars",
+       "Vertical Color Bars",
+};
+
+static struct imx728_ctrl_point imx728_hdr_20bit[] = {
+       {0, 0},

drivers/media/i2c/imx728.h line 190

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+       {1566 >> 4, 938},
+       {105740 >> 4, 1863},
+       {387380 >> 4, 2396},
+       {3818601 >> 4, 3251},
+       {16777215 >> 4, 4095},
+       {-1, -1}
+};
+
+static const struct reg_sequence imx728_3840x2160[] = {
+       {0xFFFF, 0x00, 1000},

<snip>
This is one heck of a table at 3268 register writes. Are they really all necessary, or are some setting registers to default values, or duplicated elsewhere in the driver?

Thanks
Dave

#8 lore raw
Quoted 8 lines · Dave Stevenson

Hi Spencer

Thanks for the patch - always nice to see new sensors being supported.

I assume there's no public datasheet for the sensor, but are you aware of even a product brief? Reviews are tricky without data to work with. I've just read through looking for discrepancies and common errors.

There currently isn't a public datasheet available for the sensor. I'll modify the device tree description with what is publicly available.

Quoted 201 lines · Spencer Hill
Quoted 200 lines

Add a driver for the Sony IMX728 image sensor.

---
 drivers/media/i2c/Kconfig  |   11 +
 drivers/media/i2c/Makefile |    1 +
 drivers/media/i2c/imx728.c | 1167 ++++++++++++
 drivers/media/i2c/imx728.h | 3458 ++++++++++++++++++++++++++++++++++++
 4 files changed, 4637 insertions(+)
 create mode 100644 drivers/media/i2c/imx728.c
 create mode 100644 drivers/media/i2c/imx728.h
drivers/media/i2c/Kconfig +11 -0
index c6d3ee472d81..46b6463c558a 100644
@@ -233,6 +233,17 @@ config VIDEO_IMX415
          To compile this driver as a module, choose M here: the
          module will be called imx415.
 
+config VIDEO_IMX728
+       tristate "Sony IMX728 sensor support"
+       depends on OF_GPIO
+       select V4L2_CCI_I2C
+       help
+         This is a Video4Linux2 sensor driver for the Sony
+         IMX728 camera.
+
+         To compile this driver as a module, choose M here: the
+         module will be called imx728.
+
 config VIDEO_MAX9271_LIB
        tristate
 
drivers/media/i2c/Makefile +1 -0
index dfbe6448b549..1188420ee1b4 100644
@@ -56,6 +56,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o
 obj-$(CONFIG_VIDEO_IMX355) += imx355.o
 obj-$(CONFIG_VIDEO_IMX412) += imx412.o
 obj-$(CONFIG_VIDEO_IMX415) += imx415.o
+obj-$(CONFIG_VIDEO_IMX728) += imx728.o
 obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o
 obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o
 obj-$(CONFIG_VIDEO_KS0127) += ks0127.o
drivers/media/i2c/imx728.c new file +147 -0
new file mode 100644
index 000000000000..b23359133a22
@@ -0,0 +1,1167 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/delay.h>
+#include <linux/clk.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/v4l2-mediabus.h>
+#include <linux/videodev2.h>
+#include <media/v4l2-subdev.h>
+#include <media/v4l2-ctrls.h>
+#include <media/v4l2-event.h>
+
+#include "imx728.h"
+
+static inline struct imx728 *to_imx728(struct v4l2_subdev *sd)
+{
+       return container_of(sd, struct imx728, subdev);
+}
+
+static int imx728_read(struct imx728 *imx728, u16 addr, u32 *val, size_t nbytes)
+{
+       int ret;
+       __le32 val_le = 0;
+
+       ret = regmap_bulk_read(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0) {
+               dev_err(imx728->dev, "%s: failed to read reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+               return ret;
+       }
+
+       *val = le32_to_cpu(val_le);
+
+       return 0;
+}
+
+static int imx728_write(struct imx728 *imx728, u16 addr, u32 val, size_t nbytes)
+{
+       int ret;
+       __le32 val_le = cpu_to_le32(val);
+
+       ret = regmap_bulk_write(imx728->regmap, addr, &val_le, nbytes);
+       if (ret < 0)
+               dev_err(imx728->dev, "%s: failed to write reg 0x%04x: %d\n",
+                       __func__, addr, ret);
+
+       return ret;
+}
+
+static int imx728_update_bits(struct imx728 *imx728, u16 addr, u32 val, u32 mask, size_t nbytes)
+{
+       int ret;
+       u32 cfg;
+
+       ret = imx728_read(imx728, addr, &cfg, nbytes);
+       if (ret < 0)
+               return ret;
+
+       cfg = (val) ? (cfg | mask) : (cfg & (~mask));
+
+       return imx728_write(imx728, addr, cfg, nbytes);
+}
+
+static int imx728_write_table(struct imx728 *imx728,
+                             const struct reg_sequence *regs,
+                             unsigned int nr_regs)
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(imx728->regmap, regs, nr_regs);
+       if (ret < 0)
+               dev_err(imx728->dev,
+                       "%s: failed to write reg table (%d)!\n", __func__, ret);
+       return ret;
+}
+
+static int imx728_wait_for_state(struct imx728 *imx728, enum imx728_sensor_state state)
+{
+       int ret, i;
+       u32 val;
+
+       for (i = 0; i < 50; i++) {
+               ret = imx728_read(imx728, 0x2CAC, &val, 1);
+               if (ret == 0 && val == state) {
+                       dev_info(imx728->dev, "%s: Enter state %u\n", __func__, val);
+                       return 0;
+               }
+               usleep_range(1000, 10000);
+       }
+
+       return -EBUSY;
+}
+
+static void imx728_init_formats(struct v4l2_subdev_state *state)
+{
+       struct v4l2_mbus_framefmt *format;
+
+       format = v4l2_subdev_state_get_format(state, 0, 0);
+       format->code = imx728_mbus_formats[0];
+       format->width = imx728_framesizes[0].width;
+       format->height = imx728_framesizes[0].height;
+       format->field = V4L2_FIELD_NONE;
+       format->colorspace = V4L2_COLORSPACE_SMPTE170M;
+}
+
+static int _imx728_set_routing(struct v4l2_subdev *sd,
+                              struct v4l2_subdev_state *state)
+{
+       struct v4l2_subdev_route routes[] = {
+               {
+                       .source_pad = 0,
+                       .source_stream = 0,
+                       .flags = V4L2_SUBDEV_ROUTE_FL_ACTIVE,
+               },
+               {
+                       .source_pad = 0,
+                       .source_stream = 1,
+               }
+       };
+
+       struct v4l2_subdev_krouting routing = {
+               .num_routes = ARRAY_SIZE(routes),
+               .routes = routes,
+       };
+
+       int ret;
+
+       ret = v4l2_subdev_set_routing(sd, state, &routing);
+       if (ret < 0)
+               return ret;
+
+       imx728_init_formats(state);
+
+       return 0;
+}
+
+static int imx728_enum_mbus_code(struct v4l2_subdev *sd,
+                                struct v4l2_subdev_state *state,
Quoted 9 lines

drivers/media/i2c/imx728.c line 151

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+                                struct v4l2_subdev_mbus_code_enum *code)
+{
+
+       if (code->index >= ARRAY_SIZE(imx728_mbus_formats))

imx728_mbus_formats only lists MEDIA_BUS_FMT_SRGGB10_1X10. Is this for potential addition of the 12, 16, or 20 bit readout modes? How likely are those to actually happen?

The sensor supports 10, 12, 16, 20, and 24 bit output. I have settings that are supposed to be for 12bit output, however I do not have hardware that I can test it on, as my current set up is over FPD-Link 3, and when operating in 12 bit mode the sensor surpasses the maximum bandwidth of that interface and no longer functions. I would like to add more modes in the future when I get access to a better hardware setup for testing them.

Quoted 114 lines
Quoted 114 lines
drivers/media/i2c/imx728.c new file +114 -0
+               return -EINVAL;
+
+       code->code = imx728_mbus_formats[code->index];
+
+       return 0;
+}
+
+static int imx728_enum_frame_sizes(struct v4l2_subdev *sd,
+                                  struct v4l2_subdev_state *state,
+                                  struct v4l2_subdev_frame_size_enum *fse)
+{
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fse->code)
+                       break;
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               return -EINVAL;
+
+       if (fse->index >= ARRAY_SIZE(imx728_framesizes))
+               return -EINVAL;
+
+       fse->min_width = imx728_framesizes[fse->index].width;
+       fse->max_width = fse->min_width;
+       fse->min_height = imx728_framesizes[fse->index].height;
+       fse->max_height = fse->min_height;
+
+       return 0;
+}
+
+static int imx728_set_fmt(struct v4l2_subdev *sd,
+                         struct v4l2_subdev_state *state,
+                         struct v4l2_subdev_format *fmt)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       struct v4l2_mbus_framefmt *format;
+       const struct v4l2_area *fsize;
+       unsigned int i;
+       u32 code;
+       int ret = 0;
+
+       if (fmt->pad != 0)
+               return -EINVAL;
+
+       if (fmt->stream != 0)
+               return -EINVAL;
+
+       for (i = 0; i < ARRAY_SIZE(imx728_mbus_formats); ++i) {
+               if (imx728_mbus_formats[i] == fmt->format.code) {
+                       code = fmt->format.code;
+                       break;
+               }
+       }
+
+       if (i == ARRAY_SIZE(imx728_mbus_formats))
+               code = imx728_mbus_formats[0];
+
+       fsize = v4l2_find_nearest_size(imx728_framesizes,
+                                      ARRAY_SIZE(imx728_framesizes), width,
+                                      height, fmt->format.width,
+                                      fmt->format.height);
+
+       mutex_lock(&imx728->lock);
+
+       format = v4l2_subdev_state_get_format(state, fmt->pad, fmt->stream);
+
+       if (fmt->which == V4L2_SUBDEV_FORMAT_ACTIVE && imx728->streaming) {
+               ret = -EBUSY;
+               goto done;
+       }
+
+       format->code = code;
+       format->width = fsize->width;
+       format->height = fsize->height;
+
+       fmt->format = *format;
+
+done:
+       mutex_unlock(&imx728->lock);
+
+       return ret;
+}
+
+static int imx728_get_frame_desc(struct v4l2_subdev *sd, unsigned int pad,
+                                struct v4l2_mbus_frame_desc *fd)
+{
+       struct v4l2_subdev_state *state;
+       struct v4l2_mbus_framefmt *fmt;
+       u32 bpp;
+       int ret = 0;
+
+       if (pad != 0)
+               return -EINVAL;
+
+       state = v4l2_subdev_lock_and_get_active_state(sd);
+
+       fmt = v4l2_subdev_state_get_format(state, 0, 0);
+       if (!fmt) {
+               ret = -EPIPE;
+               goto out;
+       }
+
+       memset(fd, 0, sizeof(*fd));
+
+       fd->type = V4L2_MBUS_FRAME_DESC_TYPE_CSI2;
+
+       bpp = 10;
+
+       fd->entry[fd->num_entries].stream = 0;
+
+       fd->entry[fd->num_entries].flags = V4L2_MBUS_FRAME_DESC_FL_LEN_MAX;
+       fd->entry[fd->num_entries].length = fmt->width * fmt->height * bpp / 8;
Quoted 9 lines

drivers/media/i2c/imx728.c line 268

Quoted 3 lines
drivers/media/i2c/imx728.c new file +3 -0
+       fd->entry[fd->num_entries].pixelcode = fmt->code;
+       fd->entry[fd->num_entries].bus.csi2.vc = 0;
+       fd->entry[fd->num_entries].bus.csi2.dt = 0x2b;

Presumably this 0x2b is MIPI_CSI2_DT_RAW10.
That comes back to the question above as to whether supporting other bit depths is really likely, as if so then prepare to change this value based on mbus_code.

I will make sure that this changes based on the mbus_code once more bit depths are supported.

Quoted 7 lines

drivers/media/i2c/imx728.c line 270

Quoted 2 lines
drivers/media/i2c/imx728.c new file +2 -0
+
+       fd->num_entries++;

Presumably this fd->num_entries manipulation is due to expecting to support multiple data types? Whilst not wrong, at the moment it feels a little redundant.

I can remove this from this patch set if that would be preferred, until more modes are available.

Quoted 169 lines
Quoted 154 lines
drivers/media/i2c/imx728.c new file +154 -0
+
+out:
+
+       v4l2_subdev_unlock_state(state);
+
+       return ret;
+}
+
+static int imx728_set_routing(struct v4l2_subdev *sd,
+                             struct v4l2_subdev_state *state,
+                             enum v4l2_subdev_format_whence which,
+                             struct v4l2_subdev_krouting *routing)
+{
+       int ret;
+
+       if (routing->num_routes == 0 || routing->num_routes > 1)
+               return -EINVAL;
+
+       ret = _imx728_set_routing(sd, state);
+
+       return ret;
+}
+
+static int imx728_set_ctrl(struct v4l2_ctrl *ctrl)
+{
+       struct imx728 *imx728 = container_of(ctrl->handler,
+                                       struct imx728, ctrl.handler);
+       int ret = 0;
+
+       dev_dbg(imx728->dev, "%s: %s, value: %d\n",
+                       __func__, ctrl->name, ctrl->val);
+
+       if (!pm_runtime_get_if_in_use(imx728->dev))
+               return 0;
+
+       switch (ctrl->id) {
+       case V4L2_CID_EXPOSURE:
+               ret = imx728_write(imx728, 0x98DC, ctrl->val, 4);
+               break;
+       case V4L2_CID_ANALOGUE_GAIN:
+               ret = imx728_update_bits(imx728, 0x98F8,
+                               (ctrl->val * 10),
+                               0x1FFFF, 4);
+               break;
+       case V4L2_CID_HFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val, 0x1, 1);
+               ret |= imx728_update_bits(imx728, 0xB67C,
+                                         ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_VFLIP:
+               ret = imx728_update_bits(imx728, 0x9651,
+                                        ctrl->val << 1, 0x2, 1);
+               ret = imx728_update_bits(imx728, 0xB67D,
+                                        ctrl->val, 0x1, 1);
+               break;
+       case V4L2_CID_WIDE_DYNAMIC_RANGE:
+       case V4L2_CID_TEST_PATTERN:
+               // Both of these are configured during start stream.
+               ret = 0;
+               break;
+       default:
+               ret = -EINVAL;
+       }
+
+       pm_runtime_put_noidle(imx728->dev);
+       return ret;
+}
+
+static int imx728_detect(struct imx728 *imx728)
+{
+       int ret;
+       u32 minor, major;
+
+       ret = imx728_read(imx728, 0x6002, &major, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MAJOR_VER!");
+               return ret;
+       }
+       ret = imx728_read(imx728, 0x6000, &minor, 1);
+       if (ret != 0) {
+               dev_err(imx728->dev, "Could not read PARAM_MINOR_VER!");
+               return ret;
+       }
+       dev_dbg(imx728->dev, "Got version: %d.%d", major, minor);
+
+       return 0;
+}
+
+static int imx728_reset(struct imx728 *imx728)
+{
+
+       if (!IS_ERR_OR_NULL(imx728->xclr_gpio)) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+               usleep_range(1000, 10000);
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 0);
+               msleep(100);
+
+               return 0;
+       }
+
+       return -1;
+}
+
+static int imx728_power_on(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = clk_prepare_enable(imx728->clk);
+       if (ret < 0)
+               return ret;
+
+       imx728_reset(imx728);
+       return 0;
+}
+
+static int imx728_power_off(struct imx728 *imx728)
+{
+
+       if (imx728->xclr_gpio) {
+               gpiod_set_value_cansleep(imx728->xclr_gpio, 1);
+
+               usleep_range(1, 10);
+       }
+       clk_disable_unprepare(imx728->clk);
+       return 0;
+}
+
+static int imx728_get_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = imx728->fps;
+       return 0;
+}
+
+static int imx728_set_frame_interval(struct v4l2_subdev *sd,
+                                    struct v4l2_subdev_state *sd_state,
+                                    struct v4l2_subdev_frame_interval *fi)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       u32 req_fps;
+
+       mutex_lock(&imx728->lock);
+
+       if (fi->interval.numerator == 0 || fi->interval.denominator == 0) {
+               fi->interval.denominator = IMX728_FRAMERATE_DEFAULT;
+               fi->interval.numerator = 1;
+       }
+
+       req_fps = clamp_val(DIV_ROUND_CLOSEST(fi->interval.denominator,

drivers/media/i2c/imx728.c line 434

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+                                             fi->interval.numerator),
+                           IMX728_FRAMERATE_MIN, IMX728_FRAMERATE_MAX);
+
+       fi->interval.numerator = 1;
+       fi->interval.denominator = req_fps;
+
+       imx728->fps = req_fps;
+
+       mutex_unlock(&imx728->lock);
+       dev_dbg(imx728->dev, "%s frame rate = %d\n", __func__, imx728->fps);

Is setting the frame rate actually supported in the driver? I can't see imx728->fps being used other than to return the value in imx728_get_frame_interval.

Quoted 4 lines

Frame rate control on raw sensors is normally controlled through
V4L2_CID_VBLANK and V4L2_CID_HBLANK, not these ioctls.
See https://www.kernel.org/doc/html/latest/userspace-api/media/drivers/camera-sensor.html#raw-camera-sensors

I don't presently have frame rate control implemented. There is a register that allows me to increase the number of lines read from the sensor in order to lower the frame rate. Would it be better to implement the V4L2_CID_HBLANK directly in that case rather than exposing the frame rate this way?

Quoted 188 lines
Quoted 188 lines
drivers/media/i2c/imx728.c new file +188 -0
+
+       return 0;
+}
+
+static int imx728_powerup_to_standby(struct imx728 *imx728)
+{
+       int ret;
+
+       dev_info(imx728->dev, "powerup -> standby...");
+
+       ret = imx728_reset(imx728);
+       if (ret) {
+               dev_err(imx728->dev, "Error resetting: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_SLEEP);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Sleep state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B20, imx728->clk_rate / 1000000, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B1C, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write INCK frequency!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B05, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write to CK_SLEEP!");
+               return ret;
+       }
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition from Sleep to Standby state!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xFFFF, IMX728_REMAP_MODE_STANDBY, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write regmap mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_hdr_fixed_brightness(struct imx728 *imx728)
+{
+       int ret;
+
+       // Sony recommended values
+       unsigned int exposure_sp1_sp2_us = 10000;
+       unsigned int exposure_sp1vs_us = 56;
+       unsigned int sp1h_gain = 240;
+       unsigned int sp1l_gain = 75;
+       unsigned int sp1ec_gain = 21;
+       unsigned int sp2_gain = 33;
+       unsigned int sp1vs_gain = 84;
+
+       ret = imx728_write(imx728, 0x98DC, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98E4, exposure_sp1_sp2_us, 4);
+       ret |= imx728_write(imx728, 0x98EC, exposure_sp1vs_us, 4);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed exposure values.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x98F8,
+                         sp1h_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x98FC,
+                         sp1l_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9900,
+                         sp1ec_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9904,
+                         sp2_gain,
+                         0x1FFFF,
+                         4);
+       ret |= imx728_update_bits(imx728, 0x9908,
+                         sp1vs_gain,
+                         0x1FFFF,
+                         4);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to write fixed gain values.");
+               return ret;
+       }
+
+       dev_info(imx728->dev, "Wrote fixed brightness for HDR");
+
+       return 0;
+}
+
+static int imx728_hdr_configure(
+       struct imx728 *imx728,
+       struct imx728_ctrl_point *points,
+       int hdr_bits)
+{
+       u32 hdr_norm_x0;
+       u32 hdr_norm_x1;
+       u32 hdr_norm_y0;
+       u32 hdr_norm_y1;
+
+       int ret;
+       int i;
+
+       switch (hdr_bits) {
+       case 20:
+               hdr_norm_x0 = 0x2000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xd000;
+               break;
+       case 24:
+               hdr_norm_x0 = 0x3000;
+               hdr_norm_x1 = 0x5000;
+
+               hdr_norm_y0 = 0x0;
+               hdr_norm_y1 = 0xe000;
+               break;
+       default:
+               dev_err(imx728->dev, "%i bit HDR not supported.", hdr_bits);
+               break;
+       }
+
+       ret = imx728_write(imx728, 0x9C60, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C6C, hdr_norm_x0, 4);
+       ret |= imx728_write(imx728, 0x9C64, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C70, hdr_norm_x1, 4);
+       ret |= imx728_write(imx728, 0x9C68, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C74, hdr_norm_y0, 2);
+       ret |= imx728_write(imx728, 0x9C6A, hdr_norm_y1, 2);
+       ret |= imx728_write(imx728, 0x9C76, hdr_norm_y1, 2);
+
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed when setting HDR Normalization gains: %i", ret);
+               return ret;
+       }
+
+       for (i = 0; i < 16; i++) {
+               ret = imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_X(i),
+                       points->x, 4);
+
+               ret |= imx728_write(
+                       imx728,
+                       IMX728_REG_CTRL_POINT_Y(i),
+                       points->y, 4);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to write control point %i", i);
+                       return ret;
+               }
+
+               if ((points+1)->x >= 0 && (points+1)->y >= 0)
+                       points++;
+       }
+
+       return imx728_hdr_fixed_brightness(imx728);
+}
+
+static int imx728_configure(struct imx728 *imx728)
+{
+       int ret;
+       bool hdr = imx728->ctrl.wdr->val;
+       enum imx728_img_raw_mode img_out_mode;
+       enum imx728_drive_mode mode_sel;
+       enum imx728_aemode ae_mode;
+
+       if (hdr) {
+               img_out_mode = IMX728_IMG_MODE_HDR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
Quoted 9 lines

drivers/media/i2c/imx728.c line 627

Quoted 5 lines
drivers/media/i2c/imx728.c new file +5 -0
+               ae_mode = IMX728_AEMODE_FULL_ME;
+       } else {
+               img_out_mode = IMX728_IMG_MODE_LINEAR;
+               mode_sel = IMX728_MODE_3856x2176_40_4LANE_RAW10;
+               ae_mode = IMX728_AEMODE_FULL_ME;

Unless my eyes deceive me, mode_sel and ae_mode are the same in both modes. Why do they need to be conditional?

I'll adjust the conditional. When I was originally trying
to bring up 12bit HDR this made more sense and was left over from then.

Quoted 34 lines
Quoted 34 lines
drivers/media/i2c/imx728.c new file +34 -0
+       }
+
+       ret = imx728_write(imx728, 0x98AC, ae_mode, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set AE mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xA248, IMX728_AWBMODE_FULL_MWB, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't set full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x1808, 0x1, 0x1, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't enable full manual white balance mode!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98E8, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x98F0, IMX728_FME_SHTVAL_UNIT_MICROSECONDS, 1);
+       if (ret < 0) {
Quoted 9 lines

drivers/media/i2c/imx728.c line 666

Quoted 5 lines
drivers/media/i2c/imx728.c new file +5 -0
+               dev_err(imx728->dev, "Couldn't write exposure time unit to microseconds!");
+               return ret;
+       }
+
+       if (hdr) {

The xclr GPIO is optional, so is there a guaranteed register reset in the big table to reset these HDR registers back to defaults?

I do not believe so. If the sensor does not have an xclr pin hooked up then these registers will remain the same between runs. If the sensor is not in HDR mode these registers do not impact the operation though, and the out mode is always configured. I will investigate adding a software reset as well just for the sake of sanity though.

Quoted 42 lines
Quoted 42 lines
drivers/media/i2c/imx728.c new file +42 -0
+               ret = imx728_hdr_configure(imx728, imx728_hdr_20bit, 20);
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Couldn't configure sensor for HDR mode: %i", ret);
+                       return ret;
+               }
+       }
+
+       dev_info(imx728->dev, "Disabling metadata...");
+       ret = imx728_write(imx728, 0x1708, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1709, 0x00, 1);
+       ret |= imx728_write(imx728, 0x170A, 0x00, 1);
+       ret |= imx728_write(imx728, 0x1B40, 0x00, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling metadata: %i", ret);
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0x9728,
+                         mode_sel,
+                         0x7FFF,
+                         2);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't write mode select.");
+               return ret;
+       }
+
+       ret = imx728_update_bits(imx728, 0xEC7E,
+                         img_out_mode,
+                         0x7,
+                         1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't select image out mode.");
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0xEC12, 0x28, 2);
+       ret |= imx728_write(imx728, 0xEC14, 0x0, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error disabling OB output.");
+               return ret;
+       }
+
Quoted 9 lines

drivers/media/i2c/imx728.c line 713

Quoted 5 lines
drivers/media/i2c/imx728.c new file +5 -0
+       ret = imx728_write(imx728, 0x1761, 0x0, 1);
+       if (ret < 0)
+               dev_err(imx728->dev, "Error disabling skew calibration from sensor to SER");
+
+       switch (imx728->ctrl.pg_mode->val) {

Even if the test mode can't be changed whilst running, this could be in imx728_set_ctrl as it'll be called by __v4l2_ctrl_handler_setup

I will move this code into that handler.

Quoted 4 lines

drivers/media/i2c/imx728.c line 714

Quoted 1 line
drivers/media/i2c/imx728.c new file +1 -0
+       case 0:

Again xclr GPIO is optional. Are these reset to defaults?

These are not reset back to default. I'll make sure that there is a software reset as well in the next version of the patch set.

Quoted 54 lines
Quoted 54 lines
drivers/media/i2c/imx728.c new file +54 -0
+               break;
+       case 1:
+               // Horizontal Color Bars
+               ret = imx728_write(imx728, 0x1A2A, 8, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x0, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x0, 1);
+               break;
+       case 2:
+               // Vertical Color Bars
+               ret = imx728_write(imx728, 0x1A2C, 16, 2);
+               ret |= imx728_write(imx728, 0x1A30, 0, 3);
+               ret |= imx728_write(imx728, 0x1A38, 1, 3);
+               ret |= imx728_write(imx728, 0xB58F, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C5, 0x1, 1);
+               break;
+       default:
+               break;
+       }
+
+       // Assume that everything except 'disabled' requires pattern gen enable
+       if (imx728->ctrl.pg_mode->val != 0) {
+               ret |= imx728_write(imx728, 0xB58E, 0x1, 1);
+               ret |= imx728_write(imx728, 0xB6C4, 0x1, 1);
+
+               if (ret < 0) {
+                       dev_err(imx728->dev, "Failed to enable PG mode.");
+                       return ret;
+               }
+       }
+
+       ret = imx728_update_bits(imx728, 0x9714,
+                         IMX728_RAW_SEL_SP1H,
+                         0x7,
+                         1);
+       ret |= imx728_update_bits(imx728, 0xB684,
+                          IMX728_RAW_SEL_SP1H,
+                          0x7,
+                          1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Failed to set subpixel register");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_start_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_powerup_to_standby(imx728);
+       if (ret < 0)
Quoted 9 lines

drivers/media/i2c/imx728.c line 771

Quoted 3 lines
drivers/media/i2c/imx728.c new file +3 -0
+               return ret;
+
+       ret = imx728_write_table(imx728, imx728_3840x2160, ARRAY_SIZE(imx728_3840x2160));

You've enabled delayed suspend through pm_runtime, but you're always sending the whole of this array. Is there an option for only resending on actual power up to reduce the time to restart if the device hasn't suspended?

At the moment the system always tries to reset the sensor if possible, so it makes sense to write the table again. It may be possible to differentiate between a power on and a resume and not call that reset, and thus not need to write the entire table again. I will make changes adjusting it so that this write is only performed if the sensor was in a sleep state (indicating that it lost power or was otherwise reset).

Quoted 116 lines
Quoted 116 lines
drivers/media/i2c/imx728.c new file +116 -0
+       if (ret < 0)
+               return ret;
+
+       msleep(100);
+
+       ret = imx728_configure(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = __v4l2_ctrl_handler_setup(imx728->subdev.ctrl_handler);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: failed to apply v4l2 ctrls: %d\n", __func__, ret);
+               return ret;
+       }
+
+       ret = imx728_write(imx728, 0x1B04, 0x5C, 1);
+       if (ret < 0)
+               return ret;
+       ret = imx728_write(imx728, 0x1B04, 0xA3, 1);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STREAMING);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Could not transition to Streaming!");
+               return ret;
+       }
+
+       msleep(20);
+
+       return 0;
+}
+
+static int imx728_stop_stream(struct imx728 *imx728)
+{
+       int ret;
+
+       ret = imx728_write(imx728, 0x1B04, 0xFF, 1);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Error sending stop stream command: %i", ret);
+               return ret;
+       }
+
+       imx728_wait_for_state(imx728, IMX728_SENSOR_STATE_STANDBY);
+       if (ret < 0) {
+               dev_err(imx728->dev, "Couldn't transition out of Streaming mode!");
+               return ret;
+       }
+
+       return 0;
+}
+
+static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
+{
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       mutex_lock(&imx728->lock);
+       if (imx728->streaming == enable) {
+               mutex_unlock(&imx728->lock);
+               return 0;
+       }
+
+       if (enable) {
+               ret = pm_runtime_get_sync(imx728->dev);
+               if (ret < 0) {
+                       pm_runtime_put_noidle(imx728->dev);
+                       goto err_unlock;
+               }
+
+               ret = imx728_start_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+       } else {
+               ret = imx728_stop_stream(imx728);
+               if (ret < 0)
+                       goto err_runtime_put;
+               pm_runtime_mark_last_busy(imx728->dev);
+               pm_runtime_put_autosuspend(imx728->dev);
+       }
+
+       imx728->streaming = enable;
+
+       __v4l2_ctrl_grab(imx728->ctrl.wdr, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.h_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.v_flip, enable);
+       __v4l2_ctrl_grab(imx728->ctrl.pg_mode, enable);
+
+       mutex_unlock(&imx728->lock);
+       return 0;
+
+err_runtime_put:
+       pm_runtime_put(imx728->dev);
+
+err_unlock:
+       mutex_unlock(&imx728->lock);
+       dev_err(imx728->dev,
+               "%s: failed to setup streaming %d\n", __func__, ret);
+       return ret;
+}
+
+static const struct v4l2_subdev_core_ops imx728_core_ops = {
+       .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+       .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
+static const struct v4l2_subdev_video_ops imx728_subdev_video_ops = {
+       .s_stream = imx728_set_stream,
+};
+
+static const struct v4l2_subdev_pad_ops imx728_subdev_pad_ops = {
+       .enum_mbus_code = imx728_enum_mbus_code,
+       .enum_frame_size = imx728_enum_frame_sizes,
+       .get_fmt = v4l2_subdev_get_fmt,
+       .set_fmt = imx728_set_fmt,
Quoted 9 lines

drivers/media/i2c/imx728.c line 891

Quoted 4 lines
drivers/media/i2c/imx728.c new file +4 -0
+       .get_frame_interval = imx728_get_frame_interval,
+       .set_frame_interval = imx728_set_frame_interval,
+       .set_routing = imx728_set_routing,
+       .get_frame_desc = imx728_get_frame_desc,

Support for get_selection would be nice to reflect the array geometry, assuming the information is in the datasheet. It's likely to be mandatory for libcamera soon.

I have access to this information and will implement this.

Quoted 85 lines
Quoted 74 lines
drivers/media/i2c/imx728.c new file +74 -0
+};
+
+static const struct v4l2_subdev_ops imx728_subdev_ops = {
+       .core  = &imx728_core_ops,
+       .video = &imx728_subdev_video_ops,
+       .pad   = &imx728_subdev_pad_ops,
+};
+
+static const struct v4l2_ctrl_ops imx728_ctrl_ops = {
+       .s_ctrl = imx728_set_ctrl,
+};
+
+static int imx728_probe(struct i2c_client *client)
+{
+       struct imx728 *imx728;
+       struct v4l2_subdev *sd;
+       struct v4l2_ctrl_handler *ctrl_hdr;
+       int ret;
+
+       imx728 = devm_kzalloc(&client->dev, sizeof(*imx728), GFP_KERNEL);
+       if (!imx728)
+               return -ENOMEM;
+
+       imx728->dev = &client->dev;
+
+       imx728->regmap = devm_regmap_init_i2c(client, &imx728_regmap_config);
+       if (IS_ERR(imx728->regmap))
+               return PTR_ERR(imx728->regmap);
+
+       imx728->xclr_gpio = devm_gpiod_get_optional(imx728->dev,
+                                            "xclr", GPIOD_OUT_LOW);
+       if (IS_ERR(imx728->xclr_gpio))
+               return PTR_ERR(imx728->xclr_gpio);
+
+       imx728->clk = devm_clk_get(imx728->dev, "inck");
+       if (IS_ERR(imx728->clk))
+               return PTR_ERR(imx728->clk);
+
+       imx728->clk_rate = clk_get_rate(imx728->clk);
+       dev_info(imx728->dev, "inck rate: %lu Hz\n", imx728->clk_rate);
+
+       if (imx728->clk_rate < 18000000 || imx728->clk_rate > 30000000)
+               return -EINVAL;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       ret = imx728_detect(imx728);
+       if (ret < 0)
+               return ret;
+
+       sd = &imx728->subdev;
+       v4l2_i2c_subdev_init(sd, client, &imx728_subdev_ops);
+
+       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                    V4L2_SUBDEV_FL_HAS_EVENTS |
+                    V4L2_SUBDEV_FL_STREAMS;
+
+       imx728->pad.flags = MEDIA_PAD_FL_SOURCE;
+       sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
+       ret = media_entity_pads_init(&sd->entity, 1, &imx728->pad);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: media entity init failed %d\n", __func__, ret);
+               return ret;
+       }
+
+       ctrl_hdr = &imx728->ctrl.handler;
+       ret = v4l2_ctrl_handler_init(ctrl_hdr, 8);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: ctrl handler init failed: %d\n", __func__, ret);
+               goto err_media_cleanup;

drivers/media/i2c/imx728.c line 975

Quoted 10 lines
drivers/media/i2c/imx728.c new file +10 -0
+       }
+
+       mutex_init(&imx728->lock);
+       imx728->ctrl.handler.lock = &imx728->lock;
+       imx728->fps = IMX728_FRAMERATE_DEFAULT;
+
+       imx728->ctrl.exposure = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                                 V4L2_CID_EXPOSURE, 0,
+                                                 33000, 1,
+                                                 IMX728_EXPOSURE_DEFAULT);
Quoted 8 lines

That looks like you're clipping the max exposure time based on 30fps, and the units are usecs.
Units on V4L2_CID_EXPOSURE are undefined, and normally expected to be lines for raw image sensors, but that then needs to know HBLANK and PIXEL_RATE.
There is V4L2_CID_EXPOSURE_ABSOLUTE which has defined units of 100usecs, but I'm not sure if that is very useful in this case.

The recommended values for the sensor were provided to me in usecs and the sensor allows configuring what unit is used for exposure, so at the moment the exposure is configured in usecs. Would it be better if I implemented V4L2_CID_EXPOSURE_ABSOLUTE instead then?

Quoted 12 lines
Quoted 12 lines
drivers/media/i2c/imx728.c new file +12 -0
+
+       imx728->ctrl.again = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                              V4L2_CID_ANALOGUE_GAIN, 0,
+                                              102, 1,
+                                              24);
+
+       imx728->ctrl.wdr = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_WIDE_DYNAMIC_RANGE,
+                                            0, 1, 1, 1);
+
+       imx728->ctrl.h_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_HFLIP, 0, 1, 1, 0);
Quoted 9 lines

drivers/media/i2c/imx728.c line 990

Quoted 3 lines
drivers/media/i2c/imx728.c new file +3 -0
+
+       imx728->ctrl.v_flip = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                               V4L2_CID_VFLIP, 0, 1, 1, 0);

Other Sony sensors end up changing the Bayer order based on flips. I just want to check that this isn't the case for this sensor, otherwise you need to set the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag and report the mbus code based on flips.

My understanding from the datasheet is that this sensor does not change the Bayer order when you perform HFLIP or VFLIP operations. It shifts the pixel readout horizontally or vertically so that the order of readout does not change.

Quoted 120 lines
Quoted 120 lines
drivers/media/i2c/imx728.c new file +120 -0
+
+       imx728->ctrl.pg_mode = v4l2_ctrl_new_std_menu_items(ctrl_hdr,
+                                       &imx728_ctrl_ops, V4L2_CID_TEST_PATTERN,
+                                       ARRAY_SIZE(imx728_ctrl_pg_qmenu) - 1,
+                                       0, 0, imx728_ctrl_pg_qmenu);
+
+       imx728->ctrl.pixel_rate = v4l2_ctrl_new_std(ctrl_hdr, &imx728_ctrl_ops,
+                                            V4L2_CID_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE,
+                                            IMX728_PIXEL_RATE, 1,
+                                            IMX728_PIXEL_RATE);
+
+       imx728->ctrl.link_freq = v4l2_ctrl_new_int_menu(ctrl_hdr, &imx728_ctrl_ops,
+                                                V4L2_CID_LINK_FREQ,
+                                                ARRAY_SIZE(imx728_link_freq_menu) - 1, 0,
+                                                imx728_link_freq_menu);
+
+       if (imx728->ctrl.link_freq)
+               imx728->ctrl.link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
+       imx728->subdev.ctrl_handler = ctrl_hdr;
+       if (imx728->ctrl.handler.error) {
+               ret = imx728->ctrl.handler.error;
+               dev_err(imx728->dev,
+                       "%s: failed to add the ctrls: %d\n", __func__, ret);
+               goto err_ctrl_free;
+       }
+
+       pm_runtime_set_active(imx728->dev);
+       pm_runtime_enable(imx728->dev);
+       pm_runtime_set_autosuspend_delay(imx728->dev, IMX728_PM_IDLE_TIMEOUT);
+       pm_runtime_use_autosuspend(imx728->dev);
+       pm_runtime_get_noresume(imx728->dev);
+
+       ret = v4l2_subdev_init_finalize(sd);
+       if (ret < 0)
+               goto err_pm_disable;
+
+       ret = v4l2_async_register_subdev(sd);
+       if (ret < 0) {
+               dev_err(imx728->dev,
+                       "%s: v4l2 subdev register failed %d\n", __func__, ret);
+               goto err_subdev_cleanup;
+       }
+
+       dev_info(imx728->dev, "imx728 probed\n");
+       pm_runtime_mark_last_busy(imx728->dev);
+       pm_runtime_put_autosuspend(imx728->dev);
+       return 0;
+
+err_subdev_cleanup:
+       v4l2_subdev_cleanup(&imx728->subdev);
+
+err_pm_disable:
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_put_noidle(imx728->dev);
+       pm_runtime_disable(imx728->dev);
+
+err_ctrl_free:
+       v4l2_ctrl_handler_free(ctrl_hdr);
+       mutex_destroy(&imx728->lock);
+
+err_media_cleanup:
+       media_entity_cleanup(&imx728->subdev.entity);
+
+       return ret;
+}
+
+static int __maybe_unused imx728_runtime_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = imx728_power_on(imx728);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int __maybe_unused imx728_runtime_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       imx728_power_off(imx728);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_suspend(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       if (imx728->streaming)
+               imx728_stop_stream(imx728);
+
+       ret = pm_runtime_force_suspend(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to suspend: %i\n", __func__, ret);
+
+       return 0;
+}
+
+static int __maybe_unused imx728_resume(struct device *dev)
+{
+       struct i2c_client *client = to_i2c_client(dev);
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+       int ret;
+
+       ret = pm_runtime_force_resume(dev);
+       if (ret < 0)
+               dev_warn(dev, "%s: failed to resume: %i\n", __func__, ret);
Quoted 9 lines

drivers/media/i2c/imx728.c line 1113

Quoted 3 lines
drivers/media/i2c/imx728.c new file +3 -0
+
+       if (imx728->streaming)
+               ret = imx728_start_stream(imx728);

You're likely to get comment from Laurent on this one. He went through and removed all the suspend/resume handlers as they should really be handled by the CSI2 receiver driver, not the sensor driver. Resuming streaming in a random order on system resume is unlikely to work.

Should I remove these handlers then? Or wait for comment?

Quoted 76 lines
Quoted 61 lines
drivers/media/i2c/imx728.c new file +54 -0
+
+       if (ret < 0) {
+               imx728_stop_stream(imx728);
+               imx728->streaming = 0;
+               return ret;
+       }
+
+       return 0;
+}
+
+static void imx728_remove(struct i2c_client *client)
+{
+       struct v4l2_subdev *sd = i2c_get_clientdata(client);
+       struct imx728 *imx728 = to_imx728(sd);
+
+       v4l2_async_unregister_subdev(sd);
+       v4l2_ctrl_handler_free(&imx728->ctrl.handler);
+       v4l2_subdev_cleanup(&imx728->subdev);
+       media_entity_cleanup(&sd->entity);
+       mutex_destroy(&imx728->lock);
+
+       pm_runtime_disable(imx728->dev);
+       pm_runtime_dont_use_autosuspend(imx728->dev);
+       pm_runtime_set_suspended(imx728->dev);
+}
+
+static const struct dev_pm_ops imx728_pm_ops = {
+       SET_RUNTIME_PM_OPS(imx728_runtime_suspend,
+                          imx728_runtime_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(imx728_suspend, imx728_resume)
+};
+
+static const struct of_device_id imx728_dt_id[] = {
+       { .compatible = "sony,imx728" },
+       { /* sentinel */ }
+};
+
+MODULE_DEVICE_TABLE(of, imx728_dt_id);
+
+static struct i2c_driver imx728_i2c_driver = {
+       .driver = {
+               .name = "imx728",
+               .of_match_table = of_match_ptr(imx728_dt_id),
+               .pm = &imx728_pm_ops,
+       },
+       .probe = imx728_probe,
+       .remove = imx728_remove,
+};
+
+module_i2c_driver(imx728_i2c_driver);
+
+MODULE_DESCRIPTION("Camera Sensor Driver for Sony IMX728");
+MODULE_AUTHOR("Spencer Hill <[email protected]>");
+MODULE_LICENSE("GPL");
drivers/media/i2c/imx728.h new file +1 -0
new file mode 100644
index 000000000000..6f320214b780
@@ -0,0 +1,3458 @@
+/* SPDX-License-Identifier: GPL-2.0 */

drivers/media/i2c/imx728.h line 11

Quoted 10 lines
drivers/media/i2c/imx728.h new file +10 -0
+/*
+ * Sony IMX728 CMOS Image Sensor Driver
+ *
+ * Copyright (c) 2024 Define Design Deploy Corp
+ */
+
+#include <linux/types.h>
+
+#define IMX728_OUT_WIDTH               3840
+#define IMX728_OUT_HEIGHT              2160

https://leopardimaging.com/wp-content/uploads/pdf/LI-IMX728-9295-xxxH-_Datasheet.pdf
lists IMX728 as 3857x2177 (strange to see odd numbers in a Bayer sensor). Do you have definitive numbers for the array size?

Quoted 3 lines

Seeing as these defines are only used in imx728_framesizes, I'd stick the values directly in the structure.

I will move these numbers into the structure itself.

Quoted 9 lines

drivers/media/i2c/imx728.h line 17

Quoted 6 lines
drivers/media/i2c/imx728.h new file +6 -0
+
+#define IMX728_FRAMERATE_MAX           30
+#define IMX728_FRAMERATE_DEFAULT       30
+#define IMX728_FRAMERATE_MIN           10
+
+#define IMX728_PIXEL_RATE              225504000

225504000 / 3840 / 2160 = 27.18fps. How does that square with achieving 30fps?

Sorry this should be 248832000, I will change that.

Quoted 4 lines

drivers/media/i2c/imx728.h line 18

Quoted 1 line
drivers/media/i2c/imx728.h new file +1 -0
+#define IMX728_LINK_FREQ               800000000

1.6Gbit/s per lane feels high. I assume it has been checked.

This is what the sensor seems to be operating at given my testing. It's my understanding that this sensor can actually go all the way to 2.5Gbit/s per lane, but I do not have a setup that can test that at the moment.

Quoted 74 lines
Quoted 74 lines
drivers/media/i2c/imx728.h new file +74 -0
+
+#define IMX728_EXPOSURE_DEFAULT                10000
+
+#define IMX728_PM_IDLE_TIMEOUT         1000
+
+
+#define IMX728_REG_CTRL_POINT_X(i) (0xA198 + (i) * 8)
+#define IMX728_REG_CTRL_POINT_Y(i) (IMX728_REG_CTRL_POINT_X(i) + 4)
+
+enum imx728_sensor_state {
+       IMX728_SENSOR_STATE_SLEEP               = 0x02,
+       IMX728_SENSOR_STATE_STANDBY             = 0x04,
+       IMX728_SENSOR_STATE_STREAMING           = 0x10,
+       IMX728_SENSOR_STATE_SAFE                = 0x20,
+};
+
+
+enum imx728_remap_mode_id {
+       IMX728_REMAP_MODE_STANDBY = 0x00,
+       IMX728_REMAP_MODE_STANDBY_PIXEL_SHADING_COMPENSATION = 0x01,
+       IMX728_REMAP_MODE_STANDBY_SPOT_PIXEL_COMPENSATION = 0x02,
+       IMX728_REMAP_MODE_STREAMING = 0x04,
+       IMX728_REMAP_MODE_STREAMING_PIXEL_SHADING_COMPENSATION = 0x05,
+       IMX728_REMAP_MODE_STREAMING_SPOT_PIXEL_COMPENSATION = 0x06,
+       IMX728_REMAP_MODE_SLEEP = 0x20,
+};
+
+enum imx728_drive_mode {
+       IMX728_MODE_3856x2176_45_4LANE_RAW10 = 0x01,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12 = 0x02,
+       IMX728_MODE_3856x2176_45_4LANE_RAW16 = 0x03,
+       IMX728_MODE_3856x2176_45_4LANE_RAW20 = 0x04,
+       IMX728_MODE_3856x2176_45_4LANE_RAW12_HDR = 0x05,
+       IMX728_MODE_3856x2176_40_4LANE_RAW10 = 0x11,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12 = 0x12,
+       IMX728_MODE_3856x2176_40_4LANE_RAW16 = 0x13,
+       IMX728_MODE_3856x2176_40_4LANE_RAW20 = 0x14,
+       IMX728_MODE_3856x2176_40_4LANE_RAW12_HDR = 0x16,
+};
+
+enum imx728_awbmode {
+       IMX728_AWBMODE_ATW = 0,
+       IMX728_AWBMODE_ALL_PULL_IN = 1,
+       IMX728_AWBMODE_USER_PRESET = 2,
+       IMX728_AWBMODE_FULL_MWB = 3,
+       IMX728_AWBMODE_HOLD = 4,
+};
+
+enum imx728_img_raw_mode {
+       IMX728_IMG_MODE_LINEAR = 0x0,
+       IMX728_IMG_MODE_LI = 0x1,
+       IMX728_IMG_MODE_HDR = 0x2,
+       IMX728_IMG_MODE_LI_HDR = 0x3,
+};
+
+enum imx728_aemode {
+       IMX728_AEMODE_AE_AUTO  = 0,
+       IMX728_AEMODE_AE_HOLD  = 1,
+       IMX728_AEMODE_SCALE_ME = 2,
+       IMX728_AEMODE_FULL_ME  = 3,
+};
+
+enum imx728_fme_shtval_unit {
+       IMX728_FME_SHTVAL_UNIT_LINES            = 1,
+       IMX728_FME_SHTVAL_UNIT_MICROSECONDS     = 3,
+       IMX728_FME_SHTVAL_UNIT_FRAMES           = 4,
+};
+
+enum imx728_linear_raw_sel {
+       IMX728_RAW_SEL_SP1H = 0x0,
+       IMX728_RAW_SEL_SP1L = 0x1,
+       IMX728_RAW_SEL_SP1EC = 0x2,
+       IMX728_RAW_SEL_SP2 = 0x3,
+       IMX728_RAW_SEL_SP1VS = 0x4
Quoted 9 lines

drivers/media/i2c/imx728.h line 98

Quoted 6 lines
drivers/media/i2c/imx728.h new file +6 -0
+};
+
+enum imx728_binn_avg {
+       IMX728_BINN_SIMPLE_AVG,
+       IMX728_BINN_WEIGHTED_AVG,
+};

Not used.

This is used for other resolution modes, I will remove it until those are in and it is actually used.

Quoted 88 lines
Quoted 88 lines
drivers/media/i2c/imx728.h new file +88 -0
+
+struct imx728_ctrl {
+       struct v4l2_ctrl_handler handler;
+       struct v4l2_ctrl *wdr;
+       struct v4l2_ctrl *exposure;
+       struct v4l2_ctrl *again;
+       struct v4l2_ctrl *h_flip;
+       struct v4l2_ctrl *v_flip;
+       struct v4l2_ctrl *pg_mode;
+       struct v4l2_ctrl *pixel_rate;
+       struct v4l2_ctrl *link_freq;
+};
+
+struct imx728_ctrl_point {
+       int x, y;
+};
+
+/*
+ * struct imx728 - imx728 device structure
+ * @dev: Device handle
+ * @clk: Pointer to imx728 clock
+ * @client: Pointer to I2C client
+ * @regmap: Pointer to regmap structure
+ * @xclr_gpio: Pointer to XCLR gpio
+ * @subdev: V4L2 subdevice structure
+ * @format: V4L2 media bus frame format structure
+ *             (width and height are in sync with the compose rect)
+ * @pad: Media pad structure
+ * @ctrl: imx728 control structure
+ * @clk_rate: Frequency of imx728 clock
+ * @lock: Mutex structure for V4L2 ctrl handler
+ * @streaming: Flag to store streaming on/off status
+ */
+struct imx728 {
+       struct device *dev;
+
+       struct clk *clk;
+       struct i2c_client *client;
+       struct regmap *regmap;
+       struct gpio_desc *xclr_gpio;
+
+       struct v4l2_subdev subdev;
+       struct v4l2_mbus_framefmt format;
+       struct media_pad pad;
+
+       struct imx728_ctrl ctrl;
+
+       unsigned long clk_rate;
+       u32 fps;
+
+       struct mutex lock;
+       bool streaming;
+};
+
+static const struct v4l2_area imx728_framesizes[] = {
+       {
+               .width = IMX728_OUT_WIDTH,
+               .height = IMX728_OUT_HEIGHT,
+       },
+};
+
+static const u32 imx728_mbus_formats[] = {
+       MEDIA_BUS_FMT_SRGGB10_1X10,
+};
+
+static const s64 imx728_link_freq_menu[] = {
+       IMX728_LINK_FREQ,
+};
+
+static const struct regmap_config imx728_regmap_config = {
+       .reg_bits = 16,
+       .val_bits = 8,
+};
+
+static const char *const imx728_ctrl_pg_qmenu[] = {
+       "Disabled",
+       "Horizontal Color Bars",
+       "Vertical Color Bars",
+};
+
+static struct imx728_ctrl_point imx728_hdr_20bit[] = {
+       {0, 0},
+       {1566 >> 4, 938},
+       {105740 >> 4, 1863},
+       {387380 >> 4, 2396},
+       {3818601 >> 4, 3251},
+       {16777215 >> 4, 4095},
+       {-1, -1}
Quoted 9 lines

drivers/media/i2c/imx728.h line 190

Quoted 4 lines
drivers/media/i2c/imx728.h new file +4 -0
+};
+
+static const struct reg_sequence imx728_3840x2160[] = {
+       {0xFFFF, 0x00, 1000},

<snip>
This is one heck of a table at 3268 register writes. Are they really all necessary, or are some setting registers to default values, or duplicated elsewhere in the driver?

This table was provided by Sony for bringing up the sensor, I don't actually have much insight into which writes are absolutely necessary or not. A quick glance shows that some of them seem to be writing default values for registers that are changed later, but comparitively very few, and I'm hesitant to change anything in this table given it was provided by Sony directly.

Quoted 2 lines

Thanks
Dave

Thanks,
Spencer
Please be aware that this email includes email addresses outside of the organization.

#9 lore raw

PATCH 2/2 media: dt-bindings: Add Sony IMX728

In reply to Spencer Hill

Add bindings for Sony IMX728.

---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +78 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-
+  Sony IMX728 camera sensor.
+
+properties:
+  compatible:
+    enum:
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck
+
+  xclr-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +9 -0
index ef6be9d95143..34fde35eb0bd 100644
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c
+F:     drivers/media/i2c/imx728.h
+
 SONY MEMORYSTICK SUBSYSTEM
 M:     Maxim Levitsky <[email protected]>
 M:     Alex Dubov <[email protected]>

--
2.40.1

Please be aware that this email includes email addresses outside of the organization.

#10 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

Quoted 2 lines · Spencer Hill

Add bindings for Sony IMX728.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries. </form letter>

Best regards,
Krzysztof

#11 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

Quoted 22 lines · Krzysztof Kozlowski
Quoted 2 lines · Spencer Hill

Add bindings for Sony IMX728.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.

Quoted 6 lines

Please kindly resend and include all necessary To/Cc entries. </form letter>

Best regards,
Krzysztof

I will be sure to use b4 to send out the patch to the correct people after I make the modifications based on the other feedback I've received.

Thanks,
Spencer
Please be aware that this email includes email addresses outside of the organization.

#12 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

In reply to Spencer Hill
Quoted 3 lines · Spencer Hill

Add bindings for Sony IMX728.

Since this was not tested, limited review follows:

Quoted 2 lines
---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++

Bindings are before users.

Quoted 12 lines
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +2 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 12

Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +10 -0
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-

Do not need '|-' unless you need to preserve formatting.

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 13

Quoted 1 line
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +1 -0
+  Sony IMX728 camera sensor.

That's duplicating title. Say something more about hardware or just drop.

Quoted 70 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +65 -0
+
+properties:
+  compatible:
+    enum:
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck
+
+  xclr-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +0 -0
index ef6be9d95143..34fde35eb0bd 100644

MAINTAINERS T: git git://linuxtv.org/media_tree.git · line 20596

Quoted 8 lines
MAINTAINERS +5 -0
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git

Drop this T:. You do not maintain that git tree so it is already covered by subsystem entry.

MAINTAINERS T: git git://linuxtv.org/media_tree.git · line 20598

Quoted 2 lines
MAINTAINERS +2 -0
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c

.[ch] or *

Best regards,
Krzysztof

#13 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

Quoted 12 lines · Krzysztof Kozlowski
Quoted 3 lines · Spencer Hill

Add bindings for Sony IMX728.

Since this was not tested, limited review follows:

Quoted 2 lines
---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++

Bindings are before users.

Sorry I am not sure what you are recommending here, should I change the order of the patches so that the dt-binding patch is first?

Quoted 16 lines
Quoted 16 lines
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +6 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
Quoted 9 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 12

Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +6 -0
+title: Sony IMX728 Camera Sensor
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-

Do not need '|-' unless you need to preserve formatting.

This will be needed once I add more information.

Quoted 4 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 13

Quoted 1 line
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +1 -0
+  Sony IMX728 camera sensor.

That's duplicating title. Say something more about hardware or just drop.

I will add some more information about the sensor here.

Quoted 73 lines
Quoted 73 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +65 -0
+
+properties:
+  compatible:
+    enum:
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck
+
+  xclr-gpios:
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +0 -0
index ef6be9d95143..34fde35eb0bd 100644
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
Quoted 9 lines

MAINTAINERS T: git git://linuxtv.org/media_tree.git · line 20596

Quoted 5 lines
MAINTAINERS +5 -0
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git

Drop this T:. You do not maintain that git tree so it is already covered by subsystem entry.

Okay

Quoted 5 lines

MAINTAINERS T: git git://linuxtv.org/media_tree.git · line 20598

Quoted 2 lines
MAINTAINERS +2 -0
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c

.[ch] or *

The .h file will be removed in an updated patch set in response to other feedback.

Quoted 5 lines

Best regards,
Krzysztof

I'll make these changes

Thanks,
Spencer
Please be aware that this email includes email addresses outside of the organization.

#14 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

In reply to Spencer Hill

Hi Spencer,

thanks for the patch.

Am Mittwoch, 26. Juni 2024, 23:15:29 CEST schrieb Spencer Hill:

Quoted 18 lines

Add bindings for Sony IMX728.

---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +3 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 13

Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +10 -0
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-
+  Sony IMX728 camera sensor.

Are there some more information? Like max resolution, image format, bpp, framerate, etc.

Quoted 4 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +4 -0
+
+properties:
+  compatible:
+    enum:

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 27

Quoted 10 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +10 -0
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck

Are there any restrictions about frequency? Like a specific set of frequencies?

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 29

Quoted 2 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +2 -0
+
+  xclr-gpios:

reset-gpios, see sony.imx290.yaml

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 32

Quoted 3 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +3 -0
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.

No voltage supplies?

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 41

Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +9 -0
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false

Which data-lane configuration is allowed? 4 lanes only? or 2 lanes?

Best regards,
Alexander

Quoted 63 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +37 -0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +9 -1
index ef6be9d95143..34fde35eb0bd 100644
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c
+F:     drivers/media/i2c/imx728.h
+
 SONY MEMORYSTICK SUBSYSTEM
 M:     Maxim Levitsky <[email protected]>
 M:     Alex Dubov <[email protected]>
--

2.40.1

Please be aware that this email includes email addresses outside of the organization.

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
#15 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

Quoted 27 lines · Alexander Stein

Hi Spencer,

thanks for the patch.

Am Mittwoch, 26. Juni 2024, 23:15:29 CEST schrieb Spencer Hill:

Quoted 22 lines

Add bindings for Sony IMX728.

---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +7 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
Quoted 9 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 13

Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +6 -0
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-
+  Sony IMX728 camera sensor.

Are there some more information? Like max resolution, image format, bpp, framerate, etc.

I will add some more descriptive information about the sensor. Should information that is only relevant to the driver be included here? Or should I just describe the sensor? For example, the sensor supports a significant number of different modes, however only a single one is implemented in the driver at the moment, should I list the possible modes, or just the supported ones?

Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +9 -0
+
+properties:
+  compatible:
+    enum:
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
Quoted 9 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +5 -0
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck

Are there any restrictions about frequency? Like a specific set of frequencies?

The sensor must be between 18MHz and 30MHz, I will add this to the description.

Quoted 5 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 29

Quoted 2 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +2 -0
+
+  xclr-gpios:

reset-gpios, see sony.imx290.yaml

I will rename this here and in the driver.

Quoted 6 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 32

Quoted 3 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +3 -0
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.

No voltage supplies?

I will add these.

Quoted 12 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 41

Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +9 -0
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false

Which data-lane configuration is allowed? 4 lanes only? or 2 lanes?

Quoted 3 lines

Best regards,
Alexander

The sensor supports both 4 and 2 lane modes, though only 4 is implemented at the moment.

Quoted 60 lines
Quoted 60 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +37 -0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +9 -1
index ef6be9d95143..34fde35eb0bd 100644
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c
+F:     drivers/media/i2c/imx728.h
+
 SONY MEMORYSTICK SUBSYSTEM
 M:     Maxim Levitsky <[email protected]>
 M:     Alex Dubov <[email protected]>
--

2.40.1

Quoted 12 lines
Quoted 3 lines

Please be aware that this email includes email addresses outside of the organization.

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Please be aware that this email includes email addresses outside of the organization.

#16 lore raw

Re: [PATCH 2/2] media: dt-bindings: Add Sony IMX728

Hi,

I noticed you missed at least DT bindings maintainer in Cc. Please use scripts/get_maintainer.pl to get the To/Cc list.

Am Donnerstag, 27. Juni 2024, 19:33:37 CEST schrieb Spencer Hill:

Quoted 38 lines · Alexander Stein
Quoted 27 lines

Hi Spencer,

thanks for the patch.

Am Mittwoch, 26. Juni 2024, 23:15:29 CEST schrieb Spencer Hill:

Quoted 22 lines

Add bindings for Sony IMX728.

---
 .../bindings/media/i2c/sony,imx728.yaml       | 78 +++++++++++++++++++
 MAINTAINERS                                   |  9 +++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +7 -0
new file mode 100644
index 000000000000..613042ab5abe
@@ -0,0 +1,78 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx728.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony IMX728 Camera Sensor
Quoted 9 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 13

Quoted 6 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +6 -0
+
+maintainers:
+  - Spencer Hill <[email protected]>
+
+description: |-
+  Sony IMX728 camera sensor.

Are there some more information? Like max resolution, image format, bpp, framerate, etc.

Quoted 6 lines

I will add some more descriptive information about the sensor. Should information that is only relevant to the driver be included here? Or should I just describe the sensor? For example, the sensor supports a significant number of different modes, however only a single one is implemented in the driver at the moment, should I list the possible modes, or just the supported ones?

Bindings are independent from implementations, DT bindings maintainer will tell you ;-)

Take a look at Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml to get an idea.

Quoted 51 lines
Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +9 -0
+
+properties:
+  compatible:
+    enum:
+      - sony,imx728
+
+  reg:
+    maxItems: 1
+
Quoted 9 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 27

Quoted 5 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +5 -0
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: inck

Are there any restrictions about frequency? Like a specific set of frequencies?

The sensor must be between 18MHz and 30MHz, I will add this to the description.

Quoted 5 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 29

Quoted 2 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +2 -0
+
+  xclr-gpios:

reset-gpios, see sony.imx290.yaml

I will rename this here and in the driver.

Quoted 6 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 32

Quoted 3 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +3 -0
+    maxItems: 1
+    description:
+      Specifier for the GPIO connected to the XCLR (System Reset) pin.

No voltage supplies?

I will add these.

Quoted 12 lines

Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml line 41

Quoted 9 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +9 -0
+
+  port:
+    $ref: /schemas/graph.yaml#/properties/port
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: ../video-interfaces.yaml#
+        unevaluatedProperties: false

Which data-lane configuration is allowed? 4 lanes only? or 2 lanes?

Quoted 6 lines
Quoted 3 lines

Best regards,
Alexander

The sensor supports both 4 and 2 lane modes, though only 4 is implemented at the moment.

Again, driver implementation doesn't matter here. If the hardware (!) supports both modes, then list it here accordingly.

Thanks and best regards,
Alexander

Quoted 75 lines
Quoted 60 lines
Quoted 60 lines
Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml new file +37 -0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c {
+        clock-frequency = <400000>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@1a {
+            compatible = "sony,imx728";
+            reg = <0x1a>;
+
+            clocks = <&fixed_clock>;
+            clock-names = "inck";
+
+            xclr-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
+
+            port {
+                camera1: endpoint {
+                    remote-endpoint = <&vin1a_ep>;
+                };
+            };
+        };
+    };
+
+...
MAINTAINERS +9 -1
index ef6be9d95143..34fde35eb0bd 100644
@@ -20589,6 +20589,15 @@ T:     git git://linuxtv.org/media_tree.git
 F:     Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml
 F:     drivers/media/i2c/imx415.c
 
+SONY IMX728 SENSOR DRIVER
+M:     Spencer Hill <[email protected]>
+L:     [email protected]
+S:     Maintained
+T:     git git://linuxtv.org/media_tree.git
+F:     Documentation/devicetree/bindings/media/i2c/sony,imx728.yaml
+F:     drivers/media/i2c/imx728.c
+F:     drivers/media/i2c/imx728.h
+
 SONY MEMORYSTICK SUBSYSTEM
 M:     Maxim Levitsky <[email protected]>
 M:     Alex Dubov <[email protected]>
--

2.40.1

Quoted 12 lines
Quoted 3 lines

Please be aware that this email includes email addresses outside of the organization.

--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Please be aware that this email includes email addresses outside of the organization.

Signature · 4 lines
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/