rcutorture: Add CFcommon.arch for the various arch's need
Subsystems (3)
PATCH v3 1/1 rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
x86 specific kernel option CONFIG_HYPERVISOR_GUEST to CFcommon.arch
The patch has been revised and improved under
Paul E. McKenney's guidance [3].
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/
Tested in x86_64 and PPC VM of Open Source Lab of Oregon State University.
--- tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 ++ tools/testing/selftests/rcutorture/configs/rcu/CFcommon | 1 - tools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 | 1 + tools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 create mode 100644 tools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64
tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2 -0
@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`
tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0 -1
@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=n
tools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1 -0
@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
tools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1 -0
@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
Signature · 1 line
2.25.1
Paul E. McKenney
maintainerQuoted 9 lines · Zhouyi Zhou
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
Fixes a6fda6dab93c ("rcutorture: Tweak kvm options") by movingx86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.archThe patch has been revised and improved under
Paul E. McKenney's guidance [3].
Quoted 7 lines
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Signed-off-by Zhouyi Zhou <[email protected]>
Much better, thank you!
I queued and pushed for review and testing with the usual editing, so please let me know if I messed anything up.
I added Mark on CC in case he has thoughts from an ARM perspective.
Thanx, Paul
------------------------------------------------------------------------
commit 29cf4c63d04b9752a32e33d46a57717121353ef7
Author: Zhouyi Zhou <[email protected]> Date: Wed Jun 12 01:35:27 2024 +0000
rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
In accordance with [1] and [2], this patch moves x86 specific kernel option CONFIG_HYPERVISOR_GUEST to CFcommon.arch
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
Tested in x86_64 and PPC VM of Open Source Lab of Oregon State University.
tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2 -0
@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`
tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0 -1
@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=n
tools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1 -0
@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
tools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1 -0
@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
Quoted 16 lines · Paul E. McKenney
Quoted 15 lines · Zhouyi Zhou
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
Fixes a6fda6dab93c ("rcutorture: Tweak kvm options") by movingx86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.archThe patch has been revised and improved under
Paul E. McKenney's guidance [3].[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.
Quoted 8 lines
Quoted 1 line
Signed-off-by Zhouyi Zhou <[email protected]>Much better, thank you!
I queued and pushed for review and testing with the usual editing, so please let me know if I messed anything up.
I added Mark on CC in case he has thoughts from an ARM perspective.
Ah, thanks!
From a quick scan, the only thing I spot is that CONFIG_KVM_GUEST is also not an arm64 thing, and only exists on x86 & powerpc, so pulling that out too would be nice.
That aside, this looks good to me; having the infrastructure to do this per-arch is nice!
Mark.
Quoted 67 lines
Thanx, Paul
------------------------------------------------------------------------
commit
29cf4c63d04b9752a32e33d46a57717121353ef7Author: Zhouyi Zhou <[email protected]> Date: Wed Jun 12 01:35:27 2024 +0000rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
In accordance with [1] and [2], this patch moves x86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.arch[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Fixes a6fda6dab93c ("rcutorture: Tweak kvm options")Suggested-by Paul E. McKenney <[email protected]>Signed-off-by Zhouyi Zhou <[email protected]>Cc Mark Rutland <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2
-0@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0
-1@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=ntools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=ytools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
Paul E. McKenney
maintainerQuoted 24 lines · Mark Rutland
Quoted 23 lines · Paul E. McKenney
Quoted 9 lines · Zhouyi Zhou
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
Fixes a6fda6dab93c ("rcutorture: Tweak kvm options") by movingx86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.archThe patch has been revised and improved under
Paul E. McKenney's guidance [3].Quoted 7 lines
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Signed-off-by Zhouyi Zhou <[email protected]>Much better, thank you!
I queued and pushed for review and testing with the usual editing, so please let me know if I messed anything up.
Quoted 7 lines
Quoted 1 line
I added Mark on CC in case he has thoughts from an ARM perspective.
Ah, thanks!
Quoted 1 line
From a quick scan, the only thing I spot is that
CONFIG_KVM_GUESTisalso not an arm64 thing, and only exists on x86 & powerpc, so pulling that out too would be nice.
Thank you for looking this over!
Zhouyi, would you be willing to add this change, either as a new version of this patch or as a new patch on top of it? (Your choice.)
Quoted 2 lines
That aside, this looks good to me; having the infrastructure to do this per-arch is nice!
Glad you like it! May we have your ack?
Thanx, Paul
Quoted 69 lines
Mark.
Quoted 67 lines
Thanx, Paul
------------------------------------------------------------------------
commit
29cf4c63d04b9752a32e33d46a57717121353ef7Author: Zhouyi Zhou <[email protected]> Date: Wed Jun 12 01:35:27 2024 +0000rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
In accordance with [1] and [2], this patch moves x86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.arch[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Fixes a6fda6dab93c ("rcutorture: Tweak kvm options")Suggested-by Paul E. McKenney <[email protected]>Signed-off-by Zhouyi Zhou <[email protected]>Cc Mark Rutland <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2
-0@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0
-1@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=ntools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=ytools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
Quoted 26 lines · Paul E. McKenney
Quoted 24 lines · Mark Rutland
Quoted 23 lines · Paul E. McKenney
Quoted 9 lines · Zhouyi Zhou
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
Fixes a6fda6dab93c ("rcutorture: Tweak kvm options") by movingx86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.archThe patch has been revised and improved under
Paul E. McKenney's guidance [3].Quoted 7 lines
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Signed-off-by Zhouyi Zhou <[email protected]>Much better, thank you!
I queued and pushed for review and testing with the usual editing, so please let me know if I messed anything up.
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
I added Mark on CC in case he has thoughts from an ARM perspective.
Ah, thanks!
Quoted 1 line
From a quick scan, the only thing I spot is that
CONFIG_KVM_GUESTisalso not an arm64 thing, and only exists on x86 & powerpc, so pulling that out too would be nice.
yes, CONFIG_KVM_GUEST exists in powerpc & x86, which makes me think it is global.
Quoted 5 lines
Thank you for looking this over!
Zhouyi, would you be willing to add this change, either as a new version of this patch or as a new patch on top of it? (Your choice.)
Thanks to Paul and Mark's guidance, I achieved a lot during this process ;-)
I am going to create a new version of the patch, and test is both on X86 and PowerPC
Cheers
Zhouyi
Quoted 5 lines
Quoted 3 lines
That aside, this looks good to me; having the infrastructure to do this per-arch is nice!
Glad you like it! May we have your ack?
Very happy that Mark likes it ;-)
Quoted 72 lines
Thanx, Paul
Quoted 69 lines
Mark.
Quoted 67 lines
Thanx, Paul
------------------------------------------------------------------------
commit
29cf4c63d04b9752a32e33d46a57717121353ef7Author: Zhouyi Zhou <[email protected]> Date: Wed Jun 12 01:35:27 2024 +0000rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
In accordance with [1] and [2], this patch moves x86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.arch[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Fixes a6fda6dab93c ("rcutorture: Tweak kvm options")Suggested-by Paul E. McKenney <[email protected]>Signed-off-by Zhouyi Zhou <[email protected]>Cc Mark Rutland <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2
-0@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0
-1@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=ntools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=ytools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y
Paul E. McKenney
maintainerQuoted 37 lines · Zhouyi Zhou
Quoted 26 lines · Paul E. McKenney
Quoted 24 lines · Mark Rutland
Quoted 23 lines · Paul E. McKenney
Quoted 9 lines · Zhouyi Zhou
Add CFcommon.arch for the various arch's need for rcutorture.
According to [1] and [2], this patch
Fixes a6fda6dab93c ("rcutorture: Tweak kvm options") by movingx86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.archThe patch has been revised and improved under
Paul E. McKenney's guidance [3].Quoted 7 lines
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/
[3] https://lore.kernel.org/lkml/cd3709dc-2c08-4ac2-a19b-d8edb66195e3@paulmck-laptop/T/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Signed-off-by Zhouyi Zhou <[email protected]>Much better, thank you!
I queued and pushed for review and testing with the usual editing, so please let me know if I messed anything up.
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
I added Mark on CC in case he has thoughts from an ARM perspective.
Ah, thanks!
Quoted 1 line
From a quick scan, the only thing I spot is that
CONFIG_KVM_GUESTisalso not an arm64 thing, and only exists on x86 & powerpc, so pulling that out too would be nice.
yes,
CONFIG_KVM_GUESTexists in powerpc & x86, which makes me think it is global.Quoted 1 line
Quoted 8 lines
Quoted 4 lines
Thank you for looking this over!
Zhouyi, would you be willing to add this change, either as a new version of this patch or as a new patch on top of it? (Your choice.)
Thanks to Paul and Mark's guidance, I achieved a lot during this process ;-)
I am going to create a new version of the patch, and test is both on X86 and PowerPC
Very good, looking forward to it!
Thanx, Paul
Quoted 80 lines
Cheers
ZhouyiQuoted 5 lines
Quoted 3 lines
That aside, this looks good to me; having the infrastructure to do this per-arch is nice!
Glad you like it! May we have your ack?
Very happy that Mark likes it ;-)
Quoted 72 lines
Thanx, Paul
Quoted 69 lines
Mark.
Quoted 67 lines
Thanx, Paul
------------------------------------------------------------------------
commit
29cf4c63d04b9752a32e33d46a57717121353ef7Author: Zhouyi Zhou <[email protected]> Date: Wed Jun 12 01:35:27 2024 +0000rcutorture: Add CFcommon.arch for the various arch's need
Add CFcommon.arch for the various arch's need for rcutorture.
In accordance with [1] and [2], this patch moves x86 specific kernel option
CONFIG_HYPERVISOR_GUESTto CFcommon.arch[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop/Tested in
x86_64and PPC VM of Open Source Lab of Oregon State University.Fixes a6fda6dab93c ("rcutorture: Tweak kvm options")Suggested-by Paul E. McKenney <[email protected]>Signed-off-by Zhouyi Zhou <[email protected]>Cc Mark Rutland <[email protected]>Signed-off-by Paul E. McKenney <[email protected]>tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh +2
-0@@ -68,6 +68,8 @@ config_override_param "--gdb options" KcList "$TORTURE_KCONFIG_GDB_ARG" config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN_ARG" config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN_ARG" config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_ARG" +config_override_param "$config_dir/CFcommon.$(uname -m)" KcList \ + "`cat $config_dir/CFcommon.$(uname -m) 2> /dev/null`" cp $T/KcList $resdir/ConfigFragment base_resdir=`echo $resdir | sed -e 's/\.[0-9]\+$//'`tools/testing/selftests/rcutorture/configs/rcu/CFcommon +0
-1@@ -1,6 +1,5 @@ CONFIG_RCU_TORTURE_TEST=y CONFIG_PRINTK_TIME=y -CONFIG_HYPERVISOR_GUEST=y CONFIG_PARAVIRT=y CONFIG_KVM_GUEST=y CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=ntools/testing/selftests/rcutorture/configs/rcu/CFcommon.i686 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=ytools/testing/selftests/rcutorture/configs/rcu/CFcommon.x86_64 new file +1
-0@@ -0,0 +1 @@ +CONFIG_HYPERVISOR_GUEST=y