Skip to contentSkip to conversation

symlink01 split

PATCH In review Andrea Cervesato 4 participants 10 messages Jul 11, 2024

lore
Share & tools
lore
#0 lore raw

v4 cover symlink01 split

This is a developement series (requested by Petr Vorel) that handle symlink01 split, which has been already merged in the master branch.

In this series we face the next part of symlink01 split that includes stat04, lstat03, open15 and chmod08.

---
Changes in v4:
- stat04: use asprintf
- stat04: remove unlink() from cleanup
- lstat04: remove unlink() from cleanup
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- stat04: smarter cleanup
- lstat03: smarter cleanup
- open15: fix algorithm, read/write from/to symlink
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- update TST_EXP_EXTR to support stringification
- call stat() inside the test run() routine
- call lstat() inside the test run() routine
- simplify chmod08
- simplify open15
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Andrea Cervesato (4):
Add stat04 test
Add lstat03 test
Add chmod08 test
Add open15 test

 runtest/smoketest                          |   4 +-
 runtest/syscalls                           |  11 +--
 testcases/kernel/syscalls/chmod/.gitignore |   1 +
 testcases/kernel/syscalls/chmod/chmod08.c  |  45 ++++++++++++
 testcases/kernel/syscalls/lstat/.gitignore |   2 +
 testcases/kernel/syscalls/lstat/lstat03.c  |  99 ++++++++++++++++++++++++++
 testcases/kernel/syscalls/open/.gitignore  |   1 +
 testcases/kernel/syscalls/open/open15.c    |  75 ++++++++++++++++++++
 testcases/kernel/syscalls/stat/.gitignore  |   2 +
 testcases/kernel/syscalls/stat/stat04.c    | 109 +++++++++++++++++++++++++++++
 10 files changed, 341 insertions(+), 8 deletions(-)

---
base-commit: afd3ac1d0f2d28960de073bca7e7d4c71a61dd00
change-id: 20240702-stat04-ceeb58b80910

Best regards,

Signature · 5 lines
Andrea Cervesato <[email protected]>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH v4 1/4 Add stat04 test

From: Andrea Cervesato <[email protected]>

This test has been extracted from symlink01 test and it checks that stat() executed on file provide the same information of symlink linking to it.

---
 runtest/smoketest                         |   4 +-
 runtest/syscalls                          |   4 +-
 testcases/kernel/syscalls/stat/.gitignore |   2 +
 testcases/kernel/syscalls/stat/stat04.c   | 109 ++++++++++++++++++++++++++++++
 4 files changed, 114 insertions(+), 5 deletions(-)
runtest/smoketest +1 -3
index f6f14fd2b..aeb74c9ee 100644
@@ -8,9 +8,7 @@ time01 time01
 wait02 wait02
 write01 write01
 symlink01 symlink01
-stat04 symlink01 -T stat04
-utime07 utime07
-rename01A symlink01 -T rename01
+stat04 stat04
 splice02 splice02 -s 20
 df01_sh df01.sh
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
runtest/syscalls +2 -2
index b6cadb2df..1e1203503 100644
@@ -1535,8 +1535,8 @@ stat02 stat02
 stat02_64 stat02_64
 stat03 stat03
 stat03_64 stat03_64
-stat04 symlink01 -T stat04
-stat04_64 symlink01 -T stat04_64
+stat04 stat04
+stat04_64 stat04_64
 
 statfs01 statfs01
 statfs01_64 statfs01_64
testcases/kernel/syscalls/stat/.gitignore +2 -0
index fa0a4ce9f..0a62dc6ee 100644
@@ -4,3 +4,5 @@
 /stat02_64
 /stat03
 /stat03_64
+/stat04
+/stat04_64
testcases/kernel/syscalls/stat/stat04.c new file +109 -0

109 lines not on this page · raw message

Signature · 5 lines
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

PATCH v4 2/4 Add lstat03 test

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

This test has been extracted from symlink01 test and it checks that lstat() provides the right information, according with device, access time, block size, ownership, etc.

---
 runtest/syscalls                           |  4 +-
 testcases/kernel/syscalls/lstat/.gitignore |  2 +
 testcases/kernel/syscalls/lstat/lstat03.c  | 99 ++++++++++++++++++++++++++++++
 3 files changed, 103 insertions(+), 2 deletions(-)
runtest/syscalls +2 -2
index 1e1203503..160725893 100644
@@ -725,12 +725,12 @@ lseek02 lseek02
 lseek07 lseek07
 lseek11 lseek11
 
-lstat01A symlink01 -T lstat01
-lstat01A_64 symlink01 -T lstat01_64
 lstat01 lstat01
 lstat01_64 lstat01_64
 lstat02 lstat02
 lstat02_64 lstat02_64
+lstat03 lstat03
+lstat03_64 lstat03_64
 
 mallinfo02 mallinfo02
 
testcases/kernel/syscalls/lstat/.gitignore +2 -0
index a497a445f..72cba871f 100644
@@ -2,3 +2,5 @@
 /lstat01_64
 /lstat02
 /lstat02_64
+/lstat03
+/lstat03_64
testcases/kernel/syscalls/lstat/lstat03.c new file +99 -0

99 lines not on this page · raw message

Signature · 5 lines
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#4 lore raw

PATCH v4 3/4 Add chmod08 test

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

This test has been extracted from symlink01 and it verifies that chmod() is working correctly on symlink() generated files.

---
 runtest/syscalls                           |  1 +
 testcases/kernel/syscalls/chmod/.gitignore |  1 +
 testcases/kernel/syscalls/chmod/chmod08.c  | 45 ++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+)
runtest/syscalls +1 -0
index 160725893..40c0dd070 100644
@@ -72,6 +72,7 @@ chmod03 chmod03
 chmod05 chmod05
 chmod06 chmod06
 chmod07 chmod07
+chmod08 chmod08
 
 chown01 chown01
 chown01_16 chown01_16
testcases/kernel/syscalls/chmod/.gitignore +1 -0
index 27ddfce16..f295f4dcb 100644
@@ -3,3 +3,4 @@
 /chmod05
 /chmod06
 /chmod07
+/chmod08
testcases/kernel/syscalls/chmod/chmod08.c new file +45 -0

45 lines not on this page · raw message

Signature · 5 lines
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v4 3/4
#5 lore raw

Re: [LTP] [PATCH v4 3/4] Add chmod08 test

Hi!

testcases/kernel/syscalls/chmod/chmod08.c line 20

Quoted 3 lines
testcases/kernel/syscalls/chmod/chmod08.c new file +3 -0
+#define PERMS 01777
+#define TESTFILE "myobject"
+#define	SYMBNAME "my_symlink0"

^
There is stil tab instead of a space.

Otherwise:

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#6 lore raw

Re: [LTP] [PATCH v4 3/4] Add chmod08 test

Quoted 11 lines · Cyril Hrubis

Hi!

testcases/kernel/syscalls/chmod/chmod08.c line 20

Quoted 3 lines
testcases/kernel/syscalls/chmod/chmod08.c new file +3 -0
+#define PERMS 01777
+#define TESTFILE "myobject"
+#define	SYMBNAME "my_symlink0"

^
There is stil tab instead of a space.

Otherwise:

This seems like it has been merged already. Maybe I messed up the rebase. Feel free to merge the remaining patches.

Andrea

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#7 lore raw

PATCH v4 4/4 Add open15 test

In reply to Andrea Cervesato

From: Andrea Cervesato <[email protected]>

This test has been extracted from symlink01 and it verifies that open() is working correctly on symlink() generated files.

---
 runtest/syscalls                          |  2 +-
 testcases/kernel/syscalls/open/.gitignore |  1 +
 testcases/kernel/syscalls/open/open15.c   | 75 +++++++++++++++++++++++++++++++
 3 files changed, 77 insertions(+), 1 deletion(-)
runtest/syscalls +1 -1
index 40c0dd070..4dfdf3782 100644
@@ -923,7 +923,6 @@ nice04 nice04
 nice05 nice05
 
 open01 open01
-open01A symlink01 -T open01
 open02 open02
 open03 open03
 open04 open04
@@ -936,6 +935,7 @@ open11 open11
 open12 open12
 open13 open13
 open14 open14
+open15 open15
 
 openat01 openat01
 openat02 openat02
testcases/kernel/syscalls/open/.gitignore +1 -0
index 001d874d6..af5997572 100644
@@ -12,3 +12,4 @@
 /open12_child
 /open13
 /open14
+/open15
testcases/kernel/syscalls/open/open15.c new file +75 -0

75 lines not on this page · raw message

Signature · 5 lines
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#9 lore raw

Re: [LTP] [PATCH v4 4/4] Add open15 test

Hi all,

the rest of the patchset merged, thanks for your patience.

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp