Skip to contentSkip to conversation

hwmon: (ltc2991) re-order conditions to fix off by one bug

PATCH Applied Dan Carpenter 2 participants 2 messages Jul 4, 2024 – Jul 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (ltc2991) re-order conditions to fix off by one bug

LTC2991_T_INT_CH_NR is 4. The st->temp_en[] array has LTC2991_MAX_CHANNEL
(4) elements. Thus if "channel" is equal to LTC2991_T_INT_CH_NR then we have read one element beyond the end of the array. Flip the conditions around so that we check if "channel" is valid before using it as an array index.

Fixes 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
---
 drivers/hwmon/ltc2991.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/ltc2991.c +2 -2
index a01f887392f9..573cd8f5721b 100644
@@ -225,8 +225,8 @@ static umode_t ltc2991_is_visible(const void *data,
 	case hwmon_temp:
 		switch (attr) {
 		case hwmon_temp_input:
-			if (st->temp_en[channel] ||
-			    channel == LTC2991_T_INT_CH_NR)
+			if (channel == LTC2991_T_INT_CH_NR ||
+			    st->temp_en[channel])
 				return 0444;
 			break;
 		}
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw
Quoted 8 lines · Dan Carpenter

LTC2991_T_INT_CH_NR is 4. The st->temp_en[] array has LTC2991_MAX_CHANNEL
(4) elements. Thus if "channel" is equal to LTC2991_T_INT_CH_NR then we have read one element beyond the end of the array. Flip the conditions around so that we check if "channel" is valid before using it as an array index.

Fixes 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")

Applied.

Thanks,
Guenter