Skip to contentSkip to conversation

vsprintf: add missing MODULE_DESCRIPTION() macro

PATCH In review Jeff Johnson 2 participants 6 messages Jun 1, 2024 – Jul 24, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vsprintf: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

(Using vsprintf prefix since these files match the VSPRINTF entry in the MAINTAINERS file)

---
 lib/test_printf.c | 1 +
 lib/test_scanf.c  | 1 +
 2 files changed, 2 insertions(+)
lib/test_printf.c +1 -0
index 69b6a5e177f2..965cb6f28527 100644
@@ -824,4 +824,5 @@ static void __init selftest(void)
 
 KSTM_MODULE_LOADERS(test_printf);
 MODULE_AUTHOR("Rasmus Villemoes <[email protected]>");
+MODULE_DESCRIPTION("Test cases for printf facility");
 MODULE_LICENSE("GPL");
lib/test_scanf.c +1 -0
index a2707af2951a..7257b1768545 100644
@@ -810,4 +810,5 @@ static void __init selftest(void)
 
 KSTM_MODULE_LOADERS(test_scanf);
 MODULE_AUTHOR("Richard Fitzgerald <[email protected]>");
+MODULE_DESCRIPTION("Test cases for sscanf facility");
 MODULE_LICENSE("GPL v2");

---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240531-md-vsprintf-dab845ebc566

Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Best Regards,
Petr

#2 lore raw
In reply to Jeff Johnson
Quoted 7 lines · Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

JFYI, the patch has been comitted into printk/linux.git, branch for-6.11.

Best Regards,
Petr

#3 lore raw
Quoted 7 lines · Petr Mladek
Quoted 6 lines · Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Quoted 7 lines
Quoted 1 line

JFYI, the patch has been comitted into printk/linux.git, branch for-6.11.

Best Regards,
Petr

Hi Petr,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

Thanks!
/jeff

#4 lore raw
Quoted 13 lines · Jeff Johnson
Quoted 12 lines · Petr Mladek
Quoted 7 lines · Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

JFYI, the patch has been comitted into printk/linux.git, branch for-6.11.

Quoted 7 lines
Quoted 2 lines

Best Regards,
Petr

Hi Petr,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

The pull request is still being discussed, see
https://lore.kernel.org/r/CAHk-=whU_woFnFN-3Jv2hNCmwLg_fkrT42AWwxm-=Ha5BmNX4w@mail.gmail.com

If the printk rework part is not acceptable then I'll send these trivial changes separately.

Best Regards,
Petr

PS: I have sent the pull request late because I have had vacation
previous two weeks.

#5 lore raw
Quoted 25 lines · Petr Mladek
Quoted 13 lines · Jeff Johnson
Quoted 12 lines · Petr Mladek
Quoted 7 lines · Jeff Johnson

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_printf.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_scanf.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

JFYI, the patch has been comitted into printk/linux.git, branch for-6.11.

Quoted 7 lines
Quoted 2 lines

Best Regards,
Petr

Hi Petr,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11. Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.

The pull request is still being discussed, see
https://lore.kernel.org/r/CAHk-=whU_woFnFN-3Jv2hNCmwLg_fkrT42AWwxm-=Ha5BmNX4w@mail.gmail.com

Quoted 8 lines

If the printk rework part is not acceptable then I'll send these trivial changes separately.

Best Regards,
Petr

PS: I have sent the pull request late because I have had vacation
previous two weeks.

Thanks for the update.

Note that, at the advice of Greg KH, after the merge window closes I'll send a series that contains all of the MODULE_DESCRIPTION patches that didn't make it in, so it can come in via that series as well.

/jeff