Skip to contentSkip to conversation

generic/754: fix _fixed_by tags

PATCH In review Darrick J. Wong 3 participants 3 messages Jul 26, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/754: fix _fixed_by tags

From: Darrick J. Wong <[email protected]>

This test requires an xfs_repair patch, so note that in the test. Also update the kernel git hash since we now have one.

---
 tests/generic/754 |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tests/generic/754 +5 -2
index f73d1ed611..7afda609f5 100755
@@ -13,9 +13,12 @@ _begin_fstest auto
 
 _require_scratch
 
-test $FSTYP = "xfs" && \
-	_fixed_by_git_commit kernel XXXXXXXXXXXXX \
+if [ $FSTYP = "xfs" ]; then
+	_fixed_by_git_commit kernel 38de567906d95 \
 			"xfs: allow symlinks with short remote targets"
+	_fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
+			"xfs_repair: small remote symlinks are ok"
+fi
 
 _scratch_mkfs >> $seqres.full
 _scratch_mount >> $seqres.full
Reviewed-by on v1 1/1
#2 lore raw
In reply to Darrick J. Wong
Quoted 16 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

This test requires an xfs_repair patch, so note that in the test. Also update the kernel git hash since we now have one.

---
 tests/generic/754 |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
tests/generic/754 +0 -0
index f73d1ed611..7afda609f5 100755

tests/generic/754 _begin_fstest auto · line 20

Quoted 10 lines
tests/generic/754 +4 -2
@@ -13,9 +13,12 @@ _begin_fstest auto
 
 _require_scratch
 
-test $FSTYP = "xfs" && \
-	_fixed_by_git_commit kernel XXXXXXXXXXXXX \
+if [ $FSTYP = "xfs" ]; then
+	_fixed_by_git_commit kernel 38de567906d95 \
 			"xfs: allow symlinks with short remote targets"
+	_fixed_by_git_commit xfsprogs XXXXXXXXXXXXX \
+			"xfs_repair: small remote symlinks are ok"

Thanks for this update.

Quoted 5 lines
tests/generic/754 +1 -0
+fi
 
 _scratch_mkfs >> $seqres.full
 _scratch_mount >> $seqres.full