Skip to contentSkip to conversation

package/ffmpeg: fix microblaze compile issue

PATCH Applied Waldemar Brodkorb 3 participants 4 messages Aug 15, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ffmpeg: fix microblaze compile issue

Since the update of ffmpeg to 6.1.1 in commit fa36a6375dbeae131c596070570cec66c7bd2456 there are a lot of microblaze build failures.

The compilation failure is triggered by GCC Bug 68485.

Fixes:
- http://autobuild.buildroot.net/results/524/524cef193aec30471e55eb0eecfa39f0d6011a91

And many more.

---
 package/ffmpeg/ffmpeg.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/ffmpeg/ffmpeg.mk +5 -0
index 19c270a14b..a010c0168c 100644
@@ -557,6 +557,11 @@ FFMPEG_CONF_OPTS += --disable-optimizations
 FFMPEG_CFLAGS += -O0
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+FFMPEG_CONF_OPTS += --disable-optimizations
+FFMPEG_CFLAGS += -O0
+endif
+
 ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
 FFMPEG_CFLAGS += -marm
 endif
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

package/ffmpeg/ffmpeg.mk FFMPEG_CONF_OPTS += --disable-optimizations · line 563

Quoted 4 lines · On Thu, 15 Aug 2024 12:45:45 +0200 Waldemar Brodkorb <[email protected]> wrote:
package/ffmpeg/ffmpeg.mk +4 -0
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+FFMPEG_CONF_OPTS += --disable-optimizations
+FFMPEG_CFLAGS += -O0
+endif

Could you clarify why both --disable-optimizations and -O0 are needed?

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi Thomas,
Thomas Petazzoni wrote,

Quoted 9 lines

package/ffmpeg/ffmpeg.mk FFMPEG_CONF_OPTS += --disable-optimizations · line 563

Quoted 4 lines · On Thu, 15 Aug 2024 12:45:45 +0200 Waldemar Brodkorb <[email protected]> wrote:
package/ffmpeg/ffmpeg.mk +4 -0
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+FFMPEG_CONF_OPTS += --disable-optimizations
+FFMPEG_CFLAGS += -O0
+endif

Could you clarify why both --disable-optimizations and -O0 are needed?

Yes, --disable-optimization prevents adding -O3 after our CFLAGS. So indeed both things are required to complete the build.

best regards
Waldemar
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Waldemar Brodkorb

Waldemar, All,

On 2024-08-15 12:45 +0200, Waldemar Brodkorb spake thusly:

Quoted 5 lines

Since the update of ffmpeg to 6.1.1 in commit fa36a6375dbeae131c596070570cec66c7bd2456 there are a lot of microblaze build failures.

The compilation failure is triggered by GCC Bug 68485.

I added a little blurb with your explanations why --disable-optimizations was also needed.

Quoted 6 lines

Fixes:
- http://autobuild.buildroot.net/results/524/524cef193aec30471e55eb0eecfa39f0d6011a91

And many more.

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 package/ffmpeg/ffmpeg.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/ffmpeg/ffmpeg.mk +5 -0
index 19c270a14b..a010c0168c 100644
@@ -557,6 +557,11 @@ FFMPEG_CONF_OPTS += --disable-optimizations
 FFMPEG_CFLAGS += -O0
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+FFMPEG_CONF_OPTS += --disable-optimizations
+FFMPEG_CFLAGS += -O0
+endif
+
 ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
 FFMPEG_CFLAGS += -marm
 endif
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot