Skip to contentSkip to conversation

KVM/arm64 fixes for 6.11, round #1

GIT PULL Oliver Upton 2 participants 2 messages Aug 9, 2024 – Aug 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Paolo,

Decent bit of fixes this time around. The most noteworthy among these is probably Marc's vgic fix that closes a race which can precipitate a UAF, as seen w/ syskaller.

Please pull.

Signature · 77 lines
Thanks,
Oliver

The following changes since commit 8400291e289ee6b2bf9779ff1c83a291501f017b:

  Linux 6.11-rc1 (2024-07-28 14:19:55 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-6.11-1

for you to fetch changes up to 9eb18136af9fe4dd688724070f2bfba271bd1542:

  KVM: arm64: vgic: Hold config_lock while tearing down a CPU interface (2024-08-08 16:58:22 +0000)

----------------------------------------------------------------
KVM/arm64 fixes for 6.11, round #1

 - Use kvfree() for the kvmalloc'd nested MMUs array

 - Set of fixes to address warnings in W=1 builds

 - Make KVM depend on assembler support for ARMv8.4

 - Fix for vgic-debug interface for VMs without LPIs

 - Actually check ID_AA64MMFR3_EL1.S1PIE in get-reg-list selftest

 - Minor code / comment cleanups for configuring PAuth traps

 - Take kvm->arch.config_lock to prevent destruction / initialization
   race for a vCPU's CPUIF which may lead to a UAF

----------------------------------------------------------------
Danilo Krummrich (1):
      KVM: arm64: free kvm->arch.nested_mmus with kvfree()

Fuad Tabba (1):
      KVM: arm64: Tidying up PAuth code in KVM

Marc Zyngier (2):
      KVM: arm64: Enforce dependency on an ARMv8.4-aware toolchain
      KVM: arm64: vgic: Hold config_lock while tearing down a CPU interface

Mark Brown (1):
      KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list

Sebastian Ott (3):
      KVM: arm64: fix override-init warnings in W=1 builds
      KVM: arm64: fix kdoc warnings in W=1 builds
      KVM: arm64: vgic: fix unexpected unlock sparse warnings

Takahiro Itazuri (1):
      docs: KVM: Fix register ID of SPSR_FIQ

Zenghui Yu (1):
      KVM: arm64: vgic-debug: Exit the iterator properly w/o LPI

 Documentation/virt/kvm/api.rst                     |  2 +-
 arch/arm64/include/asm/kvm_ptrauth.h               |  2 +-
 arch/arm64/kvm/Kconfig                             |  1 +
 arch/arm64/kvm/Makefile                            |  3 +++
 arch/arm64/kvm/arm.c                               | 15 +++++----------
 arch/arm64/kvm/hyp/include/hyp/switch.h            |  1 -
 arch/arm64/kvm/hyp/nvhe/Makefile                   |  2 ++
 arch/arm64/kvm/hyp/nvhe/switch.c                   |  5 ++---
 arch/arm64/kvm/hyp/vhe/Makefile                    |  2 ++
 arch/arm64/kvm/nested.c                            |  2 +-
 arch/arm64/kvm/vgic/vgic-debug.c                   |  5 +++--
 arch/arm64/kvm/vgic/vgic-init.c                    |  3 +--
 arch/arm64/kvm/vgic/vgic-irqfd.c                   |  7 ++++---
 arch/arm64/kvm/vgic/vgic-its.c                     | 18 +++++++++++-------
 arch/arm64/kvm/vgic/vgic-v3.c                      |  2 +-
 arch/arm64/kvm/vgic/vgic.c                         |  2 +-
 arch/arm64/kvm/vgic/vgic.h                         |  2 +-
 tools/testing/selftests/kvm/aarch64/get-reg-list.c |  4 ++--
 18 files changed, 42 insertions(+), 36 deletions(-)
maintainer
#1 lore raw
Quoted 8 lines · Oliver Upton

Hi Paolo,

Decent bit of fixes this time around. The most noteworthy among these is probably Marc's vgic fix that closes a race which can precipitate a UAF, as seen w/ syskaller.

Please pull.

Pulled, thanks.

Paolo

Quoted 79 lines

--
Thanks,
Oliver

The following changes since commit 8400291e289ee6b2bf9779ff1c83a291501f017b:

Linux 6.11-rc1 (2024-07-28 14:19:55 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-6.11-1

for you to fetch changes up to 9eb18136af9fe4dd688724070f2bfba271bd1542:

KVM: arm64: vgic: Hold config_lock while tearing down a CPU interface (2024-08-08 16:58:22 +0000)

----------------------------------------------------------------
KVM/arm64 fixes for 6.11, round #1

- Use kvfree() for the kvmalloc'd nested MMUs array

- Set of fixes to address warnings in W=1 builds

- Make KVM depend on assembler support for ARMv8.4

- Fix for vgic-debug interface for VMs without LPIs

- Actually check ID_AA64MMFR3_EL1.S1PIE in get-reg-list selftest

- Minor code / comment cleanups for configuring PAuth traps

- Take kvm->arch.config_lock to prevent destruction / initialization race for a vCPU's CPUIF which may lead to a UAF

----------------------------------------------------------------
Danilo Krummrich (1):

      KVM: arm64: free kvm->arch.nested_mmus with kvfree()

Fuad Tabba (1):
KVM: arm64: Tidying up PAuth code in KVM

Marc Zyngier (2):
KVM: arm64: Enforce dependency on an ARMv8.4-aware toolchain
KVM: arm64: vgic: Hold config_lock while tearing down a CPU interface

Mark Brown (1):
KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list

Sebastian Ott (3):
KVM: arm64: fix override-init warnings in W=1 builds
KVM: arm64: fix kdoc warnings in W=1 builds
KVM: arm64: vgic: fix unexpected unlock sparse warnings

Takahiro Itazuri (1):
docs: KVM: Fix register ID of SPSR_FIQ

Zenghui Yu (1):
KVM: arm64: vgic-debug: Exit the iterator properly w/o LPI

 Documentation/virt/kvm/api.rst                     |  2 +-
 arch/arm64/include/asm/kvm_ptrauth.h               |  2 +-
 arch/arm64/kvm/Kconfig                             |  1 +
 arch/arm64/kvm/Makefile                            |  3 +++
 arch/arm64/kvm/arm.c                               | 15 +++++----------
 arch/arm64/kvm/hyp/include/hyp/switch.h            |  1 -
 arch/arm64/kvm/hyp/nvhe/Makefile                   |  2 ++
 arch/arm64/kvm/hyp/nvhe/switch.c                   |  5 ++---
 arch/arm64/kvm/hyp/vhe/Makefile                    |  2 ++
 arch/arm64/kvm/nested.c                            |  2 +-
 arch/arm64/kvm/vgic/vgic-debug.c                   |  5 +++--
 arch/arm64/kvm/vgic/vgic-init.c                    |  3 +--
 arch/arm64/kvm/vgic/vgic-irqfd.c                   |  7 ++++---
 arch/arm64/kvm/vgic/vgic-its.c                     | 18 +++++++++++-------
 arch/arm64/kvm/vgic/vgic-v3.c                      |  2 +-
 arch/arm64/kvm/vgic/vgic.c                         |  2 +-
 arch/arm64/kvm/vgic/vgic.h                         |  2 +-
 tools/testing/selftests/kvm/aarch64/get-reg-list.c |  4 ++--
 18 files changed, 42 insertions(+), 36 deletions(-)