Skip to contentSkip to conversation

iommu/arm-smmu: Un-demote unhandled-fault msg

PATCH Applied Rob Clark 3 participants 3 messages Aug 9, 2024 – Aug 16, 2024

Subsystems (2)
IOMMU Arm SMMU drivers
lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 iommu/arm-smmu: Un-demote unhandled-fault msg

From: Rob Clark <[email protected]>

Previously this was dev_err_ratelimited() but it got changed to a ratelimited dev_dbg(). Change it back to dev_err().

Fixes d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
Signed-off-by Rob Clark <[email protected]>

---
We have crash telemetry watching for "Unhandled context fault", so we want to preserve this error msg.

 drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/arm/arm-smmu/arm-smmu.c +1 -1
index 723273440c21..8321962b3714 100644
@@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
 void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
 				       const struct arm_smmu_context_fault_info *cfi)
 {
-	dev_dbg(smmu->dev,
+	dev_err(smmu->dev,
 		"Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
 		cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
Signature · 1 line
2.46.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 30 lines · Rob Clark

From: Rob Clark <[email protected]>

Previously this was dev_err_ratelimited() but it got changed to a ratelimited dev_dbg(). Change it back to dev_err().

Fixes d525b0af0c3b ("iommu/arm-smmu: Pretty-print context fault related regs")
Signed-off-by Rob Clark <[email protected]>

---
We have crash telemetry watching for "Unhandled context fault", so we want to preserve this error msg.

 drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/arm/arm-smmu/arm-smmu.c +1 -1
index 723273440c21..8321962b3714 100644
@@ -417,7 +417,7 @@ void arm_smmu_read_context_fault_info(struct arm_smmu_device *smmu, int idx,
 void arm_smmu_print_context_fault_info(struct arm_smmu_device *smmu, int idx,
 				       const struct arm_smmu_context_fault_info *cfi)
 {
-	dev_dbg(smmu->dev,
+	dev_err(smmu->dev,
 		"Unhandled context fault: fsr=0x%x, iova=0x%08lx, fsynr=0x%x, cbfrsynra=0x%x, cb=%d\n",
 		cfi->fsr, cfi->iova, cfi->fsynr, cfi->cbfrsynra, idx);
Signature · 1 line
2.46.0

Yup, this should be changed back to dev_err.

Reviewed-by Pranjal Shrivastava <[email protected]>
maintainer Applied
#2 lore raw
In reply to Rob Clark
Quoted 4 lines · Rob Clark

Previously this was dev_err_ratelimited() but it got changed to a ratelimited dev_dbg(). Change it back to dev_err().

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/arm-smmu: Un-demote unhandled-fault msg

      https://git.kernel.org/will/c/98db56e49008

Cheers,

Signature · 5 lines
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev