package/bird: update to 2.15.1
PATCH 1/1 package/bird: update to 2.15.1
See here for a changelog:
https://gitlab.nic.cz/labs/bird/-/blob/master/NEWS
An uClibc-ng based system needs _GNU_SOURCE in the CFLAGS to provide getrandom().
--- package/bird/bird.hash | 2 +- package/bird/bird.mk | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)
package/bird/bird.hash +1 -1
@@ -1,2 +1,2 @@ -sha256 3ec462a237d06d1f4455d6ec00a42f0b1686061fc988e5c89a841d01dd753b53 bird-2.0.12.tar.gz +sha256 48e85c622de164756c132ea77ad1a8a95cc9fd0137ffd0d882746589ce75c75d bird-2.15.1.tar.gz sha256 94c53c84320078920ac1f0d49c81a4e9004512f534521a58bdf145acbcbc2cd2 README
package/bird/bird.mk +3 -1
@@ -4,7 +4,7 @@ # ################################################################################ -BIRD_VERSION = 2.0.12 +BIRD_VERSION = 2.15.1 BIRD_SITE = https://bird.network.cz/download BIRD_LICENSE = GPL-2.0+ BIRD_LICENSE_FILES = README
@@ -12,6 +12,8 @@ BIRD_CPE_ID_VENDOR = nic BIRD_SELINUX_MODULES = bird BIRD_DEPENDENCIES = host-flex host-bison +BIRD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE" + # 0001-configure.ac-fix-build-with-autoconf-2.70.patch BIRD_AUTORECONF = YES
Signature · 6 lines
2.39.2 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello,
+Fabrice in Cc, as there is a request below :-)
Quoted 7 lines · On Sun, 11 Aug 2024 09:16:31 +0200 Waldemar Brodkorb <[email protected]> wrote:
See here for a changelog:
https://gitlab.nic.cz/labs/bird/-/blob/master/NEWSAn uClibc-ng based system needs
_GNU_SOURCEin the CFLAGS to providegetrandom().Signed-off-by Waldemar Brodkorb <[email protected]>
Thanks, I've applied to next, but I have some comments below.
Quoted 1 line
+BIRD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE"
This seems to be a workaround for an issue in uClibc. Indeed, I don't see in the manpage of getrandom() anything that indicates that defining _GNU_SOURCE is needed to get the definition of getrandom(). Why uClibc is guarding the definition of getrandom() on _GNU_SOURCE, and not glibc or musl?
Quoted 2 lines
# 0001-configure.ac-fix-build-with-autoconf-2.70.patch
BIRD_AUTORECONF= YES
Could you work on upstreaming this patch perhaps? Or maybe convince Fabrice to upstream it? :-)
Thanks a lot!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Thomas,
Thomas Petazzoni wrote,
Quoted 17 lines
Hello,
+Fabrice in Cc, as there is a request below :-)
Quoted 7 lines · On Sun, 11 Aug 2024 09:16:31 +0200 Waldemar Brodkorb <[email protected]> wrote:
See here for a changelog:
https://gitlab.nic.cz/labs/bird/-/blob/master/NEWSAn uClibc-ng based system needs
_GNU_SOURCEin the CFLAGS to providegetrandom().Signed-off-by Waldemar Brodkorb <[email protected]>Thanks, I've applied to next, but I have some comments below.
Quoted 7 lines
Quoted 1 line
+BIRD_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_GNU_SOURCE"
This seems to be a workaround for an issue in uClibc. Indeed, I don't see in the manpage of
getrandom()anything that indicates that defining_GNU_SOURCEis needed to get the definition ofgetrandom(). Why uClibc is guarding the definition ofgetrandom()on_GNU_SOURCE, and not glibc or musl?
I don't know :)
Hopefully fixed in uClibc-ng 1.0.50.
best regards
Waldemar
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot