Skip to contentSkip to conversation

package/unbound: allow TFO for uClibc-ng, add user

PATCH In review Waldemar Brodkorb 2 participants 2 messages Aug 12, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/unbound: allow TFO for uClibc-ng, add user

uClibc-ng toolchains have MSG_FASTOPEN since 2018 so no need to disable support for TCP fastopen.

Add the missing unbound user, which prevents unbound daemon startup on boot.

---
 package/unbound/unbound.mk | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
package/unbound/unbound.mk +5 -8
index ff0262bef1..d46317ed99 100644
@@ -18,18 +18,11 @@ UNBOUND_CONF_OPTS = \
 	--with-pidfile=/var/run/unbound.pid \
 	--with-rootkey-file=/etc/unbound/root.key \
 	--enable-tfo-server \
+	--enable-tfo-client \
 	--with-libevent=$(STAGING_DIR)/usr \
 	--with-libexpat=$(STAGING_DIR)/usr \
 	--with-ssl=$(STAGING_DIR)/usr
 
-# uClibc-ng does not have MSG_FASTOPEN
-# so TCP Fast Open client mode disabled for it
-ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
-UNBOUND_CONF_OPTS += --disable-tfo-client
-else
-UNBOUND_CONF_OPTS += --enable-tfo-client
-endif
-
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
 UNBOUND_CONF_OPTS += --with-pthreads
 else
@@ -54,4 +47,8 @@ define UNBOUND_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S70unbound
 endef
 
+define UNBOUND_USERS
+	unbound -1 unbound -1 * /etc/unbound - - unbound daemon
+endef
+
 $(eval $(autotools-package))
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · On Mon, 12 Aug 2024 07:16:04 +0200 Waldemar Brodkorb <[email protected]> wrote:

uClibc-ng toolchains have MSG_FASTOPEN since 2018 so no need to disable support for TCP fastopen.

Add the missing unbound user, which prevents unbound daemon startup on boot.

---
 package/unbound/unbound.mk | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

Thanks for this patch, but could you make it two patches? Indeed, adding the unbound user is a fix, so we will want to backport it, while the other one is really a "new" feature.

Also, could you change to "enable tfo-client", because TFO server was already enabled, it's really TFO client that wasn't.

Thanks a lot!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot