coccinelle: Add rules to find str_down_up() replacements
Subsystems (2)
Kees Cook
maintainerPATCH 1/1 coccinelle: Add rules to find str_down_up() replacements
As done with str_up_down(), add checks for str_down_up() opportunities. 5 cases currently exist in the tree.
Suggested-by Andy Shevchenko <[email protected]>
Signed-off-by Kees Cook <[email protected]>
---
Cc: Andy Shevchenko <[email protected]>
Cc: Michal Wajdeczko <[email protected]>
Cc: Julia Lawall <[email protected]>
Cc: Nicolas Palix <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- scripts/coccinelle/api/string_choices.cocci | 23 +++++++++++++++++++++ 1 file changed, 23 insertions(+)
scripts/coccinelle/api/string_choices.cocci +23 -0
@@ -62,3 +62,26 @@ e << str_up_down_r.E; @@ coccilib.report.print_report(p[0], "opportunity for str_up_down(%s)" % e) + +@str_down_up depends on patch@ +expression E; +@@ +( +- ((E) ? "down" : "up") ++ str_down_up(E) +) + +@str_down_up_r depends on !patch exists@ +expression E; +position P; +@@ +( +* ((E@P) ? "down" : "up") +) + +@script:python depends on report@ +p << str_down_up_r.P; +e << str_down_up_r.E; +@@ + +coccilib.report.print_report(p[0], "opportunity for str_down_up(%s)" % e)
Signature · 1 line
2.34.1
Quoted 2 lines · Kees Cook
As done with
str_up_down(), add checks forstr_down_up()opportunities. 5 cases currently exist in the tree.
Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko