Skip to contentSkip to conversation

package/fbdump: fix gcc 14.x issue

PATCH Applied Waldemar Brodkorb 2 participants 3 messages Aug 28, 2024 – Sep 3, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/fbdump: fix gcc 14.x issue

Following error is seen with gcc 14.x:
/home/autobuild/autobuild/instance-0/output-1/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I. -I.. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -O2 -fomit-frame-pointer -s -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -c test -f 'main.c' || echo './'main.c
main.c: In function 'main':
main.c:82:49: error: passing argument 4 of 'Options_parse' from incompatible pointer type [-Wincompatible-pointer-types]

   82 |   if( Options_parse( opt_template, &opts, argc, argv ) != 0 )
      |                                                 ^~~~
      |                                                 |
      |                                                 char **

In file included from main.c:17:
options.h:32:83: note: expected 'const char **' but argument is of type 'char **'
32 | int Options_parse( const OptionTemplate *tmplt, void *opts, int argc, const char *argv[] );
| ~~~~~~~~~~~~^~~~~~
make[3]: *** [Makefile:240: main.o] Error 1
make[3]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2/src' make[2]: *** [Makefile:201: all-recursive] Error 1
make[2]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2' make[1]: *** [Makefile:156: all] Error 2
make[1]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2'

Fixes:

http://autobuild.buildroot.net/results/3a0/3a0abff75023e257f3d6048688485a380b72fbb3

---
 package/fbdump/0001-fix-gcc14-compile-issue.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 package/fbdump/0001-fix-gcc14-compile-issue.patch
package/fbdump/0001-fix-gcc14-compile-issue.patch new file +15 -0
new file mode 100644
index 0000000000..a554b4faf6
@@ -0,0 +1,15 @@
+Signed-off-by: Waldemar Brodkorb <[email protected]>
+Upstream: N/A no SCM, not active anymore
+
+diff -Nur fbdump-0.4.2.orig/src/main.c fbdump-0.4.2/src/main.c
+--- fbdump-0.4.2.orig/src/main.c	2007-03-03 04:14:37.000000000 +0100
++++ fbdump-0.4.2/src/main.c	2024-08-16 09:25:42.828125778 +0200
+@@ -58,7 +58,7 @@
+ }
+ 
+ 
+-int main( int argc, char *argv[] )
++int main( int argc, const char *argv[] )
+ {
+   Options  opts = {
+     .fbdev = DEFAULT_DEVICE,
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 21 lines · On Wed, 28 Aug 2024 14:59:40 +0200 Waldemar Brodkorb <[email protected]> wrote:

Following error is seen with gcc 14.x:
/home/autobuild/autobuild/instance-0/output-1/host/bin/armeb-buildroot-linux-uclibcgnueabi-gcc -DHAVE_CONFIG_H -I. -I. -I.. -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -O2 -fomit-frame-pointer -s -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -g0 -c test -f 'main.c' || echo './'main.c
main.c: In function 'main':
main.c:82:49: error: passing argument 4 of 'Options_parse' from incompatible pointer type [-Wincompatible-pointer-types]

   82 |   if( Options_parse( opt_template, &opts, argc, argv ) != 0 )
      |                                                 ^~~~
      |                                                 |
      |                                                 char **

In file included from main.c:17:
options.h:32:83: note: expected 'const char **' but argument is of type 'char **'
32 | int Options_parse( const OptionTemplate *tmplt, void *opts, int argc, const char *argv[] );
| ~~~~~~~~~~~~^~~~~~
make[3]: *** [Makefile:240: main.o] Error 1
make[3]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2/src' make[2]: *** [Makefile:201: all-recursive] Error 1
make[2]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2' make[1]: *** [Makefile:156: all] Error 2
make[1]: Leaving directory '/home/autobuild/autobuild/instance-0/output-1/build/fbdump-0.4.2'

Fixes:

Quoted 7 lines

http://autobuild.buildroot.net/results/3a0/3a0abff75023e257f3d6048688485a380b72fbb3

---
 package/fbdump/0001-fix-gcc14-compile-issue.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 package/fbdump/0001-fix-gcc14-compile-issue.patch

Applied to next, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
Quoted 5 lines · On Tue, 3 Sep 2024 23:33:27 +0200 Thomas Petazzoni…
Quoted 3 lines
 package/fbdump/0001-fix-gcc14-compile-issue.patch | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 package/fbdump/0001-fix-gcc14-compile-issue.patch  

Applied to next, thanks.

Sorry, wrong, I applied to master. Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot