Initialize symbol 'entity' in sched_main.c
Subsystems (3)
PATCH 1/1 Initialize symbol 'entity' in sched_main.c
smatch reported following error:
'''staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'. '''
The symbol entity is initialized.
Signed-off-by Dipendra Khadka <[email protected]>
--- drivers/gpu/drm/scheduler/sched_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/scheduler/sched_main.c +1 -1
@@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,static struct drm_sched_entity *drm_sched_select_entity (struct drm_gpu_scheduler *sched) { -struct drm_sched_entity *entity; +struct drm_sched_entity *entity =NULL ;int i;/* Start with the highest priority.
Signature · 1 line
2.43.0
Matthew Brost
maintainerQuoted 8 lines · Dipendra Khadka
smatch reported following error:
'''
staging/drivers/gpu/drm/scheduler/sched_main.c:1063drm_sched_select_entity()error: uninitialized symbol 'entity'. '''The symbol entity is initialized.
Looks like false postive, no opposed merging it but since 'sched->num_rqs' must be greater than zero it entity should always be set unless I'm missing something.
Matt
Quoted 21 lines
Signed-off-by Dipendra Khadka <[email protected]>--- drivers/gpu/drm/scheduler/sched_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/scheduler/sched_main.c +1
-1@@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,static struct drm_sched_entity *drm_sched_select_entity (struct drm_gpu_scheduler *sched) { -struct drm_sched_entity *entity; +struct drm_sched_entity *entity =NULL ;int i;/* Start with the highest priority. Signature · 1 line
2.43.0