Skip to contentSkip to conversation

Initialize symbol 'entity' in sched_main.c

PATCH In review Dipendra Khadka 2 participants 2 messages Aug 17, 2024 – Aug 18, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Initialize symbol 'entity' in sched_main.c

smatch reported following error:

'''
staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'. '''

The symbol entity is initialized.

---
 drivers/gpu/drm/scheduler/sched_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/scheduler/sched_main.c +1 -1
index 7e90c9f95611..dcfd4d0f7c6e 100644
@@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,
 static struct drm_sched_entity *
 drm_sched_select_entity(struct drm_gpu_scheduler *sched)
 {
-	struct drm_sched_entity *entity;
+	struct drm_sched_entity *entity = NULL;
 	int i;
 
 	/* Start with the highest priority.
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 8 lines · Dipendra Khadka

smatch reported following error:

'''
staging/drivers/gpu/drm/scheduler/sched_main.c:1063 drm_sched_select_entity() error: uninitialized symbol 'entity'. '''

The symbol entity is initialized.

Looks like false postive, no opposed merging it but since 'sched->num_rqs' must be greater than zero it entity should always be set unless I'm missing something.

Matt

Quoted 21 lines
---
 drivers/gpu/drm/scheduler/sched_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/scheduler/sched_main.c +1 -1
index 7e90c9f95611..dcfd4d0f7c6e 100644
@@ -1047,7 +1047,7 @@ void drm_sched_wakeup(struct drm_gpu_scheduler *sched,
 static struct drm_sched_entity *
 drm_sched_select_entity(struct drm_gpu_scheduler *sched)
 {
-	struct drm_sched_entity *entity;
+	struct drm_sched_entity *entity = NULL;
 	int i;
 
 	/* Start with the highest priority.
Signature · 1 line
2.43.0