Skip to contentSkip to conversation

selftests: netfilter: nft_queue.sh: sctp coverage

PATCH Applied Florian Westphal 2 participants 2 messages Jul 2, 2024 – Aug 19, 2024

Subsystems (3)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 selftests: netfilter: nft_queue.sh: sctp coverage

From: Antonio Ojea <[email protected]>

Test that nfqueue with and without GSO process SCTP packets correctly.

Joint work with Florian and Pablo.

---
Squash patch of original+local fixes to make this work in netdev CI.

Main changes:
* update config, ss -S won't work without SCTP_DIAG=m
* reduce file size for sctp output test.
This is rather slow (~3mbyte/s), but I'm reluctant to just skb_orphan() before doing the nfnetlink_queue segmentation (this "fixes" the problem).
* "wait" before comparing output file size, not after. Else we might get file mismatch because sender exited but receiver is still processing inflight packets.
* flush existing rules
* don't start nf_queue program first: it has an idle (no-packets-seen) timeout of just 2s, on slow machines this can cause exit() before the sender emits the init packet (-> test timeout).

I did not find anything wrong with the sctp patch to nfnetlink_queue.

 tools/testing/selftests/net/netfilter/config  |  2 +
 .../selftests/net/netfilter/nft_queue.sh      | 85 ++++++++++++++++++-
 2 files changed, 86 insertions(+), 1 deletion(-)
tools/testing/selftests/net/netfilter/config +2 -0
index 63ef80ef47a4..b2dd4db45215 100644
@@ -87,3 +87,5 @@ CONFIG_XFRM_USER=m
 CONFIG_XFRM_STATISTICS=y
 CONFIG_NET_PKTGEN=m
 CONFIG_TUN=m
+CONFIG_INET_DIAG=m
+CONFIG_SCTP_DIAG=m
tools/testing/selftests/net/netfilter/nft_queue.sh +84 -1

114 lines not on this page · raw message

Signature · 1 line
2.44.2
maintainer Applied
#1 lore raw
Quoted 5 lines · Florian Westphal

From: Antonio Ojea <[email protected]>

Test that nfqueue with and without GSO process SCTP packets correctly.

Joint work with Florian and Pablo.

applied this to nf-next, including:

netfilter: nfnetlink_queue: unbreak SCTP traffic