Skip to contentSkip to conversation

ARM: dts: imx28-tx28: Fix the fsl,saif-master usage

PATCH Applied Fabio Estevam 3 participants 3 messages Sep 2, 2024 – Sep 3, 2024

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx28-tx28: Fix the fsl,saif-master usage

From: Fabio Estevam <[email protected]>

According to fsl,saif.yaml, fsl,saif-master is a phandle to the master SAIF.

Change it accordingly, to fix the following dt-schema warnings:

saif@80042000: fsl,saif-master: True is not of type 'array'
saif@80042000: Unevaluated properties are not allowed ('fsl,saif-master' was unexpected)

---
 arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts +1 -1
index d38183edf0fd..9290635352f1 100644
@@ -615,13 +615,13 @@ MX28_PAD_JTAG_RTCK__GPIO_4_20 /* USBH_OC */
 &saif0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&saif0_pins_b>;
-	fsl,saif-master;
 	status = "okay";
 };
 
 &saif1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&saif1_pins_a>;
+	fsl,saif-master = <&saif0>;
 	status = "okay";
 };
 
Signature · 1 line
2.34.1
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 24 lines

From: Fabio Estevam <[email protected]>

According to fsl,saif.yaml, fsl,saif-master is a phandle to the master SAIF.

Change it accordingly, to fix the following dt-schema warnings:

saif@80042000: fsl,saif-master: True is not of type 'array'
saif@80042000: Unevaluated properties are not allowed ('fsl,saif-master' was unexpected)

---
 arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts +0 -1
index d38183edf0fd..9290635352f1 100644
@@ -615,13 +615,13 @@ MX28_PAD_JTAG_RTCK__GPIO_4_20 /* USBH_OC */
 &saif0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&saif0_pins_b>;
-	fsl,saif-master;

arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts MX28_PAD_JTAG_RTCK__GPIO_4_20 /* USBH_OC */ · line 627

Quoted 10 lines
arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts +1 -0
 	status = "okay";
 };
 
 &saif1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&saif1_pins_a>;
+	fsl,saif-master = <&saif0>;
 	status = "okay";
 };
 

Lothar Waßmann

Signature · 9 lines
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | [email protected]
___________________________________________________________
Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

According to fsl,saif.yaml, fsl,saif-master is a phandle to the master SAIF.

Change it accordingly, to fix the following dt-schema warnings:

saif@80042000: fsl,saif-master: True is not of type 'array'
saif@80042000: Unevaluated properties are not allowed ('fsl,saif-master' was unexpected)

Applied, thanks!