target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64
PATCH v2 1/1 target/hppa: Fix PSW V-bit packaging in cpu_hppa_get for hppa64
While adding hppa64 support, the psw_v variable got extended from 32 to 64 bits. So, when packaging the PSW-V bit from the psw_v variable for interrupt processing, check bit 31 instead the 63th (sign) bit.
This fixes a hard to find Linux kernel boot issue where the loss of the PSW-V bit due to an ITLB interruption in the middle of a series of ds/addc instructions (from the divU milicode library) generated the wrong division result and thus triggered a Linux kernel crash.
Reported-by Guenter Roeck <[email protected]>
Signed-off-by Helge Deller <[email protected]>
Reviewed-by Richard Henderson <[email protected]>
Tested-by Guenter Roeck <[email protected]>
Fixes 931adff31478 ("target/hppa: Update cpu_hppa_get/put_psw for hppa64")
Cc [email protected] # v8.2+
---
v2:
- added change to cpu.h (as requested by Richard)
- added Richards R-b
- added stable CC tag
target/hppa/helper.c +1 -1
@@ -53,7 +53,7 @@ target_ulong cpu_hppa_get_psw(CPUHPPAState *env) } psw |= env->psw_n *PSW_N ; - psw |= (env->psw_v <0 ) *PSW_V ; + psw |= ((env->psw_v >>31 ) &1 ) *PSW_V ; psw |= env->psw | env->psw_xb;return psw;
target/hppa/cpu.h +1 -1
@@ -211,7 +211,7 @@ typedef struct CPUArchState {uint32_t psw;/* All psw bits except the following: */ uint32_t psw_xb;/* X and B, in their normal positions */ target_ulong psw_n;/* boolean */ -target_long psw_v;/* in most significant bit */ +target_long psw_v;/* in bit 31 */ /* Splitting the carry-borrow field into the MSB and "the rest", allows * for "the rest" to be deleted when it is unused, but the MSB is in use.