Skip to contentSkip to conversation

crypto: x86/aesni - update docs for aesni-intel module

PATCH In review Eric Biggers 2 participants 2 messages Aug 27, 2024 – Sep 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: x86/aesni - update docs for aesni-intel module

From: Eric Biggers <[email protected]>

Update the kconfig help and module description to reflect that VAES instructions are now used in some cases. Also fix XTR => XCTR.

---
 arch/x86/crypto/Kconfig            | 8 ++++++--
 arch/x86/crypto/aesni-intel_glue.c | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)
arch/x86/crypto/Kconfig +6 -2
index 24875e6295f2d..7b1bebed879df 100644
@@ -12,25 +12,29 @@ config CRYPTO_CURVE25519_X86
 
 	  Architecture: x86_64 using:
 	  - ADX (large integer arithmetic)
 
 config CRYPTO_AES_NI_INTEL
-	tristate "Ciphers: AES, modes: ECB, CBC, CTS, CTR, XTR, XTS, GCM (AES-NI)"
+	tristate "Ciphers: AES, modes: ECB, CBC, CTS, CTR, XCTR, XTS, GCM (AES-NI/VAES)"
 	depends on X86
 	select CRYPTO_AEAD
 	select CRYPTO_LIB_AES
 	select CRYPTO_LIB_GF128MUL
 	select CRYPTO_ALGAPI
 	select CRYPTO_SKCIPHER
 	select CRYPTO_SIMD
 	help
 	  Block cipher: AES cipher algorithms
 	  AEAD cipher: AES with GCM
-	  Length-preserving ciphers: AES with ECB, CBC, CTS, CTR, XTR, XTS
+	  Length-preserving ciphers: AES with ECB, CBC, CTS, CTR, XCTR, XTS
 
 	  Architecture: x86 (32-bit and 64-bit) using:
 	  - AES-NI (AES new instructions)
+	  - VAES (Vector AES)
+
+	  Some algorithm implementations are supported only in 64-bit builds,
+	  and some have additional prerequisites such as AVX2 or AVX512.
 
 config CRYPTO_BLOWFISH_X86_64
 	tristate "Ciphers: Blowfish, modes: ECB, CBC"
 	depends on X86 && 64BIT
 	select CRYPTO_SKCIPHER
arch/x86/crypto/aesni-intel_glue.c +1 -1
index d63ba9eaba3e4..b0dd835554997 100644
@@ -1748,8 +1748,8 @@ static void __exit aesni_exit(void)
 }
 
 late_initcall(aesni_init);
 module_exit(aesni_exit);
 
-MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm, Intel AES-NI instructions optimized");
+MODULE_DESCRIPTION("AES cipher and modes, optimized with AES-NI or VAES instructions");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS_CRYPTO("aes");

base-commit: 3c44d31cb34ce4eb8311a2e73634d57702948230

Signature · 1 line
2.46.0
maintainer
#1 lore raw
Quoted 10 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Update the kconfig help and module description to reflect that VAES instructions are now used in some cases. Also fix XTR => XCTR.

---
arch/x86/crypto/Kconfig | 8 ++++++--
arch/x86/crypto/aesni-intel_glue.c | 2 +-

2 files changed, 7 insertions(+), 3 deletions(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt