dt-bindings: usb: add missing compatible arraylist

PATCH In review Karan Sanghavi 3 participants 5 messages Sep 22, 2024 – Sep 28, 2024

Subsystems (2)

Device tree bindings USB

lore

Share & tools

lore

Karan Sanghavi

author

2024-09-22 17:00 UTC #0 lore raw

PATCH 1/1 dt-bindings: usb: add missing compatible arraylist

Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml

This is highly ambiguous to me as where exactly the changes needs to be added is it in the dts file or is the yaml where we have to reverse the order already mentioned or do we have to add the another order as I have done ?

Signed-off-by Karan Sanghavi <[email protected]>

---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
 1 file changed, 3 insertions(+)

Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +3 -0

index 95ff9791baea..822653217c43 100644
@@ -17,6 +17,9 @@ properties:
       - items:
           - const: ti,j721e-usb
           - const: ti,am64-usb
+      - items:
+          - const: ti,am64-usb
+          - const: ti,j721e-usb
 
   reg:
     maxItems: 1

Signature · 1 line

2.43.0

Krzysztof Kozlowski

2024-09-22 18:51 UTC #1 lore raw

Quoted 8 lines · Karan Sanghavi

Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml
This is highly ambiguous to me as where exactly the changes needs to be added is it in the dts file or is the yaml where we have to reverse the order already mentioned or do we have to add the another order as I have done ?

If you do not understand the problem being fixed thus not know how to fix it, I don't quite get why you decided to send a patch...

Quoted 11 lines

Signed-off-by Karan Sanghavi <[email protected]>
---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +0 -0
index 95ff9791baea..822653217c43 100644

Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml properties: · line 22

Quoted 6 lines

Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +3 -0

@@ -17,6 +17,9 @@ properties:
       - items:
           - const: ti,j721e-usb
           - const: ti,am64-usb
+      - items:
+          - const: ti,am64-usb
+          - const: ti,j721e-usb

Sorry, this does not look right - duplicates above compatibles. Nothing in the commit msg explains why this order is needed (in terms of hardware).

Best regards,
Krzysztof

Roger Quadros

2024-09-23 11:53 UTC #2 lore raw

In reply to Karan Sanghavi

Quoted 3 lines · Karan Sanghavi

Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml

k3-am642-sk.dts does not introduce any nodes with the said compatibles.

"ti,am64-usb" compatible is introduced by k3-am642-main.dtsi. There is only one compatible introduced so there is nothing to do about order here.

i.e.

        usbss0: cdns-usb@f900000 {
                compatible = "ti,am64-usb";
                reg = <0x00 0xf900000 0x00 0x100>;

What is the functional problem you are facing? Maybe then someone can point you in the right direction.

Quoted 25 lines

This is highly ambiguous to me as where exactly the changes needs to be added is it in the dts file or is the yaml where we have to reverse the order already mentioned or do we have to add the another order as I have done ?
Signed-off-by Karan Sanghavi <[email protected]>
---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +3 -0
index 95ff9791baea..822653217c43 100644
@@ -17,6 +17,9 @@ properties:
       - items:
           - const: ti,j721e-usb
           - const: ti,am64-usb
+      - items:
+          - const: ti,am64-usb
+          - const: ti,j721e-usb
 
   reg:
     maxItems: 1

Signature · 2 lines

cheers,
-roger

Karan Sanghavi

author

2024-09-28 07:40 UTC #3 lore raw

Quoted 12 lines · Roger Quadros

Quoted 3 lines · Karan Sanghavi
Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml
k3-am642-sk.dts does not introduce any nodes with the said compatibles.
"ti,am64-usb" compatible is introduced by k3-am642-main.dtsi. There is only one compatible introduced so there is nothing to do about order here.

Quoted 8 lines

i.e.
        usbss0: cdns-usb@f900000 {
                compatible = "ti,am64-usb";
                reg = <0x00 0xf900000 0x00 0x100>;
What is the functional problem you are facing? Maybe then someone can point you in the right direction.

Sorry for mentioning the wrong file name; yes,
the problem is in k3-am64-main.dtsi file as mentioned below

usbss0: cdns-usb@f900000 {
766 compatible = "ti,am64-usb", "ti,j721e-usb";
767 reg = <0x00 0xf900000 0x00 0x100>;

Due to this, it gives an error as in the YAML file the order is in reverse order.
Also, I cloned the repo yesterday and still found the same error in the dtsi file.
So have I done something wrong? as I see I might be out of sync with latest changes

Thank you.

Quoted 29 lines

Quoted 16 lines
This is highly ambiguous to me as where exactly the changes needs to be added is it in the dts file or is the yaml where we have to reverse the order already mentioned or do we have to add the another order as I have done ?
Signed-off-by Karan Sanghavi <[email protected]>
---
 Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +0 -0
index 95ff9791baea..822653217c43 100644
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml properties: · line 25
Quoted 9 lines
Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml +3 -0
@@ -17,6 +17,9 @@ properties:
       - items:
           - const: ti,j721e-usb
           - const: ti,am64-usb
+      - items:
+          - const: ti,am64-usb
+          - const: ti,j721e-usb
 
   reg:
     maxItems: 1
--
cheers,
-roger

Roger Quadros

2024-09-28 07:58 UTC #4 lore raw

Quoted 22 lines · Karan Sanghavi

Quoted 12 lines · Roger Quadros
Quoted 3 lines · Karan Sanghavi
Added the vice versa order for compatible property in the yaml file so that the dtb can parse for the order mentioned in the dts file k3-am642-sk.dts for ti,j721e-usb.yaml
k3-am642-sk.dts does not introduce any nodes with the said compatibles.
"ti,am64-usb" compatible is introduced by k3-am642-main.dtsi. There is only one compatible introduced so there is nothing to do about order here.
Quoted 8 lines
i.e.
        usbss0: cdns-usb@f900000 {
                compatible = "ti,am64-usb";
                reg = <0x00 0xf900000 0x00 0x100>;
What is the functional problem you are facing? Maybe then someone can point you in the right direction.

Quoted 7 lines

Sorry for mentioning the wrong file name; yes,
the problem is in k3-am64-main.dtsi file as mentioned below
usbss0: cdns-usb@f900000 {
766 compatible = "ti,am64-usb", "ti,j721e-usb";
767 reg = <0x00 0xf900000 0x00 0x100>;

Which tree are you looking at?

https://elixir.bootlin.com/linux/v6.11/source/arch/arm64/boot/dts/ti/k3-am64-main.dtsi#L761

	usbss0: cdns-usb@f900000 {
		compatible = "ti,am64-usb";
		reg = <0x00 0xf900000 0x00 0x100>;

Quoted 6 lines

Due to this, it gives an error as in the YAML file the order is in reverse order.
Also, I cloned the repo yesterday and still found the same error in the dtsi file.
So have I done something wrong? as I see I might be out of sync with latest changes

You seem to be looking at some old tree. Please refer to latest kernel tree when submitting changes upstream.

Signature · 2 lines

cheers,
-roger