staging: rtl8712: use kmalloc_array
PATCH v2 1/1 staging: rtl8712: use kmalloc_array
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: Prefer kmalloc_array over kmalloc with multiply
+ pxmitpriv->pxmitbuf = kmalloc(NR_XMITBUFF * sizeof(struct xmit_buf), GFP_ATOMIC);
Signed-off-by Tudor Gheorghiu <[email protected]>
---
v2: Update patch description
--- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_xmit.c +1 -1
@@ -117,7 +117,7 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,/*init xmit_buf*/ _init_queue (&pxmitpriv->free_xmitbuf_queue);_init_queue (&pxmitpriv->pending_xmitbuf_queue); - pxmitpriv->pxmitbuf =kmalloc (NR_XMITBUFF *sizeof (struct xmit_buf ),GFP_ATOMIC ); + pxmitpriv->pxmitbuf =kmalloc_array (NR_XMITBUFF ,sizeof (struct xmit_buf ),GFP_ATOMIC );if (!pxmitpriv->pxmitbuf) goto clean_up_frame_buf; pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
Signature · 1 line
2.43.0
Quoted 19 lines · Tudor Gheorghiu
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: Prefer
kmalloc_arrayover kmalloc with multiply
+pxmitpriv->pxmitbuf=kmalloc(NR_XMITBUFF * sizeof(struct xmit_buf), GFP_ATOMIC);Signed-off-by Tudor Gheorghiu <[email protected]>---
v2: Update patch description--- drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8712/rtl871x_xmit.c +0
-0
drivers/staging/rtl8712/rtl871x_xmit.c int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv, · line 123
Quoted 8 lines
drivers/staging/rtl8712/rtl871x_xmit.c +1
-1@@ -117,7 +117,7 @@ int _r8712_init_xmit_priv(struct xmit_priv *pxmitpriv,/*init xmit_buf*/ _init_queue (&pxmitpriv->free_xmitbuf_queue);_init_queue (&pxmitpriv->pending_xmitbuf_queue); - pxmitpriv->pxmitbuf =kmalloc (NR_XMITBUFF *sizeof (struct xmit_buf ),GFP_ATOMIC ); + pxmitpriv->pxmitbuf =kmalloc_array (NR_XMITBUFF ,sizeof (struct xmit_buf ),GFP_ATOMIC );if (!pxmitpriv->pxmitbuf) goto clean_up_frame_buf; pxmitbuf = (struct xmit_buf *)pxmitpriv->pxmitbuf;
Reviewed-by Philipp Hortmann <[email protected]>