perf: Remove unused add_perf_probe_events
PATCH 1/1 perf: Remove unused add_perf_probe_events
From: "Dr. David Alan Gilbert" <[email protected]>
add_perf_probe_events has been unused since 2015's commit b02137cc6550 ("perf probe: Move print logic into cmd_probe()") which confusingly now uses perf_add_probe_events.
Remove it.
--- tools/perf/util/probe-event.c | 18 ------------------ tools/perf/util/probe-event.h | 1 - 2 files changed, 19 deletions(-)
tools/perf/util/probe-event.c +0 -18
@@ -3705,24 +3705,6 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs) } } -int add_perf_probe_events (struct perf_probe_event *pevs,int npevs) -{ -int ret; - - ret =init_probe_symbol_maps (pevs->uprobes); -if (ret <0 ) -return ret; - - ret =convert_perf_probe_events (pevs, npevs); -if (ret ==0 ) - ret =apply_perf_probe_events (pevs, npevs); - -cleanup_perf_probe_events (pevs, npevs); - -exit_probe_symbol_maps (); -return ret; -} -int del_perf_probe_events (struct strfilter *filter) {int ret, ret2, ufd =-1 , kfd =-1 ;
tools/perf/util/probe-event.h +0 -1
@@ -159,7 +159,6 @@ void line_range__clear(struct line_range *lr);/* Initialize line range */ int line_range__init (struct line_range *lr); -int add_perf_probe_events (struct perf_probe_event *pevs,int npevs);int convert_perf_probe_events (struct perf_probe_event *pevs,int npevs);int apply_perf_probe_events (struct perf_probe_event *pevs,int npevs);int show_probe_trace_events (struct perf_probe_event *pevs,int npevs);
Signature · 1 line
2.46.2
Namhyung Kim
maintainerAdding Masami to CC.
Quoted 58 lines · On Sun, Sep 29, 2024 at 02:06:59AM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
add_perf_probe_eventshas been unused since 2015's commitb02137cc6550("perf probe: Move print logic intocmd_probe()") which confusingly now usesperf_add_probe_events.Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- tools/perf/util/probe-event.c | 18 ------------------ tools/perf/util/probe-event.h | 1 - 2 files changed, 19 deletions(-)tools/perf/util/probe-event.c +0
-18@@ -3705,24 +3705,6 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs) } } -int add_perf_probe_events (struct perf_probe_event *pevs,int npevs) -{ -int ret; - - ret =init_probe_symbol_maps (pevs->uprobes); -if (ret <0 ) -return ret; - - ret =convert_perf_probe_events (pevs, npevs); -if (ret ==0 ) - ret =apply_perf_probe_events (pevs, npevs); - -cleanup_perf_probe_events (pevs, npevs); - -exit_probe_symbol_maps (); -return ret; -} -int del_perf_probe_events (struct strfilter *filter) {int ret, ret2, ufd =-1 , kfd =-1 ;tools/perf/util/probe-event.h +0
-1@@ -159,7 +159,6 @@ void line_range__clear(struct line_range *lr);/* Initialize line range */ int line_range__init (struct line_range *lr); -int add_perf_probe_events (struct perf_probe_event *pevs,int npevs);int convert_perf_probe_events (struct perf_probe_event *pevs,int npevs);int apply_perf_probe_events (struct perf_probe_event *pevs,int npevs);int show_probe_trace_events (struct perf_probe_event *pevs,int npevs);Signature · 1 line
2.46.2
Quoted 8 lines · On Sun, 29 Sep 2024 02:06:59 +0100, [email protected] wrote:
add_perf_probe_eventshas been unused since 2015's commitb02137cc6550("perf probe: Move print logic intocmd_probe()") which confusingly now usesperf_add_probe_events.Remove it.
[...]
Applied to perf-tools-next, thanks!
[1/1] perf: Remove unused add_perf_probe_events
commit: 3c4e558787f233044052ffd255a44ff7127952ce
Best regards,
Namhyung