riscv: dts: starfive: jh7110: Add camera subsystem nodes
Hi, Aurelien
Quoted 19 lines
Hi,
Quoted 7 lines · Changhuang Liang
Add camera subsystem nodes for the StarFive JH7110 SoC. They contain the dphy-rx, csi2rx, camss nodes.
Signed-off-by Changhuang Liang <[email protected]>--- .../jh7110-starfive-visionfive-2.dtsi | 49 ++++++++++++++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 67+++++++++++++++++++
Quoted 1 line
2 files changed, 116 insertions(+)We have been asked to enable
CONFIG_VIDEO_STARFIVE_CAMSSin the Debian kernel, which from my understanding and given the device tree shown below also requires enablingCONFIG_VIDEO_CADENCE_CSI2RX. That said doing so triggers the following error in dmesg:
Quoted 6 lines
[ 25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rxfailed with error -22
From a quick look it seems there is something in the port@0 csi2rx entry. Do you happen to know what is wrong?
You need to add your sensor node. You can refer to this patch:
https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/
We suggest that using the imx219
Quoted 62 lines
Thanks
AurelienQuoted 59 lines
diff --git
a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsib/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsiindexb89e9791efa7..737ee97a3577100644arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi +49
-0@@ -125,6 +125,55 @@ &tdm_ext { clock-frequency = <49152000>; }; +&camss { + assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>, + <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>; + assigned-clock-rates = <49500000>, <198000000>; + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + }; + + port@1 { + reg = <1>; + + camss_from_csi2rx: endpoint { + remote-endpoint = <&csi2rx_to_camss>; + }; + }; + }; +}; + +&csi2rx { + assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>; + assigned-clock-rates = <297000000>; + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + /* remote MIPI sensor endpoint */ + }; + + port@1 { + reg = <1>; + + csi2rx_to_camss: endpoint { + remote-endpoint = <&camss_from_csi2rx>; + }; + }; + }; +}; +
Quoted 8 lines
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi &tdm_ext { · line 179
Quoted 3 lines
arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi +0
-0&gmac0 { phy-handle = <&phy0>; phy-mode = "rgmii-id";--
Aurelien Jarno GPG: 4096R/1DDD8C9B
[email protected] http://aurel32.net
Thanks,
changhuang
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Hi,
Quoted 24 lines · Changhuang Liang
Hi, Aurelien
Quoted 22 lines
Hi,
Quoted 7 lines · Changhuang Liang
Add camera subsystem nodes for the StarFive JH7110 SoC. They contain the dphy-rx, csi2rx, camss nodes.
Signed-off-by Changhuang Liang <[email protected]>--- .../jh7110-starfive-visionfive-2.dtsi | 49 ++++++++++++++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 67+++++++++++++++++++
Quoted 1 line
2 files changed, 116 insertions(+)We have been asked to enable
CONFIG_VIDEO_STARFIVE_CAMSSin the Debian kernel, which from my understanding and given the device tree shown below also requires enablingCONFIG_VIDEO_CADENCE_CSI2RX. That said doing so triggers the following error in dmesg:[ 25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rxfailed with error -22
Quoted 8 lines
Quoted 3 lines
From a quick look it seems there is something in the port@0 csi2rx entry. Do you happen to know what is wrong?
You need to add your sensor node. You can refer to this patch:
https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/We suggest that using the imx219
Thanks for your answer. I do not have any sensor attached, the goal is to build a generic kernel, and people can use overlays or patch their device tree to add support for additional devices.
In that regard, I have the impression that csi2rx device (and maybe the camss device?) should not be marked as enabled in the default device tree. I think they could be enabled by users as part of the change need to add the sensor node.
Regards
Aurelien
Signature · 2 lines
Aurelien Jarno GPG: 4096R/1DDD8C9B [email protected] http://aurel32.net
Quoted 36 lines · Aurelien Jarno
Hi,
Quoted 24 lines · Changhuang Liang
Hi, Aurelien
Quoted 22 lines
Hi,
Quoted 7 lines · Changhuang Liang
Add camera subsystem nodes for the StarFive JH7110 SoC. They contain the dphy-rx, csi2rx, camss nodes.
Signed-off-by Changhuang Liang <[email protected]>--- .../jh7110-starfive-visionfive-2.dtsi | 49 ++++++++++++++ arch/riscv/boot/dts/starfive/jh7110.dtsi | 67+++++++++++++++++++
Quoted 1 line
2 files changed, 116 insertions(+)We have been asked to enable
CONFIG_VIDEO_STARFIVE_CAMSSin the Debian kernel, which from my understanding and given the device tree shown below also requires enablingCONFIG_VIDEO_CADENCE_CSI2RX. That said doing so triggers the following error in dmesg:[ 25.143282] cdns-csi2rx 19800000.csi: probe with driver cdns-csi2rxfailed with error -22
Quoted 8 lines
Quoted 3 lines
From a quick look it seems there is something in the port@0 csi2rx entry. Do you happen to know what is wrong?
You need to add your sensor node. You can refer to this patch:
https://patchwork.kernel.org/project/linux-riscv/patch/[email protected]/We suggest that using the imx219
Quoted 8 lines
Thanks for your answer. I do not have any sensor attached, the goal is to build a generic kernel, and people can use overlays or patch their device tree to add support for additional devices.
In that regard, I have the impression that csi2rx device (and maybe the camss device?) should not be marked as enabled in the default device tree. I think they could be enabled by users as part of the change need to add the sensor node.
Yeah, that's probably what should've been done when the imx219 node was removed. Feel free to send a patch with a Fixes: tag for that removal and a cc: stable on it - otherwise I'll send one out tomorrow or w/e.