Skip to contentSkip to conversation

Of clk_hw_unregister_fractional_divider

DISCUSSION Dr. David Alan Gilbert 2 participants 4 messages Oct 9, 2024 – Oct 10, 2024 Common clk

lore
Share & tools
lore
#0 lore raw

Hi,
One of my scripts noticed that clk_hw_unregister_fractional_divider
was unused and I was thinking of dead coding it, but thought it worth asking whether it's actually a missing call to it.

It was added in 2016 by:

commit 39b44cff4ad4af6d7abd9dd2acb288b005c26503

Author: Stephen Boyd <[email protected]>
Date:   Sun Feb 7 00:15:09 2016 -0800

clk: fractional-divider: Add hw based registration APIs

and I can see clk_hw_register_fractional_divider is called from clk_register_fractional_divider.

Is that just consequence of them being system devices that never get unregistered or something else?

Thanks,

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#1 lore raw

Quoting Dr. David Alan Gilbert (2024-10-08 17:54:24)

Quoted 11 lines

Hi,
One of my scripts noticed that clk_hw_unregister_fractional_divider
was unused and I was thinking of dead coding it, but thought it worth asking whether it's actually a missing call to it.

It was added in 2016 by:

commit 39b44cff4ad4af6d7abd9dd2acb288b005c26503

Author: Stephen Boyd <[email protected]>
Date:   Sun Feb 7 00:15:09 2016 -0800
Quoted 8 lines

clk: fractional-divider: Add hw based registration APIs

and I can see clk_hw_register_fractional_divider is called from clk_register_fractional_divider.

Is that just consequence of them being system devices that never get unregistered or something else?

I don't know what you mean by system devices.

The clk_hw prefixed functions and clk_hw based APIs should be used instead of struct clk APIs for clk providers in general. I'd accept a patch that migrates the two calls to clk_register_fractional_divider() with a call to clk_hw_register_fractional_divider() instead. If that's done we can remove clk_register_fractional_divider(), which is the overall plan but nobody got around to it so far.

#2 lore raw
Quoted 14 lines · * Stephen Boyd ([email protected]) wrote:

Quoting Dr. David Alan Gilbert (2024-10-08 17:54:24)

Quoted 13 lines

Hi,
One of my scripts noticed that clk_hw_unregister_fractional_divider
was unused and I was thinking of dead coding it, but thought it worth asking whether it's actually a missing call to it.

It was added in 2016 by:

commit 39b44cff4ad4af6d7abd9dd2acb288b005c26503

Author: Stephen Boyd <[email protected]>
Date:   Sun Feb 7 00:15:09 2016 -0800

clk: fractional-divider: Add hw based registration APIs

Quoted 8 lines
Quoted 6 lines

and I can see clk_hw_register_fractional_divider is called from clk_register_fractional_divider.

Is that just consequence of them being system devices that never get unregistered or something else?

I don't know what you mean by system devices.

I mean something that can't get unplugged/removed.

Quoted 6 lines

The clk_hw prefixed functions and clk_hw based APIs should be used instead of struct clk APIs for clk providers in general. I'd accept a patch that migrates the two calls to clk_register_fractional_divider() with a call to clk_hw_register_fractional_divider() instead. If that's done we can remove clk_register_fractional_divider(), which is the overall plan but nobody got around to it so far.

Oh hmm, that doesn't look too hard for those two - although I'm not sure I have a way of testing it?

However, my question was about the clk_hw_*un*register_fractional_divider
- I can see the clk_register_fractional_divider can be replaced by clk_hw_register_fractional_divider - but would there need to be a call to the unregister somewhere? (Which is what my script noticed there's no callers of).

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#3 lore raw

Quoting Dr. David Alan Gilbert (2024-10-09 17:58:21)

Quoted 18 lines · * Stephen Boyd ([email protected]) wrote:
Quoted 17 lines

Quoting Dr. David Alan Gilbert (2024-10-08 17:54:24)

Quoted 16 lines

Hi,
One of my scripts noticed that clk_hw_unregister_fractional_divider
was unused and I was thinking of dead coding it, but thought it worth asking whether it's actually a missing call to it.

It was added in 2016 by:

commit 39b44cff4ad4af6d7abd9dd2acb288b005c26503

Author: Stephen Boyd <[email protected]>
Date:   Sun Feb 7 00:15:09 2016 -0800

clk: fractional-divider: Add hw based registration APIs

and I can see clk_hw_register_fractional_divider is called from clk_register_fractional_divider.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Is that just consequence of them being system devices that never get unregistered or something else?

I don't know what you mean by system devices.

I mean something that can't get unplugged/removed.

Ok.

Quoted 10 lines
Quoted 7 lines

The clk_hw prefixed functions and clk_hw based APIs should be used instead of struct clk APIs for clk providers in general. I'd accept a patch that migrates the two calls to clk_register_fractional_divider() with a call to clk_hw_register_fractional_divider() instead. If that's done we can remove clk_register_fractional_divider(), which is the overall plan but nobody got around to it so far.

Oh hmm, that doesn't look too hard for those two - although I'm not sure I have a way of testing it?

Sure. I don't think anything really changes if that's done so probably a compile test is all that's needed.

Quoted 7 lines

However, my question was about the clk_hw_*un*register_fractional_divider
- I can see the clk_register_fractional_divider can be replaced by clk_hw_register_fractional_divider - but would there need to be a call to the unregister somewhere? (Which is what my script noticed there's no callers of).

Yes they would call clk_hw_unregister_fractional_divider() as well after changing to use clk_hw pointers for the registration path.