dt-bindings: spi: Convert to dtschema
Subsystems (4)
PATCH v3 1/1 dt-bindings: spi: Convert to dtschema
Convert bcm2835-aux-spi binding to Dt schema
---
Changes since V2:
- Modified the Patch subject
- Removed unnecessary description and example
.../bindings/spi/brcm,bcm2835-aux-spi.txt | 38 -------------- .../bindings/spi/brcm,bcm2835-aux-spi.yaml | 51 +++++++++++++++++++ 2 files changed, 51 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml
Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.txt deleted +0 -38
@@ -1,38 +0,0 @@ -Broadcom BCM2835 auxiliary SPI1/2 controller - -The BCM2835 contains two forms of SPI master controller, one known simply as -SPI0, and the other known as the "Universal SPI Master"; part of the -auxiliary block. This binding applies to the SPI1/2 controller. - -Required properties: -- compatible: Should be "brcm,bcm2835-aux-spi". -- reg: Should contain register location and length for the spi block -- interrupts: Should contain shared interrupt of the aux block -- clocks: The clock feeding the SPI controller - needs to - point to the auxiliary clock driver of the bcm2835, - as this clock will enable the output gate for the specific - clock. -- cs-gpios: the cs-gpios (native cs is NOT supported) - see also spi-bus.txt - -Example: - -spi1@7e215080 { - compatible = "brcm,bcm2835-aux-spi"; - reg = <0x7e215080 0x40>; - interrupts = <1 29>; - clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI1>; - #address-cells = <1>; - #size-cells = <0>; - cs-gpios = <&gpio 18>, <&gpio 17>, <&gpio 16>; -}; - -spi2@7e2150c0 { - compatible = "brcm,bcm2835-aux-spi"; - reg = <0x7e2150c0 0x40>; - interrupts = <1 29>; - clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>; - #address-cells = <1>; - #size-cells = <0>; - cs-gpios = <&gpio 43>, <&gpio 44>, <&gpio 45>; -};
Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml new file +51 -0
51 lines not on this page · raw message
Signature · 1 line
2.43.0
Quoted 3 lines · Karan Sanghavi
Convert bcm2835-aux-spi binding to Dt schema
Signed-off-by Karan Sanghavi <[email protected]>
Thank you for your patch. There is something to discuss/improve.
Subject misses device prefix and considering Mark's preference about
spi: it should look like:
spi: dt-bindings: brcm,bcm2835-aux-spi: Convert to dtschema
Quoted 6 lines
---
Changes since V2:
- Modified the Patch subject
- Removed unnecessary description and example
...
Quoted 8 lines
Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml new file +2
-0@@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2
Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml line 12
Quoted 10 lines
Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml new file +10
-0+--- +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-aux-spi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom BCM2835 Auxiliary SPI1/2 Controller + +maintainers: + - Karan Sanghavi <[email protected]> + +description: The BCM2835 contains two forms of SPI master controller. One is known simply as
This feels loo long. Wrapping is according to coding style (not checkpatch), so at 80. You can also have line break after "description" keyword, so:
description:
The BCM2835 contains ......
Rest looks good, so please send v4 unless Mark could fix these up when applying.
If sending v4, remember about tag (see explanation below):
<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.
https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>
Best regards,
Krzysztof