Skip to contentSkip to conversation

input/touchscreen: imagis: Fix not used variable 'imagis_3038_data'

PATCH Applied Zeng Heng 3 participants 3 messages Oct 23, 2024

Subsystems (3)
HID Input drivers Imagis touchscreen driver
lore
Share & tools
lore

Zeng Heng

author
#0 lore raw

PATCH 1/1 input/touchscreen: imagis: Fix not used variable 'imagis_3038_data'

Fix the following compilation warnings:
drivers/input/touchscreen/imagis.c:422:39: warning: ‘imagis_3038c_data’ defined but not used [-Wunused-const-variable=]
422 | static const struct imagis_properties imagis_3038c_data = {
drivers/input/touchscreen/imagis.c:415:39: warning: ‘imagis_3038b_data’ defined but not used [-Wunused-const-variable=]
415 | static const struct imagis_properties imagis_3038b_data = {
drivers/input/touchscreen/imagis.c:407:39: warning: ‘imagis_3038_data’ defined but not used [-Wunused-const-variable=]
407 | static const struct imagis_properties imagis_3038_data = {
drivers/input/touchscreen/imagis.c:398:39: warning: ‘imagis_3032c_data’ defined but not used [-Wunused-const-variable=]
398 | static const struct imagis_properties imagis_3032c_data = {

Only define the variables 'imagis_303*_data' when the CONFIG_OF is enabled.

Fixes 1e48ee99f603 ("Input: imagis - add supports for Imagis IST3038")
Signed-off-by Zeng Heng <[email protected]>
---
 drivers/input/touchscreen/imagis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/imagis.c +1 -1
index aeabf8d057de..abeae9102323 100644
@@ -395,6 +395,7 @@ static int imagis_resume(struct device *dev)
 
 static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
 
+#ifdef CONFIG_OF
 static const struct imagis_properties imagis_3032c_data = {
 	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
 	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,

@@ -427,7 +428,6 @@ static const struct imagis_properties imagis_3038c_data = {
 	.protocol_b = true,
 };
 
-#ifdef CONFIG_OF
 static const struct of_device_id imagis_of_match[] = {
 	{ .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
 	{ .compatible = "imagis,ist3038", .data = &imagis_3038_data },
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw

Hello,

Quoted 36 lines · Zeng Heng

Fix the following compilation warnings:
drivers/input/touchscreen/imagis.c:422:39: warning: ‘imagis_3038c_data’ defined but not used [-Wunused-const-variable=]
422 | static const struct imagis_properties imagis_3038c_data = {
drivers/input/touchscreen/imagis.c:415:39: warning: ‘imagis_3038b_data’ defined but not used [-Wunused-const-variable=]
415 | static const struct imagis_properties imagis_3038b_data = {
drivers/input/touchscreen/imagis.c:407:39: warning: ‘imagis_3038_data’ defined but not used [-Wunused-const-variable=]
407 | static const struct imagis_properties imagis_3038_data = {
drivers/input/touchscreen/imagis.c:398:39: warning: ‘imagis_3032c_data’ defined but not used [-Wunused-const-variable=]
398 | static const struct imagis_properties imagis_3032c_data = {

Only define the variables 'imagis_303*_data' when the CONFIG_OF is enabled.

Fixes 1e48ee99f603 ("Input: imagis - add supports for Imagis IST3038")
Signed-off-by Zeng Heng <[email protected]>
---
  drivers/input/touchscreen/imagis.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/imagis.c +1 -0
index aeabf8d057de..abeae9102323 100644
@@ -395,6 +395,7 @@ static int imagis_resume(struct device *dev)
 
  static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
 
+#ifdef CONFIG_OF
  static const struct imagis_properties imagis_3032c_data = {
  	.interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
  	.touch_coord_cmd = IST3038C_REG_TOUCH_COORD,

drivers/input/touchscreen/imagis.c static const struct imagis_properties imagis_3038c_data = { · line 433

Quoted 7 lines
drivers/input/touchscreen/imagis.c +0 -1
@@ -427,7 +428,6 @@ static const struct imagis_properties imagis_3038c_data = {
  	.protocol_b = true,
  };
 
-#ifdef CONFIG_OF
  static const struct of_device_id imagis_of_match[] = {
  	{ .compatible = "imagis,ist3032c", .data = &imagis_3032c_data },
  	{ .compatible = "imagis,ist3038", .data = &imagis_3038_data },
Acked-by Markuss Broks <[email protected]>

- Markuss

maintainer Applied
#2 lore raw
In reply to Zeng Heng
Quoted 14 lines · Zeng Heng

Fix the following compilation warnings:
drivers/input/touchscreen/imagis.c:422:39: warning: ‘imagis_3038c_data’ defined but not used [-Wunused-const-variable=]
422 | static const struct imagis_properties imagis_3038c_data = {
drivers/input/touchscreen/imagis.c:415:39: warning: ‘imagis_3038b_data’ defined but not used [-Wunused-const-variable=]
415 | static const struct imagis_properties imagis_3038b_data = {
drivers/input/touchscreen/imagis.c:407:39: warning: ‘imagis_3038_data’ defined but not used [-Wunused-const-variable=]
407 | static const struct imagis_properties imagis_3038_data = {
drivers/input/touchscreen/imagis.c:398:39: warning: ‘imagis_3032c_data’ defined but not used [-Wunused-const-variable=]
398 | static const struct imagis_properties imagis_3032c_data = {

Quoted 5 lines

Only define the variables 'imagis_303*_data' when the CONFIG_OF is enabled.

Fixes 1e48ee99f603 ("Input: imagis - add supports for Imagis IST3038")
Signed-off-by Zeng Heng <[email protected]>

Applied, thank you.

Signature · 1 line
Dmitry