Skip to contentSkip to conversation

KVM: x86: Document an erratum in KVM_SET_VCPU_EVENTS on Intel CPUs

PATCH Applied Sean Christopherson 1 participant 3 messages Aug 2, 2024 – Nov 1, 2024

Subsystems (2)
lore
Share & tools
lore

Sean Christopherson

author reviewer
#0 lore raw

PATCH 1/1 KVM: x86: Document an erratum in KVM_SET_VCPU_EVENTS on Intel CPUs

Document a flaw in KVM's ABI which lets userspace attempt to inject a "bad" hardware exception event, and thus induce VM-Fail on Intel CPUs. Fixing the flaw is a fool's errand, as AMD doesn't sanity check the validity of the error code, Intel CPUs that support CET relax the check for Protected Mode, userspace can change the mode after queueing an exception, KVM ignores the error code when emulating Real Mode exceptions, and so on and so forth.

The VM-Fail itself doesn't harm KVM or the kernel beyond triggering a ratelimited pr_warn(), so just document the oddity.

---
 Documentation/virt/kvm/x86/errata.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/virt/kvm/x86/errata.rst +12 -0
index 4116045a8744..37c79362a48f 100644
@@ -33,6 +33,18 @@ Note however that any software (e.g ``WIN87EM.DLL``) expecting these features
 to be present likely predates these CPUID feature bits, and therefore
 doesn't know to check for them anyway.
 
+``KVM_SET_VCPU_EVENTS`` issue
+-----------------------------
+
+Invalid KVM_SET_VCPU_EVENTS input with respect to error codes *may* result in
+failed VM-Entry on Intel CPUs.  Pre-CET Intel CPUs require that exception
+injection through the VMCS correctly set the "error code valid" flag, e.g.
+require the flag be set when injecting a #GP, clear when injecting a #UD,
+clear when injecting a soft exception, etc.  Intel CPUs that enumerate
+IA32_VMX_BASIC[56] as '1' relax VMX's consistency checks, and AMD CPUs have no
+restrictions whatsoever.  KVM_SET_VCPU_EVENTS doesn't sanity check the vector
+versus "has_error_code", i.e. KVM's ABI follows AMD behavior.
+
 Nested virtualization features
 ------------------------------
 

base-commit: 332d2c1d713e232e163386c35a3ba0c1b90df83f

Signature · 1 line
2.46.0.rc2.264.g509ed76dc8-goog
author reviewer Applied
#1 lore raw
Quoted 9 lines · Sean Christopherson

Document a flaw in KVM's ABI which lets userspace attempt to inject a "bad" hardware exception event, and thus induce VM-Fail on Intel CPUs. Fixing the flaw is a fool's errand, as AMD doesn't sanity check the validity of the error code, Intel CPUs that support CET relax the check for Protected Mode, userspace can change the mode after queueing an exception, KVM ignores the error code when emulating Real Mode exceptions, and so on and so forth.

[...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Document an erratum in KVM_SET_VCPU_EVENTS on Intel CPUs

      https://github.com/kvm-x86/linux/commit/eebc1cfae6c9

--
https://github.com/kvm-x86/linux/tree/next

author reviewer
#2 lore raw
Quoted 9 lines · Sean Christopherson
Quoted 8 lines · Sean Christopherson

Document a flaw in KVM's ABI which lets userspace attempt to inject a "bad" hardware exception event, and thus induce VM-Fail on Intel CPUs. Fixing the flaw is a fool's errand, as AMD doesn't sanity check the validity of the error code, Intel CPUs that support CET relax the check for Protected Mode, userspace can change the mode after queueing an exception, KVM ignores the error code when emulating Real Mode exceptions, and so on and so forth.

Quoted 6 lines
Quoted 1 line

[...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Document an erratum in KVM_SET_VCPU_EVENTS on Intel CPUs

      https://github.com/kvm-x86/linux/commit/eebc1cfae6c9

FYI, I rebased misc to v6.12-rc5, as patches in another series had already been taken through the tip tree. New hash:

[1/1] KVM: x86: Document an erratum in KVM_SET_VCPU_EVENTS on Intel CPUs

      https://github.com/kvm-x86/linux/commit/0e3b70aa137c