MIPS: kernel: proc: Use str_yes_no() helper function
PATCH v2 1/1 MIPS: kernel: proc: Use str_yes_no() helper function
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by Thorsten Blum <[email protected]>
--- arch/mips/kernel/proc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
arch/mips/kernel/proc.c +8 -9
@@ -66,24 +66,23 @@ static int show_cpuinfo(struct seq_file *m, void *v)seq_printf (m,"BogoMIPS\t\t: %u.%02u\n" , cpu_data[n].udelay_val / (500000 /HZ ), (cpu_data[n].udelay_val / (5000 /HZ )) %100 ); -seq_printf (m,"wait instruction\t: %s\n" , cpu_wait ?"yes" :"no" ); +seq_printf (m,"wait instruction\t: %s\n" ,str_yes_no (cpu_wait));seq_printf (m,"microsecond timers\t: %s\n" , - cpu_has_counter ?"yes" :"no" ); +str_yes_no (cpu_has_counter));seq_printf (m,"tlb_entries\t\t: %d\n" , cpu_data[n].tlbsize);seq_printf (m,"extra interrupt vector\t: %s\n" , - cpu_has_divec ?"yes" :"no" ); -seq_printf (m,"hardware watchpoint\t: %s" , - cpu_has_watch ?"yes, " :"no\n" ); +str_yes_no (cpu_has_divec)); +seq_printf (m,"hardware watchpoint\t: %s" ,str_yes_no (cpu_has_watch));if (cpu_has_watch) { -seq_printf (m,"count: %d, address/irw mask: [" , +seq_printf (m,", count: %d, address/irw mask: [" , cpu_data[n].watch_reg_count);for (i =0 ; i < cpu_data[n].watch_reg_count; i++)seq_printf (m,"%s0x%04x" , i ?", " :"" , cpu_data[n].watch_reg_masks[i]); -seq_puts (m,"]\n" ); +seq_puts (m,"]" ); } -seq_puts (m,"isa\t\t\t:" ); +seq_puts (m,"\nisa\t\t\t:" );if (cpu_has_mips_1)seq_puts (m," mips1" );if (cpu_has_mips_2)
@@ -155,7 +154,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)if (cpu_has_mmips) {seq_printf (m,"micromips kernel\t: %s\n" , - (read_c0_config3 () &MIPS_CONF3_ISA_OE ) ?"yes" :"no" ); +str_yes_no (read_c0_config3 () &MIPS_CONF3_ISA_OE )); }seq_puts (m,"Options implemented\t:" );
Signature · 1 line
2.47.0
Quoted 3 lines · Thorsten Blum
Remove hard-coded strings by using the
str_yes_no()helper function.Signed-off-by Thorsten Blum <[email protected]>
Forgot the link to v1:
https://lore.kernel.org/r/[email protected]/
And I just noticed the use of seq_printf(m,) vs. seq_puts(m,) and I'm not sure this is still correct. Have to check this again later.
Sorry for the noise.
Quoted 4 lines · Thorsten Blum
Remove hard-coded strings by using the
str_yes_no()helper function.Signed-off-by Thorsten Blum <[email protected]>---
Reviewed-by Maciej W. Rozycki <[email protected]>
LGTM, thanks!
Maciej
Quoted 6 lines · Thorsten Blum
Remove hard-coded strings by using the
str_yes_no()helper function.Signed-off-by Thorsten Blum <[email protected]>--- arch/mips/kernel/proc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
applied to mips-next.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]