net/af_xdp: use strlcpy instead of strncpy
PATCH v2 1/1 net/af_xdp: use strlcpy instead of strncpy
strncpy may leave the destination buffer not NULL terminated so use strlcpy instead.
Coverity issue: 362975
---
v2:
* use strlcpy instead of snprintf
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/af_xdp/rte_eth_af_xdp.c +1 -1
@@ -1362,7 +1362,7 @@ xdp_get_channels_info(const char *if_name, int *max_queues, channels.cmd =ETHTOOL_GCHANNELS ; ifr.ifr_data = (void *)&channels; -strncpy (ifr.ifr_name, if_name,IFNAMSIZ ); +strlcpy (ifr.ifr_name, if_name,IFNAMSIZ ); ret =ioctl (fd,SIOCETHTOOL , &ifr);if (ret) {if (errno ==EOPNOTSUPP ) {
Signature · 1 line
2.17.1
PATCH v3 1/1 net/af_xdp: use rte_strscpy instead of strncpy
strncpy may leave the destination buffer not NULL terminated so use rte_strscpy instead.
Coverity issue: 362975
---
v3:
* use rte_strscpy instead of strlcpy
v2:
* use strlcpy instead of snprintf
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/af_xdp/rte_eth_af_xdp.c +1 -1
@@ -1362,7 +1362,7 @@ xdp_get_channels_info(const char *if_name, int *max_queues, channels.cmd =ETHTOOL_GCHANNELS ; ifr.ifr_data = (void *)&channels; -strncpy (ifr.ifr_name, if_name,IFNAMSIZ ); +strlcpy (ifr.ifr_name, if_name,IFNAMSIZ ); ret =ioctl (fd,SIOCETHTOOL , &ifr);if (ret) {if (errno ==EOPNOTSUPP ) {
Signature · 1 line
2.17.1
PATCH v4 1/1 net/af_xdp: use rte_strscpy instead of strncpy
strncpy may leave the destination buffer not NULL terminated so use rte_strscpy instead.
Coverity issue: 362975
---
v4:
* actually use rte_strscpy instead of strlcpy
v3:
* use rte_strscpy instead of strlcpy
v2:
* use strlcpy instead of snprintf
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/af_xdp/rte_eth_af_xdp.c +1 -1
@@ -1362,7 +1362,7 @@ xdp_get_channels_info(const char *if_name, int *max_queues, channels.cmd =ETHTOOL_GCHANNELS ; ifr.ifr_data = (void *)&channels; -strncpy (ifr.ifr_name, if_name,IFNAMSIZ ); +rte_strscpy (ifr.ifr_name, if_name,IFNAMSIZ ); ret =ioctl (fd,SIOCETHTOOL , &ifr);if (ret) {if (errno ==EOPNOTSUPP ) {
Signature · 1 line
2.17.1
Quoted 7 lines · Ciara Loftus
strncpy may leave the destination buffer not NULL terminated so use strlcpy instead.
Coverity issue: 362975
Fixes 339b88c6a91f ("net/af_xdp: support multi-queue")Signed-off-by Ciara Loftus <[email protected]>---
If the community prefers using rte_strscpy, this ack can also apply to v4 too. :-)
Quoted 22 lines
v2:
* use strlcpy instead of snprintfdrivers/net/af_xdp/rte_eth_af_xdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/af_xdp/rte_eth_af_xdp.c +1
-1@@ -1362,7 +1362,7 @@ xdp_get_channels_info(const char *if_name, int *max_queues, channels.cmd =ETHTOOL_GCHANNELS ; ifr.ifr_data = (void *)&channels; -strncpy (ifr.ifr_name, if_name,IFNAMSIZ ); +strlcpy (ifr.ifr_name, if_name,IFNAMSIZ ); ret =ioctl (fd,SIOCETHTOOL , &ifr);if (ret) {if (errno ==EOPNOTSUPP ) {Signature · 1 line
2.17.1
Quoted 11 lines · Bruce Richardson
Quoted 7 lines · Ciara Loftus
strncpy may leave the destination buffer not NULL terminated so use strlcpy instead.
Coverity issue: 362975
Fixes 339b88c6a91f ("net/af_xdp: support multi-queue")Signed-off-by Ciara Loftus <[email protected]>---
Acked-by Bruce Richardson <[email protected]>
Applied to dpdk-next-net/main, thanks.