Skip to contentSkip to conversation

Use info->reset_cmd instead of FLASH_CMD_RESET

PATCH New Zachary Landau 2 participants 2 messages Feb 12, 2005 – Sep 25, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use info->reset_cmd instead of FLASH_CMD_RESET

Hello,

This patch makes cfi_flash.c use info->cmd_reset. It was being set by flash_get_size() but not being used, which kept the Flash on my board from properly being reset.

It looks like there are a lot of switch cases for different flash types that could probably probably be removed by setting up some function pointers, but that is a project for another time.

Signature · 8 lines
Zachary P. Landau <[email protected]>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmd_reset.patch
Type: text/x-patch
Size: 1660 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050211/286d27df/attachment.bin 
#1 lore raw

PATCH 1/1 Use info->reset_cmd instead of FLASH_CMD_RESET

Quoted 4 lines · In message <[email protected]> you wrote:

This patch makes cfi_flash.c use info->cmd_reset. It was being set by flash_get_size() but not being used, which kept the Flash on my board from properly being reset.

Added, thanks. But please provide a CHANEGLOG entry next time.

Quoted 3 lines

It looks like there are a lot of switch cases for different flash types that could probably probably be removed by setting up some function pointers, but that is a project for another time.

Patches are welcome!

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
                                                    - Albert Einstein