pinctrl: renesas: Add R-Car S4-8 support
Subsystems (4)
Geert Uytterhoeven
maintainerv2 cover pinctrl: renesas: Add R-Car S4-8 support
Hi all,
This patch series adds pin control support for the Renesas R-Car S4-8 Soc. It is based on patches in the BSP by LUU HOAI, with many changes on top (see the individual patches).
Changes compared to v1[1]:
- Add Reviewed-by,
- Fix whitespace in Makefile,
- Remove GPIO and No-GPIO pins, pin function definitions, and registers that can only be accessed from the Control Domain,
- Spin off clock and DTS patches into separate series,
- Drop RFC state and widen audience.
Serial console and I2C have been tested on the Renesas Spider development board.
Thanks for your comments!
[1] "[PATCH/RFC 00/15] arm64: renesas: Add-R-Car S4-8 Pin control support"
https://lore.kernel.org/r/[email protected]
Geert Uytterhoeven (11):
pinctrl: renesas: Add PORT_GP_CFG_19 macros
pinctrl: renesas: Initial R8A779F0 PFC support
pinctrl: renesas: r8a779f0: Add SCIF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add I2C pins, groups, and functions
pinctrl: renesas: r8a779f0: Add HSCIF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add INTC-EX pins, groups, and function
pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
pinctrl: renesas: r8a779f0: Add MSIOF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add PCIe pins, groups, and function
pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
pinctrl: renesas: r8a779f0: Add Ethernet pins, groups, and functions
LUU HOAI (1):
dt-bindings: pinctrl: renesas,pfc: Document r8a779f0 support
.../bindings/pinctrl/renesas,pfc.yaml | 1 + drivers/pinctrl/renesas/Kconfig | 5 + drivers/pinctrl/renesas/Makefile | 1 + drivers/pinctrl/renesas/core.c | 6 + drivers/pinctrl/renesas/pfc-r8a779f0.c | 2126 +++++++++++++++++ drivers/pinctrl/renesas/sh_pfc.h | 9 +- 6 files changed, 2146 insertions(+), 2 deletions(-) create mode 100644 drivers/pinctrl/renesas/pfc-r8a779f0.c
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsGeert Uytterhoeven
maintainerPATCH v2 1/12 dt-bindings: pinctrl: renesas,pfc: Document r8a779f0 support
From: LUU HOAI <[email protected]>
Document Pin Function Controller (PFC) support for the Renesas R-Car S4-8 (R8A779F0) SoC.
---
v2:
- Add Reviewed-by.
--- Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml +1 -0
@@ -44,6 +44,7 @@ properties: - renesas,pfc-r8a77990 # R-Car E3 - renesas,pfc-r8a77995 # R-Car D3 - renesas,pfc-r8a779a0 # R-Car V3U + - renesas,pfc-r8a779f0 # R-Car S4-8 - renesas,pfc-sh73a0 # SH-Mobile AG5 reg:
Signature · 1 line
2.25.1
Re: [PATCH v2 01/12] dt-bindings: pinctrl: renesas,pfc: Document r8a779f0 support
Quoted 8 lines · Geert Uytterhoeven
From: LUU HOAI <[email protected]>
Document Pin Function Controller (PFC) support for the Renesas R-Car S4-8 (R8A779F0) SoC.
Signed-off-by LUU HOAI <[email protected]>Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Yoshihiro Shimoda <[email protected]>
Quoted 7 lines
---
v2:
- Add Reviewed-by.--- Documentation/devicetree/bindings/pinctrl/renesas,pfc.yaml | 1 + 1 file changed, 1 insertion(+)
Geert Uytterhoeven
maintainerPATCH v2 2/12 pinctrl: renesas: Add PORT_GP_CFG_19 macros
In reply to Geert UytterhoevenAdd PORT_GP_CFG_19() and PORT_GP_19() helper macros, to be used by the r8a779f0 subdriver.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- Add Reviewed-by.
Changes compared to the BSP:
- Rework PORT_GP_CFG_20() on top of the new PORT_GP_CFG_19().
--- drivers/pinctrl/renesas/sh_pfc.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/pinctrl/renesas/sh_pfc.h +6 -2
@@ -517,9 +517,13 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info; PORT_GP_CFG_1(bank, 17, fn, sfx, cfg)#define PORT_GP_18 (bank, fn, sfx) PORT_GP_CFG_18(bank, fn, sfx, 0) -#define PORT_GP_CFG_20 (bank, fn, sfx, cfg) \ +#define PORT_GP_CFG_19 (bank, fn, sfx, cfg) \ PORT_GP_CFG_18(bank, fn, sfx, cfg), \ - PORT_GP_CFG_1(bank, 18, fn, sfx, cfg), \ + PORT_GP_CFG_1(bank, 18, fn, sfx, cfg) +#define PORT_GP_19 (bank, fn, sfx) PORT_GP_CFG_19(bank, fn, sfx, 0) + +#define PORT_GP_CFG_20 (bank, fn, sfx, cfg) \ + PORT_GP_CFG_19(bank, fn, sfx, cfg), \ PORT_GP_CFG_1(bank, 19, fn, sfx, cfg)#define PORT_GP_20 (bank, fn, sfx) PORT_GP_CFG_20(bank, fn, sfx, 0)
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 3/12 pinctrl: renesas: Initial R8A779F0 PFC support
In reply to Geert UytterhoevenAdd initial Pin Function Controller (PFC) support for the Renesas R-Car S4-8 (R8A779F0) SoC, including bias, drive strength and voltage control.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- Fix whitespace in Makefile,
- Remove GPIO and No-GPIO pins, pin function definitions, and registers that can only be accessed from the Control Domain.
This depends on "[PATCH 01/10] pinctrl: renesas: Remove unused pfc parameter from .pin_to_pocctrl()"[1].
Changes compared to the BSP:
- Remove GPIO and No-GPIO pins, pin function definitions, and registers that can only be accessed from the Control Domain,
- Sort PINCTRL_PFC_R8A779F0 config entry,
- Replace "R-Car S4" and "S4" by "R-Car S4-8",
- All non-GP pins with pull-up capabilities support both pull-up/down,
- Remove nonexistent "PRESETOUT#" pin,
- Handle functions that can appear on multiple pins:
- R-Switch2:
- Add B-suffixes to some TSNx on GP_3_x,
- Add TSNx_A on GP_0_x and GP_1_x.
- Rename the MOD_SEL1_* definitions, to match the bitfield order in IPxSRy_* definitions and in MOD_SEL* definitions in other drivers,
- Replace "PINMUX_IPSR_PHYS_NOFN(y, z)" by "PINMUX_IPSR_NOFN(GP1_x, y, z)", as I2C requires GPSR1[x] to be configured for peripheral mode,
- Add comments to sentinels,
- Remove unused pfc parameter from .pin_to_pocctrl(),
- Rename pinmux_ops to r8a779f0_pfc_ops,
- Drop adding PINMUX_IPSR_PHYS_NOFN(),
- Whitespace fixes.
--- drivers/pinctrl/renesas/Kconfig | 5 + drivers/pinctrl/renesas/Makefile | 1 + drivers/pinctrl/renesas/core.c | 6 + drivers/pinctrl/renesas/pfc-r8a779f0.c | 1024 ++++++++++++++++++++++++ drivers/pinctrl/renesas/sh_pfc.h | 1 + 5 files changed, 1037 insertions(+) create mode 100644 drivers/pinctrl/renesas/pfc-r8a779f0.c
drivers/pinctrl/renesas/Kconfig +5 -0
@@ -37,6 +37,7 @@ config PINCTRL_RENESAS select PINCTRL_PFC_R8A77990 if ARCH_R8A77990 select PINCTRL_PFC_R8A77995 if ARCH_R8A77995 select PINCTRL_PFC_R8A779A0 if ARCH_R8A779A0 + select PINCTRL_PFC_R8A779F0 if ARCH_R8A779F0 select PINCTRL_RZG2L if ARCH_R9A07G044 select PINCTRL_RZG2L if ARCH_R9A07G054 select PINCTRL_PFC_SH7203 if CPU_SUBTYPE_SH7203
@@ -133,6 +134,10 @@ config PINCTRL_PFC_R8A77961 bool "pin control support for R-Car M3-W+" if COMPILE_TEST select PINCTRL_SH_PFC +config PINCTRL_PFC_R8A779F0 + bool "pin control support for R-Car S4-8" if COMPILE_TEST + select PINCTRL_SH_PFC + config PINCTRL_PFC_R8A7792 bool "pin control support for R-Car V2H" if COMPILE_TEST select PINCTRL_SH_PFC
drivers/pinctrl/renesas/Makefile +1 -0
@@ -30,6 +30,7 @@ obj-$(CONFIG_PINCTRL_PFC_R8A77980) += pfc-r8a77980.o obj-$(CONFIG_PINCTRL_PFC_R8A77990) += pfc-r8a77990.o obj-$(CONFIG_PINCTRL_PFC_R8A77995) += pfc-r8a77995.o obj-$(CONFIG_PINCTRL_PFC_R8A779A0) += pfc-r8a779a0.o +obj-$(CONFIG_PINCTRL_PFC_R8A779F0) += pfc-r8a779f0.o obj-$(CONFIG_PINCTRL_PFC_SH7203) += pfc-sh7203.o obj-$(CONFIG_PINCTRL_PFC_SH7264) += pfc-sh7264.o obj-$(CONFIG_PINCTRL_PFC_SH7269) += pfc-sh7269.o
drivers/pinctrl/renesas/core.c +6 -0
@@ -636,6 +636,12 @@ static const struct of_device_id sh_pfc_of_table[] = { .data = &r8a779a0_pinmux_info, },#endif +#ifdef CONFIG_PINCTRL_PFC_R8A779F0 + { + .compatible = "renesas,pfc-r8a779f0", + .data = &r8a779f0_pinmux_info, + }, +#endif #ifdef CONFIG_PINCTRL_PFC_SH73A0 { .compatible = "renesas,pfc-sh73a0",
drivers/pinctrl/renesas/pfc-r8a779f0.c new file +1024 -0
1,024 lines not on this page · raw message
drivers/pinctrl/renesas/sh_pfc.h +1 -0
@@ -324,6 +324,7 @@ extern const struct sh_pfc_soc_info r8a77980_pinmux_info;extern const struct sh_pfc_soc_info r8a77990_pinmux_info;extern const struct sh_pfc_soc_info r8a77995_pinmux_info;extern const struct sh_pfc_soc_info r8a779a0_pinmux_info; +extern const struct sh_pfc_soc_info r8a779f0_pinmux_info;extern const struct sh_pfc_soc_info sh7203_pinmux_info;extern const struct sh_pfc_soc_info sh7264_pinmux_info;extern const struct sh_pfc_soc_info sh7269_pinmux_info;
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH v2 03/12] pinctrl: renesas: Initial R8A779F0 PFC support
I love your patch! Yet something to improve:
Hi Geert,
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/a774a621c83874c65ae824a0a53f2741f3612df8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkout a774a621c83874c65ae824a0a53f2741f3612df8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/renesas/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:998:20: error: incompatible function pointer types initializing 'int (*)(struct sh_pfc *, unsigned int, u32 *)' (aka 'int (*)(struct sh_pfc *, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types]
.pin_to_pocctrl = r8a779f0_pin_to_pocctrl,
^~~~~~~~~~~~~~~~~~~~~~~1 error generated.
vim +998 drivers/pinctrl/renesas/pfc-r8a779f0.c
996
997 static const struct sh_pfc_soc_operations r8a779f0_pfc_ops = {
> 998 .pin_to_pocctrl = r8a779f0_pin_to_pocctrl,
999 .get_bias = rcar_pinmux_get_bias,
1000 .set_bias = rcar_pinmux_set_bias,
1001 };
1002
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Re: [PATCH v2 03/12] pinctrl: renesas: Initial R8A779F0 PFC support
Quoted 26 lines · kernel test robot
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/202202220706.BSRvcjhD-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/a774a621c83874c65ae824a0a53f2741f3612df8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkouta774a621c83874c65ae824a0a53f2741f3612df8
# save the config file to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/pinctrl/renesas/If you fix the issue, kindly add following tag as appropriate
Quoted 8 lines
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/pinctrl/renesas/pfc-r8a779f0.c:998:20: error: incompatible function pointer types initializing 'int (*)(structsh_pfc*, unsigned int, u32 *)' (aka 'int (*)(structsh_pfc*, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types].pin_to_pocctrl = r8a779f0_pin_to_pocctrl, ^~~~~~~~~~~~~~~~~~~~~~~1 error generated.
Missing dependency:
This depends on "[PATCH 01/10] pinctrl: renesas: Remove unused pfc
parameter from .pin_to_pocctrl()"[1].
[1] https://lore.kernel.org/r/822133086f32618c7fc920123c6a96f5d4ea7ad6.1640270559.git.geert+renesas(a)glider.be/Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [kbuild-all] Re: [PATCH v2 03/12] pinctrl: renesas: Initial R8A779F0 PFC support
Quoted 29 lines · Geert Uytterhoeven
Quoted 28 lines · kernel test robot
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/a774a621c83874c65ae824a0a53f2741f3612df8
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkouta774a621c83874c65ae824a0a53f2741f3612df8
# save the config file to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/pinctrl/renesas/If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>
Quoted 8 lines
Quoted 6 lines
All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/pinctrl/renesas/pfc-r8a779f0.c:998:20: error: incompatible function pointer types initializing 'int (*)(structsh_pfc*, unsigned int, u32 *)' (aka 'int (*)(structsh_pfc*, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types].pin_to_pocctrl = r8a779f0_pin_to_pocctrl, ^~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.Missing dependency:
Hi Geert,
Thanks for the feedback, we don't support adding the dependency automatically, but we'll take a look to avoid testing such cases.
Best Regards,
Rong Chen
Quoted 20 lines
This depends on "[PATCH 01/10] pinctrl: renesas: Remove unused pfc parameter from .pin_to_pocctrl()"[1]. [1] https://lore.kernel.org/r/822133086f32618c7fc920123c6a96f5d4ea7ad6.1640270559.git.geert+renesas@glider.be/Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
kbuild-all mailing list -- [email protected]
To unsubscribe send an email to [email protected]
RE: [PATCH v2 03/12] pinctrl: renesas: Initial R8A779F0 PFC support
In reply to Geert UytterhoevenHi Geert-san,
Thank you for the patch!
Quoted 8 lines
From: Geert Uytterhoeven, Sent: Tuesday, February 22, 2022 12:44 AM
Add initial Pin Function Controller (PFC) support for the Renesas R-Car S4-8 (R8A779F0) SoC, including bias, drive strength and voltage control.
Based on a larger patch in the BSP by LUU HOAI.
Signed-off-by Geert Uytterhoeven <[email protected]>
<snip>
Quoted 6 lines
drivers/pinctrl/renesas/pfc-r8a779f0.c new file +0
-0@@ -0,0 +1,1024 @@
<snip>
drivers/pinctrl/renesas/pfc-r8a779f0.c line 834
Quoted 6 lines
drivers/pinctrl/renesas/pfc-r8a779f0.c new file +6
-0+static const struct pinmux_ioctrl_reg pinmux_ioctrl_regs[] = { + [POC0 ] = {0xe60500a0 , }, + [POC1 ] = {0xe60508a0 , }, + [POC2 ] = {0xe60510a0 , }, + [POC3 ] = {0xe60518a0 , }, + [TD0SEL1 ] = {0xe6058120 , },
TD0SEL1 should be 0xe6050920 (0xe6050800 + 0x120).
After fixed it,
Best regards,
Yoshihiro Shimoda
Re: [PATCH v2 03/12] pinctrl: renesas: Initial R8A779F0 PFC support
Hi Shimoda-san,
Quoted 23 lines · Yoshihiro Shimoda
Quoted 8 lines
From: Geert Uytterhoeven, Sent: Tuesday, February 22, 2022 12:44 AM
Add initial Pin Function Controller (PFC) support for the Renesas R-Car S4-8 (R8A779F0) SoC, including bias, drive strength and voltage control.
Based on a larger patch in the BSP by LUU HOAI.
Signed-off-by Geert Uytterhoeven <[email protected]><snip>
Quoted 6 lines
drivers/pinctrl/renesas/pfc-r8a779f0.c new file +0
-0@@ -0,0 +1,1024 @@<snip>
drivers/pinctrl/renesas/pfc-r8a779f0.c line 834
Quoted 6 lines
drivers/pinctrl/renesas/pfc-r8a779f0.c new file +6
-0+static const struct pinmux_ioctrl_reg pinmux_ioctrl_regs[] = { + [POC0 ] = {0xe60500a0 , }, + [POC1 ] = {0xe60508a0 , }, + [POC2 ] = {0xe60510a0 , }, + [POC3 ] = {0xe60518a0 , }, + [TD0SEL1 ] = {0xe6058120 , },
Quoted 5 lines
TD0SEL1 should be
0xe6050920(0xe6050800+0x120).After fixed it,
Thank you, will fix while applying.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Geert Uytterhoeven
maintainerPATCH v2 4/12 pinctrl: renesas: r8a779f0: Add SCIF pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and functions for the Serial Communication Interfaces with FIFO (SCIF) on the Renesas R-Car S4-8 (R8A779F0) SoC.
Extracted from a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 147 +++++++++++++++++++++++++ 1 file changed, 147 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +147 -0
@@ -488,10 +488,157 @@ static const struct sh_pfc_pin pinmux_pins[] = { PINMUX_GPIO_GP_ALL(), }; +/* - SCIF0 ------------------------------------------------------------------ */ +static const unsigned int scif0_data_pins[] = { +/* RX0, TX0 */ +RCAR_GP_PIN (0 ,6 ),RCAR_GP_PIN (0 ,7 ), +}; +static const unsigned int scif0_data_mux[] = { +RX0_MARK ,TX0_MARK , +}; +static const unsigned int scif0_clk_pins[] = { +/* SCK0 */ +RCAR_GP_PIN (0 ,8 ), +}; +static const unsigned int scif0_clk_mux[] = { +SCK0_MARK , +}; +static const unsigned int scif0_ctrl_pins[] = { +/* RTS0#, CTS0# */ +RCAR_GP_PIN (0 ,9 ),RCAR_GP_PIN (0 ,10 ), +}; +static const unsigned int scif0_ctrl_mux[] = { +RTS0_N_MARK ,CTS0_N_MARK , +}; + +/* - SCIF1 ------------------------------------------------------------------ */ +static const unsigned int scif1_data_pins[] = { +/* RX1, TX1 */ +RCAR_GP_PIN (0 ,12 ),RCAR_GP_PIN (0 ,13 ), +}; +static const unsigned int scif1_data_mux[] = { +RX1_MARK ,TX1_MARK , +}; +static const unsigned int scif1_clk_pins[] = { +/* SCK1 */ +RCAR_GP_PIN (0 ,14 ), +}; +static const unsigned int scif1_clk_mux[] = { +SCK1_MARK , +}; +static const unsigned int scif1_ctrl_pins[] = { +/* RTS1#, CTS1# */ +RCAR_GP_PIN (0 ,15 ),RCAR_GP_PIN (0 ,11 ), +}; +static const unsigned int scif1_ctrl_mux[] = { +RTS1_N_MARK ,CTS1_N_MARK , +}; + +/* - SCIF3 ------------------------------------------------------------------ */ +static const unsigned int scif3_data_pins[] = { +/* RX3, TX3 */ +RCAR_GP_PIN (0 ,2 ),RCAR_GP_PIN (0 ,3 ), +}; +static const unsigned int scif3_data_mux[] = { +RX3_MARK ,TX3_MARK , +}; +static const unsigned int scif3_clk_pins[] = { +/* SCK3 */ +RCAR_GP_PIN (0 ,1 ), +}; +static const unsigned int scif3_clk_mux[] = { +SCK3_MARK , +}; +static const unsigned int scif3_ctrl_pins[] = { +/* RTS3#, CTS3# */ +RCAR_GP_PIN (0 ,5 ),RCAR_GP_PIN (0 ,4 ), +}; +static const unsigned int scif3_ctrl_mux[] = { +RTS3_N_MARK ,CTS3_N_MARK , +}; + +/* - SCIF4 ------------------------------------------------------------------ */ +static const unsigned int scif4_data_pins[] = { +/* RX4, TX4 */ +RCAR_GP_PIN (1 ,6 ),RCAR_GP_PIN (1 ,7 ), +}; +static const unsigned int scif4_data_mux[] = { +RX4_MARK ,TX4_MARK , +}; +static const unsigned int scif4_clk_pins[] = { +/* SCK4 */ +RCAR_GP_PIN (1 ,5 ), +}; +static const unsigned int scif4_clk_mux[] = { +SCK4_MARK , +}; +static const unsigned int scif4_ctrl_pins[] = { +/* RTS4#, CTS4# */ +RCAR_GP_PIN (1 ,4 ),RCAR_GP_PIN (1 ,3 ), +}; +static const unsigned int scif4_ctrl_mux[] = { +RTS4_N_MARK ,CTS4_N_MARK , +}; + +/* - SCIF Clock ------------------------------------------------------------- */ +static const unsigned int scif_clk_pins[] = { +/* SCIF_CLK */ +RCAR_GP_PIN (0 ,0 ), +}; +static const unsigned int scif_clk_mux[] = { +SCIF_CLK_MARK , +}; +static const struct sh_pfc_pin_group pinmux_groups[] = { +SH_PFC_PIN_GROUP (scif0_data), +SH_PFC_PIN_GROUP (scif0_clk), +SH_PFC_PIN_GROUP (scif0_ctrl), +SH_PFC_PIN_GROUP (scif1_data), +SH_PFC_PIN_GROUP (scif1_clk), +SH_PFC_PIN_GROUP (scif1_ctrl), +SH_PFC_PIN_GROUP (scif3_data), +SH_PFC_PIN_GROUP (scif3_clk), +SH_PFC_PIN_GROUP (scif3_ctrl), +SH_PFC_PIN_GROUP (scif4_data), +SH_PFC_PIN_GROUP (scif4_clk), +SH_PFC_PIN_GROUP (scif4_ctrl), +SH_PFC_PIN_GROUP (scif_clk), +}; + +static const char *const scif0_groups[] = { +"scif0_data" , +"scif0_clk" , +"scif0_ctrl" , +}; + +static const char *const scif1_groups[] = { +"scif1_data" , +"scif1_clk" , +"scif1_ctrl" , +}; + +static const char *const scif3_groups[] = { +"scif3_data" , +"scif3_clk" , +"scif3_ctrl" , +}; + +static const char *const scif4_groups[] = { +"scif4_data" , +"scif4_clk" , +"scif4_ctrl" , +}; + +static const char *const scif_clk_groups[] = { +"scif_clk" , };static const struct sh_pfc_function pinmux_functions[] = { +SH_PFC_FUNCTION (scif0), +SH_PFC_FUNCTION (scif1), +SH_PFC_FUNCTION (scif3), +SH_PFC_FUNCTION (scif4), +SH_PFC_FUNCTION (scif_clk), };static const struct pinmux_cfg_reg pinmux_config_regs[] = {
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 5/12 pinctrl: renesas: r8a779f0: Add I2C pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and functions for the I2C Bus Interfaces (I2C) on the Renesas R-Car S4-8 (R8A779F0) SoC.
Extracted from a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 90 ++++++++++++++++++++++++++ 1 file changed, 90 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +90 -0
@@ -488,6 +488,60 @@ static const struct sh_pfc_pin pinmux_pins[] = { PINMUX_GPIO_GP_ALL(), }; +/* - I2C0 ------------------------------------------------------------------- */ +static const unsigned int i2c0_pins[] = { +/* SDA0, SCL0 */ +RCAR_GP_PIN (1 ,1 ),RCAR_GP_PIN (1 ,0 ), +}; +static const unsigned int i2c0_mux[] = { +SDA0_MARK ,SCL0_MARK , +}; + +/* - I2C1 ------------------------------------------------------------------- */ +static const unsigned int i2c1_pins[] = { +/* SDA1, SCL1 */ +RCAR_GP_PIN (1 ,3 ),RCAR_GP_PIN (1 ,2 ), +}; +static const unsigned int i2c1_mux[] = { +SDA1_MARK ,SCL1_MARK , +}; + +/* - I2C2 ------------------------------------------------------------------- */ +static const unsigned int i2c2_pins[] = { +/* SDA2, SCL2 */ +RCAR_GP_PIN (1 ,5 ),RCAR_GP_PIN (1 ,4 ), +}; +static const unsigned int i2c2_mux[] = { +SDA2_MARK ,SCL2_MARK , +}; + +/* - I2C3 ------------------------------------------------------------------- */ +static const unsigned int i2c3_pins[] = { +/* SDA3, SCL3 */ +RCAR_GP_PIN (1 ,7 ),RCAR_GP_PIN (1 ,6 ), +}; +static const unsigned int i2c3_mux[] = { +SDA3_MARK ,SCL3_MARK , +}; + +/* - I2C4 ------------------------------------------------------------------- */ +static const unsigned int i2c4_pins[] = { +/* SDA4, SCL4 */ +RCAR_GP_PIN (1 ,9 ),RCAR_GP_PIN (1 ,8 ), +}; +static const unsigned int i2c4_mux[] = { +SDA4_MARK ,SCL4_MARK , +}; + +/* - I2C5 ------------------------------------------------------------------- */ +static const unsigned int i2c5_pins[] = { +/* SDA5, SCL5 */ +RCAR_GP_PIN (1 ,11 ),RCAR_GP_PIN (1 ,10 ), +}; +static const unsigned int i2c5_mux[] = { +SDA5_MARK ,SCL5_MARK , +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -590,6 +644,12 @@ static const unsigned int scif_clk_mux[] = { };static const struct sh_pfc_pin_group pinmux_groups[] = { +SH_PFC_PIN_GROUP (i2c0), +SH_PFC_PIN_GROUP (i2c1), +SH_PFC_PIN_GROUP (i2c2), +SH_PFC_PIN_GROUP (i2c3), +SH_PFC_PIN_GROUP (i2c4), +SH_PFC_PIN_GROUP (i2c5),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk),SH_PFC_PIN_GROUP (scif0_ctrl),
@@ -605,6 +665,30 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { SH_PFC_PIN_GROUP(scif_clk), }; +static const char *const i2c0_groups[] = { +"i2c0" , +}; + +static const char *const i2c1_groups[] = { +"i2c1" , +}; + +static const char *const i2c2_groups[] = { +"i2c2" , +}; + +static const char *const i2c3_groups[] = { +"i2c3" , +}; + +static const char *const i2c4_groups[] = { +"i2c4" , +}; + +static const char *const i2c5_groups[] = { +"i2c5" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -634,6 +718,12 @@ static const char * const scif_clk_groups[] = { };static const struct sh_pfc_function pinmux_functions[] = { +SH_PFC_FUNCTION (i2c0), +SH_PFC_FUNCTION (i2c1), +SH_PFC_FUNCTION (i2c2), +SH_PFC_FUNCTION (i2c3), +SH_PFC_FUNCTION (i2c4), +SH_PFC_FUNCTION (i2c5),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1),SH_PFC_FUNCTION (scif3),
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 6/12 pinctrl: renesas: r8a779f0: Add HSCIF pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and functions for the High Speed Serial Communication Interfaces with FIFO (HSCIF) on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
Changes compared to the BSP:
- Add HSCIF[23] pin groups and functions.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 132 +++++++++++++++++++++++++ 1 file changed, 132 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +132 -0
@@ -488,6 +488,98 @@ static const struct sh_pfc_pin pinmux_pins[] = { PINMUX_GPIO_GP_ALL(), }; +/* - HSCIF0 ----------------------------------------------------------------- */ +static const unsigned int hscif0_data_pins[] = { +/* HRX0, HTX0 */ +RCAR_GP_PIN (0 ,2 ),RCAR_GP_PIN (0 ,3 ), +}; +static const unsigned int hscif0_data_mux[] = { +HRX0_MARK ,HTX0_MARK , +}; +static const unsigned int hscif0_clk_pins[] = { +/* HSCK0 */ +RCAR_GP_PIN (0 ,1 ), +}; +static const unsigned int hscif0_clk_mux[] = { +HSCK0_MARK , +}; +static const unsigned int hscif0_ctrl_pins[] = { +/* HRTS0#, HCTS0# */ +RCAR_GP_PIN (0 ,5 ),RCAR_GP_PIN (0 ,4 ), +}; +static const unsigned int hscif0_ctrl_mux[] = { +HRTS0_N_MARK ,HCTS0_N_MARK , +}; + +/* - HSCIF1 ----------------------------------------------------------------- */ +static const unsigned int hscif1_data_pins[] = { +/* HRX1, HTX1 */ +RCAR_GP_PIN (0 ,6 ),RCAR_GP_PIN (0 ,7 ), +}; +static const unsigned int hscif1_data_mux[] = { +HRX1_MARK ,HTX1_MARK , +}; +static const unsigned int hscif1_clk_pins[] = { +/* HSCK1 */ +RCAR_GP_PIN (0 ,8 ), +}; +static const unsigned int hscif1_clk_mux[] = { +HSCK1_MARK , +}; +static const unsigned int hscif1_ctrl_pins[] = { +/* HRTS1#, HCTS1# */ +RCAR_GP_PIN (0 ,9 ),RCAR_GP_PIN (0 ,10 ), +}; +static const unsigned int hscif1_ctrl_mux[] = { +HRTS1_N_MARK ,HCTS1_N_MARK , +}; + +/* - HSCIF2 ----------------------------------------------------------------- */ +static const unsigned int hscif2_data_pins[] = { +/* HRX2, HTX2 */ +RCAR_GP_PIN (1 ,1 ),RCAR_GP_PIN (1 ,2 ), +}; +static const unsigned int hscif2_data_mux[] = { +HRX2_MARK ,HTX2_MARK , +}; +static const unsigned int hscif2_clk_pins[] = { +/* HSCK2 */ +RCAR_GP_PIN (1 ,0 ), +}; +static const unsigned int hscif2_clk_mux[] = { +HSCK2_MARK , +}; +static const unsigned int hscif2_ctrl_pins[] = { +/* HRTS2#, HCTS2# */ +RCAR_GP_PIN (1 ,4 ),RCAR_GP_PIN (1 ,3 ), +}; +static const unsigned int hscif2_ctrl_mux[] = { +HRTS2_N_MARK ,HCTS2_N_MARK , +}; + +/* - HSCIF3 ----------------------------------------------------------------- */ +static const unsigned int hscif3_data_pins[] = { +/* HRX3, HTX3 */ +RCAR_GP_PIN (0 ,12 ),RCAR_GP_PIN (0 ,13 ), +}; +static const unsigned int hscif3_data_mux[] = { +HRX3_MARK ,HTX3_MARK , +}; +static const unsigned int hscif3_clk_pins[] = { +/* HSCK3 */ +RCAR_GP_PIN (0 ,14 ), +}; +static const unsigned int hscif3_clk_mux[] = { +HSCK3_MARK , +}; +static const unsigned int hscif3_ctrl_pins[] = { +/* HRTS3#, HCTS3# */ +RCAR_GP_PIN (0 ,15 ),RCAR_GP_PIN (0 ,11 ), +}; +static const unsigned int hscif3_ctrl_mux[] = { +HRTS3_N_MARK ,HCTS3_N_MARK , +}; +/* - I2C0 ------------------------------------------------------------------- */ static const unsigned int i2c0_pins[] = {/* SDA0, SCL0 */
@@ -644,6 +736,18 @@ static const unsigned int scif_clk_mux[] = { };static const struct sh_pfc_pin_group pinmux_groups[] = { +SH_PFC_PIN_GROUP (hscif0_data), +SH_PFC_PIN_GROUP (hscif0_clk), +SH_PFC_PIN_GROUP (hscif0_ctrl), +SH_PFC_PIN_GROUP (hscif1_data), +SH_PFC_PIN_GROUP (hscif1_clk), +SH_PFC_PIN_GROUP (hscif1_ctrl), +SH_PFC_PIN_GROUP (hscif2_data), +SH_PFC_PIN_GROUP (hscif2_clk), +SH_PFC_PIN_GROUP (hscif2_ctrl), +SH_PFC_PIN_GROUP (hscif3_data), +SH_PFC_PIN_GROUP (hscif3_clk), +SH_PFC_PIN_GROUP (hscif3_ctrl),SH_PFC_PIN_GROUP (i2c0),SH_PFC_PIN_GROUP (i2c1),SH_PFC_PIN_GROUP (i2c2),
@@ -665,6 +769,30 @@ static const struct sh_pfc_pin_group pinmux_groups[] = { SH_PFC_PIN_GROUP(scif_clk), }; +static const char *const hscif0_groups[] = { +"hscif0_data" , +"hscif0_clk" , +"hscif0_ctrl" , +}; + +static const char *const hscif1_groups[] = { +"hscif1_data" , +"hscif1_clk" , +"hscif1_ctrl" , +}; + +static const char *const hscif2_groups[] = { +"hscif2_data" , +"hscif2_clk" , +"hscif2_ctrl" , +}; + +static const char *const hscif3_groups[] = { +"hscif3_data" , +"hscif3_clk" , +"hscif3_ctrl" , +}; +static const char *const i2c0_groups[] = {"i2c0" , };
@@ -718,6 +846,10 @@ static const char * const scif_clk_groups[] = { };static const struct sh_pfc_function pinmux_functions[] = { +SH_PFC_FUNCTION (hscif0), +SH_PFC_FUNCTION (hscif1), +SH_PFC_FUNCTION (hscif2), +SH_PFC_FUNCTION (hscif3),SH_PFC_FUNCTION (i2c0),SH_PFC_FUNCTION (i2c1),SH_PFC_FUNCTION (i2c2),
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 7/12 pinctrl: renesas: r8a779f0: Add INTC-EX pins, groups, and function
In reply to Geert UytterhoevenAdd pins, groups, and function for the Interrupt Controller for External Devices (INTC-EX) on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
Changes compared to the BSP:
- Add IRQ[45] pin groups.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 61 ++++++++++++++++++++++++++ 1 file changed, 61 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +61 -0
@@ -634,6 +634,51 @@ static const unsigned int i2c5_mux[] = { SDA5_MARK, SCL5_MARK, }; + +/* - INTC-EX ---------------------------------------------------------------- */ +static const unsigned int intc_ex_irq0_pins[] = { +/* IRQ0 */ +RCAR_GP_PIN (0 ,17 ), +}; +static const unsigned int intc_ex_irq0_mux[] = { +IRQ0_MARK , +}; +static const unsigned int intc_ex_irq1_pins[] = { +/* IRQ1 */ +RCAR_GP_PIN (0 ,18 ), +}; +static const unsigned int intc_ex_irq1_mux[] = { +IRQ1_MARK , +}; +static const unsigned int intc_ex_irq2_pins[] = { +/* IRQ2 */ +RCAR_GP_PIN (0 ,19 ), +}; +static const unsigned int intc_ex_irq2_mux[] = { +IRQ2_MARK , +}; +static const unsigned int intc_ex_irq3_pins[] = { +/* IRQ3 */ +RCAR_GP_PIN (0 ,20 ), +}; +static const unsigned int intc_ex_irq3_mux[] = { +IRQ3_MARK , +}; +static const unsigned int intc_ex_irq4_pins[] = { +/* IRQ4 */ +RCAR_GP_PIN (0 ,11 ), +}; +static const unsigned int intc_ex_irq4_mux[] = { +IRQ4_MARK , +}; +static const unsigned int intc_ex_irq5_pins[] = { +/* IRQ5 */ +RCAR_GP_PIN (0 ,15 ), +}; +static const unsigned int intc_ex_irq5_mux[] = { +IRQ5_MARK , +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -754,6 +799,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (i2c3),SH_PFC_PIN_GROUP (i2c4),SH_PFC_PIN_GROUP (i2c5), +SH_PFC_PIN_GROUP (intc_ex_irq0), +SH_PFC_PIN_GROUP (intc_ex_irq1), +SH_PFC_PIN_GROUP (intc_ex_irq2), +SH_PFC_PIN_GROUP (intc_ex_irq3), +SH_PFC_PIN_GROUP (intc_ex_irq4), +SH_PFC_PIN_GROUP (intc_ex_irq5),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk), SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -817,6 +868,15 @@ static const char * const i2c5_groups[] = { "i2c5", }; +static const char *const intc_ex_groups[] = { +"intc_ex_irq0" , +"intc_ex_irq1" , +"intc_ex_irq2" , +"intc_ex_irq3" , +"intc_ex_irq4" , +"intc_ex_irq5" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -856,6 +916,7 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (i2c3),SH_PFC_FUNCTION (i2c4),SH_PFC_FUNCTION (i2c5), +SH_PFC_FUNCTION (intc_ex),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1), SH_PFC_FUNCTION(scif3),
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 8/12 pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
In reply to Geert UytterhoevenAdd pins, groups, and function for the MMC interface on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
This depends on "[PATCH 00/60] pinctrl: renesas: Share more pin group data"[1].
Changes compared to the BSP:
- Share MMC pin group data.
[1] https://lore.kernel.org/r/[email protected]
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 61 ++++++++++++++++++++++++++ 1 file changed, 61 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +61 -0
@@ -679,6 +679,49 @@ static const unsigned int intc_ex_irq5_mux[] = { IRQ5_MARK, }; +/* - MMC -------------------------------------------------------------------- */ +static const unsigned int mmc_data_pins[] = { +/* MMC_SD_D[0:3], MMC_D[4:7] */ +RCAR_GP_PIN (1 ,13 ),RCAR_GP_PIN (1 ,14 ), +RCAR_GP_PIN (1 ,15 ),RCAR_GP_PIN (1 ,16 ), +RCAR_GP_PIN (1 ,18 ),RCAR_GP_PIN (1 ,17 ), +RCAR_GP_PIN (1 ,19 ),RCAR_GP_PIN (1 ,21 ), +}; +static const unsigned int mmc_data_mux[] = { +MMC_SD_D0_MARK ,MMC_SD_D1_MARK , +MMC_SD_D2_MARK ,MMC_SD_D3_MARK , +MMC_D4_MARK ,MMC_D5_MARK , +MMC_D6_MARK ,MMC_D7_MARK , +}; +static const unsigned int mmc_ctrl_pins[] = { +/* MMC_SD_CLK, MMC_SD_CMD */ +RCAR_GP_PIN (1 ,12 ),RCAR_GP_PIN (1 ,22 ), +}; +static const unsigned int mmc_ctrl_mux[] = { +MMC_SD_CLK_MARK ,MMC_SD_CMD_MARK , +}; +static const unsigned int mmc_cd_pins[] = { +/* SD_CD */ +RCAR_GP_PIN (1 ,23 ), +}; +static const unsigned int mmc_cd_mux[] = { +SD_CD_MARK , +}; +static const unsigned int mmc_wp_pins[] = { +/* SD_WP */ +RCAR_GP_PIN (1 ,24 ), +}; +static const unsigned int mmc_wp_mux[] = { +SD_WP_MARK , +}; +static const unsigned int mmc_ds_pins[] = { +/* MMC_DS */ +RCAR_GP_PIN (1 ,20 ), +}; +static const unsigned int mmc_ds_mux[] = { +MMC_DS_MARK , +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -805,6 +848,13 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (intc_ex_irq3),SH_PFC_PIN_GROUP (intc_ex_irq4),SH_PFC_PIN_GROUP (intc_ex_irq5), +BUS_DATA_PIN_GROUP (mmc_data,1 ), +BUS_DATA_PIN_GROUP (mmc_data,4 ), +BUS_DATA_PIN_GROUP (mmc_data,8 ), +SH_PFC_PIN_GROUP (mmc_ctrl), +SH_PFC_PIN_GROUP (mmc_cd), +SH_PFC_PIN_GROUP (mmc_wp), +SH_PFC_PIN_GROUP (mmc_ds),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk), SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -877,6 +927,16 @@ static const char * const intc_ex_groups[] = { "intc_ex_irq5", }; +static const char *const mmc_groups[] = { +"mmc_data1" , +"mmc_data4" , +"mmc_data8" , +"mmc_ctrl" , +"mmc_cd" , +"mmc_wp" , +"mmc_ds" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -917,6 +977,7 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (i2c4),SH_PFC_FUNCTION (i2c5),SH_PFC_FUNCTION (intc_ex), +SH_PFC_FUNCTION (mmc),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1), SH_PFC_FUNCTION(scif3),
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH v2 08/12] pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
I love your patch! Yet something to improve:
Hi Geert,
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkout 06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/renesas/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:851:2: error: implicit declaration of function 'BUS_DATA_PIN_GROUP' [-Werror,-Wimplicit-function-declaration]
BUS_DATA_PIN_GROUP(mmc_data, 1),
^
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:851:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 1),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:852:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 4),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:853:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 8),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1489:20: error: incompatible function pointer types initializing 'int (*)(struct sh_pfc *, unsigned int, u32 *)' (aka 'int (*)(struct sh_pfc *, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types]
.pin_to_pocctrl = r8a779f0_pin_to_pocctrl,
^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:1504:15: error: invalid application of 'sizeof' to an incomplete type 'const struct sh_pfc_pin_group[]'
.nr_groups = ARRAY_SIZE(pinmux_groups),
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:55:32: note: expanded from macro 'ARRAY_SIZE'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
^~~~~6 errors generated.
vim +/BUS_DATA_PIN_GROUP +851 drivers/pinctrl/renesas/pfc-r8a779f0.c
825
826 static const struct sh_pfc_pin_group pinmux_groups[] = {
827 SH_PFC_PIN_GROUP(hscif0_data),
828 SH_PFC_PIN_GROUP(hscif0_clk),
829 SH_PFC_PIN_GROUP(hscif0_ctrl),
830 SH_PFC_PIN_GROUP(hscif1_data),
831 SH_PFC_PIN_GROUP(hscif1_clk),
832 SH_PFC_PIN_GROUP(hscif1_ctrl),
833 SH_PFC_PIN_GROUP(hscif2_data),
834 SH_PFC_PIN_GROUP(hscif2_clk),
835 SH_PFC_PIN_GROUP(hscif2_ctrl),
836 SH_PFC_PIN_GROUP(hscif3_data),
837 SH_PFC_PIN_GROUP(hscif3_clk),
838 SH_PFC_PIN_GROUP(hscif3_ctrl),
839 SH_PFC_PIN_GROUP(i2c0),
840 SH_PFC_PIN_GROUP(i2c1),
841 SH_PFC_PIN_GROUP(i2c2),
842 SH_PFC_PIN_GROUP(i2c3),
843 SH_PFC_PIN_GROUP(i2c4),
844 SH_PFC_PIN_GROUP(i2c5),
845 SH_PFC_PIN_GROUP(intc_ex_irq0),
846 SH_PFC_PIN_GROUP(intc_ex_irq1),
847 SH_PFC_PIN_GROUP(intc_ex_irq2),
848 SH_PFC_PIN_GROUP(intc_ex_irq3),
849 SH_PFC_PIN_GROUP(intc_ex_irq4),
850 SH_PFC_PIN_GROUP(intc_ex_irq5),
> 851 BUS_DATA_PIN_GROUP(mmc_data, 1),
852 BUS_DATA_PIN_GROUP(mmc_data, 4),
853 BUS_DATA_PIN_GROUP(mmc_data, 8),
854 SH_PFC_PIN_GROUP(mmc_ctrl),
855 SH_PFC_PIN_GROUP(mmc_cd),
856 SH_PFC_PIN_GROUP(mmc_wp),
857 SH_PFC_PIN_GROUP(mmc_ds),
858 SH_PFC_PIN_GROUP(scif0_data),
859 SH_PFC_PIN_GROUP(scif0_clk),
860 SH_PFC_PIN_GROUP(scif0_ctrl),
861 SH_PFC_PIN_GROUP(scif1_data),
862 SH_PFC_PIN_GROUP(scif1_clk),
863 SH_PFC_PIN_GROUP(scif1_ctrl),
864 SH_PFC_PIN_GROUP(scif3_data),
865 SH_PFC_PIN_GROUP(scif3_clk),
866 SH_PFC_PIN_GROUP(scif3_ctrl),
867 SH_PFC_PIN_GROUP(scif4_data),
868 SH_PFC_PIN_GROUP(scif4_clk),
869 SH_PFC_PIN_GROUP(scif4_ctrl),
870 SH_PFC_PIN_GROUP(scif_clk),
871 };
872
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Re: [PATCH v2 08/12] pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
Quoted 25 lines · kernel test robot
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/202202220816.4R3DRnX0-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkout06b5c197da936f9f7d6dc715ff6ae7ab6aee760d
# save the config file to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/pinctrl/renesas/
Quoted 6 lines
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
Quoted 1 line
Quoted 1 line
drivers/pinctrl/renesas/pfc-r8a779f0.c:851:2: error: implicit declaration of function 'BUS_DATA_PIN_GROUP' [-Werror,-Wimplicit-function-declaration]
Missing dependency:
This depends on "[PATCH 00/60] pinctrl: renesas: Share more pin group
data"[1].
[1] https://lore.kernel.org/r/cover.1640269757.git.geert+renesas(a)glider.beGr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Geert Uytterhoeven
maintainerPATCH v2 9/12 pinctrl: renesas: r8a779f0: Add MSIOF pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and function for the Clock-Synchronized Serial Interfaces with FIFO (MSIOF) on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
Changes compared to the BSP:
- Add MSIOF[123] pin groups and functions.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 240 +++++++++++++++++++++++++ 1 file changed, 240 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +240 -0
@@ -722,6 +722,182 @@ static const unsigned int mmc_ds_mux[] = { MMC_DS_MARK, }; +/* - MSIOF0 ----------------------------------------------------------------- */ +static const unsigned int msiof0_clk_pins[] = { +/* MSIOF0_SCK */ +RCAR_GP_PIN (0 ,14 ), +}; +static const unsigned int msiof0_clk_mux[] = { +MSIOF0_SCK_MARK , +}; +static const unsigned int msiof0_sync_pins[] = { +/* MSIOF0_SYNC */ +RCAR_GP_PIN (0 ,11 ), +}; +static const unsigned int msiof0_sync_mux[] = { +MSIOF0_SYNC_MARK , +}; +static const unsigned int msiof0_ss1_pins[] = { +/* MSIOF0_SS1 */ +RCAR_GP_PIN (0 ,15 ), +}; +static const unsigned int msiof0_ss1_mux[] = { +MSIOF0_SS1_MARK , +}; +static const unsigned int msiof0_ss2_pins[] = { +/* MSIOF0_SS2 */ +RCAR_GP_PIN (0 ,16 ), +}; +static const unsigned int msiof0_ss2_mux[] = { +MSIOF0_SS2_MARK , +}; +static const unsigned int msiof0_txd_pins[] = { +/* MSIOF0_TXD */ +RCAR_GP_PIN (0 ,13 ), +}; +static const unsigned int msiof0_txd_mux[] = { +MSIOF0_TXD_MARK , +}; +static const unsigned int msiof0_rxd_pins[] = { +/* MSIOF0_RXD */ +RCAR_GP_PIN (0 ,12 ), +}; +static const unsigned int msiof0_rxd_mux[] = { +MSIOF0_RXD_MARK , +}; + +/* - MSIOF1 ----------------------------------------------------------------- */ +static const unsigned int msiof1_clk_pins[] = { +/* MSIOF1_SCK */ +RCAR_GP_PIN (0 ,8 ), +}; +static const unsigned int msiof1_clk_mux[] = { +MSIOF1_SCK_MARK , +}; +static const unsigned int msiof1_sync_pins[] = { +/* MSIOF1_SYNC */ +RCAR_GP_PIN (0 ,10 ), +}; +static const unsigned int msiof1_sync_mux[] = { +MSIOF1_SYNC_MARK , +}; +static const unsigned int msiof1_ss1_pins[] = { +/* MSIOF1_SS1 */ +RCAR_GP_PIN (0 ,17 ), +}; +static const unsigned int msiof1_ss1_mux[] = { +MSIOF1_SS1_MARK , +}; +static const unsigned int msiof1_ss2_pins[] = { +/* MSIOF1_SS2 */ +RCAR_GP_PIN (0 ,18 ), +}; +static const unsigned int msiof1_ss2_mux[] = { +MSIOF1_SS2_MARK , +}; +static const unsigned int msiof1_txd_pins[] = { +/* MSIOF1_TXD */ +RCAR_GP_PIN (0 ,7 ), +}; +static const unsigned int msiof1_txd_mux[] = { +MSIOF1_TXD_MARK , +}; +static const unsigned int msiof1_rxd_pins[] = { +/* MSIOF1_RXD */ +RCAR_GP_PIN (0 ,6 ), +}; +static const unsigned int msiof1_rxd_mux[] = { +MSIOF1_RXD_MARK , +}; + +/* - MSIOF2 ----------------------------------------------------------------- */ +static const unsigned int msiof2_clk_pins[] = { +/* MSIOF2_SCK */ +RCAR_GP_PIN (1 ,5 ), +}; +static const unsigned int msiof2_clk_mux[] = { +MSIOF2_SCK_MARK , +}; +static const unsigned int msiof2_sync_pins[] = { +/* MSIOF2_SYNC */ +RCAR_GP_PIN (1 ,4 ), +}; +static const unsigned int msiof2_sync_mux[] = { +MSIOF2_SYNC_MARK , +}; +static const unsigned int msiof2_ss1_pins[] = { +/* MSIOF2_SS1 */ +RCAR_GP_PIN (1 ,2 ), +}; +static const unsigned int msiof2_ss1_mux[] = { +MSIOF2_SS1_MARK , +}; +static const unsigned int msiof2_ss2_pins[] = { +/* MSIOF2_SS2 */ +RCAR_GP_PIN (1 ,3 ), +}; +static const unsigned int msiof2_ss2_mux[] = { +MSIOF2_SS2_MARK , +}; +static const unsigned int msiof2_txd_pins[] = { +/* MSIOF2_TXD */ +RCAR_GP_PIN (1 ,7 ), +}; +static const unsigned int msiof2_txd_mux[] = { +MSIOF2_TXD_MARK , +}; +static const unsigned int msiof2_rxd_pins[] = { +/* MSIOF2_RXD */ +RCAR_GP_PIN (1 ,6 ), +}; +static const unsigned int msiof2_rxd_mux[] = { +MSIOF2_RXD_MARK , +}; + +/* - MSIOF3 ----------------------------------------------------------------- */ +static const unsigned int msiof3_clk_pins[] = { +/* MSIOF3_SCK */ +RCAR_GP_PIN (0 ,1 ), +}; +static const unsigned int msiof3_clk_mux[] = { +MSIOF3_SCK_MARK , +}; +static const unsigned int msiof3_sync_pins[] = { +/* MSIOF3_SYNC */ +RCAR_GP_PIN (0 ,9 ), +}; +static const unsigned int msiof3_sync_mux[] = { +MSIOF3_SYNC_MARK , +}; +static const unsigned int msiof3_ss1_pins[] = { +/* MSIOF3_SS1 */ +RCAR_GP_PIN (0 ,4 ), +}; +static const unsigned int msiof3_ss1_mux[] = { +MSIOF3_SS1_MARK , +}; +static const unsigned int msiof3_ss2_pins[] = { +/* MSIOF3_SS2 */ +RCAR_GP_PIN (0 ,5 ), +}; +static const unsigned int msiof3_ss2_mux[] = { +MSIOF3_SS2_MARK , +}; +static const unsigned int msiof3_txd_pins[] = { +/* MSIOF3_TXD */ +RCAR_GP_PIN (0 ,3 ), +}; +static const unsigned int msiof3_txd_mux[] = { +MSIOF3_TXD_MARK , +}; +static const unsigned int msiof3_rxd_pins[] = { +/* MSIOF3_RXD */ +RCAR_GP_PIN (0 ,2 ), +}; +static const unsigned int msiof3_rxd_mux[] = { +MSIOF3_RXD_MARK , +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -855,6 +1031,30 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (mmc_cd),SH_PFC_PIN_GROUP (mmc_wp),SH_PFC_PIN_GROUP (mmc_ds), +SH_PFC_PIN_GROUP (msiof0_clk), +SH_PFC_PIN_GROUP (msiof0_sync), +SH_PFC_PIN_GROUP (msiof0_ss1), +SH_PFC_PIN_GROUP (msiof0_ss2), +SH_PFC_PIN_GROUP (msiof0_txd), +SH_PFC_PIN_GROUP (msiof0_rxd), +SH_PFC_PIN_GROUP (msiof1_clk), +SH_PFC_PIN_GROUP (msiof1_sync), +SH_PFC_PIN_GROUP (msiof1_ss1), +SH_PFC_PIN_GROUP (msiof1_ss2), +SH_PFC_PIN_GROUP (msiof1_txd), +SH_PFC_PIN_GROUP (msiof1_rxd), +SH_PFC_PIN_GROUP (msiof2_clk), +SH_PFC_PIN_GROUP (msiof2_sync), +SH_PFC_PIN_GROUP (msiof2_ss1), +SH_PFC_PIN_GROUP (msiof2_ss2), +SH_PFC_PIN_GROUP (msiof2_txd), +SH_PFC_PIN_GROUP (msiof2_rxd), +SH_PFC_PIN_GROUP (msiof3_clk), +SH_PFC_PIN_GROUP (msiof3_sync), +SH_PFC_PIN_GROUP (msiof3_ss1), +SH_PFC_PIN_GROUP (msiof3_ss2), +SH_PFC_PIN_GROUP (msiof3_txd), +SH_PFC_PIN_GROUP (msiof3_rxd),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk), SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -937,6 +1137,42 @@ static const char * const mmc_groups[] = { "mmc_ds", }; +static const char *const msiof0_groups[] = { +"msiof0_clk" , +"msiof0_sync" , +"msiof0_ss1" , +"msiof0_ss2" , +"msiof0_txd" , +"msiof0_rxd" , +}; + +static const char *const msiof1_groups[] = { +"msiof1_clk" , +"msiof1_sync" , +"msiof1_ss1" , +"msiof1_ss2" , +"msiof1_txd" , +"msiof1_rxd" , +}; + +static const char *const msiof2_groups[] = { +"msiof2_clk" , +"msiof2_sync" , +"msiof2_ss1" , +"msiof2_ss2" , +"msiof2_txd" , +"msiof2_rxd" , +}; + +static const char *const msiof3_groups[] = { +"msiof3_clk" , +"msiof3_sync" , +"msiof3_ss1" , +"msiof3_ss2" , +"msiof3_txd" , +"msiof3_rxd" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -978,6 +1214,10 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (i2c5),SH_PFC_FUNCTION (intc_ex),SH_PFC_FUNCTION (mmc), +SH_PFC_FUNCTION (msiof0), +SH_PFC_FUNCTION (msiof1), +SH_PFC_FUNCTION (msiof2), +SH_PFC_FUNCTION (msiof3),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1), SH_PFC_FUNCTION(scif3),
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 10/12 pinctrl: renesas: r8a779f0: Add PCIe pins, groups, and function
In reply to Geert UytterhoevenAdd pins, groups, and function for the PCIe Controllers on the Renesas R-Car S4-8 (R8A779F0) SoC.
Extracted from a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 27 ++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +27 -0
@@ -898,6 +898,25 @@ static const unsigned int msiof3_rxd_mux[] = { MSIOF3_RXD_MARK, }; +/* - PCIE ------------------------------------------------------------------- */ +static const unsigned int pcie0_clkreq_n_pins[] = { +/* PCIE0_CLKREQ# */ +RCAR_GP_PIN (2 ,15 ), +}; + +static const unsigned int pcie0_clkreq_n_mux[] = { +PCIE0_CLKREQ_N_MARK , +}; + +static const unsigned int pcie1_clkreq_n_pins[] = { +/* PCIE1_CLKREQ# */ +RCAR_GP_PIN (2 ,16 ), +}; + +static const unsigned int pcie1_clkreq_n_mux[] = { +PCIE1_CLKREQ_N_MARK , +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -1055,6 +1074,8 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (msiof3_ss2),SH_PFC_PIN_GROUP (msiof3_txd),SH_PFC_PIN_GROUP (msiof3_rxd), +SH_PFC_PIN_GROUP (pcie0_clkreq_n), +SH_PFC_PIN_GROUP (pcie1_clkreq_n),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk), SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -1173,6 +1194,11 @@ static const char * const msiof3_groups[] = { "msiof3_rxd", }; +static const char *const pcie_groups[] = { +"pcie0_clkreq_n" , +"pcie1_clkreq_n" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -1218,6 +1244,7 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (msiof1),SH_PFC_FUNCTION (msiof2),SH_PFC_FUNCTION (msiof3), +SH_PFC_FUNCTION (pcie),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1), SH_PFC_FUNCTION(scif3),
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerPATCH v2 11/12 pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and functions for the Quad SPI Controllers on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
This depends on "[PATCH 00/60] pinctrl: renesas: Share more pin group data"[1].
Changes compared to the BSP:
- Share QSPI pin group data.
[1] https://lore.kernel.org/r/[email protected]
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 56 ++++++++++++++++++++++++++ 1 file changed, 56 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +56 -0
@@ -917,6 +917,42 @@ static const unsigned int pcie1_clkreq_n_mux[] = { PCIE1_CLKREQ_N_MARK, }; +/* - QSPI0 ------------------------------------------------------------------ */ +static const unsigned int qspi0_ctrl_pins[] = { +/* SPCLK, SSL */ +RCAR_GP_PIN (2 ,10 ),RCAR_GP_PIN (2 ,13 ), +}; +static const unsigned int qspi0_ctrl_mux[] = { +QSPI0_SPCLK_MARK ,QSPI0_SSL_MARK , +}; +static const unsigned int qspi0_data_pins[] = { +/* MOSI_IO0, MISO_IO1, IO2, IO3 */ +RCAR_GP_PIN (2 ,9 ),RCAR_GP_PIN (2 ,12 ), +RCAR_GP_PIN (2 ,11 ),RCAR_GP_PIN (2 ,14 ), +}; +static const unsigned int qspi0_data_mux[] = { +QSPI0_MOSI_IO0_MARK ,QSPI0_MISO_IO1_MARK , +QSPI0_IO2_MARK ,QSPI0_IO3_MARK +}; + +/* - QSPI1 ------------------------------------------------------------------ */ +static const unsigned int qspi1_ctrl_pins[] = { +/* SPCLK, SSL */ +RCAR_GP_PIN (2 ,8 ),RCAR_GP_PIN (2 ,3 ), +}; +static const unsigned int qspi1_ctrl_mux[] = { +QSPI1_SPCLK_MARK ,QSPI1_SSL_MARK , +}; +static const unsigned int qspi1_data_pins[] = { +/* MOSI_IO0, MISO_IO1, IO2, IO3 */ +RCAR_GP_PIN (2 ,7 ),RCAR_GP_PIN (2 ,5 ), +RCAR_GP_PIN (2 ,6 ),RCAR_GP_PIN (2 ,4 ), +}; +static const unsigned int qspi1_data_mux[] = { +QSPI1_MOSI_IO0_MARK ,QSPI1_MISO_IO1_MARK , +QSPI1_IO2_MARK ,QSPI1_IO3_MARK +}; +/* - SCIF0 ------------------------------------------------------------------ */ static const unsigned int scif0_data_pins[] = {/* RX0, TX0 */
@@ -1076,6 +1112,12 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (msiof3_rxd),SH_PFC_PIN_GROUP (pcie0_clkreq_n),SH_PFC_PIN_GROUP (pcie1_clkreq_n), +SH_PFC_PIN_GROUP (qspi0_ctrl), +BUS_DATA_PIN_GROUP (qspi0_data,2 ), +BUS_DATA_PIN_GROUP (qspi0_data,4 ), +SH_PFC_PIN_GROUP (qspi1_ctrl), +BUS_DATA_PIN_GROUP (qspi1_data,2 ), +BUS_DATA_PIN_GROUP (qspi1_data,4 ),SH_PFC_PIN_GROUP (scif0_data),SH_PFC_PIN_GROUP (scif0_clk), SH_PFC_PIN_GROUP(scif0_ctrl),
@@ -1199,6 +1241,18 @@ static const char * const pcie_groups[] = { "pcie1_clkreq_n", }; +static const char *const qspi0_groups[] = { +"qspi0_ctrl" , +"qspi0_data2" , +"qspi0_data4" , +}; + +static const char *const qspi1_groups[] = { +"qspi1_ctrl" , +"qspi1_data2" , +"qspi1_data4" , +}; +static const char *const scif0_groups[] = {"scif0_data" ,"scif0_clk" ,
@@ -1245,6 +1299,8 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (msiof2),SH_PFC_FUNCTION (msiof3),SH_PFC_FUNCTION (pcie), +SH_PFC_FUNCTION (qspi0), +SH_PFC_FUNCTION (qspi1),SH_PFC_FUNCTION (scif0),SH_PFC_FUNCTION (scif1), SH_PFC_FUNCTION(scif3),
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH v2 11/12] pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
I love your patch! Yet something to improve:
Hi Geert,
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/a5976fa9dc1d92148ae24e8dd706696e45a45d5a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkout a5976fa9dc1d92148ae24e8dd706696e45a45d5a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/pinctrl/renesas/
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
drivers/pinctrl/renesas/pfc-r8a779f0.c:1082:2: error: implicit declaration of function 'BUS_DATA_PIN_GROUP' [-Werror,-Wimplicit-function-declaration]
BUS_DATA_PIN_GROUP(mmc_data, 1),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1082:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 1),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1083:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 4),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1084:21: error: use of undeclared identifier 'mmc_data'
BUS_DATA_PIN_GROUP(mmc_data, 8),
^
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:1116:21: error: use of undeclared identifier 'qspi0_data'
BUS_DATA_PIN_GROUP(qspi0_data, 2),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1117:21: error: use of undeclared identifier 'qspi0_data'
BUS_DATA_PIN_GROUP(qspi0_data, 4),
^
>> drivers/pinctrl/renesas/pfc-r8a779f0.c:1119:21: error: use of undeclared identifier 'qspi1_data'
BUS_DATA_PIN_GROUP(qspi1_data, 2),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1120:21: error: use of undeclared identifier 'qspi1_data'
BUS_DATA_PIN_GROUP(qspi1_data, 4),
^
drivers/pinctrl/renesas/pfc-r8a779f0.c:1812:20: error: incompatible function pointer types initializing 'int (*)(struct sh_pfc *, unsigned int, u32 *)' (aka 'int (*)(struct sh_pfc *, unsigned int, unsigned int *)') with an expression of type 'int (unsigned int, u32 *)' (aka 'int (unsigned int, unsigned int *)') [-Werror,-Wincompatible-function-pointer-types]
.pin_to_pocctrl = r8a779f0_pin_to_pocctrl,
^~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/renesas/pfc-r8a779f0.c:1827:15: error: invalid application of 'sizeof' to an incomplete type 'const struct sh_pfc_pin_group[]'
.nr_groups = ARRAY_SIZE(pinmux_groups),
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/kernel.h:55:32: note: expanded from macro 'ARRAY_SIZE'
#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
^~~~~10 errors generated.
vim +/qspi0_data +1116 drivers/pinctrl/renesas/pfc-r8a779f0.c
1056
1057 static const struct sh_pfc_pin_group pinmux_groups[] = {
1058 SH_PFC_PIN_GROUP(hscif0_data),
1059 SH_PFC_PIN_GROUP(hscif0_clk),
1060 SH_PFC_PIN_GROUP(hscif0_ctrl),
1061 SH_PFC_PIN_GROUP(hscif1_data),
1062 SH_PFC_PIN_GROUP(hscif1_clk),
1063 SH_PFC_PIN_GROUP(hscif1_ctrl),
1064 SH_PFC_PIN_GROUP(hscif2_data),
1065 SH_PFC_PIN_GROUP(hscif2_clk),
1066 SH_PFC_PIN_GROUP(hscif2_ctrl),
1067 SH_PFC_PIN_GROUP(hscif3_data),
1068 SH_PFC_PIN_GROUP(hscif3_clk),
1069 SH_PFC_PIN_GROUP(hscif3_ctrl),
1070 SH_PFC_PIN_GROUP(i2c0),
1071 SH_PFC_PIN_GROUP(i2c1),
1072 SH_PFC_PIN_GROUP(i2c2),
1073 SH_PFC_PIN_GROUP(i2c3),
1074 SH_PFC_PIN_GROUP(i2c4),
1075 SH_PFC_PIN_GROUP(i2c5),
1076 SH_PFC_PIN_GROUP(intc_ex_irq0),
1077 SH_PFC_PIN_GROUP(intc_ex_irq1),
1078 SH_PFC_PIN_GROUP(intc_ex_irq2),
1079 SH_PFC_PIN_GROUP(intc_ex_irq3),
1080 SH_PFC_PIN_GROUP(intc_ex_irq4),
1081 SH_PFC_PIN_GROUP(intc_ex_irq5),
1082 BUS_DATA_PIN_GROUP(mmc_data, 1),
1083 BUS_DATA_PIN_GROUP(mmc_data, 4),
1084 BUS_DATA_PIN_GROUP(mmc_data, 8),
1085 SH_PFC_PIN_GROUP(mmc_ctrl),
1086 SH_PFC_PIN_GROUP(mmc_cd),
1087 SH_PFC_PIN_GROUP(mmc_wp),
1088 SH_PFC_PIN_GROUP(mmc_ds),
1089 SH_PFC_PIN_GROUP(msiof0_clk),
1090 SH_PFC_PIN_GROUP(msiof0_sync),
1091 SH_PFC_PIN_GROUP(msiof0_ss1),
1092 SH_PFC_PIN_GROUP(msiof0_ss2),
1093 SH_PFC_PIN_GROUP(msiof0_txd),
1094 SH_PFC_PIN_GROUP(msiof0_rxd),
1095 SH_PFC_PIN_GROUP(msiof1_clk),
1096 SH_PFC_PIN_GROUP(msiof1_sync),
1097 SH_PFC_PIN_GROUP(msiof1_ss1),
1098 SH_PFC_PIN_GROUP(msiof1_ss2),
1099 SH_PFC_PIN_GROUP(msiof1_txd),
1100 SH_PFC_PIN_GROUP(msiof1_rxd),
1101 SH_PFC_PIN_GROUP(msiof2_clk),
1102 SH_PFC_PIN_GROUP(msiof2_sync),
1103 SH_PFC_PIN_GROUP(msiof2_ss1),
1104 SH_PFC_PIN_GROUP(msiof2_ss2),
1105 SH_PFC_PIN_GROUP(msiof2_txd),
1106 SH_PFC_PIN_GROUP(msiof2_rxd),
1107 SH_PFC_PIN_GROUP(msiof3_clk),
1108 SH_PFC_PIN_GROUP(msiof3_sync),
1109 SH_PFC_PIN_GROUP(msiof3_ss1),
1110 SH_PFC_PIN_GROUP(msiof3_ss2),
1111 SH_PFC_PIN_GROUP(msiof3_txd),
1112 SH_PFC_PIN_GROUP(msiof3_rxd),
1113 SH_PFC_PIN_GROUP(pcie0_clkreq_n),
1114 SH_PFC_PIN_GROUP(pcie1_clkreq_n),
1115 SH_PFC_PIN_GROUP(qspi0_ctrl),
> 1116 BUS_DATA_PIN_GROUP(qspi0_data, 2), 1117 BUS_DATA_PIN_GROUP(qspi0_data, 4), 1118 SH_PFC_PIN_GROUP(qspi1_ctrl), > 1119 BUS_DATA_PIN_GROUP(qspi1_data, 2),
1120 BUS_DATA_PIN_GROUP(qspi1_data, 4),
1121 SH_PFC_PIN_GROUP(scif0_data),
1122 SH_PFC_PIN_GROUP(scif0_clk),
1123 SH_PFC_PIN_GROUP(scif0_ctrl),
1124 SH_PFC_PIN_GROUP(scif1_data),
1125 SH_PFC_PIN_GROUP(scif1_clk),
1126 SH_PFC_PIN_GROUP(scif1_ctrl),
1127 SH_PFC_PIN_GROUP(scif3_data),
1128 SH_PFC_PIN_GROUP(scif3_clk),
1129 SH_PFC_PIN_GROUP(scif3_ctrl),
1130 SH_PFC_PIN_GROUP(scif4_data),
1131 SH_PFC_PIN_GROUP(scif4_clk),
1132 SH_PFC_PIN_GROUP(scif4_ctrl),
1133 SH_PFC_PIN_GROUP(scif_clk),
1134 };
1135
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Re: [PATCH v2 11/12] pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
Quoted 25 lines · kernel test robot
I love your patch! Yet something to improve:
[auto build test ERROR on geert-renesas-drivers/renesas-pinctrl]
[also build test ERROR on robh/for-next linusw-pinctrl/devel v5.17-rc5 next-20220217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git renesas-pinctrl config: arm64-randconfig-r021-20220221 (https://download.01.org/0day-ci/archive/20220222/202202220911.QtJ97DYI-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/a5976fa9dc1d92148ae24e8dd706696e45a45d5a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Geert-Uytterhoeven/pinctrl-renesas-Add-R-Car-S4-8-support/20220221-234855 git checkouta5976fa9dc1d92148ae24e8dd706696e45a45d5a
# save the config file to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bashdrivers/pinctrl/renesas/
Quoted 6 lines
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>All errors (new ones prefixed by >>):
drivers/pinctrl/renesas/pfc-r8a779f0.c:1082:2: error: implicit declaration of function 'BUS_DATA_PIN_GROUP' [-Werror,-Wimplicit-function-declaration]
Missing dependency:
This depends on "[PATCH 00/60] pinctrl: renesas: Share more pin group
data"[1].
[1] https://lore.kernel.org/r/cover.1640269757.git.geert+renesas(a)glider.beGr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Geert Uytterhoeven
maintainerPATCH v2 12/12 pinctrl: renesas: r8a779f0: Add Ethernet pins, groups, and functions
In reply to Geert UytterhoevenAdd pins, groups, and functions for the Ethernet Time-Sensitive Networking (TSN) interfaces on the Renesas R-Car S4-8 (R8A779F0) SoC.
Based on a larger patch in the BSP by LUU HOAI.
---
v2:
- No changes.
Changes compared to the BSP:
- Add B-suffixes to groups that can appear on multiple sets of pins,
- Add missing A groups.
--- drivers/pinctrl/renesas/pfc-r8a779f0.c | 288 +++++++++++++++++++++++++ 1 file changed, 288 insertions(+)
drivers/pinctrl/renesas/pfc-r8a779f0.c +288 -0
@@ -1054,6 +1054,222 @@ static const unsigned int scif_clk_mux[] = { SCIF_CLK_MARK, }; +/* - TSN0 ------------------------------------------------ */ +static const unsigned int tsn0_link_a_pins[] = { +/* TSN0_LINK_A */ +RCAR_GP_PIN (0 ,11 ), +}; +static const unsigned int tsn0_link_a_mux[] = { +TSN0_LINK_A_MARK , +}; +static const unsigned int tsn0_magic_a_pins[] = { +/* TSN0_MAGIC_A */ +RCAR_GP_PIN (0 ,17 ), +}; +static const unsigned int tsn0_magic_a_mux[] = { +TSN0_MAGIC_A_MARK , +}; +static const unsigned int tsn0_phy_int_a_pins[] = { +/* TSN0_PHY_INT_A */ +RCAR_GP_PIN (0 ,18 ), +}; +static const unsigned int tsn0_phy_int_a_mux[] = { +TSN0_PHY_INT_A_MARK , +}; +static const unsigned int tsn0_mdio_a_pins[] = { +/* TSN0_MDC_A, TSN0_MDIO_A */ +RCAR_GP_PIN (0 ,4 ),RCAR_GP_PIN (0 ,5 ), +}; +static const unsigned int tsn0_mdio_a_mux[] = { +TSN0_MDC_A_MARK ,TSN0_MDIO_A_MARK , +}; +static const unsigned int tsn0_link_b_pins[] = { +/* TSN0_LINK_B */ +RCAR_GP_PIN (3 ,8 ), +}; +static const unsigned int tsn0_link_b_mux[] = { +TSN0_LINK_B_MARK , +}; +static const unsigned int tsn0_magic_b_pins[] = { +/* TSN0_MAGIC_B */ +RCAR_GP_PIN (3 ,12 ), +}; +static const unsigned int tsn0_magic_b_mux[] = { +TSN0_MAGIC_B_MARK , +}; +static const unsigned int tsn0_phy_int_b_pins[] = { +/* TSN0_PHY_INT_B */ +RCAR_GP_PIN (3 ,10 ), +}; +static const unsigned int tsn0_phy_int_b_mux[] = { +TSN0_PHY_INT_B_MARK , +}; +static const unsigned int tsn0_mdio_b_pins[] = { +/* TSN0_MDC_B, TSN0_MDIO_B */ +RCAR_GP_PIN (3 ,4 ),RCAR_GP_PIN (3 ,2 ), +}; +static const unsigned int tsn0_mdio_b_mux[] = { +TSN0_MDC_B_MARK ,TSN0_MDIO_B_MARK , +}; +static const unsigned int tsn0_avtp_pps_pins[] = { +/* TSN0_AVTP_PPS */ +RCAR_GP_PIN (3 ,16 ), +}; +static const unsigned int tsn0_avtp_pps_mux[] = { +TSN0_AVTP_PPS_MARK , +}; +static const unsigned int tsn0_avtp_capture_a_pins[] = { +/* TSN0_AVTP_CAPTURE_A */ +RCAR_GP_PIN (0 ,1 ), +}; +static const unsigned int tsn0_avtp_capture_a_mux[] = { +TSN0_AVTP_CAPTURE_A_MARK , +}; +static const unsigned int tsn0_avtp_match_a_pins[] = { +/* TSN0_AVTP_MATCH_A */ +RCAR_GP_PIN (0 ,2 ), +}; +static const unsigned int tsn0_avtp_match_a_mux[] = { +TSN0_AVTP_MATCH_A_MARK , +}; +static const unsigned int tsn0_avtp_capture_b_pins[] = { +/* TSN0_AVTP_CAPTURE_B */ +RCAR_GP_PIN (3 ,18 ), +}; +static const unsigned int tsn0_avtp_capture_b_mux[] = { +TSN0_AVTP_CAPTURE_B_MARK , +}; +static const unsigned int tsn0_avtp_match_b_pins[] = { +/* TSN0_AVTP_MATCH_B */ +RCAR_GP_PIN (3 ,17 ), +}; +static const unsigned int tsn0_avtp_match_b_mux[] = { +TSN0_AVTP_MATCH_B_MARK , +}; + +/* - TSN1 ------------------------------------------------ */ +static const unsigned int tsn1_link_a_pins[] = { +/* TSN1_LINK_A */ +RCAR_GP_PIN (0 ,15 ), +}; +static const unsigned int tsn1_link_a_mux[] = { +TSN1_LINK_A_MARK , +}; +static const unsigned int tsn1_phy_int_a_pins[] = { +/* TSN1_PHY_INT_A */ +RCAR_GP_PIN (0 ,19 ), +}; +static const unsigned int tsn1_phy_int_a_mux[] = { +TSN1_PHY_INT_A_MARK , +}; +static const unsigned int tsn1_mdio_a_pins[] = { +/* TSN1_MDC_A, TSN1_MDIO_A */ +RCAR_GP_PIN (0 ,10 ),RCAR_GP_PIN (0 ,9 ), +}; +static const unsigned int tsn1_mdio_a_mux[] = { +TSN1_MDC_A_MARK ,TSN1_MDIO_A_MARK , +}; +static const unsigned int tsn1_link_b_pins[] = { +/* TSN1_LINK_B */ +RCAR_GP_PIN (3 ,6 ), +}; +static const unsigned int tsn1_link_b_mux[] = { +TSN1_LINK_B_MARK , +}; +static const unsigned int tsn1_phy_int_b_pins[] = { +/* TSN1_PHY_INT_B */ +RCAR_GP_PIN (3 ,11 ), +}; +static const unsigned int tsn1_phy_int_b_mux[] = { +TSN1_PHY_INT_B_MARK , +}; +static const unsigned int tsn1_mdio_b_pins[] = { +/* TSN1_MDC_B, TSN1_MDIO_B */ +RCAR_GP_PIN (3 ,5 ),RCAR_GP_PIN (3 ,0 ), +}; +static const unsigned int tsn1_mdio_b_mux[] = { +TSN1_MDC_B_MARK ,TSN1_MDIO_B_MARK , +}; +static const unsigned int tsn1_avtp_pps_pins[] = { +/* TSN1_AVTP_PPS */ +RCAR_GP_PIN (3 ,13 ), +}; +static const unsigned int tsn1_avtp_pps_mux[] = { +TSN0_AVTP_PPS_MARK , +}; +static const unsigned int tsn1_avtp_capture_a_pins[] = { +/* TSN1_AVTP_CAPTURE_A */ +RCAR_GP_PIN (0 ,7 ), +}; +static const unsigned int tsn1_avtp_capture_a_mux[] = { +TSN1_AVTP_CAPTURE_A_MARK , +}; +static const unsigned int tsn1_avtp_match_a_pins[] = { +/* TSN1_AVTP_MATCH_A */ +RCAR_GP_PIN (0 ,6 ), +}; +static const unsigned int tsn1_avtp_match_a_mux[] = { +TSN1_AVTP_MATCH_A_MARK , +}; +static const unsigned int tsn1_avtp_capture_b_pins[] = { +/* TSN1_AVTP_CAPTURE_B */ +RCAR_GP_PIN (3 ,15 ), +}; +static const unsigned int tsn1_avtp_capture_b_mux[] = { +TSN1_AVTP_CAPTURE_B_MARK , +}; +static const unsigned int tsn1_avtp_match_b_pins[] = { +/* TSN1_AVTP_MATCH_B */ +RCAR_GP_PIN (3 ,14 ), +}; +static const unsigned int tsn1_avtp_match_b_mux[] = { +TSN1_AVTP_MATCH_B_MARK , +}; + +/* - TSN2 ------------------------------------------------ */ +static const unsigned int tsn2_link_a_pins[] = { +/* TSN2_LINK_A */ +RCAR_GP_PIN (0 ,16 ), +}; +static const unsigned int tsn2_link_a_mux[] = { +TSN2_LINK_A_MARK , +}; +static const unsigned int tsn2_phy_int_a_pins[] = { +/* TSN2_PHY_INT_A */ +RCAR_GP_PIN (0 ,20 ), +}; +static const unsigned int tsn2_phy_int_a_mux[] = { +TSN2_PHY_INT_A_MARK , +}; +static const unsigned int tsn2_mdio_a_pins[] = { +/* TSN2_MDC_A, TSN2_MDIO_A */ +RCAR_GP_PIN (1 ,2 ),RCAR_GP_PIN (1 ,3 ), +}; +static const unsigned int tsn2_mdio_a_mux[] = { +TSN2_MDC_A_MARK ,TSN2_MDIO_A_MARK , +}; +static const unsigned int tsn2_link_b_pins[] = { +/* TSN2_LINK_B */ +RCAR_GP_PIN (3 ,7 ), +}; +static const unsigned int tsn2_link_b_mux[] = { +TSN2_LINK_B_MARK , +}; +static const unsigned int tsn2_phy_int_b_pins[] = { +/* TSN2_PHY_INT_B */ +RCAR_GP_PIN (3 ,9 ), +}; +static const unsigned int tsn2_phy_int_b_mux[] = { +TSN2_PHY_INT_B_MARK , +}; +static const unsigned int tsn2_mdio_b_pins[] = { +/* TSN2_MDC_B, TSN2_MDIO_B */ +RCAR_GP_PIN (3 ,3 ),RCAR_GP_PIN (3 ,1 ), +}; +static const unsigned int tsn2_mdio_b_mux[] = { +TSN2_MDC_B_MARK ,TSN2_MDIO_B_MARK , +}; +static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (hscif0_data),SH_PFC_PIN_GROUP (hscif0_clk),
@@ -1131,6 +1347,36 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {SH_PFC_PIN_GROUP (scif4_clk),SH_PFC_PIN_GROUP (scif4_ctrl ),SH_PFC_PIN_GROUP (scif_clk ), +SH_PFC_PIN_GROUP (tsn0_link_a ), +SH_PFC_PIN_GROUP (tsn0_magic_a ), +SH_PFC_PIN_GROUP (tsn0_phy_int_a ), +SH_PFC_PIN_GROUP (tsn0_mdio_a ), +SH_PFC_PIN_GROUP (tsn0_link_b ), +SH_PFC_PIN_GROUP (tsn0_magic_b ), +SH_PFC_PIN_GROUP (tsn0_phy_int_b ), +SH_PFC_PIN_GROUP (tsn0_mdio_b ), +SH_PFC_PIN_GROUP (tsn0_avtp_pps ), +SH_PFC_PIN_GROUP (tsn0_avtp_capture_a ), +SH_PFC_PIN_GROUP (tsn0_avtp_match_a ), +SH_PFC_PIN_GROUP (tsn0_avtp_capture_b ), +SH_PFC_PIN_GROUP (tsn0_avtp_match_b ), +SH_PFC_PIN_GROUP (tsn1_link_a ), +SH_PFC_PIN_GROUP (tsn1_phy_int_a ), +SH_PFC_PIN_GROUP (tsn1_mdio_a ), +SH_PFC_PIN_GROUP (tsn1_link_b ), +SH_PFC_PIN_GROUP (tsn1_phy_int_b ), +SH_PFC_PIN_GROUP (tsn1_mdio_b ), +SH_PFC_PIN_GROUP (tsn1_avtp_pps ), +SH_PFC_PIN_GROUP (tsn1_avtp_capture_a ), +SH_PFC_PIN_GROUP (tsn1_avtp_match_a ), +SH_PFC_PIN_GROUP (tsn1_avtp_capture_b ), +SH_PFC_PIN_GROUP (tsn1_avtp_match_b ), +SH_PFC_PIN_GROUP (tsn2_link_a ), +SH_PFC_PIN_GROUP (tsn2_phy_int_a ), +SH_PFC_PIN_GROUP (tsn2_mdio_a ), +SH_PFC_PIN_GROUP (tsn2_link_b ), +SH_PFC_PIN_GROUP (tsn2_phy_int_b ), + SH_PFC_PIN_GROUP(tsn2_mdio_b), };static const char *const hscif0_groups[] = {
@@ -1281,6 +1527,45 @@ static const char * const scif_clk_groups[] = { "scif_clk", }; +static const char *const tsn0_groups[] = { +"tsn0_link_a" , +"tsn0_magic_a" , +"tsn0_phy_int_a" , +"tsn0_mdio_a" , +"tsn0_link_b" , +"tsn0_magic_b" , +"tsn0_phy_int_b" , +"tsn0_mdio_b" , +"tsn0_avtp_pps" , +"tsn0_avtp_capture_a" , +"tsn0_avtp_match_a" , +"tsn0_avtp_capture_b" , +"tsn0_avtp_match_b" , +}; + +static const char *const tsn1_groups[] = { +"tsn1_link_a" , +"tsn1_phy_int_a" , +"tsn1_mdio_a" , +"tsn1_link_b" , +"tsn1_phy_int_b" , +"tsn1_mdio_b" , +"tsn1_avtp_pps" , +"tsn1_avtp_capture_a" , +"tsn1_avtp_match_a" , +"tsn1_avtp_capture_b" , +"tsn1_avtp_match_b" , +}; + +static const char *const tsn2_groups[] = { +"tsn2_link_a" , +"tsn2_phy_int_a" , +"tsn2_mdio_a" , +"tsn2_link_b" , +"tsn2_phy_int_b" , +"tsn2_mdio_b" , +}; +static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (hscif0),SH_PFC_FUNCTION (hscif1),
@@ -1306,6 +1591,9 @@ static const struct sh_pfc_function pinmux_functions[] = {SH_PFC_FUNCTION (scif3),SH_PFC_FUNCTION (scif4 ),SH_PFC_FUNCTION (scif_clk ), +SH_PFC_FUNCTION (tsn0 ), +SH_PFC_FUNCTION (tsn1 ), + SH_PFC_FUNCTION(tsn2), };static const struct pinmux_cfg_reg pinmux_config_regs[] = {
Signature · 1 line
2.25.1
Hi Geert-san,
Quoted 16 lines
From: Geert Uytterhoeven, Sent: Tuesday, February 22, 2022 12:44 AM
Hi all,
This patch series adds pin control support for the Renesas R-Car S4-8 Soc. It is based on patches in the BSP by LUU HOAI, with many changes on top (see the individual patches).
Changes compared to v1[1]:
- Add Reviewed-by,
- Fix whitespace inMakefile,
- Remove GPIO and No-GPIO pins, pin function definitions, and registers that can only be accessed from the Control Domain,
- Spin off clock and DTS patches into separate series,
- Drop RFC state and widen audience.
Quoted 4 lines
Serial console and I2C have been tested on the Renesas Spider development board.
Thanks for your comments!
Thank you for the patch!
Quoted 4 lines
Geert Uytterhoeven (11):
pinctrl: renesas: AddPORT_GP_CFG_19macros
pinctrl: renesas: Initial R8A779F0 PFC support
pinctrl: renesas: r8a779f0: Add SCIF pins, groups, and functions
I have already reviewed these patches above independently on v1 or v2.
Quoted 8 lines
pinctrl: renesas: r8a779f0: Add I2C pins, groups, and functions
pinctrl: renesas: r8a779f0: Add HSCIF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add INTC-EX pins, groups, and function
pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
pinctrl: renesas: r8a779f0: Add MSIOF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add PCIe pins, groups, and function
pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
pinctrl: renesas: r8a779f0: Add Ethernet pins, groups, and functions
These patches (4/12 to 12/12) look good to me. So, for the patches:
Best regards,
Yoshihiro Shimoda
Hi Shimoda-san,
Quoted 36 lines · Yoshihiro Shimoda
Quoted 13 lines
From: Geert Uytterhoeven, Sent: Tuesday, February 22, 2022 12:44 AM This patch series adds pin control support for the Renesas R-Car S4-8 Soc. It is based on patches in the BSP by LUU HOAI, with many changes on top (see the individual patches).
Changes compared to v1[1]:
- Add Reviewed-by,
- Fix whitespace inMakefile,
- Remove GPIO and No-GPIO pins, pin function definitions, and registers that can only be accessed from the Control Domain,
- Spin off clock and DTS patches into separate series,
- Drop RFC state and widen audience.Quoted 4 lines
Serial console and I2C have been tested on the Renesas Spider development board.
Thanks for your comments!
Thank you for the patch!
Quoted 4 lines
Geert Uytterhoeven (11):
pinctrl: renesas: AddPORT_GP_CFG_19macros
pinctrl: renesas: Initial R8A779F0 PFC support
pinctrl: renesas: r8a779f0: Add SCIF pins, groups, and functionsI have already reviewed these patches above independently on v1 or v2.
Quoted 8 lines
pinctrl: renesas: r8a779f0: Add I2C pins, groups, and functions
pinctrl: renesas: r8a779f0: Add HSCIF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add INTC-EX pins, groups, and function
pinctrl: renesas: r8a779f0: Add MMC pins, groups, and function
pinctrl: renesas: r8a779f0: Add MSIOF pins, groups, and functions
pinctrl: renesas: r8a779f0: Add PCIe pins, groups, and function
pinctrl: renesas: r8a779f0: Add QSPI pins, groups, and functions
pinctrl: renesas: r8a779f0: Add Ethernet pins, groups, and functions
Quoted 3 lines
These patches (4/12 to 12/12) look good to me. So, for the patches:
Reviewed-by Yoshihiro Shimoda <[email protected]>
Thank you, queuing in renesas-pinctrl-for-v5.18.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds