Skip to contentSkip to conversation

net: psp: select CONFIG_SKB_EXTENSIONS

PATCH Applied Arnd Bergmann 4 participants 4 messages Feb 16 – Feb 18

Subsystems (3)
Networking Network drivers Psp security protocol
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 net: psp: select CONFIG_SKB_EXTENSIONS

From: Arnd Bergmann <[email protected]>

psp now uses skb extensions, failing to build when that is disabled:

In file included from include/net/psp.h:7,

                 from net/psp/psp_sock.c:9:
include/net/psp/functions.h: In function '__psp_skb_coalesce_diff':
include/net/psp/functions.h:60:13: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Wimplicit-function-declaration]
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |             ^~~~~~~~~~~~
      |             skb_ext_copy
include/net/psp/functions.h:60:31: error: 'SKB_EXT_PSP' undeclared (first use in this function)
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |                               ^~~~~~~~~~~

include/net/psp/functions.h:60:31: note: each undeclared identifier is reported only once for each function it appears in include/net/psp/functions.h: In function '__psp_sk_rx_policy_check':
include/net/psp/functions.h:94:53: error: 'SKB_EXT_PSP' undeclared (first use in this function)
94 | struct psp_skb_ext *pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~
net/psp/psp_sock.c: In function 'psp_sock_recv_queue_check':
net/psp/psp_sock.c:164:41: error: 'SKB_EXT_PSP' undeclared (first use in this function)
164 | pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~

Select the Kconfig symbol as we do from its other users.

Fixes 6b46ca260e22 ("net: psp: add socket security association code")
Signed-off-by Arnd Bergmann <[email protected]>
---
 net/psp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
net/psp/Kconfig +1 -0
index 371e8771f3bd..84d6b0f25460 100644
@@ -6,6 +6,7 @@ config INET_PSP
 	bool "PSP Security Protocol support"
 	depends on INET
 	select SKB_DECRYPTED
+	select SKB_EXTENSIONS
 	select SOCK_VALIDATE_XMIT
 	help
 	Enable kernel support for the PSP Security Protocol (PSP).
Signature · 1 line
2.39.5
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 37 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

psp now uses skb extensions, failing to build when that is disabled:

In file included from include/net/psp.h:7,

                 from net/psp/psp_sock.c:9:
include/net/psp/functions.h: In function '__psp_skb_coalesce_diff':
include/net/psp/functions.h:60:13: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Wimplicit-function-declaration]
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |             ^~~~~~~~~~~~
      |             skb_ext_copy
include/net/psp/functions.h:60:31: error: 'SKB_EXT_PSP' undeclared (first use in this function)
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |                               ^~~~~~~~~~~

include/net/psp/functions.h:60:31: note: each undeclared identifier is reported only once for each function it appears in include/net/psp/functions.h: In function '__psp_sk_rx_policy_check':
include/net/psp/functions.h:94:53: error: 'SKB_EXT_PSP' undeclared (first use in this function)
94 | struct psp_skb_ext *pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~
net/psp/psp_sock.c: In function 'psp_sock_recv_queue_check':
net/psp/psp_sock.c:164:41: error: 'SKB_EXT_PSP' undeclared (first use in this function)
164 | pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~

Select the Kconfig symbol as we do from its other users.

Fixes 6b46ca260e22 ("net: psp: add socket security association code")
Signed-off-by Arnd Bergmann <[email protected]>
---
 net/psp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
net/psp/Kconfig +0 -0
index 371e8771f3bd..84d6b0f25460 100644

net/psp/Kconfig config INET_PSP · line 12

Quoted 7 lines
net/psp/Kconfig +1 -0
@@ -6,6 +6,7 @@ config INET_PSP
 	bool "PSP Security Protocol support"
 	depends on INET
 	select SKB_DECRYPTED
+	select SKB_EXTENSIONS
 	select SOCK_VALIDATE_XMIT
 	help
 	Enable kernel support for the PSP Security Protocol (PSP).

I agree that the is written in such a way that it assumes this is available. And select is an appropriate way to do so.

Reviewed-by Simon Horman <[email protected]>
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 37 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

psp now uses skb extensions, failing to build when that is disabled:

In file included from include/net/psp.h:7,

                  from net/psp/psp_sock.c:9:
include/net/psp/functions.h: In function '__psp_skb_coalesce_diff':
include/net/psp/functions.h:60:13: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Wimplicit-function-declaration]
    60 |         a = skb_ext_find(one, SKB_EXT_PSP);
       |             ^~~~~~~~~~~~
       |             skb_ext_copy
include/net/psp/functions.h:60:31: error: 'SKB_EXT_PSP' undeclared (first use in this function)
    60 |         a = skb_ext_find(one, SKB_EXT_PSP);
       |                               ^~~~~~~~~~~
include/net/psp/functions.h:60:31: note: each undeclared identifier is reported only once for each function it appears in
include/net/psp/functions.h: In function '__psp_sk_rx_policy_check':
include/net/psp/functions.h:94:53: error: 'SKB_EXT_PSP' undeclared (first use in this function)
    94 |         struct psp_skb_ext *pse = skb_ext_find(skb, SKB_EXT_PSP);
       |                                                     ^~~~~~~~~~~

net/psp/psp_sock.c: In function 'psp_sock_recv_queue_check':
net/psp/psp_sock.c:164:41: error: 'SKB_EXT_PSP' undeclared (first use in this function)
164 | pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~

Select the Kconfig symbol as we do from its other users.

Fixes 6b46ca260e22 ("net: psp: add socket security association code")
Signed-off-by Arnd Bergmann <[email protected]>
---
  net/psp/Kconfig | 1 +
  1 file changed, 1 insertion(+)
net/psp/Kconfig +0 -0
index 371e8771f3bd..84d6b0f25460 100644

net/psp/Kconfig config INET_PSP · line 12

Quoted 7 lines
net/psp/Kconfig +1 -0
@@ -6,6 +6,7 @@ config INET_PSP
  	bool "PSP Security Protocol support"
  	depends on INET
  	select SKB_DECRYPTED
+	select SKB_EXTENSIONS
  	select SOCK_VALIDATE_XMIT
  	help
  	Enable kernel support for the PSP Security Protocol (PSP).

Indeed that is and has always been a mandatory config dependency for psp.

Reviewed-by Daniel Zahka <[email protected]>
CI Applied
#3 lore raw
In reply to Arnd Bergmann
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 24 lines · On Mon, 16 Feb 2026 11:54:54 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

psp now uses skb extensions, failing to build when that is disabled:

In file included from include/net/psp.h:7,

                 from net/psp/psp_sock.c:9:
include/net/psp/functions.h: In function '__psp_skb_coalesce_diff':
include/net/psp/functions.h:60:13: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Wimplicit-function-declaration]
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |             ^~~~~~~~~~~~
      |             skb_ext_copy
include/net/psp/functions.h:60:31: error: 'SKB_EXT_PSP' undeclared (first use in this function)
   60 |         a = skb_ext_find(one, SKB_EXT_PSP);
      |                               ^~~~~~~~~~~

include/net/psp/functions.h:60:31: note: each undeclared identifier is reported only once for each function it appears in include/net/psp/functions.h: In function '__psp_sk_rx_policy_check':
include/net/psp/functions.h:94:53: error: 'SKB_EXT_PSP' undeclared (first use in this function)
94 | struct psp_skb_ext *pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~
net/psp/psp_sock.c: In function 'psp_sock_recv_queue_check':
net/psp/psp_sock.c:164:41: error: 'SKB_EXT_PSP' undeclared (first use in this function)
164 | pse = skb_ext_find(skb, SKB_EXT_PSP);
| ^~~~~~~~~~~

Quoted 1 line

[...]

Here is the summary with links:
- net: psp: select CONFIG_SKB_EXTENSIONS

    https://git.kernel.org/netdev/net/c/6e980df45216

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html