Skip to contentSkip to conversation

mm/debug_vm_pgtable: Fix kernel crash with page table validate

PATCH In review Aneesh Kumar K.V 2 participants 4 messages Jun 8, 2020 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/debug_vm_pgtable: Fix kernel crash with page table validate

Architectures can have CONFIG_TRANSPARENT_HUGEPAGE enabled but no THP support enabled based on platforms. For ex: with 4K PAGE_SIZE ppc64 supports THP only with radix translation.

This results in below crash when running with hash translation and 4K PAGE_SIZE.

kernel BUG at arch/powerpc/include/asm/book3s/64/hash-4k.h:140! cpu 0x61: Vector: 700 (Program Check) at [c000000ff948f860]

    pc: c0000000018810f8: debug_vm_pgtable+0x480/0x8b0
    lr: c0000000018810ec: debug_vm_pgtable+0x474/0x8b0

...
[c000000ff948faf0] c000000001880fec debug_vm_pgtable+0x374/0x8b0 (unreliable) [c000000ff948fbf0] c000000000011648 do_one_initcall+0x98/0x4f0 [c000000ff948fcd0] c000000001843928 kernel_init_freeable+0x330/0x3fc [c000000ff948fdb0] c0000000000122ac kernel_init+0x24/0x148 [c000000ff948fe20] c00000000000cc44 ret_from_kernel_thread+0x5c/0x78

Check for THP support correctly

Fixes 399145f9eb6c ("mm/debug: add tests validating architecture page table helpers")
---
 mm/debug_vm_pgtable.c | 3 +++
 1 file changed, 3 insertions(+)
mm/debug_vm_pgtable.c +3 -0
index 188c18908964..e60151c5e997 100644
@@ -61,6 +61,9 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
 {
 	pmd_t pmd = pfn_pmd(pfn, prot);
 
+	if (!has_transparent_hugepage())
+		return;
+
 	WARN_ON(!pmd_same(pmd, pmd));
 	WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd))));
 	WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd))));
Signature · 1 line
2.26.2
#1 lore raw

Hi Aneesh,

Quoted 3 lines · Aneesh Kumar K.V

Architectures can have CONFIG_TRANSPARENT_HUGEPAGE enabled but no THP support enabled based on platforms. For ex: with 4K PAGE_SIZE ppc64 supports THP only with radix translation.

Good catch, never hit this before.

Quoted 8 lines

This results in below crash when running with hash translation and 4K PAGE_SIZE.

kernel BUG at arch/powerpc/include/asm/book3s/64/hash-4k.h:140! cpu 0x61: Vector: 700 (Program Check) at [c000000ff948f860]

    pc: c0000000018810f8: debug_vm_pgtable+0x480/0x8b0
    lr: c0000000018810ec: debug_vm_pgtable+0x474/0x8b0
Quoted 8 lines

...
[c000000ff948faf0] c000000001880fec debug_vm_pgtable+0x374/0x8b0 (unreliable) [c000000ff948fbf0] c000000000011648 do_one_initcall+0x98/0x4f0 [c000000ff948fcd0] c000000001843928 kernel_init_freeable+0x330/0x3fc [c000000ff948fdb0] c0000000000122ac kernel_init+0x24/0x148 [c000000ff948fe20] c00000000000cc44 ret_from_kernel_thread+0x5c/0x78

Check for THP support correctly

Makes sense, is this the only configuration which hit the problem ?

Quoted 13 lines
Fixes 399145f9eb6c ("mm/debug: add tests validating architecture page table helpers")
---
 mm/debug_vm_pgtable.c | 3 +++
 1 file changed, 3 insertions(+)
mm/debug_vm_pgtable.c +0 -0
index 188c18908964..e60151c5e997 100644

mm/debug_vm_pgtable.c static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) · line 66

Quoted 6 lines
mm/debug_vm_pgtable.c +3 -0
@@ -61,6 +61,9 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
 {
 	pmd_t pmd = pfn_pmd(pfn, prot);
 
+	if (!has_transparent_hugepage())
+		return;
+

We should also add this check to pud_basic_tests() as well.

mm/debug_vm_pgtable.c static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) · line 69

Quoted 4 lines
mm/debug_vm_pgtable.c +0 -0
 	WARN_ON(!pmd_same(pmd, pmd));
 	WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd))));
 	WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd))));

The subject line here should mention about correct THP support detection which fixes the problem. Probably something like this or similar ("Fix kernel crash with correct THP support check").

- Anshuman

#2 lore raw
Quoted 24 lines · Anshuman Khandual

Hi Aneesh,

Quoted 3 lines · Aneesh Kumar K.V

Architectures can have CONFIG_TRANSPARENT_HUGEPAGE enabled but no THP support enabled based on platforms. For ex: with 4K PAGE_SIZE ppc64 supports THP only with radix translation.

Good catch, never hit this before.

Quoted 15 lines

This results in below crash when running with hash translation and 4K PAGE_SIZE.

kernel BUG at arch/powerpc/include/asm/book3s/64/hash-4k.h:140! cpu 0x61: Vector: 700 (Program Check) at [c000000ff948f860]

     pc: c0000000018810f8: debug_vm_pgtable+0x480/0x8b0
     lr: c0000000018810ec: debug_vm_pgtable+0x474/0x8b0

...
[c000000ff948faf0] c000000001880fec debug_vm_pgtable+0x374/0x8b0 (unreliable) [c000000ff948fbf0] c000000000011648 do_one_initcall+0x98/0x4f0 [c000000ff948fcd0] c000000001843928 kernel_init_freeable+0x330/0x3fc [c000000ff948fdb0] c0000000000122ac kernel_init+0x24/0x148 [c000000ff948fe20] c00000000000cc44 ret_from_kernel_thread+0x5c/0x78

Quoted 3 lines
Quoted 1 line

Check for THP support correctly

Makes sense, is this the only configuration which hit the problem ?

4K hash ppc64 is the only config i guess.

Quoted 17 lines
Quoted 17 lines
Fixes 399145f9eb6c ("mm/debug: add tests validating architecture page table helpers")
---
  mm/debug_vm_pgtable.c | 3 +++
  1 file changed, 3 insertions(+)
mm/debug_vm_pgtable.c +0 -0
index 188c18908964..e60151c5e997 100644
@@ -61,6 +61,9 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
  {
  	pmd_t pmd = pfn_pmd(pfn, prot);
 
Quoted 5 lines

mm/debug_vm_pgtable.c static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) · line 66

Quoted 3 lines
mm/debug_vm_pgtable.c +3 -0
+	if (!has_transparent_hugepage())
+		return;
+

We should also add this check to pud_basic_tests() as well.

Do we have a function that check for runtime support for pud level THP? ppc64 don't do pud level THP yet. So we have CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD=n

are you suggesting we do the same check for pud level THP too?

Quoted 9 lines

mm/debug_vm_pgtable.c static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) · line 69

Quoted 5 lines
mm/debug_vm_pgtable.c +0 -0
  	WARN_ON(!pmd_same(pmd, pmd));
  	WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd))));
  	WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd))));

The subject line here should mention about correct THP support detection which fixes the problem. Probably something like this or similar ("Fix kernel crash with correct THP support check").

Not sure about that. This fix a kernel crash with page table validate code.

-aneesh

#3 lore raw
Quoted 25 lines · Aneesh Kumar K.V
Quoted 24 lines · Anshuman Khandual

Hi Aneesh,

Quoted 3 lines · Aneesh Kumar K.V

Architectures can have CONFIG_TRANSPARENT_HUGEPAGE enabled but no THP support enabled based on platforms. For ex: with 4K PAGE_SIZE ppc64 supports THP only with radix translation.

Good catch, never hit this before.

Quoted 15 lines

This results in below crash when running with hash translation and 4K PAGE_SIZE.

kernel BUG at arch/powerpc/include/asm/book3s/64/hash-4k.h:140! cpu 0x61: Vector: 700 (Program Check) at [c000000ff948f860]
     pc: c0000000018810f8: debug_vm_pgtable+0x480/0x8b0
     lr: c0000000018810ec: debug_vm_pgtable+0x474/0x8b0
...
[c000000ff948faf0] c000000001880fec debug_vm_pgtable+0x374/0x8b0 (unreliable) [c000000ff948fbf0] c000000000011648 do_one_initcall+0x98/0x4f0 [c000000ff948fcd0] c000000001843928 kernel_init_freeable+0x330/0x3fc [c000000ff948fdb0] c0000000000122ac kernel_init+0x24/0x148 [c000000ff948fe20] c00000000000cc44 ret_from_kernel_thread+0x5c/0x78

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Check for THP support correctly

Makes sense, is this the only configuration which hit the problem ?

4K hash ppc64 is the only config i guess.

Okay.

Quoted 24 lines
Quoted 10 lines
Quoted 10 lines
Fixes 399145f9eb6c ("mm/debug: add tests validating architecture page table helpers")

---
  mm/debug_vm_pgtable.c | 3 +++

  1 file changed, 3 insertions(+)
Quoted 12 lines

mm/debug_vm_pgtable.c static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) · line 65

Quoted 10 lines
mm/debug_vm_pgtable.c +2 -0
index 188c18908964..e60151c5e997 100644
@@ -61,6 +61,9 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
   {
       pmd_t pmd = pfn_pmd(pfn, prot);
   +    if (!has_transparent_hugepage())
+        return;
+

We should also add this check to pud_basic_tests() as well.

Quoted 2 lines

Do we have a function that check for runtime support for pud level THP? ppc64 don't do pud level THP yet. So  we have CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD=n

I believe, we dont have such a generic function. Please correct me, if I am missing something here.

Quoted 2 lines

are you suggesting we do the same check for pud level THP too?

Yes. Because regardless CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD, could there be any THP at PUD level when has_transparent_hugepage() returns negative ? The current dependency between THP and PUD THP configs seems some what confusing but having this check at PUD level should protect against similar problems. A quick test (after adding this check to PUD level) on x86 does not indicate any problem on the normal path.

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
mm/debug_vm_pgtable.c +0 -0
       WARN_ON(!pmd_same(pmd, pmd));
       WARN_ON(!pmd_young(pmd_mkyoung(pmd_mkold(pmd))));
       WARN_ON(!pmd_dirty(pmd_mkdirty(pmd_mkclean(pmd))));
Quoted 6 lines
Quoted 3 lines

The subject line here should mention about correct THP support detection which fixes the problem. Probably something like this or similar ("Fix kernel crash with correct THP support check").

Not sure about that. This fix a kernel crash with page table validate code.

What this fixes is very clear from the prefix itself - "mm/debug_vm_pgtable:", making "page table validate" some what bit redundant. Instead, it could just accommodate method of the fix i.e "via correct THP support check". Nonetheless, it is just a small nit.