Skip to contentSkip to conversation

dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property

PATCH Applied Rob Herring (Arm) 3 participants 3 messages Aug 7, 2025 – Aug 8, 2025

Subsystems (3)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: ipmi: aspeed,ast2400-kcs-bmc: Add missing "clocks" property

The ASpeed kcs-bmc nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source and some of the drivers manage their clock. Perhaps it is the parent device that should have the clock, but it's too late for that.

---
 .../devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml       | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/ipmi/aspeed,ast2400-kcs-bmc.yaml +3 -0
index 129e32c4c774..610c79863208 100644
@@ -40,6 +40,9 @@ properties:
       - description: ODR register
       - description: STR register
 
+  clocks:
+    maxItems: 1
+
   aspeed,lpc-io-reg:
     $ref: /schemas/types.yaml#/definitions/uint32-array
     minItems: 1
Signature · 1 line
2.47.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Rob Herring (Arm)

The ASpeed kcs-bmc nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source and some of the drivers manage their clock. Perhaps it is the parent device that should have the clock, but it's too late for that.

Thanks Rob.

maintainer Applied
#2 lore raw
Quoted 11 lines · Andrew Jeffery
Quoted 6 lines · Rob Herring (Arm)

The ASpeed kcs-bmc nodes have a "clocks" property which isn't documented. It looks like all the LPC child devices have the same clock source and some of the drivers manage their clock. Perhaps it is the parent device that should have the clock, but it's too late for that.

Thanks Rob.

Queued for 4.18, I'll add it to the next tree when 4.17-rc1 releases.

Thanks,

-corey