Skip to contentSkip to conversation

drm/tegra: vic: Do not clear driver data

PATCH In review Thierry Reding 2 participants 2 messages Jan 23, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tegra: vic: Do not clear driver data

From: Thierry Reding <[email protected]>

Upon driver failure, the driver core will take care of clearing the driver data, so there's no need to do so explicitly in the driver.

---
 drivers/gpu/drm/tegra/vic.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tegra/vic.c +0 -1
index 9cb10d1e923a..d20fcbf6196d 100644
@@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
 	err = host1x_client_register(&vic->client.base);
 	if (err < 0) {
 		dev_err(dev, "failed to register host1x client: %d\n", err);
-		platform_set_drvdata(pdev, NULL);
 		goto exit_falcon;
 	}
 
Signature · 6 lines
2.19.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

23.01.2019 16:42, Thierry Reding пишет:

Quoted 16 lines

From: Thierry Reding <[email protected]>

Upon driver failure, the driver core will take care of clearing the driver data, so there's no need to do so explicitly in the driver.

---
 drivers/gpu/drm/tegra/vic.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/tegra/vic.c +0 -0
index 9cb10d1e923a..d20fcbf6196d 100644

drivers/gpu/drm/tegra/vic.c static int vic_probe(struct platform_device *pdev) · line 417

Quoted 7 lines
drivers/gpu/drm/tegra/vic.c +0 -1
@@ -412,7 +412,6 @@ static int vic_probe(struct platform_device *pdev)
 	err = host1x_client_register(&vic->client.base);
 	if (err < 0) {
 		dev_err(dev, "failed to register host1x client: %d\n", err);
-		platform_set_drvdata(pdev, NULL);
 		goto exit_falcon;
 	}
 

Looks good,

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel