Skip to contentSkip to conversation

package/boost: disable logs with riscv32

PATCH New Fabrice Fontaine 3 participants 5 messages May 21, 2021 – Jun 9, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/boost: disable logs with riscv32

boost logs can't be built with riscv32 because it unconditionally uses __NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

---
 package/azmq/Config.in  | 3 +++
 package/boost/Config.in | 3 +++
 2 files changed, 6 insertions(+)
package/azmq/Config.in +3 -0
index 37131a260a..6751d533a4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_AZMQ
 	bool "azmq"
+	depends on !BR2_RISCV_32 # boost-log
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
@@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
 	  https://github.com/zeromq/azmq
 
 comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
 		&& BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
 
 comment "azmq needs exception_ptr"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
package/boost/Config.in +3 -0
index 3e96e1ede3..75bb81600a 100644
@@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
 
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
@@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
 	  Logging library.
 
 comment "boost-log needs a toolchain w/ NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
 comment "boost-log needs a toolchain not affected by GCC bug 64735"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_BOOST_MATH
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/boost: disable logs with riscv32

Quoted 7 lines · Fabrice Fontaine

boost logs can't be built with riscv32 because it unconditionally uses __NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~

There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].
Could you handle that as well?

Regards,
Arnout

[1]
http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log

Quoted 57 lines

Fixes:
- http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

---
 package/azmq/Config.in  | 3 +++
 package/boost/Config.in | 3 +++
 2 files changed, 6 insertions(+)
package/azmq/Config.in +3 -0
index 37131a260a..6751d533a4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_AZMQ
 	bool "azmq"
+	depends on !BR2_RISCV_32 # boost-log
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
@@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
 	  https://github.com/zeromq/azmq
 
 comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
 		&& BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
 
 comment "azmq needs exception_ptr"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
package/boost/Config.in +3 -0
index 3e96e1ede3..75bb81600a 100644
@@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
 
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
+	depends on !BR2_RISCV_32>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
 	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
@@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
 	  Logging library.
 
 comment "boost-log needs a toolchain w/ NPTL"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
 comment "boost-log needs a toolchain not affected by GCC bug 64735"
+	depends on !BR2_RISCV_32
 	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_BOOST_MATH
#2 lore raw

PATCH 1/1 package/boost: disable logs with riscv32

Hi Arnout,

Le mar. 25 mai 2021 ? 21:27, Arnout Vandecappelle <[email protected]> a ?crit :

Quoted 13 lines · Fabrice Fontaine
Quoted 7 lines

boost logs can't be built with riscv32 because it unconditionally uses __NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~

There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].

The link that you've given is also raised by log, not atomic:

- log : building

libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~
Quoted 63 lines

Could you handle that as well?

Regards,
Arnout

[1]
http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log

Quoted 52 lines

Fixes:
- http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

---
 package/azmq/Config.in  | 3 +++
 package/boost/Config.in | 3 +++
 2 files changed, 6 insertions(+)
package/azmq/Config.in +3 -0
index 37131a260a..6751d533a4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_AZMQ
      bool "azmq"
+     depends on !BR2_RISCV_32 # boost-log
      depends on BR2_INSTALL_LIBSTDCPP
      depends on BR2_TOOLCHAIN_HAS_ATOMIC
      depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
@@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
        https://github.com/zeromq/azmq
 
 comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
      depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
              && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
 
 comment "azmq needs exception_ptr"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
package/boost/Config.in +2 -0
index 3e96e1ede3..75bb81600a 100644
@@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
 
 config BR2_PACKAGE_BOOST_LOG
      bool "boost-log"
+     depends on !BR2_RISCV_32>       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
      depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
@@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
        Logging library.
 
 comment "boost-log needs a toolchain w/ NPTL"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
      depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
Quoted 8 lines

package/boost/Config.in config BR2_PACKAGE_BOOST_LOG · line 265

Quoted 5 lines
package/boost/Config.in +1 -0
 comment "boost-log needs a toolchain not affected by GCC bug 64735"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_BOOST_MATH

Best Regards,

Fabrice

#3 lore raw

PATCH 1/1 package/boost: disable logs with riscv32

Quoted 15 lines · Fabrice Fontaine

Hi Arnout,

Le mar. 25 mai 2021 ? 21:27, Arnout Vandecappelle <[email protected]> a ?crit :

Quoted 12 lines · Fabrice Fontaine
Quoted 7 lines

boost logs can't be built with riscv32 because it unconditionally uses __NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~
Quoted 8 lines
Quoted 1 line

There seems to be a similar issue in boost/atomic/detail/futex.hpp, e.g. [1].

The link that you've given is also raised by log, not atomic:

- log : building

libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

      |                             ^~~~~~~~~~

Ah, my bad. atomic/detail/futex.h has pretty much the same code, but it also
defines BOOST_ATOMIC_DETAIL_HAS_FUTEX and its users check that.

Applied to master, thanks.

Regards,
Arnout

Quoted 75 lines
Quoted 63 lines

Could you handle that as well?

Regards,
Arnout

[1]
http://autobuild.buildroot.net/results/6aa/6aa7ac8b14c3ba4f674d541fabb4476680b299a7/build-end.log

Quoted 52 lines

Fixes:
- http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

---
 package/azmq/Config.in  | 3 +++
 package/boost/Config.in | 3 +++
 2 files changed, 6 insertions(+)
package/azmq/Config.in +3 -0
index 37131a260a..6751d533a4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_AZMQ
      bool "azmq"
+     depends on !BR2_RISCV_32 # boost-log
      depends on BR2_INSTALL_LIBSTDCPP
      depends on BR2_TOOLCHAIN_HAS_ATOMIC
      depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # boost-log
@@ -22,9 +23,11 @@ config BR2_PACKAGE_AZMQ
        https://github.com/zeromq/azmq
 
 comment "azmq needs a toolchain w/ C++11, wchar and NPTL"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
      depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 \
              && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS_NPTL)
 
 comment "azmq needs exception_ptr"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
package/boost/Config.in +2 -0
index 3e96e1ede3..75bb81600a 100644
@@ -240,6 +240,7 @@ comment "boost-locale needs a toolchain not affected by GCC bug 64735"
 
 config BR2_PACKAGE_BOOST_LOG
      bool "boost-log"
+     depends on !BR2_RISCV_32>       depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
      depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # boost-thread
@@ -253,10 +254,12 @@ config BR2_PACKAGE_BOOST_LOG
        Logging library.
 
 comment "boost-log needs a toolchain w/ NPTL"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
      depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
 
Quoted 8 lines

package/boost/Config.in config BR2_PACKAGE_BOOST_LOG · line 265

Quoted 5 lines
package/boost/Config.in +1 -0
 comment "boost-log needs a toolchain not affected by GCC bug 64735"
+     depends on !BR2_RISCV_32
      depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 
 config BR2_PACKAGE_BOOST_MATH

Best Regards,

Fabrice

#4 lore raw

PATCH 1/1 package/boost: disable logs with riscv32

In reply to Fabrice Fontaine
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

boost logs can't be built with riscv32 because it unconditionally uses __NR_futex:

libs/log/src/event.cpp: In member function 'void boost::log::v2_mt_posix::aux::futex_based_event::wait()':
libs/log/src/event.cpp:38:29: error: '__NR_futex' was not declared in this scope
38 | #define BOOST_LOG_SYS_FUTEX __NR_futex

Quoted 6 lines
      |                             ^~~~~~~~~~

Fixes:
- http://autobuild.buildroot.org/results/8c8135fd7c0517c66c9b3975c494da6d7934cc1b

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard