checkpatch: recognize Assisted-by: tag
PATCH 1/1 checkpatch: recognize Assisted-by: tag
Documentation/process/coding-assistants.rst defines an Assisted-by:
trailer for disclosing AI coding tool assistance. Recognize it and skip Name <email> validation; format is AGENT_NAME:MODEL_VERSION.
--- scripts/checkpatch.pl | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +6 -2
@@ -641,6 +641,7 @@ our $signature_tags = qr{(?xi: Reviewed-by:| Reported-by:| Suggested-by:| + Assisted-by:| To:| Cc: )};
@@ -737,7 +738,7 @@ sub find_standard_signature { my ($sign_off) = @_; my @standard_signature_tags = ( 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:', - 'Reviewed-by:', 'Reported-by:', 'Suggested-by:' + 'Reviewed-by:', 'Reported-by:', 'Suggested-by:', 'Assisted-by:' ); foreach my $signature (@standard_signature_tags) { return $signature if (get_edit_distance($sign_off, $signature) <= 2);
@@ -3107,7 +3108,10 @@ sub process { my ($email_name, $name_comment, $email_address, $comment) = parse_email($email); my $suggested_email = format_email(($email_name, $name_comment, $email_address, $comment)); - if ($suggested_email eq "") { + if ($sign_off =~ /^assisted-by:$/i) { + # Assisted-by: uses AGENT_NAME:MODEL_VERSION + # format, not Name <email>. + } elsif ($suggested_email eq "") { ERROR("BAD_SIGN_OFF", "Unrecognized email address: '$email'\n" . $herecurr); } else {
--
2.49.0
Joe Perches
maintainerQuoted 3 lines · Michael Bommarito
Documentation/process/coding-assistants.rstdefines an Assisted-by:
trailer for disclosing AI coding tool assistance. Recognize it and skip Name <email> validation; format is AGENT_NAME:MODEL_VERSION.
already fixed in -next
see: d1db4118489fffd2b2f612140b7acbb477880839
Quoted 3 lines · Joe Perches
already fixed in -next
see:
d1db4118489fffd2b2f612140b7acbb477880839
Thanks, my bad, dropping.
Only other note is that you might want to add Assisted-by: to @standard_signature_tags as well for user convenience. Didn't see that in Sasha's fix.