Skip to contentSkip to conversation

leds: pwm: Fix error code in led_pwm_create_fwnode()

PATCH Applied Dan Carpenter 3 participants 3 messages Jul 11, 2023 – Jul 13, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: pwm: Fix error code in led_pwm_create_fwnode()

Negative -EINVAL was intended, not positive EINVAL. Fix it.

Fixes 95138e01275e ("leds: pwm: Make error handling more robust")
---
 drivers/leds/leds-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-pwm.c +1 -1
index 29194cc382af..87c199242f3c 100644
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
 			led.name = to_of_node(fwnode)->name;
 
 		if (!led.name) {
-			ret = EINVAL;
+			ret = -EINVAL;
 			goto err_child_out;
 		}
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Dan Carpenter

Negative -EINVAL was intended, not positive EINVAL. Fix it.

Thanks!

Quoted 22 lines
Fixes 95138e01275e ("leds: pwm: Make error handling more robust")
---
 drivers/leds/leds-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-pwm.c +1 -2
index 29194cc382af..87c199242f3c 100644
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
                        led.name = to_of_node(fwnode)->name;
 
                if (!led.name) {
-                       ret = EINVAL;
+                       ret = -EINVAL;
                        goto err_child_out;
                }
 
--

2.39.2

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 7 lines · Dan Carpenter

Negative -EINVAL was intended, not positive EINVAL. Fix it.

Fixes 95138e01275e ("leds: pwm: Make error handling more robust")
---
 drivers/leds/leds-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Signature · 1 line
Lee Jones [李琼斯]