leds: pwm: Fix error code in led_pwm_create_fwnode()
Subsystems (2)
PATCH 1/1 leds: pwm: Fix error code in led_pwm_create_fwnode()
Negative -EINVAL was intended, not positive EINVAL. Fix it.
Fixes 95138e01275e ("leds: pwm: Make error handling more robust")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/leds/leds-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-pwm.c +1 -1
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) led.name =to_of_node (fwnode)->name;if (!led.name) { - ret =EINVAL ; + ret = -EINVAL ; goto err_child_out; }
Signature · 1 line
2.39.2
Quoted 2 lines · Dan Carpenter
Negative
-EINVALwas intended, not positive EINVAL. Fix it.
Reviewed-by Andy Shevchenko <[email protected]>
Thanks!
Quoted 22 lines
Fixes 95138e01275e ("leds: pwm: Make error handling more robust")Signed-off-by Dan Carpenter <[email protected]>--- drivers/leds/leds-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/leds/leds-pwm.c +1
-2@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) led.name =to_of_node (fwnode)->name;if (!led.name) { - ret =EINVAL ; + ret = -EINVAL ; goto err_child_out; } --2.39.2
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Dan Carpenter
Negative
-EINVALwas intended, not positive EINVAL. Fix it.Fixes 95138e01275e ("leds: pwm: Make error handling more robust")Signed-off-by Dan Carpenter <[email protected]>--- drivers/leds/leds-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Signature · 1 line
Lee Jones [李琼斯]